Commit Graph

36276 Commits

Author SHA1 Message Date
Andrew Ozz
3f0f8d4a31 Update TinyMCE to 4.5.6. Has many improvements and bug fixes. Changelog: https://github.com/tinymce/tinymce/blob/4.5.x/changelog.txt.
Merges [40398] to the 4.7 branch.

Props programmin, eclev91 and boldwater for finding and reporting this.
Fixes #40305.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40419 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-13 01:51:44 +00:00
Pascal Birchler
9e500a9b06 Media: Improve handling of non-image files in wp_get_image_mime.
This prevents non-image fileypes from returning a mime type of "application/octet-stream" when `exif_imagetype()` returns `false`.

Props blobfolio.
Fixes #40017.

Merges [40397] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40403 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-10 14:27:23 +00:00
Pascal Birchler
e86ab4f969 Customize: Auto-expand a widget area section when expanding the Widgets panel if there is only one registered sidebar and it is active.
Introduces WP_Customize_Panel::$auto_expand_sole_section property which allows panels to opt-in to the behavior, which the Widgets panel is made to do by default.

Props delawski, westonruter, melchoyce.
Fixes #37471.

Merges [40395] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40402 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-10 12:35:38 +00:00
Pascal Birchler
fd09e9b680 Customize: Fix behavior of clicking Delete Menu link and keep available nav menu items panel open when doing bulk deletion.
Props maguiar, adamsilverstein for testing.
Amends [39548].
Fixes #38953.

Merges [40396] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40401 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-10 12:28:08 +00:00
Pascal Birchler
4c580ff912 Bootstrap/Load: Only load PasswordHash class once.
`require_once` prevents errors when loading WordPress and the class already exists.

See [40387].
Fixes #39445. 


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40389 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-06 18:22:32 +00:00
Pascal Birchler
4b3c4765dd Build/Test Tools: Add assertNotFalse() method to WP_UnitTestCase and use it where appropriate.
Props peterwilsoncc.
Fixes #39219.

Merges [39919] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40388 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-06 18:19:02 +00:00
Pascal Birchler
c7c37590f9 Customize: Fix HTTPS navigation of site in preview on IE11.
Accounts for HTTPS links (port 443) where [40318] only accounted for HTTP links (port 80). Addresses issue in IE11 where the default port number is unexpectedly included on `link.host` for links dynamically created by scripts.

Props mattwiebe.
Amends [40318], [38890].
See #38409.
Fixes #40198.

Merges [40381] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40386 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-06 17:32:17 +00:00
Pascal Birchler
d6bf6a5261 Multisite: Handle sites cache invalidation more granularly for option updates.
Previously `update_blog_option()` would trigger an invalidation of that site's entire cache although these changes did not affect the content of 
these caches. Furthermore changes to the special options `blogname`, `siteurl` and `post_count` should not invalidate the entire cache of that site, but only their respective site details cache. The option `home` now has the same behavior as it also belongs to the site details, but did not invalidate the cache at all previously.

Several new unit tests confirm these changes work as expected.

Fixes #40063.

Merges [40305] and [40333] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40385 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-06 17:26:04 +00:00
Pascal Birchler
1bf5e510aa Customize: Use is_header_video_active() as active_callback for external_header_video control instead of is_front_page().
Use the same `active_callback` as was supplied previously for the `header_video` control in [39240] where this instance was missed.

Amends [39240].
Props pratikshrestha.
See #38738.
Fixes #40308.

Merges [40379] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40384 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-06 17:20:08 +00:00
Pascal Birchler
8aed649adf Customize: Fix reversal of nav menu item's type and object properties for
page stub added in customizer.

Amends [38906].
See #38164.
Fixes #40277.

Merges [40380] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40383 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-06 17:17:19 +00:00
Pascal Birchler
5b74245108 Customize: Fix failure to collapse expanded sections and panels that become deactivated.
Improve jsdoc for `onChangeActive` function. Restores fix from [34557] which got dropped in [38648].

Props dlh, westonruter.
See #34391, #33509.
Fixes #39430.

Merges [40304] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40375 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-04 06:51:39 +00:00
Pascal Birchler
7abacb8516 Twenty Seventeen: Use esc_attr_e() for translatable strings in HTML attributes.
Props bor0.
Fixes #40216.

Merges [40311] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40374 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-04 06:39:15 +00:00
Pascal Birchler
9bf0436c67 Twenty Seventeen: Declare jQuery as a dependency for navigation.js.
Props chesio.
Fixes #40224.

Merges [40315] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40373 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-04 06:37:47 +00:00
Pascal Birchler
0b4f35262f Customize: Use get_user_locale() in customizer body class.
Otherwise CSS specific to the site's locale would be applied, even though the customizer is displayed in the user's locale.

See #29783.
Fixes #40271.

Merges [40368] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40369 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-03 22:40:59 +00:00
Pascal Birchler
477746ab1a Administration: Fix minor misalignments caused by the button-link CSS class.
After [40059] the CSS class `button-link` uses `text-align: left` by default.
This change now requires to limit as much as possible the use of `button-link`
to controls that should really look like links and to explicitly set
`text-align: center` in a few other cases.

Fixes #39983.

Merges [40358] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40367 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-03 22:20:37 +00:00
Pascal Birchler
f9d84dd4ba Customize: Fix selective refresh when customizing the 404 template.
Overrides the 404 status during partial refresh requests to serve back 200 so that the request is not deemed a failure and invoke the fallback behavior (full refresh).

See #27355.
Fixes #40018.

Merges [40316] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40366 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-03 22:14:33 +00:00
Pascal Birchler
4294392293 Quick/Bulk Edit: Fix the Tag suggestions position on the Bulk Edit textarea.
Always passes the complete `position` object to the jQuery autocomplete widget.
Also checks if an autocomplete instance already exists on the Bulk Edit textarea.

Props davidbenton.
Fixes #40242.

Merges [40357] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40365 602fd350-edb4-49c9-b593-d223f7449a82
2017-04-03 21:55:50 +00:00
Boone Gorges
52e1c3eff0 Invalidate term query caches when setting or deleting term relationships.
Prior to 4.7, term relationships - as set by `wp_set_object_terms()` or
`wp_remove_object_terms()` - did not affect the term query cache. The
introduction of the 'object_ids' parameter in 4.7 means that the query
cache must be aware of object-term relationships. As such, the
'last_changed' incrementor is now invalidated when term relationships
are modified.

This bug only reared its head when delaying term counting, because term
counting performs its own term query cache invalidation.

Merges [40353] to the 4.7 branch.

Props mboynes.
Fixes #40306.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40354 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-30 16:55:32 +00:00
Pascal Birchler
a983452638 Customize: Prevent client-side validation from being cleared when no corresponding server-side validation is present.
See #36944.
Fixes #39770.

Merges [40319] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40345 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-28 07:21:20 +00:00
Pascal Birchler
16c518a2b0 Customize: Trailingslash the home nav menu item URL in starter content.
This prevents an additional 301 redirect when clicking on the nav menu item, and it also prevents a scenario where the auth cookie may not be passed 
and cause an authentication error when navigating in the customizer.

Props dlh, swissspidy.
Fixes #40112.

Merges [40300] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40338 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-27 09:28:36 +00:00
Pascal Birchler
3f200a7c35 REST API: Confirm the parent post object of an attachment exists in WP_REST_Posts_Controller::check_read_permission().
Avoid a PHP Error when attempting to embed the parent post of an attachment, when the parent post ID is invalid. Instead check if the parent post 
object exists before checking the read permission for the parent post.

Props GhostToast.
Fixes #39881. 

Merges [40306] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40337 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-27 09:23:05 +00:00
Pascal Birchler
8e68bdace3 REST API: Add gmt_offset and timezone_string to the base /wp-json response.
The site's current timezone offset is an important piece of information for any REST API client that needs to manipulate dates.  It has not been 
previously available.

Expose both the `gmt_offset` (the site's current offset from UTC in hours) and `timezone_string` (which also provides information about daylight 
savings time) via the "site info" endpoint (the base `/wp-json` response).

Also update the `wp-api-generated.js` fixture file with the changes to the default API responses.

Props sagarkbhatt.
Fixes #39854.

Merges [40238] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40336 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-27 07:08:54 +00:00
Pascal Birchler
966fca980f Customize: Fix navigation of site in preview on IE11.
Addresses issue in IE11 where the default port number of `:80` is unexpectedly included on `link.host` for links dynamically created by scripts.

Props westonruter, afercia for testing.
See #38409.
Fixes #40198.

Merges [40318] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40335 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-27 06:20:19 +00:00
Pascal Birchler
c25258a927 Customize: Harden site_icon control template to account for when full image size is missing.
Props aussieguy123, westonruter.
See #36749.
Fixes #40010.

Merges [40314] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40332 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-25 15:25:48 +00:00
Pascal Birchler
b10061bf8e Customize: Prevent links to customize.php from being generated which have query vars from wp_removable_query_args() present.
Props dlh.
See #23367, #32692.
Fixes #31850.

Merges [40313] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40331 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-25 13:34:27 +00:00
Pascal Birchler
0145add43a Posts, Post Types: Add missing REST API properties to WP_Post_Type class.
Props danielbachhuber.
Fixes #39986.

Merges [40302] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40329 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-24 19:04:26 +00:00
Pascal Birchler
12080c2497 Taxonomy: Add missing REST API properties to WP_Taxonomy class.
Props danielbachhuber.
Fixes #39987.

Merges [40303] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40328 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-24 19:03:14 +00:00
Pascal Birchler
8b0f76c917 List Tables: After [38703], [38706], and [40118], adjust the jQuery selector to make the selection of a range of checkboxes work again.
Unprop afercia.
Fixes #40056.

Merges [40268] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40327 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-24 18:49:07 +00:00
Pascal Birchler
e63968f21d Themes: Add filter for excluding directories from being scanned for template files.
Exclude 'node_modules' directories from paths searched in `WP_Theme::scandir()`. Introduces the `theme_scandir_exclusions` filter to allow sites to 
exclude any other paths like `bower_components` or `vendor` from being searched for template files.

Props lukasbesch, dd32, swisspidy, rachelbaker. 
Fixes #38292.

Merges [40301] to the 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40326 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-24 18:43:13 +00:00
Pascal Birchler
d142d7fa23 REST API: Use get_gmt_from_date() when preparing a draft post for response.
This prevents wrong dates when dealing with DST, see [40115] and [40284].

Props nerrad.
Fixes #40136.

Merges [40284] and [40324] to the 4.7 branch.

git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40325 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-24 17:52:02 +00:00
John Blackbourn
8b23276a6a Login and Registration: Avoid a potentially incorrect value for the cookie hash on multisite installations that don't have a value in the siteurl network option.
This reverts [38619].

See #34084, #39497

Merges [40320] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40321 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-23 19:02:23 +00:00
Boone Gorges
4eb0dcc64d Fix the formatting of $taxonomies parameter of 'wp_get_object_terms' filter.
[38667]  changed the way that the filter parameters are built. That
changeset didn't fully account for the pre-4.7 format of `$taxonomies`.

Merge of [40290] to the 4.7 branch.

Props ig_communitysites.
Fixes #40154.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40291 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-14 18:42:57 +00:00
John Blackbourn
b842d26924 Build/Test tools: Get Travis builds working on HHVM again.
This change moves to specifying the PHPUnit version for all PHP versions, and fixes an issue where the Composer global bin directory is not at `~/.composer/vendor/bin` on the boxes that are used for HHVM builds.

See #40100

Merges [40269] and [40271] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40272 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-11 00:05:34 +00:00
John Blackbourn
ec70d962ca Build/Test tools: Don't override the wp_set_auth_cookie() and wp_clear_auth_cookie() functions.
Overriding pluggable functions in the test suite is asking for trouble in the future. In addition, it means the test suite can't be guaranteed to behave the same as core.

This instead introduces a `send_auth_cookies` filter which can be hooked in during the test suite to prevent these functions from attempting to send cookie headers to the client.

Fixes #39367

Merges [40263] and [40264]  to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40265 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-10 15:05:36 +00:00
Dominik Schilling (ocean90)
53058fc1b4 Build/Test Tools: Update .travis.yml to include latest improvements from trunk.
* Explicitly use PHPUnit 5.7 for the PHP 7 builds on Travis.
* On Travis CI install and use the node version which is specified in package.json.
* Add some more debugging to Travis and bring the format of the Xdebug fix inline with branches.

Merge of [40255] and [40257-40259] to the 4.7 branch.

Props netweb, johnbillion.
See #35105, #39822, #40086.

git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40260 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-09 22:01:32 +00:00
John Blackbourn
001cad9cf6 Build/Test tools: Remove the unnecessary clone of the twentysixteen repo.
This is no longer needed since #31550.

Fixes #40066

Merges [40252] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40253 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-09 01:35:50 +00:00
John Blackbourn
ddf26b95ac Build/Test tools: In Travis, skip some tests when not on trunk.
This skips time sensitive tests (copyright year and PHP/MySQL version requirements) when tests are run on branches on Travis.

Props netweb, jorbin

Fixes #39486

Merges [40241] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40250 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-08 00:51:22 +00:00
John Blackbourn
e220469859 Build/Test Tools: Call wp_head() and wp_footer() in the theme used during tests.
See #31550
Fixes #39988

Merges [40235] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40236 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-07 01:34:43 +00:00
John Blackbourn
513cbb5c5e Build/Test Tools: Disable Xdebug when testing on Travis to increase performance.
See #39978


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40225 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-07 00:20:32 +00:00
Sergey Biryukov
c12b33e067 Post-4.7.3 version bump for 4.7 branch.
git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40224 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 18:51:44 +00:00
James Nylen
b101339531 Bump 4.7 branch to version 4.7.3.
git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40202 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 15:55:16 +00:00
John Blackbourn
918efad6fd Press This: Verify intent before fetching in-page resources using Press This.
Props vortfu

Merges [40195] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40196 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 13:56:00 +00:00
Aaron D. Campbell
742d7e6663 Strip control characters before validating redirect.
Merges [40183] to 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40184 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 13:39:33 +00:00
John Blackbourn
a0902e8a13 Taxonomy: Correct the formatting of HTML entities when generating the screen reader text for tag removal.
Props adamsilverstein

Merges [40181] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40182 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 13:15:20 +00:00
Aaron D. Campbell
151bf11e0e Plugins: Add file check to plugin deletions.
Merges [40169] to 4.7 branch.



git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40170 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 12:57:08 +00:00
Dominik Schilling (ocean90)
bdbceecd3e Embeds: URL encode YouTube video IDs for broader compatibility.
Merge of [40160] to the 4.7 branch.


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40161 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 12:03:54 +00:00
Jeremy Felt
01c719f87e Validate video and audio metadata.
merge of [40148] to the 4.7 branch


git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40149 602fd350-edb4-49c9-b593-d223f7449a82
2017-03-06 08:02:21 +00:00
Dion Hulse
b1bc210c02 Bump the version after the 4.7.3-RC1 packaging.
git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40141 602fd350-edb4-49c9-b593-d223f7449a82
2017-02-28 00:15:02 +00:00
Dion Hulse
b7be60afb6 Version bump for WordPress 4.7.3-RC1
git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40140 602fd350-edb4-49c9-b593-d223f7449a82
2017-02-28 00:09:52 +00:00
Dominik Schilling (ocean90)
a2c633fdc7 REST API: Allow setting post formats even if they are not supported by the theme.
A `post_format` not used by the current theme, but supported by core is not a wrong/broken piece of information. It's just not used at this point in time. Therefore we should allow setting and retrieving any of the standard post formats supported in core, even if the current theme doesn't use them.

After this commit, a post's `format` value can survive a round trip through the API, which is a good general design principle for an API.

Merge of [40120] and [40121] to the 4.7 branch.

Props JPry, iseulde, davidakennedy, Drivingralle.
Fixes #39232.

git-svn-id: https://develop.svn.wordpress.org/branches/4.7@40137 602fd350-edb4-49c9-b593-d223f7449a82
2017-02-27 20:02:43 +00:00