Commit Graph

28594 Commits

Author SHA1 Message Date
Boone Gorges
51d9fc0ad1 Apply 'taxonomy_parent_dropdown_args' filter when editing terms.
Added in WP 3.7 [25123], the 'taxonomy_parent_dropdown_args' filter affected
only the term creation interface. This changeset introduces parity by ensuring
that it is applied when editing terms as well.

The new `$context` parameter indicates whether the filter is being applied in
a 'new' or 'edit' context.

Props TimothyBlynJacobs, DrewAPicture.
Fixes #29853.

git-svn-id: https://develop.svn.wordpress.org/trunk@30998 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-29 15:26:51 +00:00
Lance Willett
e30d6790aa Twenty Fifteen: fix missing style for menu in small screens.
Props valendesigns, fixes #30857.

git-svn-id: https://develop.svn.wordpress.org/trunk@30997 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-29 12:00:35 +00:00
Lance Willett
9a3942ffd8 Twenty Fifteen: pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@30996 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-29 10:07:50 +00:00
Lance Willett
31114d0d6e Twenty Fifteen: add styles for multisite registration forms.
Props valendesigns, fixes #30776.

git-svn-id: https://develop.svn.wordpress.org/trunk@30995 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-29 09:57:27 +00:00
Sergey Biryukov
b71e24216d Correct $taxonomies parameter description in get_terms() filters.
props dlh.
fixes #30851.

git-svn-id: https://develop.svn.wordpress.org/trunk@30994 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-28 01:43:47 +00:00
Boone Gorges
6d5084ef1c Pass $resource_type to 'get_ancestors' filter.
The `$resource_type` argument was added to the `get_ancestors()` function in
[30141]. In that changeset, the documentation for the filter was updated to
indicate that it would receive `$resource_type` as a param, but the filter
itself was not updated accordingly.

Props tmatsuur, DrewAPicture.
Fixes #30843.

git-svn-id: https://develop.svn.wordpress.org/trunk@30993 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-26 21:29:00 +00:00
Dominik Schilling (ocean90)
f3d83c3f6c Customizer: Use correct event variable when moving widgets to another widget area.
Fixes "ReferenceError: event is not defined error." in Firefox.

props tywayne.
fixes #30818.

git-svn-id: https://develop.svn.wordpress.org/trunk@30992 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-23 17:23:16 +00:00
Dominik Schilling (ocean90)
c05e46e4d1 Customizer: Improve IE 8 compatibility.
* Use square bracket notation for `default` keywords.
* Use Underscores `indexOf` for arrays.

props westonruter, ocean90.
fixes #30781 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30991 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-23 17:04:47 +00:00
Boone Gorges
8dbce12a61 In Imagick tests, instantiate WP_Image_Editor_Imagick directly instead of calling wp_get_image_editor().
This is for greater consistency with other image editor tests.

Props voldemortensen.
Fixes #30820.

git-svn-id: https://develop.svn.wordpress.org/trunk@30990 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-23 14:34:09 +00:00
Aaron Jorbin
1c68f89686 Add jQuery UI Core as a dependency for qUnit tests
[30919] added more qUnit tests for the Customizer. One of the dependencies for these tests is qUnit. Otherwise we end up with an error due to an unsupported pseudo.

https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/44873635#L425 shows an example of the failing test.

Props ocean90.
see #30701.
Fixes #30754.



git-svn-id: https://develop.svn.wordpress.org/trunk@30989 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-23 00:16:52 +00:00
Aaron Jorbin
86db4d88fe Update npm on Travis CI as a part of build
Travis has an outdated version of NPM.  While this is currently only generating a warning, in the future it could cause actual errors.

Fixes #30823



git-svn-id: https://develop.svn.wordpress.org/trunk@30988 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-22 23:46:46 +00:00
Aaron Jorbin
876ce714fc Switch to container-based infrastructure on Travis CI.
The container-based infrastructure has more memory and more cores.  It also is designed to startup faster. We give up the ability to use sudo, but we aren't using that right now so we should be good.

Props netweb, tw2113.
Fixes #30822.



git-svn-id: https://develop.svn.wordpress.org/trunk@30987 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-22 23:25:40 +00:00
Andrew Ozz
8298e94bfe TinyMCE wpView: when clicking on the Edit button, move the focus back to the editor before opening the modal. This is needed for IE so TinyMCE can save the proper DOM "bookmark", and makes it possible to move the focus to the modal after it is opened.
See #30817.

git-svn-id: https://develop.svn.wordpress.org/trunk@30986 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-22 21:30:16 +00:00
Boone Gorges
5f1ad2d768 In wp_update_term(), limit duplicate slug checks to the same taxonomy as the updated term.
In 4.1 [30240], `wp_insert_term()` was modified to allow the creation of terms
with duplicate slugs, as long as the terms are in different taxonomies.
`wp_update_term()` didn't get the corresponding modification, with the result
that term updates fail when the term being updated shares a slug with an older
term, regardless of that older term's taxonomy.

Props ipm-frommen.
Fixes #30780 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@30985 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-22 15:32:59 +00:00
Scott Taylor
061bfddda9 Comment List Tables:
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30984 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:27:00 +00:00
Scott Taylor
44fe0ebf75 Correct the @param docs for arguments that are truthy/falsey.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30983 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:03:21 +00:00
Scott Taylor
218dd4fd6b For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30982 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:46:53 +00:00
Scott Taylor
91dcf8796b In image_size_input_fields():
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 22:18:12 +00:00
Scott Taylor
a75c7977b9 In wp_import_handle_upload():
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30980 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 21:09:11 +00:00
Scott Taylor
f6f12912e2 Improve some docs for @param. Remove an unneeded $wpdb global import.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30979 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:55:21 +00:00
Scott Taylor
04ed6499cd Improve some wp-admin/includes/class-wp-filesystem-*.php docs for @param.
See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30978 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 20:39:41 +00:00
Andrew Ozz
6695ac3bab Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30977 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 19:33:01 +00:00
Boone Gorges
fd4231c2a1 Use correct notation for global functions in @covers test annotations.
Props sgrant.
Fixes #30769.

git-svn-id: https://develop.svn.wordpress.org/trunk@30976 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-19 15:20:41 +00:00
Andrew Nacin
26eeb623a6 About page: CDN images.
git-svn-id: https://develop.svn.wordpress.org/trunk@30971 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 17:54:43 +00:00
Andrew Nacin
657768ff9c Update theme POT files in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30969 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 17:00:41 +00:00
Lance Willett
2f096d219f Bundled Themes: bump version numbers to coordinate with 4.1 release.
git-svn-id: https://develop.svn.wordpress.org/trunk@30967 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 16:18:14 +00:00
Andrew Nacin
e8e2db6e00 Update bundled theme POT files in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30965 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-18 01:32:09 +00:00
Andrew Nacin
47d5cadf38 Add Slack notifications to Travis CI config. fixes #30755.
git-svn-id: https://develop.svn.wordpress.org/trunk@30963 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 23:50:37 +00:00
Lance Willett
439d540c20 Twenty Fifteen: use better, universal sans-serif fonts for RTL, similar to Twenty Ten which also had serif fonts throughout.
Props iamtakashi, see #30752.

git-svn-id: https://develop.svn.wordpress.org/trunk@30961 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 22:29:08 +00:00
Andrew Nacin
d268aaf37f Update version numbers in trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@30960 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 17:37:16 +00:00
Lance Willett
6a312bdd21 Twenty Fifteen: ensure RTL editor font style is consistent with front-end font style.
Props iamtakashi and alex-ye, see #30746.

git-svn-id: https://develop.svn.wordpress.org/trunk@30956 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 17:21:29 +00:00
Lance Willett
340f6052fd Twenty Fifteen: ensure menu icon is properly centered for RTL views on small screens.
Props iamtakashi, fixes #30739.

git-svn-id: https://develop.svn.wordpress.org/trunk@30955 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:38:51 +00:00
Boone Gorges
b824d6f56c Update individual term caches in get_terms().
This was removed in [29915] as part of the attempt to add cache support to
`get_term_by()`. When that support was removed in [30900], it was not properly
restored.

This changeset includes a unit test to verify that the cache is properly primed
for terms found in `get_terms()`, as well as tests to verify the other cache
setting that was touched by [30900].

Fixes #30749. See #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30954 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:38:44 +00:00
Lance Willett
c7d2f360cb Twenty Fifteen: fix styles for screen-reader-only search button in small screens.
Props iamtakashi, fixes #30744.

git-svn-id: https://develop.svn.wordpress.org/trunk@30953 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:37:05 +00:00
Helen Hou-Sandi
908a2e87c8 Ensure inline code examples stay LTR, punctuation and all.
props alex-ye.
see #30748.


git-svn-id: https://develop.svn.wordpress.org/trunk@30952 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:21:54 +00:00
Helen Hou-Sandi
d34709eaa5 About page: Don't allow tab text to wrap.
Some language, browser, and OS combinations (notably Arabic, Chrome, and Windows) were wrapping.

see #30743.


git-svn-id: https://develop.svn.wordpress.org/trunk@30951 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-17 16:01:42 +00:00
Dominik Schilling (ocean90)
fabd47a2ff About: Fix the WordPress badge.
`css-clean` (minifies our CSS) has an issue when using multiple backgrounds and background position together. Instead of relying on browser support for multiple backgrounds to display the WP logo as SVG, use the `.svg` CSS class.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30946 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:53:25 +00:00
Lance Willett
e2c36c3176 Twenty Fifteen: hide search input cancel button. See #30728.
git-svn-id: https://develop.svn.wordpress.org/trunk@30945 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:42:24 +00:00
Dominik Schilling (ocean90)
7560f4cf8c Pass locale to wordpress.org theme/plugin API.
In the future this will be used to return localized plugin/theme info.

see #30735.

git-svn-id: https://develop.svn.wordpress.org/trunk@30944 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 22:38:52 +00:00
Dominik Schilling (ocean90)
6873e08839 Twenty Fifteen: Use dynamic default color value instead of hardcoded color.
props iamtakashi.
see #30733.

git-svn-id: https://develop.svn.wordpress.org/trunk@30932 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 21:34:46 +00:00
Andrew Nacin
b4dc6629cd Last about page string. props celloexpressions. fixes #30435.
git-svn-id: https://develop.svn.wordpress.org/trunk@30929 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 21:26:34 +00:00
John Blackbourn
9189fbcff9 Make the DFW paragraph on the About page narrower to mitigate an orphan in Firefox.
See #30435
Props melchoyce


git-svn-id: https://develop.svn.wordpress.org/trunk@30921 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 20:01:56 +00:00
Dominik Schilling (ocean90)
e7f2ebf414 Customizer: Add more QUnit tests to improve coverage on the new models.
Includes tests for the broken `activate()`/`deactivate()` methods, which were fixed in [30871].

props westonruter.
see #30701.

git-svn-id: https://develop.svn.wordpress.org/trunk@30919 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 19:43:22 +00:00
Mark Jaquith
93ea9862a5 Revert [30036].
see #18035

git-svn-id: https://develop.svn.wordpress.org/trunk@30912 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 17:34:17 +00:00
Lance Willett
8d69099344 Twenty Fifteen: fallback hex color for no-comments text should come first.
Props iamtakashi, fixes #30730.

git-svn-id: https://develop.svn.wordpress.org/trunk@30910 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 16:18:40 +00:00
Scott Taylor
c9707a4a31 In response to regressions on .com, fix MEjs styles for screen reader text and overflow on the volume slider.
Props obenland.
See #30281.


git-svn-id: https://develop.svn.wordpress.org/trunk@30907 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 15:12:35 +00:00
Dominik Schilling (ocean90)
b258a6c144 Twenty Fifteen: Remove unnecessary esc_html() from get_the_date() and get_the_modified_date().
see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30905 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 14:18:48 +00:00
John Blackbourn
2069d52fa1 Move a <code> tag out of a localised string on the About page.
Props pavelevap
See #30435


git-svn-id: https://develop.svn.wordpress.org/trunk@30903 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 14:03:53 +00:00
Dominik Schilling (ocean90)
1ca9749c93 Twenty Fifteen: Remove esc_html() from get_the_author().
The display name is sanitized through `sanitize_text_field`, `wp_filter_kses`, and `_wp_specialchars`.

see #30724.

git-svn-id: https://develop.svn.wordpress.org/trunk@30901 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 13:39:32 +00:00
Boone Gorges
bf62165353 Remove caching for get_term_by() calls.
The new cache group scheme causes term invalidation to be overly broad, so
that busting the cache for one term will bust the cache for all terms in the
taxonomy. We'll have another go at more focused use of the 'last_changed'
incrementor in a future release.

Reverts [29915], [30073], [30080], [30108], [30112].
See #21760.

git-svn-id: https://develop.svn.wordpress.org/trunk@30900 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-16 13:26:19 +00:00