sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
26,409 Commits 2 Branches 473 Tags 137 MiB
ce59109919
Commit Graph

3285 Commits

Author SHA1 Message Date
Scott Taylor
da440f54fd Eliminate use of extract() in wp_list_bookmarks(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28405 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:17:52 +00:00
Scott Taylor
30564338b0 Eliminate use of extract() in _walk_bookmarks(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28404 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:04:50 +00:00
Scott Taylor
0dd9d3aeff Eliminate use of extract() in get_bookmarks(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:57:24 +00:00
Scott Taylor
61faf32275 Eliminate use of extract() in Walker_Page::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28402 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:40:48 +00:00
Scott Taylor
c96d4a94b9 Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28401 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:21:20 +00:00
Scott Taylor
e4a800238f Eliminate use of extract() in wp_dropdown_pages(). 
Adds unit tests to: `tests/post/template.php`. 
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28399 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:11:21 +00:00
Scott Taylor
21e0370e5c Eliminate use of extract() in wp_link_pages(). 
Adds unit tests to a new file: `tests/post/template.php`. 
There were previously no unit tests for `wp_link_pages()`.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28398 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 00:43:40 +00:00
Scott Taylor
9e07b1037e Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-14 22:28:08 +00:00
Scott Taylor
46f15a84ab Eliminate use of extract() in display_setup_form(). Only needs to read password and password_message. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-14 16:42:42 +00:00
Lance Willett
44e4e3e4d0 Twenty Thirteen: add accessibility-ready tag. Fixes #28225, props BODA1982. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28395 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 23:10:00 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb Properly split and document the admin_post* actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4 Clarify inline documentation for back-compat load-* action hooks. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 06:27:11 +00:00
Scott Taylor
540826e4e3 Eliminate use of extract() in wp_list_authors(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28392 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 06:01:33 +00:00
Scott Taylor
bc17731c23 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder(): 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6 Eliminate use of extract() in WP_List_Table::pagination(): 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3 Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93 Eliminate use of extract() in WP_List_Table::ajax_response(): 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b Eliminate use of extract() in WP_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 05:03:26 +00:00
Scott Taylor
f57bdbd238 Eliminate use of extract() in Custom_Image_Header::step_2(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:53:13 +00:00
Scott Taylor
ba8e36f94c Eliminate use of extract() in the_title_attribute(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28383 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:47:11 +00:00
Scott Taylor
42d6b5dd1e Eliminate use of extract() in trackback_url_list(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:43:22 +00:00
Scott Taylor
671b47ef73 Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28381 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:39:17 +00:00
Drew Jaynes (DrewAPicture)
6a63c5b59d Fix a phpdoc typo and multi-line comment syntax in wp-cron.php. 
Props rclations.
Fixes #28231.


git-svn-id: https://develop.svn.wordpress.org/trunk@28380 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:38:15 +00:00
Scott Taylor
77731c03fc Eliminate use of extract() in wp_get_archives(). 
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28379 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:28:56 +00:00
Drew Jaynes (DrewAPicture)
3c80d5f86a Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28378 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:28:30 +00:00
Drew Jaynes (DrewAPicture)
e2219e3d48 Add a complete short description to the get_attached_media filter documentation. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28377 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:20:12 +00:00
Drew Jaynes (DrewAPicture)
68f78b1dcc Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28376 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:17:16 +00:00
Drew Jaynes (DrewAPicture)
d59c371180 Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:12:02 +00:00
Scott Taylor
4e0809e3e4 Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28374 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 03:26:51 +00:00
Scott Taylor
b3ff5285f8 Eliminate use of extract() in wp-activate.php. 
Props jeremyfelt, MikeHansenMe.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28373 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 03:13:21 +00:00
Scott Taylor
961f52d367 Add xps and oxps extensions to list of supported document types. 
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.



git-svn-id: https://develop.svn.wordpress.org/trunk@28372 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 07:18:06 +00:00
Scott Taylor
8dc4b88fcf In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true. 
Props adamsilverstein.
Fixes #23954.



git-svn-id: https://develop.svn.wordpress.org/trunk@28371 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 07:02:05 +00:00
Scott Taylor
e8b8e881b2 Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath. 
Props Otto42 for the initial patch.
Fixes #25243.



git-svn-id: https://develop.svn.wordpress.org/trunk@28370 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:24:58 +00:00
Scott Taylor
e1b341cc59 In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border. 
Props avryl.
Fixes #27949.



git-svn-id: https://develop.svn.wordpress.org/trunk@28369 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:18:02 +00:00
Scott Taylor
3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.



git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:11:08 +00:00
Scott Taylor
3a554b5249 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty. 
Props SergeyBiryukov.
Fixes #23706.


git-svn-id: https://develop.svn.wordpress.org/trunk@28367 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 05:53:27 +00:00
Scott Taylor
147eeb2147 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.



git-svn-id: https://develop.svn.wordpress.org/trunk@28366 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 03:41:31 +00:00
Scott Taylor
4826c12c47 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors. 
Props celloexpressions.
Fixes #27516.



git-svn-id: https://develop.svn.wordpress.org/trunk@28365 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 02:22:42 +00:00
Scott Taylor
9705736cdf When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views. 
Fixes #27971.



git-svn-id: https://develop.svn.wordpress.org/trunk@28364 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 02:06:36 +00:00
Scott Taylor
487da46928 Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge. 
Fixes #27368.



git-svn-id: https://develop.svn.wordpress.org/trunk@28363 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 01:27:29 +00:00
Scott Taylor
b70967302b In get_the_author_posts(), if there is no current $post, return 0 and bail. 
Props krogsgard, aaroncampbell.
Fixes #27998.



git-svn-id: https://develop.svn.wordpress.org/trunk@28362 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:25:29 +00:00
Scott Taylor
8998c015b3 MediaElement players need clear: both to play nice with adjacent floated elements. 
Fixes #27385.



git-svn-id: https://develop.svn.wordpress.org/trunk@28361 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:13:49 +00:00
Scott Taylor
d007994bf3 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.


git-svn-id: https://develop.svn.wordpress.org/trunk@28360 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:04:38 +00:00
Scott Taylor
2808673b0c Remove the title attribute from markup generated in wp-includes/category-template.php: 
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	



git-svn-id: https://develop.svn.wordpress.org/trunk@28359 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:56:12 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
cb5852a813 Add inline documentation of the default arguments for wp_list_pages(). 
Props garza for the initial patches.
Fixes #11338.


git-svn-id: https://develop.svn.wordpress.org/trunk@28357 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 08:01:13 +00:00
Drew Jaynes (DrewAPicture)
f3d9e1ed7e Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28356 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 05:01:15 +00:00
Drew Jaynes (DrewAPicture)
de13f1a60c Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.


git-svn-id: https://develop.svn.wordpress.org/trunk@28355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 04:59:34 +00:00
Drew Jaynes (DrewAPicture)
0b51b6da2e Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks. 
Props GaryJ.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28352 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 11:12:11 +00:00
Drew Jaynes (DrewAPicture)
272f7533dc Rename the $action hook in wp-admin/admin-post.php to admin_post{$action}. 
Also, clarify documentation of priv vs nopriv prefixing of the hook name.

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28351 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 10:59:17 +00:00
Drew Jaynes (DrewAPicture)
b0d7e6fe3c Revert [28349] in favor of retaining the single dynamic admin_post* hook. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28350 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 10:46:41 +00:00
Drew Jaynes (DrewAPicture)
9392b42e97 Convert and rename the $action hook in wp-admin/admin-post to two dynamic hook sets. 
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users

Props Otto42, DrewAPicture.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28349 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 10:26:07 +00:00
Drew Jaynes (DrewAPicture)
bbd130fe15 Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name. 
Props Otto42.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28348 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 09:57:11 +00:00
Drew Jaynes (DrewAPicture)
30c21227be Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28347 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-08 08:15:48 +00:00
Scott Taylor
7531fd0070 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 18:24:47 +00:00
Scott Taylor
bfe7d38650 audio, video, and playlist shortcodes: 
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur

See #22400, #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28342 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 17:35:09 +00:00
Lance Willett
28d6842538 Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28341 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 04:26:07 +00:00
Scott Taylor
451319728b In wp-login.php, break is unreachable after exit 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28340 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:57:17 +00:00
Scott Taylor
4bddd84276 In wpdb, remove dead code: 
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28339 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:55:32 +00:00
Scott Taylor
e47eb14575 In WP_Widget::update_callback(), $sidebars_widgets is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28338 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:51:31 +00:00
Scott Taylor
f945487f45 In wp-includes/theme.php, break is unreachable after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28337 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:49:19 +00:00
Scott Taylor
b99dead052 In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28336 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:46:11 +00:00
Scott Taylor
b62ca9c298 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28335 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:44:06 +00:00
Scott Taylor
f63b6cde3a In wp-includes/revision.php - remove dead code: 
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28334 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:37:45 +00:00
Scott Taylor
098a5145c5 In WP_Query, remove duplicate variable setting: 
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28333 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:42:28 +00:00
Scott Taylor
16a58e34a2 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming. 
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:38:23 +00:00
Scott Taylor
11e65eb200 In wp_get_attachment_link(), $post_title is set and then not used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28331 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:34:10 +00:00
Scott Taylor
b626b11590 In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28330 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:32:25 +00:00
Scott Taylor
3f2a078f5e In get_network_by_path(), $exact_domains is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28329 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:31:14 +00:00
Scott Taylor
24b03d819b In update_metadata_by_mid(), $original_value is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28328 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:28:02 +00:00
Scott Taylor
e95edb29aa In edit_post_link(), $post_type_obj is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28327 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:26:20 +00:00
Scott Taylor
5cf2a50dba In paginate_links(), break is unreachable after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28326 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:24:22 +00:00
Scott Taylor
ef5998eabb In wp-includes/functions.php, remove dead code: 
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28325 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:22:22 +00:00
Scott Taylor
5e90fb1b3e In wp_set_comment_status(), the default case returns, so no default value for $status is needed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:16:42 +00:00
Scott Taylor
5530fe4c11 In wp-includes/comment-template.php, remove dead code: 
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28323 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:14:35 +00:00
wonderboymusic
2b1c764ec7 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28322 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:08:02 +00:00
Sergey Biryukov
18916debfd Update deleted site message in ms_site_check(). 
props boonebgorges.
fixes #28150.

git-svn-id: https://develop.svn.wordpress.org/trunk@28321 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:45:54 +00:00
Scott Taylor
0f4f941900 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28320 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:36:34 +00:00
Scott Taylor
9ad07c8c28 In wp-includes/class-wp-customize-setting.php, break is unreachable after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28319 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:33:03 +00:00
Scott Taylor
376125e0b7 In wp-includes/class-wp-admin-bar.php, break is unreachabled after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28318 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:28:46 +00:00
Scott Taylor
c5463c5cb2 In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28317 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:26:00 +00:00
Scott Taylor
5df63351b2 In wp-includes/bookmark.php, remove dead code: 
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28316 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:21:50 +00:00
Scott Taylor
22743ee2c4 In wp-admin/users.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28315 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:18:12 +00:00
Scott Taylor
64fbddfcd5 In core_upgrade_preamble(), $alternate is set then never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28314 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:16:34 +00:00
Scott Taylor
cb0578d77e In wp-admin/theme-editor.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28313 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:15:18 +00:00
Scott Taylor
0f9b925ed5 In wp-admin/post.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28312 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:14:16 +00:00
Scott Taylor
a9dfbabfe7 In wp-admin/plugins.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28311 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:12:44 +00:00
Scott Taylor
e742c23af9 In wp-admin/plugin-editor.php, break is unreachabled after exit. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28310 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:11:30 +00:00
wonderboymusic
1da6728dc0 In wp-admin/network/users.php, break is unreachabled after exit. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28309 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:10:01 +00:00
Scott Taylor
aa7cef0549 In wp-admin/network/themes.php, break is unreachabled after exit. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28308 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:07:33 +00:00
Scott Taylor
81acc42361 In wp-admin/link.php, break is unreachabled after exit. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28307 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:05:09 +00:00
Scott Taylor
e1f5876ac4 In display_setup_form(), $admin_password is set and (fortunately) not used or displayed. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28306 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:03:34 +00:00
Scott Taylor
3ed59ca164 In wp-admin/includes/upgrade.php, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28305 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:26:47 +00:00
Scott Taylor
74ad050063 In wp-admin/includes/update.php, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28304 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:20:10 +00:00
Scott Taylor
fb1054340f In WP_Screen::render_screen_options(), remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28303 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:13:30 +00:00
Scott Taylor
b64da2cb60 In get_sample_permalink_html(), $view_link is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28302 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:10:41 +00:00
Scott Taylor
5d2b452351 In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28301 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:59:29 +00:00
Scott Taylor
ffa620b972 In wp-admin/includes/nav-menu.php, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28300 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:54:10 +00:00
Scott Taylor
e518d0d652 In update_option_new_admin_email(), $email is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28299 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:47:56 +00:00
Scott Taylor
ee13be0315 In attachment_submit_meta_box(), remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28298 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:44:38 +00:00
Scott Taylor
d92f5aa154 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:40:52 +00:00
Scott Taylor
fc624a4298 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28296 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:32:16 +00:00
Scott Taylor
1e68b7dab4 In WP_MS_Users_List_Table::get_views(), remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28295 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:29:22 +00:00
Dominik Schilling (ocean90)
b09a91a666 Custom Header: Fix logic when a theme doesn't set default-text-color. 
fixes #28042.

git-svn-id: https://develop.svn.wordpress.org/trunk@28294 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:26:46 +00:00
Scott Taylor
36abe7909c In WP_Media_List_Table, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28293 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:26:32 +00:00
Scott Taylor
41d1eb8f56 In ajax-actions.php, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28292 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:18:42 +00:00
Scott Taylor
909d11cd28 Remove unreachable break statements in wp-admin/edit-tags.php. break is unnecessary after die, exit, and wp_die. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28291 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 14:51:47 +00:00
Scott Taylor
88ad28ffdf In wp-admin/custom-header.php, $default_color is set twice before it is used. The first is unnecessary. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28290 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 14:50:05 +00:00
Scott Taylor
ab01399666 Remove unreachable break statements in wp-admin/comments.php. break is unnecessary after die, exit, and wp_die. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28289 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 14:45:22 +00:00
Sergey Biryukov
7f754fa2e8 Translate a string added in 3.7 but never translated previously. 
props andrezrv.
fixes #28025.

git-svn-id: https://develop.svn.wordpress.org/trunk@28288 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:48:49 +00:00
Sergey Biryukov
4b8b0e7178 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.

git-svn-id: https://develop.svn.wordpress.org/trunk@28287 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:33:08 +00:00
Sergey Biryukov
046a2bff94 Add context for 'Previous' and 'Next' theme strings. 
see #28120, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28286 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:19:41 +00:00
Sergey Biryukov
d7a159bf81 Add a filter for wp_list_comments() arguments. 
props greenshady, hlashbrooke.
fixes #19581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28285 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 11:57:36 +00:00
Dominik Schilling (ocean90)
c30bb2fd2b Add missing Dashicons classes to User Admin menu. 
props imath.
see #28144, #26630.

git-svn-id: https://develop.svn.wordpress.org/trunk@28284 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 07:57:52 +00:00
Drew Jaynes (DrewAPicture)
8764f791f1 Where a filter no longer exists, it need not be notated. 
Fixes #24444. See r28258.


git-svn-id: https://develop.svn.wordpress.org/trunk@28283 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:37:17 +00:00
Andrew Nacin
cb022f4957 Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression. 
props jeremyfelt.
fixes #27927.


git-svn-id: https://develop.svn.wordpress.org/trunk@28280 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:31:12 +00:00
Scott Taylor
555937dc43 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:31:07 +00:00
Andrew Nacin
7839dd671c Multisite: Fix case sensitivity regressions in 3.9. 
props jeremyfelt.
fixes #27866.


git-svn-id: https://develop.svn.wordpress.org/trunk@28276 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:23:56 +00:00
Andrew Nacin
c0822b532e Custom header: Avoid warnings in the process_default_headers() method. 
props obenland.
fixes #27850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28275 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:06:39 +00:00
Scott Taylor
a1c6a10489 In general-template.php - remove dead code: 
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28274 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:57:22 +00:00
Scott Taylor
f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:44:56 +00:00
Andrew Nacin
9259c6baa7 Customizer: Only tie header button action events to the header controls. 
props danielbachhuber.
fixes #28046. see #27848.


git-svn-id: https://develop.svn.wordpress.org/trunk@28269 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:29:14 +00:00
Scott Taylor
e42ec45553 Dead code in wp-admin/includes/file.php: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:21:35 +00:00
Andrew Nacin
7ada7af9d0 Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers. 
props rzen, ehg.
fixes #27848.


git-svn-id: https://develop.svn.wordpress.org/trunk@28266 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:13:52 +00:00
Scott Taylor
eda51bf856 Remove duplicate variable setting for $link in wp_list_authors(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28265 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:51:42 +00:00
Scott Taylor
f97deae591 Remove unused variable setting for $revisions in wp_prepare_revisions_for_js(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:44:30 +00:00
Scott Taylor
4c6f405ee7 Remove a dead variable, $start, from wp_dashboard_recent_comments(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:34:22 +00:00
Andrew Nacin
4b6d5b10d4 Move 'home' option to the top of populate_options(). 
fixes #28141.


git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 21:56:11 +00:00
Scott Taylor
2b1619329e Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement. 
Props joedolson.
Fixes #27643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28259 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 20:07:53 +00:00
Scott Taylor
5c306af76d When $type is atom in get_the_category_rss(), use get_bloginfo_rss( 'url' ) when setting the scheme attribute for the <category> node. 
Props ejdanderson.
Fixes #24444.



git-svn-id: https://develop.svn.wordpress.org/trunk@28258 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 19:04:39 +00:00
Scott Taylor
fc4dfba1b8 Remove by-reference modifiers from arguments in wp_remote_retrieve_* functions. 
Props jesin.
Fixes #27687.



git-svn-id: https://develop.svn.wordpress.org/trunk@28257 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 18:45:14 +00:00
Sergey Biryukov
819ad5babc Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.

git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 10:23:16 +00:00
Sergey Biryukov
b597b02515 Fix closing tag in image editor. 
props t4k1s.
fixes #28130.

git-svn-id: https://develop.svn.wordpress.org/trunk@28255 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 10:16:14 +00:00
Sergey Biryukov
de80cc6780 Avoid displaying a negative number of plugin updates in admin menu. 
fixes #28073.

git-svn-id: https://develop.svn.wordpress.org/trunk@28254 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 09:38:36 +00:00
Sergey Biryukov
3e482eb905 Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.

git-svn-id: https://develop.svn.wordpress.org/trunk@28253 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 08:25:46 +00:00
Scott Taylor
89ecbcc7cb In WP_Date_Query::get_sql_for_subquery(), don't parse duplicate parameters - only parse one of w and week or month and monthnum. 
Adds unit tests.

Props oso96_2000, ChriCo.
Fixes #25835.



git-svn-id: https://develop.svn.wordpress.org/trunk@28252 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 23:06:07 +00:00
Scott Taylor
61765b8efd Set the proper value for wp_title() when is_author() and is_post_type_archive() are both true. post_type should always win due to the precedence indicated in get_queried_object(). 
Props mordauk.
Fixes #25398.



git-svn-id: https://develop.svn.wordpress.org/trunk@28251 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 22:20:47 +00:00
Sergey Biryukov
0a16bda6e3 Prevent 'Page %s' from being added to page title on 404 error pages in bundled themes. 
props psoluch, rob1n.
fixes #16468.

git-svn-id: https://develop.svn.wordpress.org/trunk@28250 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 13:16:30 +00:00
Sergey Biryukov
ece95a0257 Prevent 'paged-*' from being added to body classes on 404 error pages. 
props psoluch.
see #16468.

git-svn-id: https://develop.svn.wordpress.org/trunk@28249 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 13:16:13 +00:00
Sergey Biryukov
d0ced880bb Twenty Fourteen: Avoid a PHP notice in Ephemera widget. 
props jartes.
fixes #28055.

git-svn-id: https://develop.svn.wordpress.org/trunk@28248 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 18:45:06 +00:00
Drew Jaynes (DrewAPicture)
5ad1751132 Improve inline documentation for the wpdb::$show_errors property. 
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.

Props ericlewis.
Fixes #16615.


git-svn-id: https://develop.svn.wordpress.org/trunk@28243 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 12:18:07 +00:00
Sergey Biryukov
da6a3d1745 Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu(). 
props Tmeister.
fixes #27745.

git-svn-id: https://develop.svn.wordpress.org/trunk@28242 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:58:51 +00:00
Sergey Biryukov
6c401709f6 Correct 'show_in_menu' parameter description in register_taxonomy(). 
fixes #27943.

git-svn-id: https://develop.svn.wordpress.org/trunk@28241 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:28:05 +00:00
Sergey Biryukov
b9834e8275 Correct @return value for current_time(). 
props arnee.
fixes #27940.

git-svn-id: https://develop.svn.wordpress.org/trunk@28240 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:24:23 +00:00
Dominik Schilling (ocean90)
fe2f5f921e Color Picker: Close color picker when clicking outside of them and when opening another one. 
props mattwiebe.
fixes #25539.

git-svn-id: https://develop.svn.wordpress.org/trunk@28239 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:17:13 +00:00
Dominik Schilling (ocean90)
cb9480b4eb Update jQuery to 1.11.1. 
fixes #28103.

git-svn-id: https://develop.svn.wordpress.org/trunk@28238 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 09:28:55 +00:00
Sergey Biryukov
068ec39696 Twenty Eleven: Correct description for twentyeleven_theme_options_render_page(). 
props ericlewis.
fixes #28057.

git-svn-id: https://develop.svn.wordpress.org/trunk@28237 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 00:42:20 +00:00
Sergey Biryukov
2558cf0139 Fix arrow positioning in "Insert/edit link" modal. 
props avryl, sergej.mueller.
fixes #28096.

git-svn-id: https://develop.svn.wordpress.org/trunk@28236 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 21:20:16 +00:00
Dominik Schilling (ocean90)
a54c311e4f Widgets: Toggle widget arrow when widget is open/closed. 
props MikeHansenMe.
fixes #26748.

git-svn-id: https://develop.svn.wordpress.org/trunk@28235 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 14:08:44 +00:00
Dominik Schilling (ocean90)
ed52ae7a3f Quick Draft: Use text cursor for description label. 
fixes #27766.

git-svn-id: https://develop.svn.wordpress.org/trunk@28234 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 13:12:01 +00:00
Andrew Nacin
790cb99b27 Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets. 
props gcorne.
props Clorith, jorbin for tests.
see #27907, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28223 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 03:36:27 +00:00
Andrew Nacin
e18e93bb80 Improve TinyMCE string for paste command browser support. 
props ebinnion.
fixes #27988.


git-svn-id: https://develop.svn.wordpress.org/trunk@28220 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 21:19:35 +00:00
Dominik Schilling (ocean90)
a13b695fbd Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width. 
Add tests.

see #27936 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28219 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 20:24:28 +00:00
Dominik Schilling (ocean90)
fd26def119 Revert [28217]. 
Misfired commit for #27936.

git-svn-id: https://develop.svn.wordpress.org/trunk@28218 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 20:17:59 +00:00
Dominik Schilling (ocean90)
5d8f69e0c5 Recent Posts Widget: Use ob_end_flush() instead of ob_flush(). 
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28217 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 14:20:05 +00:00
Drew Jaynes (DrewAPicture)
0f759f0c01 Mark the $hook and $page_hook hooks as @internal to skip parsing. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28216 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:53:09 +00:00
Drew Jaynes (DrewAPicture)
609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
9c66e66ac5 Ensure the wp_set_comment_status action hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28214 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:54:33 +00:00
Drew Jaynes (DrewAPicture)
379f725bde Ensure the wp_edit_nav_menu_walker filter is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28213 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:49:48 +00:00
Drew Jaynes (DrewAPicture)
d1137de3de Ensure all duplicate calls of the wp_create_file_in_uploads filter are labeled as such. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28212 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:45:26 +00:00
Drew Jaynes (DrewAPicture)
42d24eebc0 Ensure adjacency of a duplicate hook comment for a the_category filter call. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28211 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:42:21 +00:00
Drew Jaynes (DrewAPicture)
3e2904138e Ensure the submitlink_box action hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28210 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:34:00 +00:00
Drew Jaynes (DrewAPicture)
bf8c70a4ee Ensure the style_loader_tag filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28209 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:28:19 +00:00
Drew Jaynes (DrewAPicture)
9da8915408 Ensure the register filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28208 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:23:31 +00:00
Drew Jaynes (DrewAPicture)
7a0eb63a19 Ensure the nav_menu_meta_box_object filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28207 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:13:15 +00:00
Mark Jaquith
c4dd499979 Use '&mdash; Select &mdash;' instead of '-- Select --' for nav menus. Looks nicer. 
see #27878

git-svn-id: https://develop.svn.wordpress.org/trunk@28205 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 00:34:20 +00:00
Mark Jaquith
65b0b658d7 Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX 
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.

fixes #27878 for trunk. props westonruter

git-svn-id: https://develop.svn.wordpress.org/trunk@28197 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 20:44:32 +00:00
Dominik Schilling (ocean90)
0202625937 Recent Posts Widget: Use ob_end_flush() instead of ob_flush(). 
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28195 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 19:47:09 +00:00
John Blackbourn
2d3568380b Remove some unnecessary abstraction introduced in [28191]. See #27985. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28194 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 11:54:31 +00:00
Andrew Ozz
d19f7a398e Ensure the editor height is saved properly, props jupiterwise, see #28000, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28193 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 04:10:51 +00:00
Andrew Ozz
fff29139b5 TinyMCE: update the 'paste' plugin to the latest dev. version. Included changes: 1b7c41cd7b and 7998b8025d. See #27909, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28192 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 00:58:13 +00:00
johnbillion
34b0686be1 Avoid an expensive attachment counting query on the post editing screen. See #27985, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28191 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-23 22:04:03 +00:00
Andrew Ozz
a6de675d14 TinyMCE: when adding a caption to an image that is in a paragraph with other text, move the caption node above the paragraph instead of below. See #27922, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28190 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-23 20:41:59 +00:00
Andrew Ozz
c602aac562 Drag/drop on the editor to upload: don't trigger the uploader when selected test is being dragged from one window to another. See #27880, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28189 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-23 20:34:43 +00:00
Andrew Ozz
a528be21ad Run WP_Editors::enqueue_scripts() on admin_print_footer_scripts priority 1 (later), instead of admin_footer. Fixes incompatibility with the customizer. Props feedmeastraycat, see #27853, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28187 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 22:40:33 +00:00
Andrew Ozz
5bbe3ef38d Fix cursor style for the resize handle of the editor, props avryl, see #27595, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28186 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 21:47:33 +00:00
Andrew Ozz
db22ae4e32 TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected, see #27847, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28185 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 21:10:14 +00:00
Scott Taylor
77c156631a Alter the layout of the checkboxes in the modal view for Audio/Video Details to allow translations more room to breathe. 
See #27893.



git-svn-id: https://develop.svn.wordpress.org/trunk@28184 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 20:28:35 +00:00
Scott Taylor
4507f1e04f Persisting <track> elements as the body of a [video] shortcode in MCE Views: 
* When generating the view's HTML, ensure that the shortcode's `content` is added to the model
* Add a `PostProcess` event in the `wpview` plugin to properly return the shortcode when the editor mode is toggled, ensuring that elements in the body are not dropped.

Props azaozz, wonderboymusic.
See #27915.




git-svn-id: https://develop.svn.wordpress.org/trunk@28183 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 18:20:54 +00:00
Scott Taylor
97c497abc2 Refinements for asynchronous rendering in wp.mce.media.PlaylistView: 
* Add `visibility: hidden` as an inline style to `<audio>` tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
* When creating new instances of `MediaElementPlayer`, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
* Rename `wp.media.mixin.unsetPlayer()` to `wp.media.mixin.unsetPlayers()` to reflect the above.
* Call `wp.media.mixin.unsetPlayers()` on the view's `unbind()` method, instead of inline in the `render()` method
* Make sure `WPPlaylistView` is instantiated for each editor instance
* Ensure that the `No Items Found` view state is not rendered when attachments actually do exist.

Props gcorne, wonderboymusic.
See #27899.




git-svn-id: https://develop.svn.wordpress.org/trunk@28182 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 17:52:06 +00:00
Andrew Nacin
620fc6660c TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink. 
props azaozz.
see #27963, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28181 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 13:49:28 +00:00
Andrew Nacin
adf4aa7393 Editor: Shrink the font size for the chosen format so it fits in more locales. 
props SergeyBiryukov.
see #27903, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28180 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 13:23:29 +00:00
Helen Hou-Sandi
c4db2733df Don't allow disabled input styling to get lost in the cascade. props ocean90. see #27906 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28179 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 20:54:13 +00:00
Scott Taylor
8c6b77a4da Use the proper translated string for Video Playlist "drag info" - the text displayed above the playlist's sortable attachments. 
See #27937.



git-svn-id: https://develop.svn.wordpress.org/trunk@28178 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 19:36:21 +00:00
Helen Hou-Sandi
2344fb91dc Simplify the admin menu notification selector so color schemes don't get stomped. props celloexpressions. see #27920 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28177 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 18:54:22 +00:00
Andrew Nacin
5295d232af Remove version string from Thickbox so it assumes the WP core version. Bust some caches. 
props celloexpressions.
see #27861, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28176 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 05:06:54 +00:00
Andrew Nacin
267c6371fa 4.0 version bumps. 
props kworthington.
fixes #27872, #27873.


git-svn-id: https://develop.svn.wordpress.org/trunk@28175 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 04:41:57 +00:00
Scott Taylor
99ca08fb55 Add calc() rules for max-width of playlist caption. 
Props celloexpressions.
See #27923.



git-svn-id: https://develop.svn.wordpress.org/trunk@28174 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 05:09:47 +00:00
Scott Taylor
a39eb76bc5 Support RTL properly when displaying playlists. 
Props SergeyBiryukov.
See #27924.



git-svn-id: https://develop.svn.wordpress.org/trunk@28173 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 04:26:59 +00:00
Scott Taylor
22c3cc1fec Properly account for text overflow in .wp-playlist-caption by adding display: block. 
Props celloexpressions.
See #27923.



git-svn-id: https://develop.svn.wordpress.org/trunk@28172 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 04:24:53 +00:00
Scott Taylor
47d8ce50b0 Add a compatibility layer in wp-playlist.js to avoid VM errors from MediaElement's plugin bridge in the TinyMCE views for playlists by suppressing playback for files whose mime-type is not supported in the user's browser natively. 
This is similar to how audio and video shortcodes are handled: file types are whitelisted for native playback.

See #27892.



git-svn-id: https://develop.svn.wordpress.org/trunk@28171 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 03:52:57 +00:00
Andrew Nacin
55a3551646 Customizer: Correct reference to the 'Add new image' button. 
props jjeaton.
see #27890, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 19:44:43 +00:00
Scott Taylor
29a1d6fe13 Don't show textareas that have "hidden" as a class in the media modal. 
See #27915.



git-svn-id: https://develop.svn.wordpress.org/trunk@28169 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:33:42 +00:00
Andrew Nacin
9ed158cc8c Properly translate 'Select Poster Image'. 
props dimadin.
see #27845, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28168 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:27:51 +00:00
Andrew Nacin
d798de002d Version bumps for Twenty Eleven, Twenty Twelve, Twenty Thirteen, Twenty Fourteen. 
props lancewillett.
see #27843.


git-svn-id: https://develop.svn.wordpress.org/trunk@28166 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:25:03 +00:00
Andrew Nacin
12d417d12a Update POT files for bundled themes. see #27843. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28165 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:22:16 +00:00
Andrew Nacin
77c11f6cc9 Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:17:12 +00:00
Andrew Nacin
9223056bb3 Fix logic inversion in [28124] to ensure widgets stay with themes during a theme switch. 
fixes #27897.


git-svn-id: https://develop.svn.wordpress.org/trunk@28161 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:11:24 +00:00
Andrew Nacin
47de352468 Use correct echoing context function. see #27889. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28160 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:08:05 +00:00
Andrew Nacin
cb4f555da4 Context for 'Installed' and 'Already Installed' theme strings. 
props SergeyBiryukov.
see #27889, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28159 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:07:30 +00:00
Scott Taylor
6ccd360ff4 Don't set the poster image for videos in a playlist if the image is the video mime-type icon blown up. 
See #27892.



git-svn-id: https://develop.svn.wordpress.org/trunk@28158 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-18 17:38:53 +00:00
Andrew Nacin
18f073cde0 Trunk is now 4.0-alpha. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28157 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 19:36:35 +00:00
Andrew Nacin
91f1a42b6a WordPress 3.9. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28153 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 18:00:26 +00:00
Mark Jaquith
3127edf4c8 Prevent customizer header image list from listing user images twice when no theme-specified images exist 
fixes #27839. props mcsf

git-svn-id: https://develop.svn.wordpress.org/trunk@28152 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 18:00:10 +00:00
Andrew Nacin
fc6d8f705f About page: Don't use wp_playlist_scripts() as that prints stuff. 
fixes #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28151 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 17:55:00 +00:00
Andrew Nacin
bd9e4f4f30 Final about page. 
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713, #27837.


git-svn-id: https://develop.svn.wordpress.org/trunk@28150 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 17:39:18 +00:00
Mark Jaquith
e05574bcf9 Ensure that wp.media.view.settings.post is set before accessing the post's id 
Avoids JS error in cases where media-editor is loaded individually
instead of with the whole `wp_enqueue_media()` process.

fixes #27836. props nacin

git-svn-id: https://develop.svn.wordpress.org/trunk@28149 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 15:25:35 +00:00
Andrew Nacin
43d194c3b6 Widgets: Better padding for translations of "Reorder". 
fixes #27788.


git-svn-id: https://develop.svn.wordpress.org/trunk@28148 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 13:07:01 +00:00
Andrew Nacin
2d4ea78457 Theme Installer: Properly call router navigation. 
props gcorne.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28147 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 03:05:52 +00:00
Andrew Nacin
9720c92028 About page: Use a better preposition to describe drag-and-drop. 
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28146 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:45:34 +00:00
Andrew Nacin
aeef0e992a Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.


git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:37:59 +00:00
Andrew Nacin
51882f8707 Graceful failures for TinyMCE views of video/audio playlists. 
props gcorne.
fixes #27821.


git-svn-id: https://develop.svn.wordpress.org/trunk@28144 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:22:28 +00:00
Andrew Nacin
6ac55e5a83 Widgets: Remove create_function() from the customizer class. 
props westonruter.
fixes #27805.


git-svn-id: https://develop.svn.wordpress.org/trunk@28143 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:10:09 +00:00
Andrew Ozz
48f7c5fce3 TinyMCE: fix icons in IE7, fixes #27829 
git-svn-id: https://develop.svn.wordpress.org/trunk@28142 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:09:10 +00:00
Andrew Nacin
68776bd079 Theme Installer: Fixes for browsers without pushState. 
props gcorne.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28141 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:03:57 +00:00
Andrew Nacin
6196b0811e Add missing string translation in widgets. 
see #27453, #27112.


git-svn-id: https://develop.svn.wordpress.org/trunk@28140 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:00:33 +00:00
Andrew Nacin
85925b39ad Cast wp_count_attachments() before iterating it to avoid a notice when items exist without a mime type. 
props bobbingwide.
fixes #27802.


git-svn-id: https://develop.svn.wordpress.org/trunk@28139 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 23:59:48 +00:00
Dion Hulse
60f6968d80 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
git-svn-id: https://develop.svn.wordpress.org/trunk@28137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 10:56:56 +00:00
Andrew Nacin
42747be0b2 Fix entities on about page. see #27713. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28136 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 09:21:55 +00:00
Andrew Nacin
31a847bb9c 3.9-RC2 
git-svn-id: https://develop.svn.wordpress.org/trunk@28135 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:58:01 +00:00
Andrew Nacin
0437f710a5 Allow the API to add text to auto update emails. 
fixes #27812.


git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:51:23 +00:00
Andrew Nacin
62a005f254 Fix typo on about page. 
props helen.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28133 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:25:10 +00:00
Andrew Nacin
fce82f9676 Final about page text. 
props siobhan, kerikae, DH-Shredder, nacin.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28132 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 07:52:32 +00:00
Drew Jaynes (DrewAPicture)
ecbe6226fa Inline documentation for three remaining hooks in wp-includes/general-template.php. 
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.

That's 184/184 hook docs files complete. Boom!

Props kpdesign, DrewAPicture.
Fixes #27719.


git-svn-id: https://develop.svn.wordpress.org/trunk@28131 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 04:41:37 +00:00
Drew Jaynes (DrewAPicture)
c91efaa74c Inline documentation for hooks in wp-includes/general-template.php. 
Props jesin, kpdesign.
See #27719.


git-svn-id: https://develop.svn.wordpress.org/trunk@28130 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 04:00:48 +00:00
Andrew Nacin
61cb5d3e49 Add a TTL to core update checks to allow us to narrow the 12-hour update window. 
props dd32.
fixes #27772.


git-svn-id: https://develop.svn.wordpress.org/trunk@28129 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 02:22:07 +00:00
Drew Jaynes (DrewAPicture)
93443ecd13 Inline documentation for hooks in wp-includes/media.php. 
Props scottlee for the initial patch. Props kpdesign, DrewAPicture.
Fixes #27718.


git-svn-id: https://develop.svn.wordpress.org/trunk@28128 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:35:49 +00:00
Andrew Nacin
606bf33d10 About page design, first pass. 
props melchoyce, ryelle.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28127 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:30:36 +00:00
Andrew Nacin
7ed14feff1 Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.


git-svn-id: https://develop.svn.wordpress.org/trunk@28126 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:15:43 +00:00
Andrew Nacin
16490ce89c Image Details modal: Remember the last state of the advanced toggle. 
props gcorne.
fixes #27366.


git-svn-id: https://develop.svn.wordpress.org/trunk@28125 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 23:55:04 +00:00
Andrew Nacin
a8efcb993f Customizer: Properly handle widget settings when activating a previewed theme. 
props westonruter, ocean90, gcorne.
fixes #27767.


git-svn-id: https://develop.svn.wordpress.org/trunk@28124 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 22:45:40 +00:00
Andrew Nacin
b807ab4a34 Theme installer: Improve route handling and make ?theme= work. 
props matveb.
fixes #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28123 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 22:05:20 +00:00
Andrew Nacin
7960418895 Color scheme support for widget choosers. 
props ocean90.
fixes #27793.


git-svn-id: https://develop.svn.wordpress.org/trunk@28122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 20:21:14 +00:00
Drew Jaynes (DrewAPicture)
6a8889ea8c Inline documentation for hooks in wp-includes/class-wp-customize-widgets.php 
Fixes #27531.


git-svn-id: https://develop.svn.wordpress.org/trunk@28117 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 18:40:29 +00:00
Andrew Ozz
cd356b6404 DFW: 
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709

git-svn-id: https://develop.svn.wordpress.org/trunk@28116 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 08:14:01 +00:00
Andrew Nacin
32721b8347 Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28113 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 07:47:10 +00:00
Andrew Nacin
e1c90794e5 TinyMCE: Always load translations, even in English, as we modify some strings. 
Move a setting to after the translations filter, and remove unused strings.

see #24067.


git-svn-id: https://develop.svn.wordpress.org/trunk@28112 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 03:22:38 +00:00
Drew Jaynes (DrewAPicture)
7c57669ec2 Inline documentation for hooks in wp-includes/link-template.php. 
Props johnbillion, DrewAPicture.
Fixes #27716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28111 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 02:12:48 +00:00
Andrew Ozz
bff230b422 Plupload: restore the settings in media_upload_form(), see #27763 
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:40:45 +00:00
Drew Jaynes (DrewAPicture)
11f2a0dc31 Inline documentation for hooks in wp-includes/functions.php. 
Props jesin, GaryJ.
Fixes #27715.


git-svn-id: https://develop.svn.wordpress.org/trunk@28109 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:19:37 +00:00
Andrew Nacin
5b4cd4b027 Plupload: Restore 3.8 handles and filenames to avoid breaking plugins. 
fixes #27763.


git-svn-id: https://develop.svn.wordpress.org/trunk@28108 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:06:03 +00:00
Andrew Nacin
c43b8b063d Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:59:01 +00:00
Drew Jaynes (DrewAPicture)
d2e679179b Part II of inline documentation for hooks in wp-includes/post.php. 
Documents all remaining hooks following [28041] and [28042]. Also updates the hash notation style for `wp_insert_post()`.

Props nacin for several hook descriptions.

Fixes #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28106 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:05:20 +00:00
Andrew Nacin
e7524d0ba7 Theme install: Set a timeout and error message for API responses. 
props ocean90.
fixes #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28105 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 19:01:21 +00:00
Andrew Nacin
4c254d8a97 Themes screen: Fix RTL layout issue in Firefox. 
props SergeyBiryukov.
fixes #27779.


git-svn-id: https://develop.svn.wordpress.org/trunk@28104 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:25:19 +00:00
Andrew Nacin
e22e40001d Don't auto-resize Quick Draft textarea in IE < 9. Avoids IE8 crash. 
props morganestes.
fixes #27761.


git-svn-id: https://develop.svn.wordpress.org/trunk@28103 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:24:25 +00:00
Andrew Nacin
a343c6020a Custom header: Fix image ordering. 
props ehg.
see #21785. fixes #27791.


git-svn-id: https://develop.svn.wordpress.org/trunk@28102 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:21:27 +00:00
Andrew Nacin
8e6a1f479b Customizer: Fix header image cropping when working with huge images. Affected Firefox in particular. 
props ehg.
fixes #27790.


git-svn-id: https://develop.svn.wordpress.org/trunk@28101 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:19:55 +00:00
Andrew Nacin
e164ec2461 Customizer: Account for a sidebar with no container to which classes can be added. 
props ocean90.
fixes #27780.


git-svn-id: https://develop.svn.wordpress.org/trunk@28100 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:40:07 +00:00
Andrew Nacin
f7d4569c8d Add context to string added in [28097]. 
props azaozz.
fixes #27785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28099 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:34:13 +00:00
Andrew Nacin
ffba43a0d9 Fix feature pointer border when using a color scheme. 
props ryelle.
see #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28098 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:32:39 +00:00
Andrew Nacin
42f6f43c35 Add missing 'Address' string for TinyMCE. 
props pavelevap, ocean90.
fixes #27785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28097 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:20:54 +00:00
Andrew Nacin
985727f256 RTL for login screen. 
props yoavf.
fixes #27784.


git-svn-id: https://develop.svn.wordpress.org/trunk@28096 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:05:16 +00:00
Andrew Ozz
07885ba6c9 Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal. 
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698

git-svn-id: https://develop.svn.wordpress.org/trunk@28095 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 04:01:53 +00:00
Andrew Ozz
3396375d47 RTL for TinyMCE: 
- Add _dir: 'rtl' to the TinyMCE translation object.
- Fix editor.css for RTL.
- Fix the Edit and Delete buttons position for wpview and images.
- For _mce_set_direction(), update documentation and fix adding the 'ltr' button.
Fixes #27773

git-svn-id: https://develop.svn.wordpress.org/trunk@28094 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 00:22:56 +00:00
Andrew Nacin
7a25da5240 The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28093 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:52:35 +00:00
Andrew Nacin
a9b0b8cd13 Translate another About string and use _e(). see #27713. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28092 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:51:56 +00:00
Andrew Nacin
36f7e292d2 Add an explanation for 'Paste from Word' in the 'Paste from Text' dialog. 
fixes #27777. see #27160.


git-svn-id: https://develop.svn.wordpress.org/trunk@28091 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:47:59 +00:00
Andrew Nacin
863116a5d2 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28090 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:47:12 +00:00
Andrew Ozz
027f0872bd Update the TinyMCE paste plugin to the latest development version. It includes a fix for pasting from Word: removes inline comments and change tracking. 
Changeset: f8cffdf342
Fixes #27771

git-svn-id: https://develop.svn.wordpress.org/trunk@28089 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:00:52 +00:00
Andrew Nacin
a1d4430fe0 About page: Translate all Under the Hood strings. 
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28088 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 19:38:49 +00:00
Andrew Nacin
aa08fb55ce User Query: Don't blindly re-append new meta queries for capabilities. 
fixes #21119.


git-svn-id: https://develop.svn.wordpress.org/trunk@28087 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 19:03:56 +00:00
Andrew Nacin
9defa138a4 Custom Headers: Allow for longer strings. 
props ehg.
see #27755.


git-svn-id: https://develop.svn.wordpress.org/trunk@28086 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:39:46 +00:00
Andrew Nacin
6c0420348e Update $_old_files for 3.9. see #27775. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28085 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:26:25 +00:00
Andrew Ozz
17a90fff8b TinyMCE wpViews: 
- Prevent undo steps from being added when the body of a wpview changes.
- Add unbind() to handle cleanup on DOM rebuilding in TinyMCE.
- Ensure that MediaElement's cleanup routine is run on every player in all instances of the editor.
- Initialize the players after some delay to ensure CSS is loaded.
Props gcorne and wonderboymusic, fixes #27389

git-svn-id: https://develop.svn.wordpress.org/trunk@28084 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:45:48 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:00:32 +00:00
Andrew Nacin
8f0329b452 Translate custom header customize control strings. Remove final added before beta to see what breakage we might cause by refactoring this class. 
see #21785. fixes #27738.


git-svn-id: https://develop.svn.wordpress.org/trunk@28082 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 23:24:32 +00:00
Andrew Ozz
8aacd10a8c Don't include the non-minified tinymce.js in /build. Load it when running from /src, else load wp-tinymce.js.gz (production) or tinymce.min.js (SCRIPT_DEBUG). Props nacin, fixes #27739 
git-svn-id: https://develop.svn.wordpress.org/trunk@28081 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 22:16:01 +00:00
Andrew Ozz
33e687ca57 Add the new modlas styling to the importer details Thickbox on Tools -> Import. Props ocean90, fixes #26952 
git-svn-id: https://develop.svn.wordpress.org/trunk@28080 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 21:49:18 +00:00
Andrew Ozz
2bde9b5b56 Fix color of disabled buttons in non-default color schemes, props ryelle, fixes #27759 
git-svn-id: https://develop.svn.wordpress.org/trunk@28079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 21:34:14 +00:00
Andrew Nacin
2d9949bf91 Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@28072 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 03:09:35 +00:00
Andrew Nacin
5dd9108e48 Editor: Ensure the link dialog does not display when styles are missing. 
props mattheu.
fixes #27605.


git-svn-id: https://develop.svn.wordpress.org/trunk@28071 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 03:08:23 +00:00
Andrew Ozz
d3b4c2359a Fix typo in var definition in [28069], see #27750 
git-svn-id: https://develop.svn.wordpress.org/trunk@28070 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 22:13:11 +00:00
Andrew Ozz
416b8e348f Fix tabbing out of the title field on Media -> Edit Media screen, fixes #27750 
git-svn-id: https://develop.svn.wordpress.org/trunk@28069 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 22:09:50 +00:00
Scott Taylor
824830ca01 Bump MediaElement.js to 2.14.2. Release Notes: 743f446523. 
Fixes #27582.



git-svn-id: https://develop.svn.wordpress.org/trunk@28068 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 21:31:24 +00:00
Andrew Ozz
2883034c6a Update TinyMCE to the current development version, 4.0.21.1. Fixes #27744 
git-svn-id: https://develop.svn.wordpress.org/trunk@28066 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 21:08:41 +00:00
Andrew Nacin
3e6d8864a9 XML-RPC: Fix bracing of conditionals around doc blocks. 
props redsweater, DrewAPicture.
fixes #27506.


git-svn-id: https://develop.svn.wordpress.org/trunk@28065 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-10 21:03:29 +00:00
Andrew Nacin
eef7258ca6 Update license copyright year to 2014. 
fixes #27728.


git-svn-id: https://develop.svn.wordpress.org/trunk@28064 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-09 23:49:05 +00:00
Andrew Ozz
c90a2a5d3b TinyMCE Views in IE8 and 7: change deselect event only for old IE, props gcorne, fixes #27546 
git-svn-id: https://develop.svn.wordpress.org/trunk@28063 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-09 15:28:17 +00:00
Andrew Ozz
b253355d2c Fix TinyMCE Views in IE8 and 7: 
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546

git-svn-id: https://develop.svn.wordpress.org/trunk@28062 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-09 00:57:46 +00:00
Andrew Ozz
0d6b3f3e3f TinyMCE: make sure vertical resizing and menubar show/hide are set to default for each instance, fixes #27724 
git-svn-id: https://develop.svn.wordpress.org/trunk@28059 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 18:57:18 +00:00
Andrew Nacin
244eca7982 3.9-RC1 
git-svn-id: https://develop.svn.wordpress.org/trunk@28058 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 18:18:03 +00:00
Andrew Nacin
3234ade164 Harden HMAC verification. props duck_. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28053 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 18:05:42 +00:00
Andrew Nacin
bef5bdc86a 3.9 about page text, rough cut. 
props markjaquith, nacin.
see #27713.


git-svn-id: https://develop.svn.wordpress.org/trunk@28052 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 17:46:48 +00:00
Andrew Nacin
402bb6208b Don't show featured images for image attachments. Remove abstractions for now. 
fixes #27673.


git-svn-id: https://develop.svn.wordpress.org/trunk@28051 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 17:39:58 +00:00
Andrew Nacin
248151298c Escape playlist data in templates. 
props wonderboymusic.
fixes #27710.


git-svn-id: https://develop.svn.wordpress.org/trunk@28050 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 17:39:06 +00:00
Andrew Nacin
9fab4162f6 Theme installer keyboard fixes. Updates [28033] and [28036]. 
props matveb.
see #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28049 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 16:23:26 +00:00
Scott Taylor
468c9d2ac7 Restore GalleryAdd() and GalleryEdit() in media-views.js to ensure back-compat. 
See [27362].



git-svn-id: https://develop.svn.wordpress.org/trunk@28048 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 15:53:42 +00:00
Dominik Schilling (ocean90)
b48bc8e7d3 Theme Installer: Prevent default events for "Upload Theme" and "Browse" buttons. 
see #27055.

git-svn-id: https://develop.svn.wordpress.org/trunk@28047 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 12:34:10 +00:00
Dominik Schilling (ocean90)
82ac1009c4 Move toolbar declaration after the :visible check, like it was before [28019]. 
props kovshenin.
fixes #24859.

git-svn-id: https://develop.svn.wordpress.org/trunk@28046 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 11:20:34 +00:00
Andrew Ozz
0e44baa89e Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055, #26907, #16284 
git-svn-id: https://develop.svn.wordpress.org/trunk@28045 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 08:28:57 +00:00
Dominik Schilling (ocean90)
ff78684898 Widget Customizer: Fix widget filtering. 
props westonruter.
fixes #27451.

git-svn-id: https://develop.svn.wordpress.org/trunk@28044 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 08:11:33 +00:00
Andrew Ozz
61d17c2163 DFW: 
- Move the word count and "Just Write" to a fixed bar at the bottom.
- Fix responsive mode to 480px. Narrower screens will have a scroll bar.
- Hide the Help button on screens < 480px, move the Save button to the right, make it bigger to match the others, and other responsive mode fixes.
Fixes #26907, see #27709

git-svn-id: https://develop.svn.wordpress.org/trunk@28043 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 07:48:55 +00:00
Drew Jaynes (DrewAPicture)
54e59a0290 Clarify documentation for hooks in sanitize_post_field(). 
* `edit_post_{$field}` pairs with `edit_{$field}`
* `pre_post_{$field}` pairs with `pre_{$field}`
* `post_{$field}` pairs with `{$field}`

As the above pairs' docs are unnecessarily duplicative, the second sets of docs have been removed. Also, the "duplicates" are purposely not marked as such in this case as the hook names differ. Also remove `@deprecated` tags mistakenly left in in [28041].

See #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28042 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 07:40:30 +00:00
Drew Jaynes (DrewAPicture)
a3d04ec9ed Part I of inline documenation for hooks in wp-includes/post.php. 
Adds docs for the following hooks:
* `get_attached_file`
* `update_attached_file`
* `_wp_relative_upload_path`
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `edit_post_{$field}`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `pre_post_{$field}`
* `{$field}_pre`
* `$field`
* `post_{$field}`
* `wp_count_posts`
* `wp_count_attachments`
* `post_mime_types`
* `wp_insert_post_empty_content`

See #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28041 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 06:48:32 +00:00
Drew Jaynes (DrewAPicture)
93b19f682e Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.


git-svn-id: https://develop.svn.wordpress.org/trunk@28040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 06:25:56 +00:00
Andrew Nacin
92381845b8 Media Templates: More escaping rather than interpolation. see #21785. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28039 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 05:27:44 +00:00
Andrew Nacin
24c0c60802 Theme Installer: Show 'Preview' button for installed themes. 
props adamsilverstein.
see #27055, see #27708.


git-svn-id: https://develop.svn.wordpress.org/trunk@28038 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:37:37 +00:00
Andrew Nacin
d5c3a966be Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:30:01 +00:00
Andrew Nacin
62b57b3b1f Theme Installer: Left/right arrow keys in the overlay. 
props adamsilverstein.
see #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28036 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:12:44 +00:00
nacin
1478afb236 Theme Installer: Use 'browse' instead of 'sort' for routes. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28035 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:12:02 +00:00
Andrew Nacin
0cff2558aa Widget Customizer: Fix incorrect replacement in [27995]. 
props westonruter.
fixes #27690.


git-svn-id: https://develop.svn.wordpress.org/trunk@28034 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:02:07 +00:00
Andrew Nacin
b47c6d0746 Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs. 
props adamsilverstein, DH-Shredder.
fixes #27521.


git-svn-id: https://develop.svn.wordpress.org/trunk@28033 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 03:57:01 +00:00
Andrew Nacin
288b1fd4f3 Nuke the TinyMCE help dialog as it is duplicated by help tabs. This leaves just Keyboard Shortcuts. 
fixes #27100.


git-svn-id: https://develop.svn.wordpress.org/trunk@28032 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 02:31:02 +00:00
Andrew Nacin
9875f51f1f Header Images: Add suggested dimensions to the media workflow. 
This updates [28030] to the latest patch.

props gcorne.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28031 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:56:42 +00:00
Andrew Nacin
d29a5cee5f Header Images: Add suggested dimensions to the media workflow. 
props ehg, gcorne.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28030 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:54:44 +00:00
Andrew Nacin
1fa68e490b Expose toolbar keyboard shortcut in Help documentation for TinyMCE. 
props joedolson, jorbin.
fixes #27024.


git-svn-id: https://develop.svn.wordpress.org/trunk@28029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:38:42 +00:00
Andrew Nacin
e0989568d2 TinyMCE help: Break up strings changed in [28027] for ease of changing later. 
Restores a not inaccurate paragraph to reduce churn.

see #27100.


git-svn-id: https://develop.svn.wordpress.org/trunk@28028 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 01:18:15 +00:00
Andrew Ozz
4360d117e2 TinyMCE help modal: 
- Don't load the old tiny_mce_popup.js.
- Add the shortcut for <code> and the second shortcut for link to the shortcuts listing.
- Update some of the text.
See #27100

git-svn-id: https://develop.svn.wordpress.org/trunk@28027 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 23:52:55 +00:00
Drew Jaynes (DrewAPicture)
c386c17457 Improve hook docs for the wp_enqueue_editor hook, added in 3.9. 
See #16284, #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28026 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 23:08:46 +00:00
Andrew Nacin
bcc41afd37 Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections. 
props matveb.
see #27055. fixes #27695.


git-svn-id: https://develop.svn.wordpress.org/trunk@28025 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 23:03:05 +00:00
Andrew Ozz
e28f610ead Fix typo and add more text to the error shown when 'wpdialogs' is not enqueued. Add 'wp_enqueue_editor' action fired when scripts and styles for the editor are being enqueued, fixes #16284 
git-svn-id: https://develop.svn.wordpress.org/trunk@28024 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:54:13 +00:00
Scott Taylor
0d6acf5b5b Make playlist tracks keyboard-accessible. 
Fixes #27644.



git-svn-id: https://develop.svn.wordpress.org/trunk@28023 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:27:06 +00:00
Andrew Nacin
82bc9c1142 Rename USE_EXT_MYSQL to WP_USE_EXT_MYSQL. see #21663. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28022 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:26:19 +00:00
Andrew Nacin
9bb79a1a97 Clean up deprecated format_to_post() docs. see #27700. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28021 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:23:00 +00:00
Drew Jaynes (DrewAPicture)
0bd5e6c02e More formatting for functions deprecated in 3.9. 
Props kpdesign.
Fixes #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28020 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:16:37 +00:00
Helen Hou-Sandi
784d1dc9bf Only show the media library loading spinner if we're scrolled toward the bottom. Prevents the spinner from flashing a second time when first loading the library due to a second query firing after initial load. 
props kovshenin. fixes #24859.


git-svn-id: https://develop.svn.wordpress.org/trunk@28019 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:14:01 +00:00
Drew Jaynes (DrewAPicture)
8b9371e915 Even deprecated functions can use a little PHPDoc formatting, time to time. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28018 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:11:55 +00:00
Drew Jaynes (DrewAPicture)
13d5b7c461 Improve hook docs for the resetpass_form hook added in 3.9. 
See #21044, #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28017 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:05:51 +00:00
Drew Jaynes (DrewAPicture)
aba414af7e PHPDoc fixes for functionality in wp-includes/wp-db.php added in 3.9. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28016 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 22:01:37 +00:00
Drew Jaynes (DrewAPicture)
7736833039 PHPDoc fixes for wp_validate_logged_in_cookie(), introduced in 3.9. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28015 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:43:00 +00:00
Drew Jaynes (DrewAPicture)
ef4d73dafc Fix PHPDoc formatting for WP_Rewrite::add_endpoint(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28014 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:38:34 +00:00
Dominik Schilling (ocean90)
c80074d551 Widget Customizer: Update icons to new Dashicons, part 2. 
props Michael Arestad.
fixes #27400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28013 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:36:52 +00:00
Andrew Ozz
5706a463bd TinyMCE: show an error in the console when a plugin attempts to use the 'wpdialogs' plugin but wpdialog.js is not enqueued, fixes #16284 
git-svn-id: https://develop.svn.wordpress.org/trunk@28012 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:34:18 +00:00
Drew Jaynes (DrewAPicture)
f96adcea2d Add a missing @since 3.9.0 to the PHPDoc for wp_register_plugin_realpath(). 
See #16953, #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28011 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:33:30 +00:00
Drew Jaynes (DrewAPicture)
18d6713716 Improve inline documentation for functionality in wp-includes/plugin.php added in 3.9. 
See #14994, #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28010 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:29:04 +00:00
Andrew Nacin
55d6cc4e1d Formally deprecate wpmu_current_site(). 
props jeremyfelt.
fixes #27702.


git-svn-id: https://develop.svn.wordpress.org/trunk@28009 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:27:13 +00:00
nacin
5404d9933f Gallery Views: Avoid JS errors when image attachments lack metadata. 
props gcorne.
fixes #27691.


git-svn-id: https://develop.svn.wordpress.org/trunk@28008 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:24:02 +00:00
Drew Jaynes (DrewAPicture)
c765ed8832 Inline documentation fixes related to the determine_current_user filter 
See #26706, #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28007 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 21:17:44 +00:00
Drew Jaynes (DrewAPicture)
372e6c5c94 Inline documentation improvements in wp-includes/ms-load.php for 3.9 functionality. 
Clarifies some mixed type parameters, spacing and comment style, and language fixes.

See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28006 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:58:11 +00:00
Dominik Schilling (ocean90)
6b007e8345 Widget Customizer: Update icons to new Dashicons. 
props melchoyce.
see #27400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28005 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:49:40 +00:00
Drew Jaynes (DrewAPicture)
9131bc6cbf General PHPDoc improvements in wp-includes/media.php for 3.9 functionality. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28004 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:37:17 +00:00
Drew Jaynes (DrewAPicture)
3011b3efef Space vs tab in function descriptions for wp_underscore_audio_template() and wp_underscore_video_template(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28003 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:28:05 +00:00
Andrew Nacin
f9e150c068 wpdb: Don't pass a second argument to mysqli_fetch_field(). 
props pento.
fixes #27693.


git-svn-id: https://develop.svn.wordpress.org/trunk@28002 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:21:16 +00:00
DrewAPicture
9415376529 Improve PHPDoc formatting for get_the_permalink(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28001 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:21:02 +00:00
Drew Jaynes (DrewAPicture)
c48069343d Use suggested language conventions in the hook docs description for the theme_page_templates filter. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@28000 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:17:55 +00:00
Andrew Nacin
e724e1b06f Don't try to resolve symlinks for single-file plugins. plugins_url() should not be used in this context anyway. 
props rmccue.
fixes #16953.


git-svn-id: https://develop.svn.wordpress.org/trunk@27999 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:14:34 +00:00
Drew Jaynes (DrewAPicture)
4d4921a9ac Use the correct parameter variables in the hook docs for wp_upgrade. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27998 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:13:00 +00:00
Drew Jaynes (DrewAPicture)
3b7d881f3c Align parameters in the hook docs for the attachment_thumbnail_args filter. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27997 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:10:01 +00:00
Drew Jaynes (DrewAPicture)
95294a170e Add missing parameter descriptions to the PHPDocs for WP_Upgrader_Skin::decrement_update_count() and Bulk_Upgrader_Skin::decrement_update_count(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27996 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:01:35 +00:00
Dominik Schilling (ocean90)
6e3b6066e5 Widget Customizer: Cleanup wp.customize.Widgets.SidebarControl. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27995 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 19:59:49 +00:00
Andrew Nacin
06152cbe6f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27990 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 17:58:37 +00:00
Dominik Schilling (ocean90)
51d6831f14 Update Dashicons. 
New icons: `.dashicons-external`, `.dashicons-editor-contract` and `.dashicons-universal-access-alt`.
Updated icons: `.dashicons-code`, `.dashicons-universal-access`, `.dashicons-arrow-x-alt` and `.dashicons-arrow-x-alt2`.
Restores also `.dashicons-post-trash` as an alias for `.dashicons-trash`, which is the new one.

props melchoyce, empireoflight.
see #26936.

git-svn-id: https://develop.svn.wordpress.org/trunk@27989 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 17:51:44 +00:00
Dominik Schilling (ocean90)
ce4961c9f7 Widget Customizer: Cleanup wp.customize.Widgets.WidgetControl. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27988 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 16:31:52 +00:00
Scott Taylor
4322e0c50a Browsers other than Firefox need a timeout when parsing audio and video shortcodes into MCE views. 
See [27655].



git-svn-id: https://develop.svn.wordpress.org/trunk@27987 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 15:11:04 +00:00
Dominik Schilling (ocean90)
18d485fb32 Widget Customizer: Make the available widgets panel a Backbone view. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27986 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 14:09:53 +00:00
Dominik Schilling (ocean90)
da677f34aa Widget Customizer: Move WidgetCustomizer to wp.customize.Widgets. First pass. 
see #27690.

git-svn-id: https://develop.svn.wordpress.org/trunk@27985 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 09:03:18 +00:00
Dominik Schilling (ocean90)
b0ba84a25c Remove trailing whitespace from [27982]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27984 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 09:02:06 +00:00