Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.
See #35417.
git-svn-id: https://develop.svn.wordpress.org/trunk@36416 602fd350-edb4-49c9-b593-d223f7449a82
* Introduce `WP_Customize_Manager::get_nonces()` to consolidate logic for retrieving nonces.
* Export nonces centrally in `wp.customize.settings.nonce` with each request and update nav menus preview to utilize.
* Send updated nonces to preview upon `nonce-refresh`.
* Request full preview refresh if Nav Menu selective refresh request fails (e.g. due to bad nonce).
* Update nav menus and widgets in Customizer to utilize `customize_refresh_nonces` for exporting nonces and keeping them up to date.
See #27355.
Fixes#35617.
git-svn-id: https://develop.svn.wordpress.org/trunk@36414 602fd350-edb4-49c9-b593-d223f7449a82
* Ensure that Setting `Value` objects in preview get initial `_dirty` flag set if values among POST data.
* Upon `saved` event, send `saved` message to preview with the `response` to trigger `saved` event there.
* Reset `_dirty` flag for all setting `Value` objects in preview upon `saved`.
* Continue to create settings synced from pane even after initial bootstrap, and create them as dirty.
* Ensure that `id` property is set for setting `Value` objects in preview.
See #27355.
Fixes#35616.
git-svn-id: https://develop.svn.wordpress.org/trunk@36407 602fd350-edb4-49c9-b593-d223f7449a82
Leads and contributing developers will now look nicer when focused.
Also, combines adjacent image and text links for the same resource thus
simplifying markup and reducing noise for screen reader users.
Props walbo, afercia.
Fixes#34953.
git-svn-id: https://develop.svn.wordpress.org/trunk@36406 602fd350-edb4-49c9-b593-d223f7449a82
Plugins installed in the plugins/ folder can be activated by users. This puts the plugin in an "active" state. Plugins in the mu-folder/ are "must-use" plugins that are always loaded. They can't be activated, and thereby can't be "active." Because of this, using the `is_plugin_active()` or `is_plugin_active_for_network()` returns false when checking for these plugins. This clarifies that behavior in the functions' docs.
git-svn-id: https://develop.svn.wordpress.org/trunk@36397 602fd350-edb4-49c9-b593-d223f7449a82
Uses the existing `#72777c` on white backgrounds and the new `#555d66` "dark medium gray" on darker backgrounds.
Fixes#35605.
git-svn-id: https://develop.svn.wordpress.org/trunk@36396 602fd350-edb4-49c9-b593-d223f7449a82
List tables on these three screens look similar but come with unexpected caveats.
The network themes screen in particular has been neglected, using a `.plugin`
class to inherit its sibling's styles and not providing classes and data
attributes that the other two offer. This will provide some more consistency.
Fixes#35335.
git-svn-id: https://develop.svn.wordpress.org/trunk@36394 602fd350-edb4-49c9-b593-d223f7449a82
Fixes a layout issue in the Customizer UI. Also de-duplicate title display logic, outputting "Loading..." as site title in PHP with actual title being set upon Customizer `ready`. Also update the site title in response to a `blogname` setting change as opposed to `input` DOM events on the control.
Fixes#35579.
git-svn-id: https://develop.svn.wordpress.org/trunk@36388 602fd350-edb4-49c9-b593-d223f7449a82
After [36381], the default value of `0` was causing the list table at
edit-comments.php to be empty. `false` prevents this.
This fix is likely temporary, while more research is done into the backward
compatibility concerns tied to [36381].
See #35090.
git-svn-id: https://develop.svn.wordpress.org/trunk@36387 602fd350-edb4-49c9-b593-d223f7449a82
Add missing `params.completeCallback` to `MenuItemControl.focus()` for parity with `Control.focus()`. Also adds `params` to `MenuItemControl.expandForm`, `MenuItemControl.collapseForm()`, and `MenuItemControl.toggleForm()`.
Props MattGeri, westonruter.
Fixes#32681.
git-svn-id: https://develop.svn.wordpress.org/trunk@36383 602fd350-edb4-49c9-b593-d223f7449a82
Also, adds missing labels and improves the existing ones.
Updates the "custom links" labels and inputs in the Customizer too.
Introduces a generic, reusable, `.wp-initial-focus` CSS class to be used for
the sole purpose of setting the initial focus.
"Quick Search": uniform the attached events and avoids new AJAX requests to
be triggered when the pressed key doesn't change the searched term.
Fixes#35374.
git-svn-id: https://develop.svn.wordpress.org/trunk@36379 602fd350-edb4-49c9-b593-d223f7449a82
We still generate the `wp-admin.*` files for compabitility purposes, however they only include the `@import()` lines.
Fixes#35229
git-svn-id: https://develop.svn.wordpress.org/trunk@36341 602fd350-edb4-49c9-b593-d223f7449a82
In r35674 only the local variables were unset, when using `unset()` with a global variable the `$GLOBALS` array must be used.
Fixes#35506.
git-svn-id: https://develop.svn.wordpress.org/trunk@36339 602fd350-edb4-49c9-b593-d223f7449a82
* Show a "Media attachment reattached."/"Media attachment detached." message when only one attachment was attached/detached.
* Use the string placeholder as `number_format_i18n()` returns a string.
* Add translator comments.
* Update help text to refer to the new dropdown menus.
* Add a more generic title to the attach modal.
Fixes#33237.
git-svn-id: https://develop.svn.wordpress.org/trunk@36328 602fd350-edb4-49c9-b593-d223f7449a82
This improves performance since browsers won't re-download the scripts and styles when there was no change in `$wp_version`.
Props sergej.mueller, dd32, swissspidy.
Fixes#28722.
git-svn-id: https://develop.svn.wordpress.org/trunk@36312 602fd350-edb4-49c9-b593-d223f7449a82
This is similar to `edit.php` -> `post.php` and `users.php` -> `user-edit.php` and fixes a bug where screen options for the list table were shown while editing a term.
Fixes#34988.
git-svn-id: https://develop.svn.wordpress.org/trunk@36308 602fd350-edb4-49c9-b593-d223f7449a82
Avoids a focus loss when saving or closing the form moving focus back to a proper place.
Uses `wp.a11y.speak()` to dispatch successful edits and error messages to screen readers.
Fixes#34756.
git-svn-id: https://develop.svn.wordpress.org/trunk@36303 602fd350-edb4-49c9-b593-d223f7449a82
After [36182], plugin data contains compatibility info from the API, which is an array and cannot be searched.
Fixes#35461.
git-svn-id: https://develop.svn.wordpress.org/trunk@36301 602fd350-edb4-49c9-b593-d223f7449a82
Also maintains visual separation for Broken Themes table on searches that
return no results.
See [36171] for `.wp-clearfix`.
Props 5um17, obenland, valendesigns, afercia.
Fixes#26646.
git-svn-id: https://develop.svn.wordpress.org/trunk@36270 602fd350-edb4-49c9-b593-d223f7449a82
Date and time formats are now displayed in plain text and available for all
users. Also, lines up them with the "custom" date and time format fields to
help reinforce what these fields do.
Props afercia, perezlabs.
Fixes#35064.
git-svn-id: https://develop.svn.wordpress.org/trunk@36263 602fd350-edb4-49c9-b593-d223f7449a82
This allows taxonomy metaboxes to be registered in a greater variety of
locations on the Dashboard.
Props johnjamesjacoby..
Fixes#35349.
git-svn-id: https://develop.svn.wordpress.org/trunk@36227 602fd350-edb4-49c9-b593-d223f7449a82
For accessibility, all interactive controls must be operable from the keyboard.
Replaces `<div>`s used as UI controls with buttons. Groups some logically-related
form elements.
Fixes#28864.
git-svn-id: https://develop.svn.wordpress.org/trunk@36223 602fd350-edb4-49c9-b593-d223f7449a82
The plugin file is unique while there can be more than one plugin with the
same slug. This also allows us to simplify the way updates from the plugin
detail iframe are executed.
See [36205].
Fixes#35350.
git-svn-id: https://develop.svn.wordpress.org/trunk@36221 602fd350-edb4-49c9-b593-d223f7449a82
Removes id attributes with non-unique plugin slug and adds a data attribute
with the unique plugin file.
Props khag7.
Fixes#18974.
git-svn-id: https://develop.svn.wordpress.org/trunk@36205 602fd350-edb4-49c9-b593-d223f7449a82
Makes the count bubble selector a little more specific to avoid interfering
with the admin menu, but not too specific for installed theme searches not to
update the bubble.
See [29786], [31495].
Fixes#35332.
git-svn-id: https://develop.svn.wordpress.org/trunk@36204 602fd350-edb4-49c9-b593-d223f7449a82
Uses `aria-label` and `screen-reader-text` where appropriate. Also removes
the default title attribute output by `privacy_on_link_title`, preserving
the ability to use the filter.
Fixes#35049.
git-svn-id: https://develop.svn.wordpress.org/trunk@36172 602fd350-edb4-49c9-b593-d223f7449a82
`.wp-clearfix` is now the recommended way to clear and contain floated elements.
Adds back compatibility for the `.nav-tab-wrapper` navigation tabs.
See #26396.
git-svn-id: https://develop.svn.wordpress.org/trunk@36171 602fd350-edb4-49c9-b593-d223f7449a82
"URL" has essentially entered language as a self-contained concept, there's
no more need to expand it with an `<abbr>` element and a title attribute.
Fixes#35174.
git-svn-id: https://develop.svn.wordpress.org/trunk@36142 602fd350-edb4-49c9-b593-d223f7449a82
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.
Fixes#35112 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@36137 602fd350-edb4-49c9-b593-d223f7449a82
The lack of space resulted in SQL error when searching for posts by content.
Props yetAnotherDaniel, johnbillion.
Fixes#35246.
git-svn-id: https://develop.svn.wordpress.org/trunk@36113 602fd350-edb4-49c9-b593-d223f7449a82
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.
Props afercia.
Fixes#35141.
git-svn-id: https://develop.svn.wordpress.org/trunk@36092 602fd350-edb4-49c9-b593-d223f7449a82
[34370] made the order that tabs are returned respect the order they are added, however it broke the respect of priority. By using a ksort instead of a sort, we can restore that default behavior. This adjusts the unit tests so that both order added and priority are tested.
Props meitar, swissspidy, jorbin
Fixes#35215. See #33941.
git-svn-id: https://develop.svn.wordpress.org/trunk@36089 602fd350-edb4-49c9-b593-d223f7449a82
This restores the reassign form when a user has a non-public post type or links assigned to them.
Props swissspidy & tharsheblows for initial patches.
Fixes#34993 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@36068 602fd350-edb4-49c9-b593-d223f7449a82
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.
Fixes#35029.
git-svn-id: https://develop.svn.wordpress.org/trunk@36053 602fd350-edb4-49c9-b593-d223f7449a82
Adds `aria-label` attributes on some links and on the "update nag" link. Adds translator comments.
Fixes#35167.
git-svn-id: https://develop.svn.wordpress.org/trunk@36032 602fd350-edb4-49c9-b593-d223f7449a82
When JavaScript is off, the reorder menu item and Edit menu item links now use `aria-label`
attributes instead of title attributes.
Fixes#35134.
git-svn-id: https://develop.svn.wordpress.org/trunk@36016 602fd350-edb4-49c9-b593-d223f7449a82
The title attribute is now replaced with plain text in a `howto` paragraph, as done for example in the Tags postbox.
Adds an `aria-describedby` attribute on the thumbnail link to target the description.
Also, fixes the focus style on the featured image thumbnail.
Fixes#35076.
git-svn-id: https://develop.svn.wordpress.org/trunk@36000 602fd350-edb4-49c9-b593-d223f7449a82
Title attributes are now replaced with `aria-label` where appropriate.
Also fixes some typos in the DocBlocks.
Fixes#35135.
git-svn-id: https://develop.svn.wordpress.org/trunk@35998 602fd350-edb4-49c9-b593-d223f7449a82
Adds an `aria-describedby` attribute targeting the input field description and styles the description as a... description.
Fixes#35123.
git-svn-id: https://develop.svn.wordpress.org/trunk@35983 602fd350-edb4-49c9-b593-d223f7449a82
There is no great value in generating reference pages for these funcitons as they explicitly serve a core-only purpose.
See #32246.
git-svn-id: https://develop.svn.wordpress.org/trunk@35966 602fd350-edb4-49c9-b593-d223f7449a82
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.
Patch prepared during WordCamp US 2015 Contributor Day.
Props mcapybara, garusky, takayukister.
See #26504.
Fixes#34867.
git-svn-id: https://develop.svn.wordpress.org/trunk@35947 602fd350-edb4-49c9-b593-d223f7449a82
Title attributes in the "Themes" screen and in the "Edit Site" screen Themes tab
are now replaced with `aria-label` attributes. Also, replaces string
concatenation with `add_query_arg()` and `sprintf()` to allow translator
comments to be properly parsed and for better code readability.
Props SergeyBiryukov, afercia.
Fixes#35051.
git-svn-id: https://develop.svn.wordpress.org/trunk@35924 602fd350-edb4-49c9-b593-d223f7449a82
When a page number is manually entered in the sites list table and no bulk action is selected, add `paged` as a query argument to the redirect.
Fixes#32982.
git-svn-id: https://develop.svn.wordpress.org/trunk@35917 602fd350-edb4-49c9-b593-d223f7449a82
Add hyphens to the list of allowed characters and add the `description` class to helper text paragraph tag.
Props thomaswm for the initial patch.
Fixes#26388.
git-svn-id: https://develop.svn.wordpress.org/trunk@35893 602fd350-edb4-49c9-b593-d223f7449a82
Also, avoids two related PHP notices when empty or not set (and thus the global `$tag` is a WP_Error object).
Fixes: #34515.
git-svn-id: https://develop.svn.wordpress.org/trunk@35875 602fd350-edb4-49c9-b593-d223f7449a82
Search engines are only discouraged from indexing the site when the option is explicitly set to `0`.
Fixes#34860.
git-svn-id: https://develop.svn.wordpress.org/trunk@35873 602fd350-edb4-49c9-b593-d223f7449a82
Removes the title attribute from the Plugin details link and adds the Plugin name hidden with `screen-reader-text` within the link text.
Props Cheffheid.
Fixes#35001.
git-svn-id: https://develop.svn.wordpress.org/trunk@35866 602fd350-edb4-49c9-b593-d223f7449a82
We forgot to run `grunt precommit` before [35834] was committed.
This change doesn't need to be backported to the 4.4 branch, as it only affects Chrome < 26, it's really just to clean up the behaviour of `grunt precommit`.
See #34663.
git-svn-id: https://develop.svn.wordpress.org/trunk@35862 602fd350-edb4-49c9-b593-d223f7449a82
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.
If this breaks the internet, I'll eat my hat.
Fixes#28617
git-svn-id: https://develop.svn.wordpress.org/trunk@35848 602fd350-edb4-49c9-b593-d223f7449a82
Number inputs didn't match the height of other form elements. Now they have a height of 28px and 40px on mobile. Both align with the sizes of other elements.
Props valendesigns.
Fixes#28984.
git-svn-id: https://develop.svn.wordpress.org/trunk@35831 602fd350-edb4-49c9-b593-d223f7449a82
Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.
See #25493.
See #34825.
git-svn-id: https://develop.svn.wordpress.org/trunk@35818 602fd350-edb4-49c9-b593-d223f7449a82
