sergiotarxz/Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
33,714 Commits 2 Branches 473 Tags 137 MiB
ce773cbc6c
Commit Graph

4120 Commits

Author SHA1 Message Date
Andrew Nacin
7fe981c578 Remove unnecessary printf(). fixes #25321. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25439 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 19:11:37 +00:00
Scott Taylor
535ae26afd Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25438 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 18:35:43 +00:00
Sergey Biryukov
64eec20413 Inline documentation for hooks in wp-admin/export.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25435 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:01:49 +00:00
Sergey Biryukov
27d3a78193 Inline documentation for hooks in wp-admin/includes/comment.php. 
props mordauk.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25434 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-14 01:00:44 +00:00
Scott Taylor
402e61f269 Fix some undefined index notices related to Comment unit tests: 
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25433 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 22:17:51 +00:00
Scott Taylor
ac23d53402 * Avoid notices in tests/ajax/Autosave by bailing early when get_post() returns nothing. 
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25430 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 21:21:16 +00:00
Dion Hulse
9c1b30860c Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378 
git-svn-id: https://develop.svn.wordpress.org/trunk@25427 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 12:52:28 +00:00
Sergey Biryukov
a57529c720 Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25425 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:36:08 +00:00
Sergey Biryukov
f2c1db3663 Inline documentation for hooks in wp-admin/ms-delete-site.php. 
props NikV.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25424 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 09:10:18 +00:00
Dion Hulse
5959a7011b WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25422 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:52:11 +00:00
Dion Hulse
63956aa479 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25421 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-13 06:18:16 +00:00
Sergey Biryukov
96d12ddd9d Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25420 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 23:14:55 +00:00
Sergey Biryukov
529c973323 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php. 
props adamsilverstein.
see #25283.

git-svn-id: https://develop.svn.wordpress.org/trunk@25419 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 22:58:45 +00:00
Andrew Nacin
bb2908d613 Clear all transients (regardless of expiration) on all database upgrades. see #20316. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25416 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 21:13:18 +00:00
Andrew Nacin
8917f2b3bd Add populate_network_meta filter to populate_network(). 
props jeremyfelt.
fixes #25020.


git-svn-id: https://develop.svn.wordpress.org/trunk@25414 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:48:20 +00:00
Andrew Nacin
3631b81545 Fix comma placement in [25179]. 
props gradyetc.
see #15004, fixes #25298.


git-svn-id: https://develop.svn.wordpress.org/trunk@25413 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 20:15:30 +00:00
Helen Hou-Sandi
91d14be2e2 No space between // and duplicate_hook. see #25229 
git-svn-id: https://develop.svn.wordpress.org/trunk@25412 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:56:32 +00:00
Helen Hou-Sandi
67633ef09e Inline docs for hooks in wp-admin/options-writing.php. props siobhyb. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25411 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 18:52:38 +00:00
Helen Hou-Sandi
435c2b5686 Add file size to attachment publish meta box. props desrosj. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25403 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 15:09:35 +00:00
Dion Hulse
cccac649d5 Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884 
git-svn-id: https://develop.svn.wordpress.org/trunk@25396 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 06:56:20 +00:00
Sergey Biryukov
1b012770eb Inline documentation for hooks in wp-admin/options.php. 
props siobhyb.
see #25229.

git-svn-id: https://develop.svn.wordpress.org/trunk@25372 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 03:43:48 +00:00
Sergey Biryukov
a56e83373d Consistently call skin methods in WP_Upgrader. fixes #25254. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 02:42:10 +00:00
Sergey Biryukov
c05412b16c Fix invalid markup when searching for installed themes. fixes #25288. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25369 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-12 00:03:01 +00:00
Dion Hulse
ea6da7d5dc Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237 
git-svn-id: https://develop.svn.wordpress.org/trunk@25349 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-11 08:26:57 +00:00
Dion Hulse
47c25b41af Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259 
git-svn-id: https://develop.svn.wordpress.org/trunk@25347 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-11 08:08:35 +00:00
Scott Taylor
270cc9702d Check $profileuser->rich_editing for empty before using it in Edit User admin code. 
Props sorich87, c3mdigital.
Fixes #17328.



git-svn-id: https://develop.svn.wordpress.org/trunk@25330 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 22:48:27 +00:00
Andrew Nacin
2c0b23557a Ignore user ID post data. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25316 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 17:57:14 +00:00
Scott Taylor
d141191598 Consistently wrap author and excerpt nodes with CDATA in feeds. 
Fixes #18056.



git-svn-id: https://develop.svn.wordpress.org/trunk@25315 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 16:54:16 +00:00
Helen Hou-Sandi
37e5277651 Show the IP address, if available, in the comment edit screen submit meta box. props leewillis77. fixes #24638. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25314 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-10 14:40:15 +00:00
Dion Hulse
4a56e07c75 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577 
git-svn-id: https://develop.svn.wordpress.org/trunk@25308 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 07:53:15 +00:00
Dion Hulse
30827b47c1 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core(). 
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874


git-svn-id: https://develop.svn.wordpress.org/trunk@25307 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 06:44:25 +00:00
Dion Hulse
fb20ed8b5b WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589 
git-svn-id: https://develop.svn.wordpress.org/trunk@25306 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 03:05:01 +00:00
Dion Hulse
beaf91c019 WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25305 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 02:54:50 +00:00
Dion Hulse
2f40784d97 WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237 
git-svn-id: https://develop.svn.wordpress.org/trunk@25304 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-09 02:42:52 +00:00
Helen Hou-Sandi
bde3435a63 Alignment standards for [25296]. props DrewAPicture. see #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25300 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 22:06:21 +00:00
Sergey Biryukov
8e4a6b31cd Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25298 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 18:16:09 +00:00
Helen Hou-Sandi
ed6316d44b Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25297 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 16:19:39 +00:00
Helen Hou-Sandi
e9173ef83b Add media_submitbox_misc_sections and audio_submitbox_misc_sections filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25296 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 16:18:26 +00:00
Sergey Biryukov
f9bb59cb30 Clarify a string in discussion settings. props Ipstenu, DrewAPicture. fixes #16705. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25295 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-07 15:35:26 +00:00
Andrew Nacin
6bad3b660a Correct @since in admin-footer. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25288 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 17:37:15 +00:00
Scott Taylor
2661cd53fc Use get_the_title() when dealing with post_type-like items in the admin. 
Props nacin, DrewAPicture.
Fixes #14975.



git-svn-id: https://develop.svn.wordpress.org/trunk@25285 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 17:08:00 +00:00
Andrew Nacin
595284f699 Mark the hooks in custom-background.php as duplicates. 
* image_size_names_choose should be documented in wp-includes/media.php
 * wp_create_file_in_uploads should be documented in custom-header.php

see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25283 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 17:04:36 +00:00
Andrew Nacin
a342806b55 Document comment_edit_redirect. 
props dustyf.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25282 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 17:00:30 +00:00
Andrew Nacin
69a949d160 Add new ajax_query_attachments_args filter. 
props alex-ye.
fixes #24285.


git-svn-id: https://develop.svn.wordpress.org/trunk@25279 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 15:17:35 +00:00
Sergey Biryukov
e8daea7de7 Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross. 
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.

git-svn-id: https://develop.svn.wordpress.org/trunk@25277 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 14:09:07 +00:00
Dion Hulse
d9c5265303 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049 
git-svn-id: https://develop.svn.wordpress.org/trunk@25274 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 08:28:59 +00:00
Andrew Nacin
37d92f4851 Short descriptions for inline docs should end with a period, per the vast majority of core. see #25229. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25273 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 01:37:59 +00:00
Dion Hulse
9095e4b866 Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25272 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-06 01:32:09 +00:00
Andrew Nacin
ad1feed450 Stop using get_blogaddress_by_domain() when updating the siteurl/homeurl from the network admin. 
props jeremyfelt, SergeyBiryukov.
fixes #18242. see #25235.


git-svn-id: https://develop.svn.wordpress.org/trunk@25261 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 18:48:26 +00:00
Scott Taylor
4286692d7d Remove redundant checks in some update functions. Adds some readability/coding standards cleanup. 
Props miqrogroove, azaozz.
Fixes #22828.


git-svn-id: https://develop.svn.wordpress.org/trunk@25256 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 17:04:03 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this. 
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 16:33:50 +00:00
Andrew Nacin
90605e02e7 Hook docs for admin-footer.php. 
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25252 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 16:20:05 +00:00
Andrew Nacin
2f0d581810 Inline documentation for the welcome_panel hook. 
props natejacobs.
see #25229.


git-svn-id: https://develop.svn.wordpress.org/trunk@25250 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-05 16:06:16 +00:00
Scott Taylor
d10b9d32a0 Remove unnecessary checks before setting $wp_settings_* arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional array. 
Props scribu.
Fixes #17884.



git-svn-id: https://develop.svn.wordpress.org/trunk@25240 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 19:06:13 +00:00
Andrew Nacin
14da301031 Clarify a database upgrade string, for 3.7. 
props SergeyBiryukov.
fixes #24845.


git-svn-id: https://develop.svn.wordpress.org/trunk@25237 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 17:49:16 +00:00
Dion Hulse
7c8107734f Core Auto Updates: Add a initial skin to allow capturing the output from the upgrader without displaying it (such as we need during cron calls). 
This has been copied almost verbatim from the automatic-updater plugin with a few style tweaks and additional upgrade-possible check. See #22704


git-svn-id: https://develop.svn.wordpress.org/trunk@25228 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 07:16:16 +00:00
Dion Hulse
ea02f466c9 Upgrader: Split the UI "skins" out from the main Upgrader file into a seperate file to reduce the length of the files. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25227 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 06:34:38 +00:00
Sergey Biryukov
f913741b58 Avoid 'Only variables should be passed by reference' notice on Widgets screen. props jdgrimes. fixes #25225. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25226 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-04 05:10:43 +00:00
Dion Hulse
2da41fa7f0 Core Updates: Switch to using a new 1.7 version check API which will return extra auto-update packages when requested over SSL. The new API has switched to returning JSON. See #22704 
git-svn-id: https://develop.svn.wordpress.org/trunk@25219 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-03 03:21:59 +00:00
Sergey Biryukov
6d23209dca Consolidate similar menu locations strings. props DrewAPicture. fixes #24945. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25218 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-03 01:41:49 +00:00
Sergey Biryukov
f695ee97e1 Set min-height for menu item title. props garyc40. fixes #16787. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25211 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 17:34:49 +00:00
Sergey Biryukov
56731f831d Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25210 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 13:53:57 +00:00
Sergey Biryukov
8b16c9bba8 Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25209 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 11:25:16 +00:00
Sergey Biryukov
a82593e4e4 Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25208 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 11:18:35 +00:00
Sergey Biryukov
f64a9d63d8 Fix a grammar error on Permalink Settings screen. props celloexpressions. fixes #25210. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25206 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 10:03:58 +00:00
Sergey Biryukov
6bef163456 Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25204 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-02 03:24:33 +00:00
Sergey Biryukov
4e75fe1bf1 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25201 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-01 12:36:45 +00:00
Andrew Nacin
a86a9f671d Nav menus: Allow assigning a new menu to an existing location when no theme setting is currently saved. 
props ocean90.
see #25064, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25195 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-31 01:36:49 +00:00
Andrew Nacin
67f42435fe Hide 'Database Upgrade Required' on admin/network/upgrade.php when you are not being asked to upgrade, to prevent confusion. 
props duck_.
see #24845. see #23540.


git-svn-id: https://develop.svn.wordpress.org/trunk@25191 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-31 00:56:31 +00:00
Andrew Ozz
fdafa8b480 Fix folding/unfolding of the admin menu on new installs, props SergeyBiryukov, fixes #24921 for 3.6.1. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25186 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 17:10:11 +00:00
Dion Hulse
b518606d42 Plugin Upgrader: Plugin_Upgrader::upgrade() returns nothing in event of success, every other install(), upgrade() and bulk_upgrade() method returns true, so return true; 
git-svn-id: https://develop.svn.wordpress.org/trunk@25181 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 07:37:32 +00:00
Dion Hulse
e320a48146 Theme Upgrader: Be super-careful and check the contents of the $wp_theme_directories variable before merging it, if someone has changed it directly, or worse, unset it, this could've resulted in the $protected_directories being empty. See [25082] See #22501 
git-svn-id: https://develop.svn.wordpress.org/trunk@25180 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 07:34:24 +00:00
Andrew Nacin
21b61a9e6f Add signup_id primary key to $wpdb->signups, and add better indexes. 
props josephscott, pento, barry.
see #15004.


git-svn-id: https://develop.svn.wordpress.org/trunk@25179 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-30 04:29:06 +00:00
Andrew Nacin
0494df8152 Move wp-config-sample.php to the root of develop.svn. 
wp-config.php is now created in the root. wp-config-sample.php is properly copied over to the build directory for syncing to core.svn.

Add some ignores.

fixes #25185, see #24976.



git-svn-id: https://develop.svn.wordpress.org/trunk@25173 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-29 20:45:17 +00:00
Andrew Nacin
fba8c3dabe Avoid validating wildcard hostnames in populate_network() when multisite is already activated. 
props jeremyfelt.
fixes #25182.


git-svn-id: https://develop.svn.wordpress.org/trunk@25171 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-29 19:30:46 +00:00
Andrew Nacin
0b9a70d548 Return to 'Item' for term updated messages for the link_category taxonomy. 
props SergeyBiryukov, pavelevap.
fixes #18714.


git-svn-id: https://develop.svn.wordpress.org/trunk@25158 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-28 18:58:57 +00:00
Andrew Nacin
444d333872 Use Dropbox's zxcvbn library for our password meter. 
The library was added in [25156].

props duck_.
see #21737.


git-svn-id: https://develop.svn.wordpress.org/trunk@25157 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-28 16:08:19 +00:00
Dominik Schilling (ocean90)
c1827f73cd Replace duplicated lines in [25143] with an assignment. see #18714. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25144 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 21:24:59 +00:00
Andrew Nacin
d37203df8e Add a terms_updated_messages filter to edit-tags.php, along with taxonomy-specific strings. 
props johnbillion.
fixes #18714.


git-svn-id: https://develop.svn.wordpress.org/trunk@25143 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 21:12:40 +00:00
Helen Hou-Sandi
6ce20d366c Make shift-click checkbox range selection work in both directions. props c3mdigital, SergeyBiryukov. fixes #23427. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25141 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 20:49:33 +00:00
Andrew Nacin
65465e9c88 Don't create an edit link to a non-UI post type in the media list table. 
props johnbillion.
fixes #20453.


git-svn-id: https://develop.svn.wordpress.org/trunk@25140 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 20:48:40 +00:00
Andrew Nacin
328117ffbf Only show 'Preview' on the custom header screen if there is something to show. 
props nickmomrik.
fixes #14531.


git-svn-id: https://develop.svn.wordpress.org/trunk@25135 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-27 12:27:00 +00:00
Dominik Schilling (ocean90)
ad422b8366 Introduce show_in_menu for register_taxonomy. 
Accepts boolean: true to show, false to hide. If not set, the default is inherited from show_ui.

fixes #20930.

git-svn-id: https://develop.svn.wordpress.org/trunk@25133 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 22:34:56 +00:00
Andrew Nacin
7694a64c06 Press This: Add admin_head-like hooks that are specific to the page. 
props sillybean.
fixes #18843.


git-svn-id: https://develop.svn.wordpress.org/trunk@25131 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 20:59:44 +00:00
Andrew Nacin
d41c30be7a Network Admin: Hide the bulk actions checkbox for the main site. 
props ericlewis.
fixes #24463.


git-svn-id: https://develop.svn.wordpress.org/trunk@25125 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 18:45:30 +00:00
Andrew Nacin
42dee6ccf0 Add post-type-$post_type and taxonomy-$taxonomy admin body classes. 
props johnbillion.
fixes #19247.


git-svn-id: https://develop.svn.wordpress.org/trunk@25124 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 18:17:23 +00:00
Sergey Biryukov
a679d43131 Add 'taxonomy_parent_dropdown_args' filter for the parent dropdown on taxonomy term editing screens. props leewillis77. fixes #18166. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25123 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 17:30:46 +00:00
Ryan Boren
71793b661c Don't show the "Get Shortlink" button for pages with a ?page_id=x permalink. 
Props sillybean
fixes #14760


git-svn-id: https://develop.svn.wordpress.org/trunk@25122 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-26 16:05:46 +00:00
Sergey Biryukov
6edecc378d Avoid displaying multiple instances of the same feature pointers on a single screen. props nacin. fixes #25022 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25117 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-24 22:33:51 +00:00
Sergey Biryukov
bcd97dac0a Remove 'admin' as a fallback for username in install. props tivnet, DrewAPicture. fixes #24078. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25115 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-24 13:56:47 +00:00
Andrew Nacin
9211de7232 Add network name to <title> tags in the network admin and user admin (global dashboard). 
props johnbillion.
fixes #19753.



git-svn-id: https://develop.svn.wordpress.org/trunk@25103 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-23 18:57:33 +00:00
Sergey Biryukov
b449f5bbb8 Correct phpdoc for wp-admin/menu.php. props neoxx. fixes #25124. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25100 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-23 13:52:12 +00:00
Sergey Biryukov
2a3c60f37d Remove redundant context for Child Themes link. fixes #25079. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25099 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-23 00:30:50 +00:00
Sergey Biryukov
107d2b8716 Remove unused variable. props jeremyfelt. fixes #25121. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25098 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-23 00:18:48 +00:00
Andrew Nacin
f57bd31f2d Fix various typos in inline documentation. props nofearinc, fixes #25119. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25094 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 22:00:41 +00:00
Andrew Nacin
0c24a916d4 In the admin, do not use auto-generated Gravatar images for comment authors. 
This makes it easier to recognize Gravatars (or lack thereof) when moderating comments.

props solarissmoke.
fixes #7054.



git-svn-id: https://develop.svn.wordpress.org/trunk@25091 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 20:07:51 +00:00
Helen Hou-Sandi
5ea9e40fed Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25083 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 15:23:41 +00:00
Dion Hulse
2ceaba8b30 Theme Installer/Updater: Handle custom Theme directories when updating themes, and installing new themes. Fixes #22501 
git-svn-id: https://develop.svn.wordpress.org/trunk@25082 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 04:49:06 +00:00
Dion Hulse
ddad24c82c Sanitize the plugin path in _get_plugin_data_markup_translate() to a WP_PLUGIN_DIR-relative path. The function is designed in mind for receiving relative paths, but may be used with a absolute path. 
This change makes the function path-agnostic, and can accept either relative or absolute (converting to relative internally). Fixes #20813


git-svn-id: https://develop.svn.wordpress.org/trunk@25081 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-22 04:02:13 +00:00
Dion Hulse
ead4efa78a Add a note that the FTP Password will not be stored on the server to the FTP credentials page. Fixes #16492 
git-svn-id: https://develop.svn.wordpress.org/trunk@25071 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-21 07:06:12 +00:00
Dion Hulse
b4f0fbd985 Add a filter on the Plugin and Theme installers table listing API args, this allows for plugins to hook in and add custom args to plugins_api() and themes_api() for the Plugin/Theme listing tabls. Fixes #18169 
git-svn-id: https://develop.svn.wordpress.org/trunk@25070 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-21 06:51:51 +00:00
Dion Hulse
318a1c9c52 WP_Filesystem: Use the FTP_* path override constants during upgrades for prefixed paths, ie. use FTP_BASE for ABSPATH/sub-dir as well as just for ABSPATH/. Props vericgar for initial patch. See #14401 
git-svn-id: https://develop.svn.wordpress.org/trunk@25057 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-20 06:46:37 +00:00
Dion Hulse
e4361d8f96 Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063 
git-svn-id: https://develop.svn.wordpress.org/trunk@25056 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-20 06:23:48 +00:00
Dion Hulse
c6e43f5327 WP_Upgrader: Don't activate maintenance mode in bulk_upgrade() when no Themes or Plugins are specified. This doesn't affect Core, but rather, plugins who use the upgrade routines and do not do precautionary tests. Props jamescollins. Fixes #24496 
git-svn-id: https://develop.svn.wordpress.org/trunk@25048 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-17 05:35:17 +00:00
Helen Hou-Sandi
becf161fb8 Make sure quick edited non-alternate list table rows don't become alternate. props mordauk. fixes #24951. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25039 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 20:18:31 +00:00
Andrew Nacin
81248f6568 In populate_network(), insert the first site as blog_id 1, overriding any auto-increment DB seed. props wpmuguru, fixes #16568. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25038 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 20:07:05 +00:00
Andrew Nacin
38b4ca010a send_origin_headers() in admin-post.php. 
props nickdaugherty, fixes #24600.



git-svn-id: https://develop.svn.wordpress.org/trunk@25036 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 19:58:42 +00:00
Andrew Nacin
ea7196081f Add a maxlength attribute to the post password input, reflecting the current DB field length.\ 
props RayBernard, DrewAPicture.
see #24792.



git-svn-id: https://develop.svn.wordpress.org/trunk@25035 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 19:55:19 +00:00
Andrew Nacin
a1ff9555a9 Add actions for term editing/creation form tags, for adding enctype attributes. Matches the pattern we've used elsewhere. props JustinSainton, fixes #15261. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25034 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 19:53:50 +00:00
Ryan Boren
5125650b72 Be consistent with the arguments passed to the theme_action_links filter. Stop passing stylesheet from class-wp-ms-themes-list-table.php. 
Props georgestephanis
fixes #24478


git-svn-id: https://develop.svn.wordpress.org/trunk@25032 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-16 15:46:08 +00:00
Ryan Boren
17267dd999 wp_get_shortlink() improvements. 
* Return shortlinks for pages and public CPTs.
* Return shortlinks even when cruft-free links are not enabled.
* Unit tests

Props sillybean, layotte, cais
fixes #18632
see #14760



git-svn-id: https://develop.svn.wordpress.org/trunk@25030 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 20:08:06 +00:00
Helen Hou-Sandi
0de512789e Better align the x icons with tag names. props TobiasBg. fixes #25050. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25029 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 19:58:04 +00:00
Sergey Biryukov
6c3b030245 Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25028 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 16:24:08 +00:00
Helen Hou-Sandi
2225b6ff1f Make sure the close button in the Customizer still works after a refresh. props lessbloat. fixes #22682. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25027 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 13:48:05 +00:00
Dion Hulse
b971127bac Remove the usage of @$_GET and @$_POST and just check to see if the indicies are set. Fixes #22429 
git-svn-id: https://develop.svn.wordpress.org/trunk@25025 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 06:05:54 +00:00
Dion Hulse
51c3faba5d WP_Filesystem: Make WP_Filesystem_Base::search_for_folder() a bit more usable on the command-line when the $verbose mode is used, additionally, bail early from the function rather than repeating itself if the CWD is the root directory already. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25024 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-15 05:59:36 +00:00
Dominik Schilling (ocean90)
bf8e3cab1e Remove unused cat JavaScript file. props carldanley. fixes #24989. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25020 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-14 15:43:03 +00:00
Jon Cave
38345135a1 Add javascript files deleted in [25013] to $_old_files. See #23486. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25019 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-14 15:18:04 +00:00
Andrew Nacin
4483b947a4 Remove zero-byte files that were meant to be deleted in [23446]. see #23486. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25013 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-07 17:43:50 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository. 
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
 2013-08-07 05:25:25 +00:00