Commit Graph

27658 Commits

Author SHA1 Message Date
Dion Hulse eb39c8f75d Avoid a PHP Notice when requesting a url without a path component (http://example.com) in the Streams HTTP component.
Props barrykooij for inital patch; Fixes #27668


git-svn-id: https://develop.svn.wordpress.org/trunk@29853 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 06:43:14 +00:00
Dion Hulse 45cd55bfc4 When making a HTTP request to a non-standard port, include the port in the Host header for the Streams HTTP transport. This bring parity to the cURL transport and respects the HTTP RFC.
Props kamelkev for the initial patch; Fixes #28982


git-svn-id: https://develop.svn.wordpress.org/trunk@29852 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 06:14:58 +00:00
Dion Hulse 4ae1397f96 Correctly support Schemeless URLs in WP_HTTP::make_absolute_url() by respecting the 'host' field if present in the relative url.
Fixes #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29851 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:57:15 +00:00
Dion Hulse e4268adfde Correctly handle url's containing url's in WP_HTTP::make_absolute_url().
A valid relative URL could be mistaken for an absolute url if it contained a :// in any position of the url.
Fixes #28001


git-svn-id: https://develop.svn.wordpress.org/trunk@29850 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:37:56 +00:00
Dion Hulse 60b8ed120a Always cast the 'code' server response to an int, this provides consistency between both of the HTTP transports.
Previously cURL would return an int and Streams a numeric string.
Fixes #28887


git-svn-id: https://develop.svn.wordpress.org/trunk@29849 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:20:01 +00:00
Dion Hulse 2ed0d6cae0 Return the correct server response for the 'message' response field from the server.
Previously this would use the generic message corresponding to the response code, which isn't always accurate. Since we're already parsing the headers, we can simply return that directly (This also has the benefit that it's the same code for both Streams and Curl header handling).
Fixes #28919


git-svn-id: https://develop.svn.wordpress.org/trunk@29848 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-08 05:18:22 +00:00
Dominik Schilling (ocean90) 539d55e068 Update jQuery UI to 1.11.1.
Because jQUI's build process no longer provides individual minified files we need some additional changes:
* Rename all files, remove the "jquery.ui." prefix. Add old files to `$_old_files`.
* Add and use non-minified files in /src.
* Add grunt task to minify jQuery UI files.
* (Non-minified files will not be shipped.)

Changelogs:
* http://jqueryui.com/changelog/1.11.0/
* http://jqueryui.com/changelog/1.11.1/

props Fab1en, ocean90.
fixes #29833.

git-svn-id: https://develop.svn.wordpress.org/trunk@29847 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-07 15:27:56 +00:00
Sergey Biryukov 564598f068 Add aria-describedby attributes to comment_form().
props joedolson, bramd.
fixes #24148.

git-svn-id: https://develop.svn.wordpress.org/trunk@29846 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 22:10:08 +00:00
Boone Gorges e79c2e0c9e In get_terms(), select term taxonomy count for all values of 'fields'.
Not having the count caused queries with 'fields' values of 'id=>name' and
'id=>slug' to return incorrect results when querying a hierarchical taxonomy
with 'hide_empty=true'.

Includes unit tests for get_terms() when using various combinations of 'fields',
'hide_empty', and 'hierarchical' arguments.

Props technical_mastermind.
Fixes #29859.

git-svn-id: https://develop.svn.wordpress.org/trunk@29845 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 22:04:11 +00:00
Aaron Jorbin 3fa30bdd37 PHP 5.6 test failures shouldn't be allowed.
PHP 5.6 was released on 28 August 2014 and thus tests on it should be on the same level as all of our other PHP tests pass.

Fixes #29682
Props netweb



git-svn-id: https://develop.svn.wordpress.org/trunk@29844 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 20:00:54 +00:00
Drew Jaynes (DrewAPicture) d8ba2cf553 Add inline documentation for `WP_User_Query` default arguments in the form of a hash notation.
Adds documentation pointers from the class-level doc for `WP_User_Query`, as well as the `get_users()` doc.

Props tschutter.
Fixes #29846.


git-svn-id: https://develop.svn.wordpress.org/trunk@29843 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 15:35:49 +00:00
Sergey Biryukov 63760f6a3f Bundled themes: Add an alt attribute with the site title for header images linked to the home page.
props rianrietveld.
fixes #15926.

git-svn-id: https://develop.svn.wordpress.org/trunk@29842 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 12:43:55 +00:00
Andrew Ozz 107d754683 Add default z-index to the admin menu, see #29806
git-svn-id: https://develop.svn.wordpress.org/trunk@29841 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-06 01:59:46 +00:00
Sergey Biryukov 937d5cdd11 Translate some previously untranslated _doing_it_wrong() messages.
props georgestephanis.
fixes #25614.

git-svn-id: https://develop.svn.wordpress.org/trunk@29840 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 21:05:54 +00:00
Sergey Biryukov 65a0f4933a Network Admin: Properly check if the theme is active on the main site to avoid deleting it via bulk actions.
props ocean90.
fixes #29861.

git-svn-id: https://develop.svn.wordpress.org/trunk@29839 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 20:36:11 +00:00
Sergey Biryukov 37f96ce3e6 Fix misleading documentation in customize-loader.js.
props ericlewis.
fixes #29866.

git-svn-id: https://develop.svn.wordpress.org/trunk@29838 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 18:39:12 +00:00
Sergey Biryukov 4ba75673d8 Update @param docs for wp_get_attachment_image().
see #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29837 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 17:51:42 +00:00
Sergey Biryukov a21e5041dd Pass the requested size to 'wp_get_attachment_image_attributes' filter.
props mattheu.
fixes #29869.

git-svn-id: https://develop.svn.wordpress.org/trunk@29836 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 17:49:32 +00:00
Andrew Ozz d2c8c72e7f Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806.
git-svn-id: https://develop.svn.wordpress.org/trunk@29835 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-05 03:08:11 +00:00
Sergey Biryukov 1a7c4efa13 Fix setting default quality in WP_Image_Editor.
props markoheijnen.
fixes #29856 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29834 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-04 13:11:38 +00:00
Scott Taylor 07a38ff81a Allow PSDs (Photoshop documents) to be uploaded.
Props michalzuber, ccprice.
Fixes #28805.


git-svn-id: https://develop.svn.wordpress.org/trunk@29833 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 19:51:56 +00:00
Scott Taylor 11c914bca9 In the admin, give media list table icons `auto` for `width` and `height`. In the post thumbnail metabox, apply `width: auto`.
If someone turns on support SVG files, this will allow them to show up.

Props arippberger for an initial patch.
Fixes #26256.


git-svn-id: https://develop.svn.wordpress.org/trunk@29832 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 19:07:17 +00:00
Scott Taylor a6f6556fca For `attachment-compat` fields, show a spinner while `wp.media.model.Attachment.saveCompat()` is firing.
Fixes #27028.


git-svn-id: https://develop.svn.wordpress.org/trunk@29831 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 18:42:13 +00:00
Boone Gorges ecac4d4a94 Improve unit test coverage for wp_insert_term().
See #5809, #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@29830 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 13:30:22 +00:00
Dominik Schilling (ocean90) f7a4e22bdb Plugin search: Wrap results in a form to fix pagination's `paged` input field.
props jesin, ocean90.
see #18724, for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29829 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 13:07:18 +00:00
Sergey Biryukov 7d2f7c6ceb Switch line-height added in [29790] to a unitless value.
props janhenckens.
fixes #29451.

git-svn-id: https://develop.svn.wordpress.org/trunk@29828 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 09:41:24 +00:00
Sergey Biryukov b16654400f Twenty Fourteen: Move custom description for background color and image from sections to controls in the customizer.
props jb510.
fixes #29490.

git-svn-id: https://develop.svn.wordpress.org/trunk@29827 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 08:42:39 +00:00
Sergey Biryukov 3d0f4d9656 Use correct links for filtering plugin reviews.
props OriginalEXE.
fixes #29754.

git-svn-id: https://develop.svn.wordpress.org/trunk@29826 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 08:08:27 +00:00
Sergey Biryukov 990f01f81f Avoid a PHP notice in list_plugin_updates() if plugins_api() returned a WP_Error object.
fixes #29583.

git-svn-id: https://develop.svn.wordpress.org/trunk@29825 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-03 00:01:51 +00:00
Sergey Biryukov 569a80e488 Add unit tests for get_blog_details().
props jeremyfelt.
fixes #29845.

git-svn-id: https://develop.svn.wordpress.org/trunk@29824 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 21:47:25 +00:00
Sergey Biryukov dc62eeff36 Make link construction in get_comment_reply_link() and get_post_reply_link() more readable.
see #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29823 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 20:44:34 +00:00
Sergey Biryukov 07cf5c5c76 Add an aria-label attribute with commenter's name to get_comment_reply_link().
props joedolson, merty, andrewryno.
fixes #16433.

git-svn-id: https://develop.svn.wordpress.org/trunk@29822 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 20:40:35 +00:00
Sergey Biryukov 32dbb27701 * Use correct context for 'Name' and 'Parent' strings on taxonomy screens.
* Remove unnecessary context for 'Slug' and 'Description' strings.

props andg.
fixes #29824.

git-svn-id: https://develop.svn.wordpress.org/trunk@29821 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 20:00:11 +00:00
Sergey Biryukov c231361790 Use a more consistent markup on taxonomy and user screens.
props paulwilde.
fixes #29842.

git-svn-id: https://develop.svn.wordpress.org/trunk@29820 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 19:39:14 +00:00
Boone Gorges 6ffb0fcafb Always sanitize user_nicename in wp_insert_user().
Previously, a 'user_nicename' parameter passed into the function was
unsanitized. This could result in a mismatch between the sanitized nicename
generated automatically at user creation, resulting in broken author archive
permalinks.

Props joemcgill.

Fixes #29696.

git-svn-id: https://develop.svn.wordpress.org/trunk@29819 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 18:53:24 +00:00
Scott Taylor dcef5d4583 In `activate_plugin()`, do not re-run the activation routine for already-active network-wide plugins.
Adds unit test.

Props jbrinley.
Fixes #28651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29818 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:55:51 +00:00
Scott Taylor 46b4ea2a6c Network Admin Menu:
* Don't display update count for Themes when the user doesn't have the 'update_themes' cap
* Don't display update count for Plugins when there aren't any/count is `0`

Props peterchester.
Fixes #29651.


git-svn-id: https://develop.svn.wordpress.org/trunk@29817 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:48:36 +00:00
Scott Taylor 701dce21b1 In `wp_delete_attachment()`: account for orphan sizes by looping over the sizes stored in metadata, instead of relying on the current sizes stored in `$_wp_additional_image_sizes`.
Props JoshuaAbenazer, desrosj, markoheijnen.
Fixes #24518.


git-svn-id: https://develop.svn.wordpress.org/trunk@29816 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 15:31:57 +00:00
Sergey Biryukov f4c6eb964b When switching to the Text editor, make the textarea visible to screen readers.
props afercia.
fixes #29815.

git-svn-id: https://develop.svn.wordpress.org/trunk@29815 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 12:45:42 +00:00
Scott Taylor a7ea80e70b Remember when we added the `style` attribute to playlists? Fix `dark`.
Props karpstrucking.
Fixes #29530.


git-svn-id: https://develop.svn.wordpress.org/trunk@29814 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 05:27:18 +00:00
Scott Taylor bb07d10803 Add the `date` filter from media grid to the media modal.
Props janhenckens, wonderboymusic.
Fixes #28990.


git-svn-id: https://develop.svn.wordpress.org/trunk@29813 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 04:31:07 +00:00
Scott Taylor f52ca9047e After [29811], combine 2 `if` statements.
git-svn-id: https://develop.svn.wordpress.org/trunk@29812 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 04:15:07 +00:00
Scott Taylor 7711e9648c Media Grid/List Table parity: when `MEDIA_TRASH` is `true` and `trash` is the current filter for the grid, add a second bulk action button: "Delete Selected"
Fixes #29742.


git-svn-id: https://develop.svn.wordpress.org/trunk@29811 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 04:12:01 +00:00
Scott Taylor ec93f031b3 Media List Table: account for `MEDIA_TRASH` in the bulk action dropdown.
See #29742.


git-svn-id: https://develop.svn.wordpress.org/trunk@29810 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 03:11:49 +00:00
Sergey Biryukov 6dca7d1023 Add a class attribute for submit button in comment form.
props bainternet.
fixes #20446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29809 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:43:32 +00:00
Boone Gorges dd9e9501c1 WP_Comment_Query: comment__in, comment__not_in, post__in, post__not_in.
Props nofearinc, mordauk, boonebgorges

Fixes #25386

git-svn-id: https://develop.svn.wordpress.org/trunk@29808 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:40:56 +00:00
Sergey Biryukov c313878af2 Reorder placeholders for consistency. see [29806].
see #21089.

git-svn-id: https://develop.svn.wordpress.org/trunk@29807 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:37:05 +00:00
Scott Taylor 3a11531451 In the `wp_new_blog_notification()` email template, include the login url.
Props obenland, georgestephanis.
Fixes #21089.


git-svn-id: https://develop.svn.wordpress.org/trunk@29806 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:27:57 +00:00
Boone Gorges 6dc662431a Improve unit tests for WP_Tax_Query.
* Exhaustive tests for publicly available functionality of WP_Tax_Query.
* For tests that are related to the tax_query argument as used in WP_Query, move to tests/post/query.php.
* Add some tax_query tests to cover single vs multiple queries using AND and OR; various values for 'field'; various values for 'operator'.
* Improve test names.
* Correct @group annotations.
* Improve performance of some WP_Query-related tests by declaring 'update_post_meta/term_cache' false.

Fixes #29718

git-svn-id: https://develop.svn.wordpress.org/trunk@29805 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 01:07:20 +00:00
Sergey Biryukov c4fcdf329e Add classes to form containers on Edit User screen.
props jarednova.
fixes #29348.

git-svn-id: https://develop.svn.wordpress.org/trunk@29804 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-02 00:55:40 +00:00