Commit Graph

25 Commits

Author SHA1 Message Date
Scott Taylor
061bfddda9 Comment List Tables:
* Declare `$extra_items` property
* Since `->get_column_info()` overrides its parent's method, it doesn't need to set `_column_headers`, which is an undeclared property that is only used for caching the lookup after the first run in the parent class, which isn't called in the child class.
* `$_args` in `WP_List_Table` has to be `protected` for `WP_Post_Comments_List_Table` to legally access it. `$_args` is awkward as is and should probably be only available via a getter.

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30984 602fd350-edb4-49c9-b593-d223f7449a82
2014-12-20 23:27:00 +00:00
Sergey Biryukov
204e5dae21 Add missing label to comment type filter dropdown.
props afercia.
fixes #29922.

git-svn-id: https://develop.svn.wordpress.org/trunk@29872 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-11 02:25:17 +00:00
Sergey Biryukov
9e5beefd72 Don't display an empty comment author IP link on Comments screen.
props afercia.
fixes #29766.

git-svn-id: https://develop.svn.wordpress.org/trunk@29774 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-28 06:37:10 +00:00
Andrew Nacin
ca32a2d410 Pinking shears.
git-svn-id: https://develop.svn.wordpress.org/trunk@29707 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-04 15:22:58 +00:00
Helen Hou-Sandi
2f71d7d8e4 Comments: Simplify JS for inline edit and reply.
fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@29662 602fd350-edb4-49c9-b593-d223f7449a82
2014-09-02 03:56:05 +00:00
Drew Jaynes (DrewAPicture)
39ba840e04 Add @access tags to constructor docblocks in list table classes.
See #28679. See [29459].


git-svn-id: https://develop.svn.wordpress.org/trunk@29460 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:21:56 +00:00
Drew Jaynes (DrewAPicture)
126147a877 Document default arguments for the WP_List_Table class. Also add referenced docblocks to extending class constructors.
Props mikejolley for the initial patch.
Fixes #28679. See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@29459 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-10 02:17:14 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Scott Taylor
510ad2e1e9 Fix mismatches in access modifiers for WP_List_Table + subclasses.
Fixes #28843, #28879.


git-svn-id: https://develop.svn.wordpress.org/trunk@29137 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 22:08:22 +00:00
Sergey Biryukov
29aabd08a9 Prevent bulk actions from being performed when Filter button is clicked.
props jesin.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28916 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-30 01:09:25 +00:00
Scott Taylor
11da6abc57 Allow comments in the trash to marked as spam.
Props mordauk.
Fixes #19256.


git-svn-id: https://develop.svn.wordpress.org/trunk@28913 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-29 23:18:24 +00:00
Scott Taylor
848034a190 Use unobtrusive JS for Comment list table row actions.
Props aubreypwd.
Fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@28810 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 23:54:28 +00:00
Scott Taylor
7ab6b096e6 Remove some dead variable assignments.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28629 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 16:58:36 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin:
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:03:44 +00:00
Scott Taylor
6e09b1f167 Add access modifier (public) to members and methods in WP_Comments_List_Table and WP_Post_Comments_List_Table.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28486 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 23:58:38 +00:00
Scott Taylor
878a974477 Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary.
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:03:26 +00:00
Andrew Nacin
78b05bc236 Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon.
props aubreypwd.
fixes #24741.


git-svn-id: https://develop.svn.wordpress.org/trunk@27747 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-26 18:52:31 +00:00
Dominik Schilling (ocean90)
9e92a95ec5 Remove "Show" prefix from filter dropdowns, see #26743.
git-svn-id: https://develop.svn.wordpress.org/trunk@27626 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-19 22:12:13 +00:00
Andrew Ozz
88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086.
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-26 20:27:21 +00:00
Matt Thomas
fc4c73feab The comment screen hides the author column at narrow screen sizes; this adds back the author info above the comment content. Fixes #26618, props SergeyBiryukov, nacin.
git-svn-id: https://develop.svn.wordpress.org/trunk@26961 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-16 20:33:45 +00:00
Andrew Nacin
d8617e0fe9 Remove whitespace from the inside of a <textarea> element, added in [26138] with inline documentation.
see #25662.


git-svn-id: https://develop.svn.wordpress.org/trunk@26273 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-19 19:34:08 +00:00
Sergey Biryukov
87b1101b49 Inline documentation for hooks in wp-admin/includes/class-wp-comments-list-table.php.
props siobhyb, kpdesign.
fixes #25662.

git-svn-id: https://develop.svn.wordpress.org/trunk@26138 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-13 19:46:20 +00:00
Sergey Biryukov
6fa1c89458 Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row().
props drozdz.
fixes #25814.

git-svn-id: https://develop.svn.wordpress.org/trunk@26001 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 10:59:58 +00:00
Helen Hou-Sandi
76cb40634b Make it possible to filter comment screen by post type; no UI. props johnbillion, c3mdigital. fixes #18596.
git-svn-id: https://develop.svn.wordpress.org/trunk@25526 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-20 20:15:51 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00