Commit Graph

857 Commits

Author SHA1 Message Date
Drew Jaynes (DrewAPicture)
e4bebb4089 Fix parameter description syntax for WP_Screen::get_option().
Props zrothauser for the initial patch.
See [30368]. Fixes #30363.


git-svn-id: https://develop.svn.wordpress.org/trunk@30369 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-17 17:10:56 +00:00
Drew Jaynes (DrewAPicture)
e6538f5e00 Add a missing @return description for WP_Screen::get_option().
Also declare the default value for the `$key` parameter.

Props dustyf for the initial patch.
Fixes #30363.


git-svn-id: https://develop.svn.wordpress.org/trunk@30368 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-17 17:07:19 +00:00
John Blackbourn
c162a0f82e Decode the sample permalink shown to the user. This avoids showing encoded non-Latin characters in the sample permalink.
Fixes #16496
Props linuxologos


git-svn-id: https://develop.svn.wordpress.org/trunk@30364 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-17 02:59:43 +00:00
John Blackbourn
c33b85fd39 Add a filter to the displayed title of the default page template.
Fixes #27178
Props johnstonphilip


git-svn-id: https://develop.svn.wordpress.org/trunk@30360 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 19:32:00 +00:00
John Blackbourn
4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:15:29 +00:00
John Blackbourn
9a043693da Add some specific JSON responses when there are user permission errors for AJAX file uploads. Replace some usage of wp_json_encode() with wp_send_json_*().
See #25849
Props gcorne


git-svn-id: https://develop.svn.wordpress.org/trunk@30354 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 05:46:35 +00:00
John Blackbourn
ee01e3672b Display a faux revision when a post only has one revision but has an autosave.
Fixes #29044
Props adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@30353 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 03:35:37 +00:00
Gary Pendergast
e1ca159011 If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again.
See #21212.



git-svn-id: https://develop.svn.wordpress.org/trunk@30346 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-14 21:33:50 +00:00
John Blackbourn
d93bad3cd3 Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared.
See #30264.
Props jorbin, ocean90, johnbillion



git-svn-id: https://develop.svn.wordpress.org/trunk@30333 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 15:20:42 +00:00
Dominik Schilling (ocean90)
c55a06370b Fix selector for the "Live Widget Previews" feature pointer.
props rzen.
fixes #30158.

git-svn-id: https://develop.svn.wordpress.org/trunk@30332 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 12:49:42 +00:00
Dion Hulse
e542c7f7b6 PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628
git-svn-id: https://develop.svn.wordpress.org/trunk@30311 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 10:43:09 +00:00
Dion Hulse
14d164397a Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally.
See #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@30310 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-12 03:05:31 +00:00
Drew Jaynes (DrewAPicture)
72cc949b5d Fix the syntax for some status-related documentation introduced in [30155].
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30284 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-08 20:55:14 +00:00
Drew Jaynes (DrewAPicture)
155561f631 Fix a couple of typos in the hook documentation for the $option filter in wp-admin/includes/class-wp-list-table.php.
Props bobbingwide.
Fixes #30229.


git-svn-id: https://develop.svn.wordpress.org/trunk@30227 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-04 16:04:37 +00:00
Drew Jaynes (DrewAPicture)
ecec9d3595 Add parameter and return descriptions to the WP_List_Table::get_pagination_arg() DocBlock.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30225 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-04 15:54:50 +00:00
Scott Taylor
6c5e90eaa5 Correct some types in wp-admin/*-location files' doc blocks.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30203 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 07:08:16 +00:00
Scott Taylor
3942ff4616 Correct all @return unknown instances.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30202 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:16:34 +00:00
Scott Taylor
ba85fbacba Fill in the @param types for the args for functions missing them in wp-admin/includes/deprecated.php (pour one out).
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30201 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:07:26 +00:00
Scott Taylor
e4b0a71ebd Fill in the @param types for the args for functions missing them in wp-admin/includes/misc.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30200 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 06:00:25 +00:00
Scott Taylor
884d27ea00 Fill in the @param types for the args for functions missing them in wp-admin/includes/plugin.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30199 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:58:14 +00:00
Scott Taylor
8ddca875b5 Fill in the @param types for the args for functions missing them in wp-admin/includes/post.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30198 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:54:04 +00:00
Scott Taylor
53df5b1a61 Fill in the @param types for the args for functions missing them in wp-admin/includes/taxonomy.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30197 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:49:57 +00:00
Scott Taylor
43d027f2af Fill in the @param types for the args for functions missing them in wp-admin/includes/template.php.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30196 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:44:33 +00:00
Scott Taylor
aff2817015 Fill in the @param types for the args for make_site_theme_from_default().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30195 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:42:06 +00:00
Scott Taylor
00d5b388c3 Fill in the @param types for the args for make_site_theme_from_oldschool(), which is actually the name of a function?
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30194 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:40:30 +00:00
Scott Taylor
fa5b45c42a Fill in the @param types for the args for dbDelta().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30193 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:39:08 +00:00
Scott Taylor
7ea8e0cb6a Fill in types for the @params for wp_comment_reply().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30190 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:20:43 +00:00
Jeremy Felt
90aa65e0f7 Use common core syntax for checking DOING_AJAX
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891


git-svn-id: https://develop.svn.wordpress.org/trunk@30177 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-02 02:23:28 +00:00
Scott Taylor
7acb2c8eb1 Declare the $update_count and $update_current properties for WP_Upgrader.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30171 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:06:38 +00:00
Scott Taylor
729bd580ab Declare the $options property for WP_Upgrader_Skin.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30170 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 23:02:52 +00:00
Scott Taylor
bb9f04baa8 Fix the return value doc for WP_List_Table->get_pagination_arg().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30169 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:59:48 +00:00
Scott Taylor
c50eaf3b0d In wp_ajax_get_tagcloud(), bail immediately if $_POST['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30168 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:53:35 +00:00
Scott Taylor
ce6a31c5fe In wp_ajax_ajax_tag_search(), bail immediately if $_GET['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30167 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 22:47:27 +00:00
Scott Taylor
bdf71f89ad Display error message when Media Library upload fails.
Props gcorne.
Fixes #29891.


git-svn-id: https://develop.svn.wordpress.org/trunk@30156 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:24:13 +00:00
Scott Taylor
c8acddfdc8 Improve some post_status-related documentation.
Props ericlewis.
See #30230.


git-svn-id: https://develop.svn.wordpress.org/trunk@30155 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 20:19:26 +00:00
Scott Taylor
c171bb4aae In WP_List_Table, add a property, $modes, to allow WP_Media_List_Table to inherit ->view_switcher().
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30154 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 19:55:26 +00:00
Boone Gorges
d6b7b7aa41 Allow resource_type to be specified in get_ancestors().
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.

git-svn-id: https://develop.svn.wordpress.org/trunk@30141 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 02:57:31 +00:00
Boone Gorges
086f2b9dbd Fix database schema update introduced in [30121].
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30134 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:10:04 +00:00
Scott Taylor
ee56980498 Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates().
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.


git-svn-id: https://develop.svn.wordpress.org/trunk@30129 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 00:14:45 +00:00
Drew Jaynes (DrewAPicture)
7cd15026bd Correct references of @uses $wpdb in core documentation to use @global.
See #30191, [30105].
Fixes #30217.


git-svn-id: https://develop.svn.wordpress.org/trunk@30122 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 17:55:39 +00:00
Boone Gorges
5073448de6 Bump db_version and add upgrade routine for schema change in [30056].
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30121 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-31 16:02:08 +00:00
Drew Jaynes (DrewAPicture)
3cc10d77a0 Remove redundant and erroneous @uses tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.


git-svn-id: https://develop.svn.wordpress.org/trunk@30105 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-30 01:04:55 +00:00
John Blackbourn
32d38fc080 Introduce some actions and filters which aid plugins in revisioning post meta.
* `wp_save_post_revision_post_has_changed` filter which can be used to determine if a post has been changed, and therefore if a revision should be created for a post.
 * `wp_get_revision_ui_diff` filter which can be used to filter the fields displayed in the post revision diff UI.
 * `wp_creating_autosave` action which is fired just before an autosave is created.

See #20564.
Props mattheu, adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@30091 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 19:01:15 +00:00
Scott Taylor
45a635d8c2 In _wp_handle_upload(), if test_upload is set to false in the array of dangerous overrides that the function allows, the only thing that happens when an upload fails is more potential breakage.
`$test_uploaded_file` lets is know if `$file['tmp_name']` exists, which allows to exit with an error, instead of continuing to attempt to move the file.

`$test_upload` override is now a noop.

Fixes #28208.


git-svn-id: https://develop.svn.wordpress.org/trunk@30076 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 21:16:06 +00:00
Boone Gorges
ad4aa0b7e0 Remove UNIQUE key from 'slug' column of terms table.
Each slug is a unique and beautiful snowflake, but let's enforce that
uniqueness elsewhere.

Props hotchkissconsulting.
Fixes #22023.

git-svn-id: https://develop.svn.wordpress.org/trunk@30056 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:36:57 +00:00
Gary Pendergast
0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8.
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 18:34:16 +00:00
Sergey Biryukov
a32ed9e1ea Remove one-time loop and redundant isset() checks in do_meta_boxes().
See [30022] for do_accordion_sections().

props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30040 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-27 12:57:24 +00:00
Drew Jaynes (DrewAPicture)
aae8ddf48f Add a missing asterisk in the DocBlock for write_post().
Also removes several `@uses` tags, which are no longer leveraged as part of the inline documentation standard.

Props tareq1988.
Fixes #30118.


git-svn-id: https://develop.svn.wordpress.org/trunk@30034 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-26 23:55:16 +00:00
Sergey Biryukov
36ee6ba8be Remove one-time loop and redundant isset() checks.
props ipm-frommen.
fixes #30093.

git-svn-id: https://develop.svn.wordpress.org/trunk@30022 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 16:33:45 +00:00
Drew Jaynes (DrewAPicture)
c61e074530 Fix an invalid type for the $section parameter in the do_settings_fields() DocBlock.
Props ipm-frommen.
See #30098.


git-svn-id: https://develop.svn.wordpress.org/trunk@30018 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 13:37:59 +00:00