Commit Graph

204 Commits

Author SHA1 Message Date
Andrew Nacin 0fc3503f69 Use maybe_unserialize() in upgrade.php's private get_option() function. This actually predates maybe_unserialize() ([2487], [3234]). props leewillis77. fixes #24365.
git-svn-id: https://develop.svn.wordpress.org/trunk@24625 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-10 04:01:20 +00:00
Andrew Nacin bcf8ba4d44 Avoid possible array collision in dbDelta when recording index adds. props apimlott, wonderboymusic. fixes #21272.
git-svn-id: https://develop.svn.wordpress.org/trunk@24584 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-08 13:54:19 +00:00
Andrew Nacin ea92deb1bb Fix storage of illegal_names. Add an upgrade routine to fix bad values.
props SergeyBiryukov.
see #23418.
for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@24448 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-19 22:06:42 +00:00
Andrew Nacin c2dd3036e3 dbDelta: When parsing out the DEFAULT value, avoid being too greedy. props hbanken, fixes #15948.
git-svn-id: https://develop.svn.wordpress.org/trunk@24065 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-22 22:00:50 +00:00
Sergey Biryukov 021c744c82 Fix typo in upgrade_100(). props tivnet, bpetty. fixes #24020.
git-svn-id: https://develop.svn.wordpress.org/trunk@23949 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-10 16:04:36 +00:00
Ryan Boren 436b32ef62 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: https://develop.svn.wordpress.org/trunk@23567 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:14:09 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Andrew Nacin 94a0410530 Make Twenty Thirteen the default theme.
Has the added benefit of ensuring the WordPress Beta Tester plugin allows updates of Twenty Thirteen.

props JustinSainton.
fixes #23573.



git-svn-id: https://develop.svn.wordpress.org/trunk@23529 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-28 19:01:07 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Peter Westwood d927271553 Tighten our braces. Fixes #23118 props evansolomon.
git-svn-id: https://develop.svn.wordpress.org/trunk@23265 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-04 10:13:51 +00:00
Andrew Nacin a50c33bc44 Fix disabling of the link manager on upgrade from 3.4.2 when there are no links.
In the 3.4 branch we bumped the DB version past the version used for disabling links in trunk, preventing it from running. In the future, we must avoid increasing branch DB version bumps to HEAD.

props SergeyBiryukov.
fixes #22626.



git-svn-id: https://develop.svn.wordpress.org/trunk@22911 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-29 00:37:30 +00:00
Andrew Nacin 30280a363c Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697.
git-svn-id: https://develop.svn.wordpress.org/trunk@22422 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 18:01:31 +00:00
Andrew Nacin 6a54459a18 Make Twenty Twelve the default theme for new installs. props markoheijnen, SergeyBiryukov. see #21789.
git-svn-id: https://develop.svn.wordpress.org/trunk@22054 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-27 07:47:51 +00:00
Andrew Nacin 774a12be83 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: https://develop.svn.wordpress.org/trunk@21996 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-25 05:26:19 +00:00
Andrew Nacin 7f29924c6a Remove ms-files.php rewriting from WordPress multisite. fixes #19235.
Keep existing networks compatible with a ms_files_rewriting network option.



git-svn-id: https://develop.svn.wordpress.org/trunk@21823 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 22:22:20 +00:00
Andrew Nacin dfac91464f Remove AtomPub from core.
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: https://develop.svn.wordpress.org/trunk@21818 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 20:11:39 +00:00
Andrew Nacin 56c0d2932c Remove old edit_*_per_page usermeta keys.
These per-page values were when the post type or taxonomy name has a hyphen.
Previously, these were converted to underscores. This changed in [21322].

fixes #18958.



git-svn-id: https://develop.svn.wordpress.org/trunk@21811 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 02:08:29 +00:00
Andrew Nacin 6df2aff40b Turn XML-RPC on and remove the option on the Writing Settings page.
props markoheijnen for the initial patch.

Introduces a new filter, xmlrpc_enabled.

Respects any current callbacks registered to the pre_option_enable_xmlrpc
and option_enable_xmlrpc filters, for anyone forcing it off via code.

fixes #21509.



git-svn-id: https://develop.svn.wordpress.org/trunk@21804 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 00:37:31 +00:00
Andrew Nacin 48a78c01a3 Disable the Link Manager on any future upgrade if it is still enabled but there are no links. see #21307.
git-svn-id: https://develop.svn.wordpress.org/trunk@21536 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-16 23:08:07 +00:00
Andrew Nacin 9931c1a45d Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: https://develop.svn.wordpress.org/trunk@21501 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-13 16:18:42 +00:00
Andrew Nacin 58ad892373 Stop adding default links and the 'Blogroll' link category on install. props wonderboymusic. see #21307.
git-svn-id: https://develop.svn.wordpress.org/trunk@21500 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-13 15:55:15 +00:00
Andrew Nacin a5c7405975 Move most instances of new WP_User to get_userdata(). see #21120.
git-svn-id: https://develop.svn.wordpress.org/trunk@21413 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-03 01:06:05 +00:00
Ryan Boren 8ac43209f5 Fix some spelling errors. Props thee17. fixes #21191
git-svn-id: https://develop.svn.wordpress.org/trunk@21333 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-25 18:06:13 +00:00
Mark Jaquith 6ef0b4c765 Insert a proper line break (instead of an HTML line break) into the "first comment". props nacin. fixes #16712
git-svn-id: https://develop.svn.wordpress.org/trunk@21234 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-09 03:19:02 +00:00
Andrew Nacin b128d68f11 Do not force table names to be lowercase in dbDelta, as this breaks sites using capital letters in table prefixes. props netweblogic. fixes #19748.
git-svn-id: https://develop.svn.wordpress.org/trunk@20704 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-02 21:19:37 +00:00
Andrew Nacin 54a6a40533 Introduce $wpdb->delete(). props justindgivens, scribu. fixes #18948.
git-svn-id: https://develop.svn.wordpress.org/trunk@20287 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-24 15:24:31 +00:00
Andrew Nacin f9d7952855 The allowed_themes rolling upgrade for individual sites should not add empty allowedthemes arrays. If there are no allowed themes, don't add an empty option. Move the network rolling upgrade to upgrade_network(). see #20146.
git-svn-id: https://develop.svn.wordpress.org/trunk@20148 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-08 03:22:39 +00:00
Andrew Nacin 129754ed3d Don't autoload the uninstall_plugins option. fixes #16741.
git-svn-id: https://develop.svn.wordpress.org/trunk@20080 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 20:13:35 +00:00
Jon Cave cafa8dab24 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546.
git-svn-id: https://develop.svn.wordpress.org/trunk@20023 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:29:33 +00:00
Andrew Nacin 21630b2828 Do not save the last visited tab on the multisite Network Themes page and Site Themes tab. These are poor UX, see #18810 for plugins. Entering these screens will always default to 'all' themes view. see #20103.
git-svn-id: https://develop.svn.wordpress.org/trunk@20022 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 20:13:21 +00:00
Andrew Nacin ee01523b96 Deprecate ancient "debugging" tools.
* logIO() and the global $xmlrpc_logging in XML-RPC.
 * log_app() and the global $app_logging in APP.
 * debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.
see #20051.



git-svn-id: https://develop.svn.wordpress.org/trunk@19935 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-17 00:02:42 +00:00
Ryan Boren 52048ffa75 Drop the comment_approved index from the comments table. comment_approved_date_gmt is sufficient. fixes #19935
git-svn-id: https://develop.svn.wordpress.org/trunk@19799 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-31 18:26:07 +00:00
Ryan Boren 22784619f4 Drop the blog_id column from the options table during upgrade. Props barry. fixes #17188
git-svn-id: https://develop.svn.wordpress.org/trunk@19798 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-31 17:45:22 +00:00
Andrew Nacin ea092db65b Switch to Feedback, from Suggest Ideas, for a default link, based on 3.3 toolbar. see #19601.
git-svn-id: https://develop.svn.wordpress.org/trunk@19786 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-29 20:25:59 +00:00
Andrew Nacin 2801fa6b22 Offer default links and applicable URLs for translation. Some of these are already translatable elsewhere. see #19601.
git-svn-id: https://develop.svn.wordpress.org/trunk@19781 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-29 05:14:59 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Andrew Nacin 8d60951aa4 Use array_filter() to remove empty values from an array, not jankiness.
git-svn-id: https://develop.svn.wordpress.org/trunk@19691 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 21:22:44 +00:00
Andrew Nacin be1142f66f Update some old upgrade functions to use untrailingslashit().
git-svn-id: https://develop.svn.wordpress.org/trunk@19690 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 21:21:51 +00:00
Ryan Boren a8d77cbae9 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: https://develop.svn.wordpress.org/trunk@19687 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:50:54 +00:00
Ryan Boren 54067a5f20 Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: https://develop.svn.wordpress.org/trunk@19596 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-14 17:36:38 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Ryan Boren ef187a99f6 Initialize active_sitewide_plugins during network install and upgrade. fixes #19385
git-svn-id: https://develop.svn.wordpress.org/trunk@19470 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-28 20:35:36 +00:00
Andrew Nacin 23dcc6ef17 Move multisite-specific upgrade code from upgrade_330() to upgrade_network(). see #18693.
git-svn-id: https://develop.svn.wordpress.org/trunk@19469 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-28 20:04:00 +00:00
Andrew Nacin 4d89846637 Change show/hide storage mechanism for show_welcome_panel. 0 = hide, 1 = show, 2 = show if the multisite owner. Make welcome panel dismissable without JS (openable too via the URL). fixes #19338, fixes #19127.
git-svn-id: https://develop.svn.wordpress.org/trunk@19418 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-23 18:30:45 +00:00
Mark Jaquith 00fd073cc0 Introduce initial_db_version and leverage it so that pointers only get shown to updated installs, not new 3.3 installs. props nacin. see #18693
git-svn-id: https://develop.svn.wordpress.org/trunk@19410 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-22 21:50:50 +00:00
Andrew Nacin 2929a7ee9a Remove old dismissed pointers as the IDs have changed. Switch to underscores that way we don't need to translate them for method names. Avoid an empty pointer in the array. see #18693.
git-svn-id: https://develop.svn.wordpress.org/trunk@19389 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-21 23:04:35 +00:00
Andrew Nacin 261ee73e3d Merge upgrade_old_widgets_order_array() into upgrade_330(). see #18811, see #18821.
git-svn-id: https://develop.svn.wordpress.org/trunk@19062 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-25 05:50:39 +00:00
Andrew Nacin 96e4fffaa9 Introduce upgrade_330() to clear usermeta keys show_admin_bar_admin and plugins_last_view. fixes #18811.
git-svn-id: https://develop.svn.wordpress.org/trunk@19061 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-25 05:48:09 +00:00
Andrew Nacin f3e64d5112 Undent (by two tabs) a whole lot of code in dbDelta(). Thx. see #17998.
git-svn-id: https://develop.svn.wordpress.org/trunk@19041 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-21 22:40:30 +00:00
Andrew Nacin c64486425a Have dbDelta() loop through tables it knows about, rather than loop through a potentially expensive and definitely unnecessary SHOW TABLES. fixes #17998.
git-svn-id: https://develop.svn.wordpress.org/trunk@19040 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-21 22:35:33 +00:00