Scott Taylor
d5e9f8770a
Add missing annotations to
ajax-actions.php`
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32652 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 16:00:29 +00:00
Helen Hou-Sandi
923bffda98
Define a primary column for WP_Post_Comments_List_Table
.
...
props boonebgorges.
see #25408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32651 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:51:11 +00:00
Scott Taylor
c8a44d437a
Add @static*
annotations where they are missing.
...
Initialize all static vars that are not, most to `null`.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 15:42:40 +00:00
Dominik Schilling (ocean90)
cced199188
Customizer: Replace accordion behavior of sections with a slide-in navigation.
...
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.
props valendesigns, celloexpressions.
see #31336 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32649 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 13:56:39 +00:00
Helen Hou-Sandi
ea9de1aacd
After [32644], sanity for a pile of selectors.
...
see #25408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32645 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:59:44 +00:00
Helen Hou-Sandi
86c907d2a5
List tables: introduce the concept of a "primary" column.
...
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.
props stephdau, DaveAl, jesin.
see #25408 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32644 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:40:52 +00:00
Scott Taylor
f864c1d712
Add @global
annotations to (the rest of the?) wp-admin/*
files.
...
Does not include list table file changes.
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32643 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-29 02:05:26 +00:00
Scott Taylor
23ce2efd12
Add @global
annotations for wp-admin/*
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Helen Hou-Sandi
805d876017
About: Give bottom navigation links the full width.
...
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.
props tyxla.
fixes #32391 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32636 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 15:38:44 +00:00
Jeremy Felt
b1e80f0388
Use site objects rather than get_blog_status() in MS list tables.
...
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.
Fixes #32512 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32630 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-27 23:13:04 +00:00
Mark Jaquith
556ffa235a
Insert temporary password field hook for feature development in a plugin.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32625 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-27 19:58:38 +00:00
Scott Taylor
bd06ad2725
get_comments()
can return int
, so a few places need to check if the return value is traversable before passing what is assumed to be an array
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32600 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-25 17:58:52 +00:00
Dion Hulse
d8dc5d9f63
Updates: Correctly identify more failed update cases. This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases.
...
The error message in these cases is still not displayed in the UI.
See #32473 , #32435
git-svn-id: https://develop.svn.wordpress.org/trunk@32571 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 08:44:09 +00:00
Dion Hulse
8d64dc4e6b
Shiny Updates: Handle the case where the plugin is installed into a different directory than it previously existed in.
...
A good example of this is when the plugin being updated is currently installed as 'Plugin-Name' but the canonical directory is 'plugin-name', but it can also occur when the plugin is installed in 'super-cool-plugin' and it's canonical name is 'average-plugin'.
Fixes #32465 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@32570 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 08:04:55 +00:00
Konstantin Obenland
065cdadce9
Improve description for link notification option.
...
Makes it clear that the option only applies to new articles.
Props chriscct7.
Fixes #22961 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32569 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-24 07:54:06 +00:00
Scott Taylor
46752a491e
When calling unset()
, it is unnecessary to immediately precede it with a call to isset()
.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32545 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 05:46:47 +00:00
Helen Hou-Sandi
6d1e0f0704
Updates: Use the warning color for the backup notice, as it's not a success message.
...
props paulwilde.
fixes #32241 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32522 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:09:46 +00:00
jorbin
8bb46554a8
In List Tables, ensure sorting indicator is visible on focus
...
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose.
Happy #GAAD
Props afercia
Fixes #32189
git-svn-id: https://develop.svn.wordpress.org/trunk@32521 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-21 18:04:03 +00:00
Scott Taylor
e088947cea
In WP_Media_List_Table::get_views()
, declare $num_posts
explicitly before looping.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32517 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:49:59 +00:00
Scott Taylor
17fff532cd
In WP_Comments_List_Table::column_comment()
, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
...
See #32444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32516 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 20:45:36 +00:00
Jeremy Felt
6f4e407208
Move network update submenu items to the Network Dashboard menu item
...
Provides parity with the placement of the "Updates" submenu item in single site.
props Ipstenu.
fixes #32431 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32514 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-19 16:59:40 +00:00
Helen Hou-Sandi
d800ebdf96
Accessibility: Ensure screen reader text is read as words and not affected by word-wrap.
...
props afercia.
fixes #31962 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32509 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-18 18:36:46 +00:00
Helen Hou-Sandi
42eb2ec407
Autoprefixer for [32506]. see #31874 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32508 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 20:43:02 +00:00
Helen Hou-Sandi
691656f2cf
Media: Visually align upload errors with other admin notices.
...
props sagarjadhav.
fixes #31874 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32506 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-15 16:18:50 +00:00
Andrew Ozz
12b3b1c100
Fix dragging to the bottom of the screen on the Dashboard.
...
Props eltobiano. See #32094 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32505 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 23:49:44 +00:00
Dion Hulse
047c2fdadd
Allow plugins to activate other plugins within their Activation hook. Fixes #32368
...
git-svn-id: https://develop.svn.wordpress.org/trunk@32504 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-14 06:57:47 +00:00
Andrew Ozz
59eb437a35
Fix comments postbox:
...
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32495 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-12 01:21:58 +00:00
Dominik Schilling (ocean90)
297a4eae48
Improve focus styles for the Switch View links in Posts listings and Media Library.
...
props afercia.
fixes #32294 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32485 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-11 19:33:32 +00:00
Andrew Ozz
5bf60d981b
Widgets:
...
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@32480 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-10 00:31:47 +00:00
Dominik Schilling (ocean90)
bcbae1cee3
Improve focus styles for:
...
* Quick Draft links
* Media Library list mode thumbnails
props afercia.
fixes #32284 , #32291 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32476 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 21:04:21 +00:00
Dominik Schilling (ocean90)
0422e527b1
Improve focus styles for:
...
* Welcome Panel dismiss link
* Welcome Panel assembled links
* At a Glance links
* Recently Published/Publishing Soon and latest Comments links in the Dashboard Activity box
props afercia.
fixes #32287 , #32288 , #32289 , #32292 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32475 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 20:34:13 +00:00
Dominik Schilling (ocean90)
27d0216b0c
Merge a help tab string for pages.
...
fixes #32328 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32474 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 20:07:00 +00:00
Dominik Schilling (ocean90)
ca2cd7405c
List Table: Add placeholder to a plural string.
...
props SergeyBiryukov.
fixes #32034 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32473 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 19:21:38 +00:00
Dominik Schilling (ocean90)
3df6a4a9da
Sites List Table: Replace context with a translators comment for the site name and tagline.
...
props ramiy.
fixes #31849 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32472 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 19:18:00 +00:00
Dominik Schilling (ocean90)
ff4f261101
Merge similar error strings.
...
props pavelevap.
fixes #32327 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32471 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 18:26:37 +00:00
Gary Pendergast
733e06315a
Upgrades: If a table has already been converted to utf8mb4
, there's no need to try and convert it again.
...
Props gabrielperezs for the initial patch.
See #32310 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32456 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 12:21:18 +00:00
Gary Pendergast
2cde17f232
When saving Writing Options, check that the UI is enabled for use_smilies
and use_balanceTags
before trying to update them.
...
Fixes #5161 .
Fixes #32298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32455 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 11:58:22 +00:00
Gary Pendergast
231c73751b
On the Writing Options screen, hide the Balance Tags and Convert Smilies options on new installs.
...
Fixes #5161 .
Fixes #32298 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32454 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 06:51:52 +00:00
Michael Adams (mdawaffe)
80238b81d6
Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
...
Props jorbin, et alii.
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32440 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 01:10:05 +00:00
Michael Adams (mdawaffe)
89b384a05a
Upgrade: $wpdb->get_col_length()
sanity check: bail on unexpected return value.
...
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32429 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 23:10:18 +00:00
Michael Adams (mdawaffe)
a42401d0c9
Upgrade: Ensure unintelligible DB schemas don't result in content loss.
...
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32417 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 21:45:58 +00:00
Aaron Jorbin
1417929e0d
When upgrading WordPress remove genericons example.html files
...
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin
--This line,build.wordpress-develop.dea and those below, will be ignored--
M src/wp-admin/includes/update-core.php
git-svn-id: https://develop.svn.wordpress.org/trunk@32385 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 18:36:48 +00:00
Sergey Biryukov
5af9ac0ea2
Customizer: Use a semantic, accessible element for Remove Header Image button.
...
Make the button more noticeable on dark, light, and busy images.
props afercia, RDall, melchoyce.
fixes #32227 , #31325 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32382 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 10:53:07 +00:00
Sergey Biryukov
2b8e7270d5
Multisite: Add translator comments to default email messages with non-typical placeholders.
...
props yoavf.
fixes #32263 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32381 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 09:11:18 +00:00
Gary Pendergast
9e12deeb9c
Fix an incorrect version number check in [32378].
...
See #32099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32379 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:40:36 +00:00
Gary Pendergast
ca11cafb07
Upgrades: When converting to utf8mb4
, we were trying to change the wrong index on wp_signups
, causing the conversion to later fail.
...
Props kovshenin, pento.
See #32099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32378 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:33:53 +00:00
Gary Pendergast
2ce97b2984
WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding()
, as it behaves differently to MySQL's character encoding conversion.
...
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32364 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 02:59:50 +00:00
Drew Jaynes
3ca1ff6b72
Fix documentation syntax and formatting for the media_sideload_image()
DocBlock.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32352 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:19:47 +00:00
Drew Jaynes
7138b7e1bd
Add two changelog entries for functional changes introduced in 4.2.0.
...
Props dimadin.
See #31925 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32350 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:15:27 +00:00
Drew Jaynes
eea4111667
Add a missing DocBlock for wp_caption_input_textarea()
.
...
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@32341 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-04 01:12:12 +00:00