Commit Graph

38371 Commits

Author SHA1 Message Date
Sergey Biryukov 9192d7ab71 Docs: Add missing verb in `is_admin()`, `is_blog_admin()`, `is_network_admin()`, `is_user_admin()` descriptions.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@43022 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-29 21:13:49 +00:00
Andrea Fercia 518c7ab6ac Coding standards: Change one occurrence of font weight 700 to 600.
Props chetan200891.
Amends [43018].
See #43897.


git-svn-id: https://develop.svn.wordpress.org/trunk@43021 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-29 18:03:29 +00:00
Andrea Fercia 52e28b4085 Accessibility: Improve the Themes Installer navigation buttons accessibility.
- really disables buttons when they look disabled (when navigation is at the first or last theme)
- when navigation is at the first or last theme, moves focus to the other navigation button, to avoid a focus loss
- improves the buttons visually hidden accessibility text

Props walbo, afercia.
Fixes #36627.


git-svn-id: https://develop.svn.wordpress.org/trunk@43020 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-29 17:03:56 +00:00
Andrea Fercia 75ca3d6386 Accessibility: Better color contrast for the tables pagination links.
By making the pagination links use the default style for buttons, color contrast
is improved and the CSS is simplified. Improves consistency with other UI controls.
Also, slightly increases the white space below the pagination links.

Props benoitchantre, afercia.
Fixes #41858.


git-svn-id: https://develop.svn.wordpress.org/trunk@43019 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-29 16:24:41 +00:00
Andrea Fercia b3836882ef Coding standards: Use numeric font weights instead of keywords.
Fixes #43897.


git-svn-id: https://develop.svn.wordpress.org/trunk@43018 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-29 11:36:53 +00:00
John Blackbourn 6eef5a6234 Docs: Correct the possible return types for the `wpdb::query()` method.
Props isabel104

See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@43017 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-28 14:43:36 +00:00
John Blackbourn c71a898f78 Formatting: Begin the process of improving the docs for KSES related functions.
See #33801


git-svn-id: https://develop.svn.wordpress.org/trunk@43016 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-28 13:57:32 +00:00
Andrew Ozz 6173287317 Privacy: fix unit tests after [43012].
Props iandunn.
See #43546.

git-svn-id: https://develop.svn.wordpress.org/trunk@43015 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-28 12:10:13 +00:00
Andrew Ozz bf1ddda65f Fix docs and white space.
Props desrosj.
See #43443.

git-svn-id: https://develop.svn.wordpress.org/trunk@43014 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-28 12:03:09 +00:00
John Blackbourn 790f1ef5da Build/Test Tools: Don't trigger the global variable override PHPCS sniff for core.
Props jrf

Fixes #43776


git-svn-id: https://develop.svn.wordpress.org/trunk@43013 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-28 00:44:50 +00:00
Andrew Ozz da5dc711a5 Privacy: add means to export personal data by username or email address. Generate a zipped export file containing all data. First run.
Props allendav.
See #43546.

git-svn-id: https://develop.svn.wordpress.org/trunk@43012 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-27 19:53:37 +00:00
Andrew Ozz a0c3fab75b Privacy: update and enhance the method to confirm user requests by email. Introduce WP_User_Request to hold all request vars similarly to WP_Post.
Props mikejolley.
See #43443.


git-svn-id: https://develop.svn.wordpress.org/trunk@43011 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-27 17:30:28 +00:00
Felix Arntz f9d314aaf7 Multisite: Add meta query functionality to `WP_Site_Query`.
After the introduction of site metadata in [42836], it should be possible to query sites by that data.

Fixes #40229.


git-svn-id: https://develop.svn.wordpress.org/trunk@43010 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-27 11:40:35 +00:00
Felix Arntz 1e9d46387c Bootstrap: Load `class-wp-meta-query.php` earlier in `wp-settings.php`.
This change is necessary to enable multisite-specific meta query functionality during the multisite bootstrap process.

Fixes #40948. See #40229.


git-svn-id: https://develop.svn.wordpress.org/trunk@43009 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-27 11:36:47 +00:00
Andrew Ozz 11d594e3a8 Privacy: update the method to confirm user requests by email. Use a single CPT to store the requests and to allow logging/audit trail.
Props mikejolley.
See #43443.


git-svn-id: https://develop.svn.wordpress.org/trunk@43008 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-27 10:12:01 +00:00
Gary Pendergast 0907ed4894 REST API: Include `viewable` attribute on Post Type resource for `edit` context
For the block editor to be able to expose the Preview button correctly, it needs to know the `is_post_type_viewable()` setting, this change adds it to the Post Type response.

Props danielbachhuber.
Fixes #43739.



git-svn-id: https://develop.svn.wordpress.org/trunk@43007 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-27 03:05:40 +00:00
Felix Arntz 41b6e0da34 General: Implement editorial, design and accessibility feedback for the PHP version nag.
The updated version of the nag is shorter, more on point and less aggressive than the previous one. It integrates better with the other dashboard widgets and fixes several accessibility concerns. A yellow warning color is used when the current PHP version is outdated, a red error color is used when it is also insecure.

Props afercia, birgire, danieltj, flixos90, johnjamesjacoby, karmatosed, Luciano Croce, nerrad, pento, schlessera, SergeyBiryukov, sonjaleix.

Fixes #41191.


git-svn-id: https://develop.svn.wordpress.org/trunk@43006 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-26 14:30:24 +00:00
Felix Arntz 79bf20d320 Tests: Skip multisite-only or single site-only tests correctly based on test doc annotations.
Without the `ms-required` and `ms-excluded` groups being marked as excluded in the PHPUnit configurations for the project, those groups were still executed, causing fatal errors. Checking against the groups in the correct structure of the array returned from PHPUnit's `Testcase::getAnnotations()` ensures that those tests are skipped properly.

Fixes #43863.


git-svn-id: https://develop.svn.wordpress.org/trunk@43005 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-25 22:37:08 +00:00
Ella Van Dorpe f6c215c8bf TinyMCE: Update to 4.7.11
git-svn-id: https://develop.svn.wordpress.org/trunk@43004 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-25 22:34:41 +00:00
Andrew Ozz 6cd0ee3b7a Privacy: add better docs for `wp_add_privacy_policy_content()` and `WP_Privacy_Policy_Content::add()`.
See #43620.

git-svn-id: https://develop.svn.wordpress.org/trunk@43003 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-25 18:10:00 +00:00
Ian Dunn d336475bf5 Privacy: Add template tags for building link to privacy policy page.
This introduces the `get_the_privacy_policy_link()` and `the_privacy_policy_link()` functions, as well as the `privacy_policy_url` filter.

A new `tests/url/` folder was added to better organize tests related to `get_*_url()` functions. Previously, those tests were placed in `tests/url.php` and `tests/link/`, but neither of those locations are optimal. Placing tests in `tests/url.php` violates the guideline of creating separate files/classes for each function under test, and using `tests/link/` conflates two distinct -- albeit related -- groups of functions. Over time, URL-related tests can be migrated to the new folder.

Props birgire, xkon, azaozz, iandunn.
See #43850.


git-svn-id: https://develop.svn.wordpress.org/trunk@43002 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-25 15:54:29 +00:00
Gary Pendergast 50e9639f22 REST API: Add `who=authors` as a query parameter for `GET wp/v2/users`.
Any WordPress user who can `edit_posts` of a post type with `show_in_rest=true` can query for authors. This maps to current WordPress behavior where a WordPress user who can view the Manage Posts view for a post type can see any WordPress user assigned to a post (whether published or draft).

This implementation, over restricting `who=authors` to users with `list_users`, gives us future flexibility in displaying lists of posts. It still respects more restrictive permissions for `context=edit`.

Props danielbachhuber.
Fixes #42202.



git-svn-id: https://develop.svn.wordpress.org/trunk@43001 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-25 13:05:48 +00:00
Andrew Ozz 6bee78edcf Privacy: fix styling of counts on the list tables for user requests.
Props allendav.
Fixes #43846.

git-svn-id: https://develop.svn.wordpress.org/trunk@43000 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-24 21:34:59 +00:00
Andrew Ozz 84251cc161 Make the string `WordPress` translatable.
Props mnelson4.
See #43620.

git-svn-id: https://develop.svn.wordpress.org/trunk@42999 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-24 21:22:52 +00:00
Felix Arntz f3150c77c5 Plugins: Show the required PHP version in the plugin details view, if specified.
Props xkon.
Fixes #43650.


git-svn-id: https://develop.svn.wordpress.org/trunk@42998 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-24 11:40:25 +00:00
Gary Pendergast f9e4467b3d REST API: Remove `permalink_structure` from the index.
This was originally added to allow Gutenberg to do permalink editing, but is no longer required. It's also superceded by #41014.

Reverts [42142].
Fixes #42465.



git-svn-id: https://develop.svn.wordpress.org/trunk@42997 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-23 04:11:42 +00:00
Anton Timmermans db0a8af84b Docs: Improve JSDoc for `wp-includes/js/wp-backbone.js`.
Changes some additional docs after [42993].

Props birgire, adamsilverstein, netweb.
Fixes #35465.


git-svn-id: https://develop.svn.wordpress.org/trunk@42996 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-22 14:36:23 +00:00
Andrew Ozz c9aaa0ddb7 Privacy: fix `get_privacy_policy_url()` to only return the URL when the page is published.
See #43435.

git-svn-id: https://develop.svn.wordpress.org/trunk@42995 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-20 14:43:26 +00:00
Andrew Ozz 7e26130f12 Privacy: add functionality to anonymize commenters.
Props xkon, fclaussen, allendav, birgire, azaozz.
See #43442.

git-svn-id: https://develop.svn.wordpress.org/trunk@42994 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-20 12:18:35 +00:00
Anton Timmermans ad13b8bbda Docs: Improve JSDoc for `wp-includes/js/wp-backbone.js`.
Props ericlewis, gma992, adamsilverstein.
Fixes #35465.


git-svn-id: https://develop.svn.wordpress.org/trunk@42993 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-19 14:01:48 +00:00
Andrew Ozz ed3b9746ce Privacy: make the sections in the suggested privacy policy text postbox foldable. Add Read More/Read Less buttons. Fix copying of the suggested text by pressing the button.
Props melchoyce, xkon, azaozz.
See #43620.

git-svn-id: https://develop.svn.wordpress.org/trunk@42992 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-19 12:38:44 +00:00
Aaron Jorbin 9208eec92c Wow. I really shouldn't try to fix the build.
Previous [42989] [42986].
See #43440.


git-svn-id: https://develop.svn.wordpress.org/trunk@42991 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-19 00:25:52 +00:00
Aaron Jorbin c2ec9a43ea Remove accidental addition to package.json
Introduced in [42989].

See #43440.
Unprops jorbin.



git-svn-id: https://develop.svn.wordpress.org/trunk@42990 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-19 00:23:24 +00:00
Aaron Jorbin 770fbb4bcb Privacy: Fix JSHint errors
Introduced in [42986].

See #43440.


git-svn-id: https://develop.svn.wordpress.org/trunk@42989 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-19 00:22:11 +00:00
John Blackbourn 1b598aee0d Upgrade/Install: Don't include `wp-includes/formatting.php` twice during installation.
This avoids a fatal error caused by function redeclaration.

Props ocean90, kkarpieszuk

Fixes #43609


git-svn-id: https://develop.svn.wordpress.org/trunk@42988 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-18 23:53:53 +00:00
Andrew Ozz cf7865a91f Privacy: fix docs, formatting, white space, add tests for the personal data from comments exporter.
Props birgire.
See #43440.

git-svn-id: https://develop.svn.wordpress.org/trunk@42987 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-18 22:54:23 +00:00
Andrew Ozz cdb3f044c4 Privacy: add means to erase personal data by username or email address. First run.
Props allendav, coreymckrill, ericdaams, azaozz.
See #43637, #43602.

git-svn-id: https://develop.svn.wordpress.org/trunk@42986 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-18 22:29:59 +00:00
Andrew Ozz 7eb3daf562 Fix typo in 'wp_get_default_privacy_policy_content' filter.
Props claudiu.
See #43620.

git-svn-id: https://develop.svn.wordpress.org/trunk@42985 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-17 21:08:38 +00:00
Sergey Biryukov b7ab3c7064 I18N: Use consistent pattern for placeholder references in a translator comment in `media_upload_max_image_resize()`.
See #43523.

git-svn-id: https://develop.svn.wordpress.org/trunk@42984 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-16 18:36:03 +00:00
Sergey Biryukov 031a90a6b3 I18N: Correct placeholder references in a translator comment in `wp_print_file_editor_templates()`.
Props afercia.
See #43523.

git-svn-id: https://develop.svn.wordpress.org/trunk@42983 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-16 18:35:44 +00:00
Andrew Ozz bb4dff10f6 Fix typo (missing `!`).
See #43491.

git-svn-id: https://develop.svn.wordpress.org/trunk@42982 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-16 10:13:38 +00:00
Andrew Ozz 5786dee456 Privacy: automatically create a Privacy Policy page when installing WordPress.
Props fclaussen, azaozz.

Fixes #43491.

git-svn-id: https://develop.svn.wordpress.org/trunk@42981 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-16 08:59:19 +00:00
Andrew Ozz 257842079c Privacy: add a postbox that is shown when editing the privacy policy page, and where plugins and core will output suggested content and additional privacy info. First run.
Props melchoyce, azaozz.
See #43620.

git-svn-id: https://develop.svn.wordpress.org/trunk@42980 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-16 08:52:18 +00:00
Peter Wilson 1a40a17275 Upgrade/Install: Use high-dpi plugin icons on update dashboard.
Reorder the `$preferred_icons` array for plugins to prefer high-dpi icons (2x) over standard-dpi icons (1x).

Props dd32.
Fixes #43727.



git-svn-id: https://develop.svn.wordpress.org/trunk@42979 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-16 00:12:03 +00:00
Andrew Ozz 1af1f65a21 Privacy: improve the screen for setting a privacy policy page.
Props melchoyce, xkon, azaozz.
See #43435.

git-svn-id: https://develop.svn.wordpress.org/trunk@42978 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 17:55:25 +00:00
Andrew Ozz 99c3f4594a Privacy: fix error message and list table sorting errors on the Export Personal Data and Remove Personal Data screens.
See #43481.

git-svn-id: https://develop.svn.wordpress.org/trunk@42977 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 16:14:54 +00:00
Felix Arntz 63eda3b3a4 Multisite: Verify the signup nonce using `wp_verify_nonce()` in `signup_nonce_check()`.
Prior to this change, the nonce passed from `wp-signup.php` was verified with a simple comparison. Furthermore in case of failures, `wp_die()` would be called right during the HTML markup being already printed. Now the error message is returned properly, modifying the `WP_Error` object in the passed `$result`.

Props herregroen.
Fixes #43667.


git-svn-id: https://develop.svn.wordpress.org/trunk@42976 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 15:29:52 +00:00
Dominik Schilling (ocean90) 2468899f38 Customize: Remove a stray whitespace.
Props tfrommen.
Fixes #43762.


git-svn-id: https://develop.svn.wordpress.org/trunk@42975 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 15:09:30 +00:00
Dominik Schilling (ocean90) 9f9facad50 Administration: Avoid an extra space in the admin body class.
Props jainnidhi, rhetorical, birgire, mathieuhays.
Fixes #43465.

git-svn-id: https://develop.svn.wordpress.org/trunk@42974 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 14:02:10 +00:00
Gary Pendergast b57b486d96 REST API: Fix a typo introduced in [42729].
Props danielbachhuber.
Fixes #42707.



git-svn-id: https://develop.svn.wordpress.org/trunk@42973 602fd350-edb4-49c9-b593-d223f7449a82
2018-04-13 00:55:28 +00:00