sergiotarxz
/
Wordpress
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
24,911 Commits 2 Branches 473 Tags 137 MiB
Commit Graph

24911 Commits

Author SHA1 Message Date
Scott Taylor d6cb8c399e Introduce `maybe_regenerate_attachment_metadata( $attachment )`. On the Edit Media screen, call it for Audio and Video files. 
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.



git-svn-id: https://develop.svn.wordpress.org/trunk@27127 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 22:40:32 +00:00
Scott Taylor 4b047c21ab Add some inline docs to `media-views.js` and remove some unnecessary comments from a few `super` calls. 
Props gcorne.
See #26870.



git-svn-id: https://develop.svn.wordpress.org/trunk@27126 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 20:20:38 +00:00
Scott Taylor 81679ef453 When a `term_id` matches in `_get_term_children()`, recurse through its children until there is no more depth in the hierarchy. Since `get_terms()` return terms with a `count` of `0` when their children are not empty, we must return all children so that `get_terms()` can check their count. 
In [27108], #26903 was fixed, but only because we were using the example in the ticket, leaving out infinite depth for hierarchical taxonomies.

Adds unit tests, including `Tests_Term_getTerms::test_get_terms_seven_levels_deep()`.

Fixes #26903. Again.



git-svn-id: https://develop.svn.wordpress.org/trunk@27125 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 19:53:01 +00:00
Lance Willett 5ddc101010 Twenty Fourteen: fix Ephemera Widget to avoid showing full post content when displayed in single post or page. Restore the global `$more` to its original value after the widget output to avoid any issues caused by changing a global variable. 
Props obenland, mor10, Frank Klein. See #26961.

git-svn-id: https://develop.svn.wordpress.org/trunk@27124 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 18:03:00 +00:00
Lance Willett 2ec5e68249 Twenty Fourteen: pinking shears. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27123 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 18:01:20 +00:00
Lance Willett 9ddb14eb97 Twenty Fourteen: translate `featured` tag slug used to link to specific tags in Posts editor. See #26526. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27122 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:46:46 +00:00
Lance Willett 7d23aedf8b Twenty Fourteen: fix unreachable links when the content area is shorter than the sidebar in smaller viewpoints. Props celloexpressions, see #26782. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27121 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:42:59 +00:00
Lance Willett 6f9758f69b Twenty Fourteen: delete the `featured_content_ids` transient on theme switch to make sure child themes can override the Featured Content quantity value. Also remove quantity parameter so child themes can change the amount of featured posts with `$max_posts`. 
Props obenland, see #26660.

git-svn-id: https://develop.svn.wordpress.org/trunk@27120 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:38:08 +00:00
Sergey Biryukov 5b7c8cf7c1 Use .screen-reader-text class instead of an alt attribute for overlay button labels on Themes screen. 
props bramd.
fixes #26603 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@27119 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:32:31 +00:00
Lance Willett cb8654eade Twenty Fourteen: make sure `featured` tag is hidden on front-end views as expected. Add a check for the tag name in case we're using default values and the default ID of `0` does not match the term id of the `featured` tag. 
Props obenland, fixes #26732.

git-svn-id: https://develop.svn.wordpress.org/trunk@27118 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:16:53 +00:00
Lance Willett dfb4b73fbe Twenty Fourteen: fix gap above static pages, props SergeyBiryukov. Fixes #26694. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27117 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 17:10:04 +00:00
Sergey Biryukov ab112fecb8 Fix typo in wp_set_auth_cookie() description. 
props drozdz.
fixes #27046.

git-svn-id: https://develop.svn.wordpress.org/trunk@27116 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 09:46:19 +00:00
Andrew Nacin 4f5608f653 Use a float for last_changed microtime cache values. 
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.

props _jameslee, drozdz.
fixes #27000. see #23448.


git-svn-id: https://develop.svn.wordpress.org/trunk@27115 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 08:13:37 +00:00
Andrew Nacin 3dbd4f8dcb Revisions browser: The back button should return to the post you were editing (use replaceState instead of pushState). 
props adamsilverstein.
fixes #26997.


git-svn-id: https://develop.svn.wordpress.org/trunk@27114 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 23:27:47 +00:00
Andrew Nacin 99c1b7323c Add imgur to the list of oEmbed providers. 
props bradparbs.
fixes #21632.


git-svn-id: https://develop.svn.wordpress.org/trunk@27113 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 23:11:21 +00:00
Andrew Nacin a2c2c3bfba Network install: When showing the path to wp-config.php make sure our slashes are normalized. 
props VarunAgw.
fixes #27025.


git-svn-id: https://develop.svn.wordpress.org/trunk@27112 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 22:21:34 +00:00
Andrew Nacin 1304fb3463 Fix the conditional enqueueing/printing of colors stylesheets, without breaking dependencies. 
fixes #18380.
see #20729 which should properly fix this.


git-svn-id: https://develop.svn.wordpress.org/trunk@27111 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 22:15:25 +00:00
Andrew Ozz 4d7d68b565 Fix scrolling inside the Visual editor on MacOS, add the same functionality to the Text editor, see #27013 
git-svn-id: https://develop.svn.wordpress.org/trunk@27110 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 19:33:13 +00:00
Helen Hou-Sandi 1b160c1c40 Fix some hover/focus styling and specificity issues. see #18380. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27109 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 17:56:30 +00:00
Scott Taylor 8dad11bfe2 In `get_terms()`, don't set automatically `hierarchical` to `false` when `parent => 0` is passed. The default value for `parent` is `''`. 
In `_get_term_children()`, don't skip a top-level term without first including its children in the returned term list. Ironically, the call to `_get_term_children()` in `get_terms()` has a comment stating `"Make sure we show empty categories that have children."`, but it didn't work if you were retrieving top-level categories only.

All unit tests pass. Added a unit test based on the use case described in this ticket.

Fixes #26903.



git-svn-id: https://develop.svn.wordpress.org/trunk@27108 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 17:44:50 +00:00
Helen Hou-Sandi c2e018dd0d Some tweaks to [27106]: 
* Add more @todo markings and remove one that's been resolved.
* Restore a missing comma in a `.wp-badge` background rule, and add a comment reminding us why it's there.

see #18380.


git-svn-id: https://develop.svn.wordpress.org/trunk@27107 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 07:07:42 +00:00
Helen Hou-Sandi 802baab31a Merge colors.css into wp-admin.css. Non-default color schemes became overloads rather than swaps in the 3.8 redesign. Benefits include: 
* No more border-width, border-style, border-color insanity.
* Point releases are much less likely to require extra finagling to avoid rebuilding the color schemes.
* Yours truly has a better overall vision of ~14,000 lines of admin CSS and where we go from here.

1,065 net lines of red, y'all.
props helen, jorbin. fixes #18380.


git-svn-id: https://develop.svn.wordpress.org/trunk@27106 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 06:24:36 +00:00
Andrew Nacin 7ff0442a07 JSHint fixes for media-views and Gruntfile. 
props gcorne.
fixes #27032, #27033.


git-svn-id: https://develop.svn.wordpress.org/trunk@27105 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 05:31:22 +00:00
Scott Taylor 2127c9322d Move some cache related tests to the new `term/cache.php` from [27103]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27104 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 05:19:05 +00:00
Scott Taylor 324b2799b3 Add the unit test from #25711. The patch was unnecessary due to [27102], but the test is useful. 
Props dd32.
See #25711.



git-svn-id: https://develop.svn.wordpress.org/trunk@27103 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 03:39:22 +00:00
Scott Taylor 50a96f165e Regenerate the term hierarchy cache (`{taxonomy}_children`) when it is out of sync with the passed taxonomy's `last_changed` value. 
Introduces `taxonomy_hierarchy_is_fresh()`, which is only called in `_get_term_hierarchy()`. The taxonomy's `last_changed` value is checked against the value of `wp_cache_get( 'hierarchy_last_changed', $taxonomy )`.

Adds a unit test - `Tests_Term:test_hierachy_invalidation()`.

See [27101], which makes this type of cache invalidation possible.
Fixes #14485.



git-svn-id: https://develop.svn.wordpress.org/trunk@27102 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 01:58:01 +00:00
Scott Taylor e33ef0c6ac Add cache invalidation when updating a term, example: create a category, assign it to a post, edit the category. Currently, the post's term cache is not updated. When updating terms in a given taxonomy, invalidate the object term caches linked to that taxonomy. 
Introduce `get_taxonomy_last_changed()`, `set_taxonomy_last_changed()`, and `post_taxonomy_is_fresh()`.

`post_taxonomy_is_fresh()` is only called in `get_object_term_cache()` - at which point the taxonomy's `last_changed` value is checked against the post's `{$taxonomy}_last_changed` value.

`set_taxonomy_last_changed()` is called whenever directory database queries are made that insert new terms or affect existing terms.

Fixes #22526.



git-svn-id: https://develop.svn.wordpress.org/trunk@27101 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-06 01:40:05 +00:00
Scott Taylor 9b85472ac9 The unit test for the video shortcode needs to mimic the default params for width and post ID. 
See #26628.



git-svn-id: https://develop.svn.wordpress.org/trunk@27100 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 05:16:22 +00:00
Scott Taylor 22fef7cf4b Add a unit test demonstrating the failure to invalidate a post's term cache when the term is updated. 
See #22526.



git-svn-id: https://develop.svn.wordpress.org/trunk@27099 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 03:49:48 +00:00
Andrew Ozz 5a3fb502cb TinyMCE: set the proper caption width when clicking image resize handle on image with caption. Props gcorne, fixes #27009, see #24067. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27098 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 02:06:10 +00:00
wonderboymusic 71947f18d3 When a video shortcode has content in its body, append it as inner HTML in the resulting `<video>`. 
Reverts [27096].
Fixes #26628.
See #27016.



git-svn-id: https://develop.svn.wordpress.org/trunk@27097 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 01:42:02 +00:00
Scott Taylor 3ccf9e9d29 The video shortcode unit test shouldn't be expected to maintain HTML comments. 
See #26864.



git-svn-id: https://develop.svn.wordpress.org/trunk@27096 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 01:24:58 +00:00
Andrew Ozz 89b8edf8f1 TinyMCE: don't scroll the main window when scrolling the editor content with a mouse wheel or trackpad and reaching the end. Fixes #27013. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27095 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 01:09:42 +00:00
Andrew Ozz 6a0251847b Consolidate handling of <object>, <audio> and <video> in wpautop() and add unit tests for them. Part props wonderboymusic, see #26864 
git-svn-id: https://develop.svn.wordpress.org/trunk@27094 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 00:45:53 +00:00
Andrew Ozz b33135c08d When using wp_editor(), make it easier to specify which editor is shown first, fixes #20822 
git-svn-id: https://develop.svn.wordpress.org/trunk@27093 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-05 00:33:49 +00:00
Andrew Nacin 6aaad4785a Autosave: Fix typo in event namespace. props avryl, see #25272. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27092 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 16:06:13 +00:00
Andrew Nacin 2f013a3706 Default themes: Use the 'display' filter for get_bloginfo( 'name' ) attached to the wp_title filter. 
props michelwppi.
fixes #26811.


git-svn-id: https://develop.svn.wordpress.org/trunk@27091 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 13:56:49 +00:00
Drew Jaynes d88b191c9a Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php. 
Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.

Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608.


git-svn-id: https://develop.svn.wordpress.org/trunk@27090 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 08:24:13 +00:00
Drew Jaynes 75d5d14049 Inline documentation for hooks in wp-admin/includes/class-wp-terms-list-table.php. 
Props Ajay, kpdesign.
Fixes #26209.


git-svn-id: https://develop.svn.wordpress.org/trunk@27089 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 07:55:48 +00:00
DrewAPicture ac4774ddbd Inline documentation for hooks in wp-admin/network/sites.php. 
Props NikV, kpdesign.
Fixes #26124.


git-svn-id: https://develop.svn.wordpress.org/trunk@27088 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 07:48:03 +00:00
Scott Taylor 050e4f26e9 Invalidate the post cache for posts associated with a user who has been removed from a blog in `remove_user_from_blog()`. Adds a unit test. 
Props nprasath002 for the initial patch.
Fixes #25545.



git-svn-id: https://develop.svn.wordpress.org/trunk@27087 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-04 04:12:52 +00:00
Andrew Nacin e07424147c Test suite: Trim queries before deciding whether to create temporary tables. 
props jdgrimes.
fixes #24800.


git-svn-id: https://develop.svn.wordpress.org/trunk@27086 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 22:39:47 +00:00
Andrew Ozz 840423ea10 Minor cleanup (jshint) of wp-fullscreen.js and /wordpress/plugin.js, see #24067 
git-svn-id: https://develop.svn.wordpress.org/trunk@27085 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 21:30:25 +00:00
Andrew Ozz 5ff41a8635 Add back missing var definition in wplink.js, props TobiasBg, see #24067 
git-svn-id: https://develop.svn.wordpress.org/trunk@27084 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 21:26:39 +00:00
Andrew Ozz c24e451ae3 TinyMCE: don't replace <i> with <em> and <b> with <strong> and don't remove them when empty, see #24067, see #23037. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 20:25:08 +00:00
Sergey Biryukov 0d8921de03 Add braces around conditionals. props TobiasBg. fixes #25704. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27082 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 20:16:08 +00:00
Scott Taylor 28bab15d16 Properly invalidate the cache for `wp_count_posts()` on insert, trash, or when transitioning `post_status` inside of `_transition_post_status()`. Introduces `_count_posts_cache_key()`. Adds unit tests. 
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879.



git-svn-id: https://develop.svn.wordpress.org/trunk@27081 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 19:41:40 +00:00
Andrew Ozz 9fd8c54ef9 Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27080 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-03 05:30:12 +00:00
Andrew Ozz 33b079b036 Open previews of different posts in different windows/tabs. Prevent confusion when using a former preview window again if the user navigated to edit another post. If the first post is still being edited, clicking Preview there will use the current window to show the preview. Props ippetkov, fixes #20233. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27079 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-02 23:49:05 +00:00
Andrew Ozz 90662a17f4 Editor: add :focus style for the Quicktags buttons, fixes #26932 
git-svn-id: https://develop.svn.wordpress.org/trunk@27078 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-02 22:37:37 +00:00