Andrew Ozz
6228058b64
Fix JS error in tmpl-editor-gallery, 'string'.trim()
is not available in IE < 9. See #28089
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28683 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 01:49:44 +00:00
Helen Hou-Sandi
3d9fc450b2
Grid view for the media library, first pass. This is alpha; expect imperfection. We will be iterating further.
...
props ericlewis, shaunandrews, wonderboymusic.
see #24716 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28682 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 22:00:24 +00:00
Sergey Biryukov
c7c1a4a88a
Remove one-time variable from add_settings_error().
...
props niallkennedy.
fixes #22228 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28681 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 18:28:15 +00:00
Scott Taylor
c18f082b15
Simplify the creation of MCE views somewhat:
...
* Rename the `wp.mce.media` mixin (which was named too ambiguously) to `wp.mce.av`.
* Use the same technique for extending mixins for MCE base classes for views and their base.View property class
* `wp.mce.views.register()` should have default constructor logic if one is not passed.
Props avryl.
See #28458 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28680 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 17:26:24 +00:00
Sergey Biryukov
504f5ad680
Deprecate get_all_category_ids(). Suggest get_terms() as a replacement.
...
props winterDev, MikeHansenMe.
fixes #21200 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28679 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 16:25:01 +00:00
Sergey Biryukov
2ed8b8578c
Remove closing PHP tags from the rest of index.php files in wp-content, for consistency with wp-content/index.php.
...
props kraftbj.
fixes #23505 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28678 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:58:46 +00:00
Sergey Biryukov
83bffbc6c7
Correct @return value for get_children().
...
props ghost1227.
fixes #28422 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28677 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:52:51 +00:00
Sergey Biryukov
ff3f4e888f
Add a note about return value in case of an expired transient to get_transient() and get_site_transient().
...
props ruud@joyo.
fixes #28462 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28676 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 15:33:30 +00:00
Scott Taylor
60a49287f6
Media modal documentation:
...
Add some clarity to default values for controllers.
Props ericlewis.
See #28459 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28675 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 14:53:44 +00:00
Andrew Nacin
0dcce859fb
Force SSL admin when siteurl is explicitly configured with HTTPS.
...
see #27954 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28674 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 14:08:11 +00:00
Sergey Biryukov
7f3b20c45d
Remove redundant 'Visit author homepage' title attributes for plugins and themes.
...
props joedolson.
fixes #26554 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28673 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:51:55 +00:00
Sergey Biryukov
c556e74943
wp_insert_comment() and wp_new_comment() should check if the comment was successfully inserted into the database.
...
props pento.
fixes #28254 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28672 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 04:37:02 +00:00
Sergey Biryukov
4fde71e75d
Avoid an empty href attribute in paginate_links(). Add unit tests.
...
props obenland, Nessworthy.
fixes #24606 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28671 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 02:09:12 +00:00
Sergey Biryukov
5c071dbc16
Add a filter to human_time_diff().
...
props slimndap.
fixes #27271 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28670 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 00:38:33 +00:00
Sergey Biryukov
f54a73f637
Add 'wp_title_parts' filter to wp_title().
...
props aaroncampbell, obenland.
fixes #17877 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28669 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-05 00:27:37 +00:00
Sergey Biryukov
d33d83495c
Move is_admin check to a more appropriate place.
...
see #11330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28668 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 23:46:39 +00:00
Sergey Biryukov
0b5eac467f
Avoid a PHP notice when using WP_Query::get_queried_object() in pre_get_posts action.
...
props wpsmith.
fixes #28412 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28667 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 23:42:09 +00:00
Scott Taylor
2948b6d35a
Prevent admin breakage for s
in WP_Query
after [28623].
...
See #11330 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28666 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 20:02:46 +00:00
Scott Taylor
577d223715
Wrap individual meta query WHERE
clases in parens, missed in 28659
.
...
Props boonebgorges.
Fixes #25538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28665 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 18:20:59 +00:00
Scott Taylor
ee9f2e48bb
After [28613], also kill queries that explicityly pass empty arrays to category__in
, tag__in
, tag_slug__in
, and author__in
to WP_Query
.
...
Adds unit tests.
Fixes #28099 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28664 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 17:49:26 +00:00
Lance Willett
e0e0685ebd
Twenty Fourteen: apply .widget
input and textarea styles only if they are inside .widget-area
. Props jesin, fixes #27677 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28663 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 17:33:42 +00:00
Lance Willett
7e678bbfce
Twenty Thirteen: fix layout issue with search form in older versions of Safari and Android. Fixes #24192 , props iljoja.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28662 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 17:31:15 +00:00
Lance Willett
4cfc6c0cb0
Twenty Fourteen: add documentation for global variables used in twentyfourteen_wp_title()
. Closes #28421 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28661 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 17:14:24 +00:00
Drew Jaynes (DrewAPicture)
d4768ff0fe
Improve inline documentation for the __construct()
and add()
methods in WP_Error
class.
...
Props jdgrimes.
Fixes #28203 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28660 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 06:05:46 +00:00
Scott Taylor
1ffe74ad6f
Fix SQL generation when meta_query
has an 'relation' => 'OR'
for its queries and wants to 'orderby' => 'meta_value'
.
...
Adds unit test.
Props jackreichert.
Fixes #25538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28659 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 05:47:19 +00:00
Drew Jaynes (DrewAPicture)
24b3ed214e
Make sure to use 3-digit x.x.x style for two 3.9.0 @since
versions.
...
Props netweb.
Fixes #28446 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28658 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 05:34:37 +00:00
Drew Jaynes (DrewAPicture)
85961d28df
Mark the MYSQL_NEW_LINK
constant as deprecated in 3.9+ as no equivalent to the $new_link
parameter exists in mysqli_*
functions.
...
Fixes #27933 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28657 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 05:00:00 +00:00
Drew Jaynes (DrewAPicture)
9232548142
Improve inline documentation for wp-includes/load.php.
...
Props ericlewis, DrewAPicture.
Fixes #24886 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28656 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-04 04:11:21 +00:00
Drew Jaynes (DrewAPicture)
b884487767
Be more specific that $post_id
does not default to the ID of the global $post
in some cases.
...
See [28654]. See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28655 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:51:05 +00:00
Drew Jaynes (DrewAPicture)
d068c888f3
Ensure $post_id
is documented as optional where applicable.
...
See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28654 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 04:43:47 +00:00
Drew Jaynes (DrewAPicture)
9bb9177199
Make sure $post
is properly documented as optional where applicable.
...
See #28388 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28653 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-03 03:52:46 +00:00
Scott Taylor
6a9c55cd9f
Because of YouTube's overwhelming dominance in the online video space, we should help our users who paste bad URLs when possible. It is easy to fix
http://youtube.com/embed/acb1233 URLs by turning them into
http://youtube.com/watch?v=abc1233 embeds using an embed handler (we already have one to fix Google Video embeds).
...
We should avoid doing this in almost every other case, but it's YouTube, and it's an easy error for a novice to make.
Fixes #24660 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28652 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 01:21:13 +00:00
Sergey Biryukov
9953e4ddaf
Add oEmbed support for TED talks.
...
props pdclark.
fixes #28285 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28651 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:45:12 +00:00
Scott Taylor
174af6cca4
In the spirit of [27622], add a few CSS rules to ensure that videos will be responsive, regardless of theme.
...
Props Funkatronic.
Fixes #28414 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28650 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:39:47 +00:00
Scott Taylor
58690d7b97
In WPPlaylistView::ended()
, at the end of a playlist, set the index to 0
and call ->setCurrent()
instead of ->loadCurrent()
so that the first track is properly highlighted.
...
Fixes #28428 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28649 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-02 00:26:24 +00:00
Sergey Biryukov
d4b336ded2
Fix typo in mbstring_binary_safe_encoding() description.
...
props ghost1227.
fixes #28423 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28648 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-01 05:05:44 +00:00
Sergey Biryukov
4ecfd017b8
Capitalize 'ID' correctly to avoid random failures of Tests_Tax_Query::test_term_taxonomy_id_field_no_taxonomy().
...
see #25284 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28647 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-01 03:17:16 +00:00
Sergey Biryukov
e8e39d212b
Plugin activation/deletion errors should be styled as such.
...
props johnbillion.
fixes #28260 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28646 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-31 20:09:26 +00:00
Lance Willett
f48c3b9582
Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's pagination_base
value instead. Document global variable usage properly.
...
Props SergeyBiryukov, fixes #28405 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28645 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-31 18:50:16 +00:00
Sergey Biryukov
c04daa1ade
Avoid stomping of the $plugin variable in activate_plugin().
...
fixes #28102 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28644 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:07:43 +00:00
Sergey Biryukov
9120e6a9d7
Display the site scheme, not the current scheme on Edit Site screen in network admin.
...
props johnbillion.
fixes #28406 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28643 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 22:00:45 +00:00
Sergey Biryukov
dbef7e2587
Add paragraph tags to 'Add Existing User' section on 'Add New User' screen in multisite.
...
props jkudish, topher1kenobe.
fixes #20271 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28642 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 21:50:24 +00:00
Sergey Biryukov
3afd9885c2
Adjacent links in wp_head() should only be generated for posts, not pages.
...
props alexander.rohmann.
fixes #21658 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28641 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 21:19:55 +00:00
wonderboymusic
2d0be44d85
In WP_Image_Editor_GD::_save()
, pass $compression_level
into the args array for ->make_image()
.
...
Props MuViMoTV, markoheijnen, SergeyBiryukov, mikemanger, ericlewis.
Fixes #24380 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28640 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 20:05:02 +00:00
Scott Taylor
804b82bd11
Make the image editor less jumpy when opening.
...
Props eddiemoya, ericlewis.
Fixes #22793 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28639 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:52:35 +00:00
Scott Taylor
3d48e21248
Fix an error caused by [28604] in get_comments_number()
unit tests.
...
Props SergeyBiryukov.
Fixes #26240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28638 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:46:05 +00:00
Scott Taylor
e996a74984
Restore $val
in WP_Importer::bump_request_timeout()
- even though the parent class and WP_Import
ignore the parameter, it creates an incompatible interface notice in the plugin.
...
See [28629].
git-svn-id: https://develop.svn.wordpress.org/trunk@28637 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:34:53 +00:00
Scott Taylor
fc2601044b
wp_xmlrpc_server::wp_getPage()
should return new IXR_Error(
instead of return(new IXR_Error(
. One of the few places that is unparseable by static analysis.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28636 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:21:33 +00:00
Scott Taylor
273fd5ca4c
Add more test coverage for wpdb
.
...
See #26999 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28635 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 19:17:15 +00:00
Scott Taylor
de685a9f73
Move default
to the bottom in _wp_mysql_week()
.
...
See #28409 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28634 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-30 18:09:43 +00:00