Commit Graph

29843 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
ff4f261101 Merge similar error strings.
props pavelevap.
fixes #32327.

git-svn-id: https://develop.svn.wordpress.org/trunk@32471 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 18:26:37 +00:00
Scott Taylor
e7d9eda799 In fetch_feed(), call ->set_output_encoding() on the SimplePie instance to ensure the feed is served with encoding specified by the blog_charset option.
Props chriscct7.
Fixes #10713.


git-svn-id: https://develop.svn.wordpress.org/trunk@32469 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:48:45 +00:00
Scott Taylor
6ce6180884 Serve RSS feeds with the proper mime-type: application/rss+xml. The reason for hacking around browsers by using text/xml appears to no longer be relevant.
Props @chriscct7.
Reverts [11334] and [11358]
Fixes #15110.


git-svn-id: https://develop.svn.wordpress.org/trunk@32468 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:38:38 +00:00
Scott Taylor
5d69ee66dd In media-template.php, change a few <a href="#" class="button">s to <button type="button" class="button" ...>.
See #26550.


git-svn-id: https://develop.svn.wordpress.org/trunk@32467 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 06:06:50 +00:00
Scott Taylor
f9fd563ec7 Media Grid: clean up our flawed Backbone.Router implementation so that the browser forward/back buttons work the same way as the left/right keys when the Edit Attachment frame is open.
Fixes #31846.


git-svn-id: https://develop.svn.wordpress.org/trunk@32466 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 05:41:01 +00:00
John Blackbourn
1b76bd6246 Introduce a $token argument to wp_set_auth_cookie() so session tokens can be reused by custom authentication implementations.
Props rmccue

Fixes 30247


git-svn-id: https://develop.svn.wordpress.org/trunk@32465 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-09 00:27:11 +00:00
Scott Taylor
8303e8f314 wp.media.view.Button should create <button>s, not <a href="#">s.
Props afercia.
See #32236.


git-svn-id: https://develop.svn.wordpress.org/trunk@32464 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:38:55 +00:00
Scott Taylor
3fd2730435 In EmbedLink, a URL needs to be at least 11 chars to be useful.
Fixes #32059.


git-svn-id: https://develop.svn.wordpress.org/trunk@32463 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:29:55 +00:00
Scott Taylor
bbcddbbb72 When creating an EmbedLink view, don't add a spinner - it already exists in Embed.
Use the value of `wp.media.controller.Embed.sensitivity` as the sensitivity value for the debounced method in `EmbedLink` to ensure that the spinner toggles don't stutter or overlap.

Fixes #32036.


git-svn-id: https://develop.svn.wordpress.org/trunk@32462 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 20:09:58 +00:00
Boone Gorges
637bedeece Use table prefix for comment__in and comment__not_in SQL clauses of WP_Comment_Query.
The prefix prevents ambiguity when joining against other tables.

Props willgladstone.
Fixes #32081.

git-svn-id: https://develop.svn.wordpress.org/trunk@32461 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 19:44:06 +00:00
Scott Taylor
c8ca3c2304 When fetching in media/views/embed/link.js, call abort() on any existing XHRs.
Use `$.ajax` instead of `wp.ajax.send()` to allow this.
Pass `this` as `context` to the options to remove the need to bind callbacks.

Fixes #32035.


git-svn-id: https://develop.svn.wordpress.org/trunk@32460 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 19:15:34 +00:00
Scott Taylor
c6592462ef In media/views/embed/link.js, URLs should have a valid protocol before an attempt to fetch them is made.
Fixes #32037.


git-svn-id: https://develop.svn.wordpress.org/trunk@32459 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 18:33:34 +00:00
Andrew Nacin
df717e8294 Add a comment to maybe_serialize().
git-svn-id: https://develop.svn.wordpress.org/trunk@32458 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 16:26:13 +00:00
Gary Pendergast
733e06315a Upgrades: If a table has already been converted to utf8mb4, there's no need to try and convert it again.
Props gabrielperezs for the initial patch.

See #32310.



git-svn-id: https://develop.svn.wordpress.org/trunk@32456 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 12:21:18 +00:00
Gary Pendergast
2cde17f232 When saving Writing Options, check that the UI is enabled for use_smilies and use_balanceTags before trying to update them.
Fixes #5161.
Fixes #32298.



git-svn-id: https://develop.svn.wordpress.org/trunk@32455 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 11:58:22 +00:00
Gary Pendergast
231c73751b On the Writing Options screen, hide the Balance Tags and Convert Smilies options on new installs.
Fixes #5161.
Fixes #32298.



git-svn-id: https://develop.svn.wordpress.org/trunk@32454 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-08 06:51:52 +00:00
Drew Jaynes
8cb8a90b7e Fix a wide variety of syntactical, spacing, wording, and other issues in wp-includes/taxonomy.php.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32453 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 06:13:27 +00:00
Drew Jaynes
3ff997b3b6 Ensure the optional parameter in get_object_taxonomies() is documented as such.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32452 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 05:32:29 +00:00
Drew Jaynes
2b62df22b3 Add a description to the hook documentation for the created_$taxonomy action to clarify the dynamic portion of the hook name.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32451 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 05:27:36 +00:00
Drew Jaynes
97ac7fffa1 Add missing parameter descriptions to the created_term hook documentation.
Props dlh.
Fixes #32276.


git-svn-id: https://develop.svn.wordpress.org/trunk@32450 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 05:25:30 +00:00
Andrew Nacin
b462ce203f Twenty Fifteen is 1.2 after [32392].
git-svn-id: https://develop.svn.wordpress.org/trunk@32442 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 01:38:08 +00:00
Michael Adams (mdawaffe)
80238b81d6 Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes.
Props jorbin, et alii.

See #32165.


git-svn-id: https://develop.svn.wordpress.org/trunk@32440 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-07 01:10:05 +00:00
Michael Adams (mdawaffe)
89b384a05a Upgrade: $wpdb->get_col_length() sanity check: bail on unexpected return value.
See #32165.


git-svn-id: https://develop.svn.wordpress.org/trunk@32429 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 23:10:18 +00:00
Michael Adams (mdawaffe)
a42401d0c9 Upgrade: Ensure unintelligible DB schemas don't result in content loss.
See #32165.


git-svn-id: https://develop.svn.wordpress.org/trunk@32417 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 21:45:58 +00:00
Dominik Schilling (ocean90)
2abdcf41cf Bundled Themes: Remove Genericons example.html files.
git-svn-id: https://develop.svn.wordpress.org/trunk@32392 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 19:26:59 +00:00
Aaron Jorbin
1417929e0d When upgrading WordPress remove genericons example.html files
Props @dd32, @boone, @johnjamesjacoby, @drewapicture, @jorbin

--This line,build.wordpress-develop.dea and those below, will be ignored--

M    src/wp-admin/includes/update-core.php


git-svn-id: https://develop.svn.wordpress.org/trunk@32385 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 18:36:48 +00:00
Sergey Biryukov
5af9ac0ea2 Customizer: Use a semantic, accessible element for Remove Header Image button.
Make the button more noticeable on dark, light, and busy images.

props afercia, RDall, melchoyce.
fixes #32227, #31325.

git-svn-id: https://develop.svn.wordpress.org/trunk@32382 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 10:53:07 +00:00
Sergey Biryukov
2b8e7270d5 Multisite: Add translator comments to default email messages with non-typical placeholders.
props yoavf.
fixes #32263.

git-svn-id: https://develop.svn.wordpress.org/trunk@32381 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 09:11:18 +00:00
Gary Pendergast
9e12deeb9c Fix an incorrect version number check in [32378].
See #32099.



git-svn-id: https://develop.svn.wordpress.org/trunk@32379 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:40:36 +00:00
Gary Pendergast
ca11cafb07 Upgrades: When converting to utf8mb4, we were trying to change the wrong index on wp_signups, causing the conversion to later fail.
Props kovshenin, pento.

See #32099.



git-svn-id: https://develop.svn.wordpress.org/trunk@32378 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 07:33:53 +00:00
Gary Pendergast
ba24459a63 The UTF-8 regex can occasionally fail on very low memory machines. Reduce the amount of memory it uses.
See #32204.



git-svn-id: https://develop.svn.wordpress.org/trunk@32375 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 06:57:44 +00:00
Gary Pendergast
ed53ad2c53 WPDB: When sanity checking query character sets, there's no need to check queries that don't return user data.
See #32104.



git-svn-id: https://develop.svn.wordpress.org/trunk@32374 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 06:04:50 +00:00
Gary Pendergast
923c6c981b WPDB: Allow queries to reference tables in the dbname.tablename format, and allow table names to contain any valid character, rather than just ASCII.
Props pento, willstedt for the initial patch.

See #32090.



git-svn-id: https://develop.svn.wordpress.org/trunk@32368 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 05:00:39 +00:00
Andrew Ozz
8737968ac2 TinyMCE: update to 4.1.10.
Fixes #32262.

git-svn-id: https://develop.svn.wordpress.org/trunk@32366 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 03:22:04 +00:00
Gary Pendergast
2ce97b2984 WPDB: When checking that a string can be sent to MySQL, we shouldn't use mb_convert_encoding(), as it behaves differently to MySQL's character encoding conversion.
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.



git-svn-id: https://develop.svn.wordpress.org/trunk@32364 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-06 02:59:50 +00:00
Boone Gorges
35db6d722b In paginate_links(), improve handling of custom pagination query vars.
Custom pagination query vars, as provided in the 'base' parameter, must be
detected in the current page URL and removed before generating fresh pagination
links. The logic introduced in this changeset ensures that these custom
query vars are properly detected in cases where the 'format' param contains
a `#`.

This is a follow-up to [31203] #30831.

Fixes #31939.

git-svn-id: https://develop.svn.wordpress.org/trunk@32359 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 21:58:23 +00:00
Boone Gorges
70f530e238 youtube.com oEmbed test should always expect HTTPS.
YouTube recently changed its oEmbed endpoint so that the iframe markup always
contains an HTTPS URL, regardless of the scheme of the video URL originally
requested. This changeset fixes the corresponding unit test.

Fixes #32260.

git-svn-id: https://develop.svn.wordpress.org/trunk@32358 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 21:30:57 +00:00
Aaron Jorbin
e68f7765c1 Update grunt-autoprefixer to 3.0.0
Two changes we need to know about:
* Aborts build if there is an exception thrown bu autoprefixer
* Less verbose output in standard mode

Major version seems to have been bumped due to change in annotation option which which we do not use.

Upstream Changes e30d2c5bfd...6f8dfe8840

See #31700


git-svn-id: https://develop.svn.wordpress.org/trunk@32357 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 21:29:04 +00:00
Aaron Jorbin
ee60ec1c23 Update grunt-contrib-qunit to 0.7.0
This upgrade adds two changes, both of which are aimed at less reporting of false test passing:
* Log PhantomJS errors as warnings
* Add noGlobals option, forwarded to QUnit. Report proper exit code to grunt based on failures. Add support for AMD.

See #31700



git-svn-id: https://develop.svn.wordpress.org/trunk@32356 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 20:29:29 +00:00
Boone Gorges
bb29a878c6 Improve performance of get_page_children().
The new algorithm uses a hash table rather than function recursion, reducing
complexity to O(N). On large numbers of pages, the performance improvement is
several orders of magnitude.

Props santagada, hailin, mihai.
Fixes #10852.

git-svn-id: https://develop.svn.wordpress.org/trunk@32355 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 19:36:58 +00:00
Boone Gorges
ba712c6789 Unit tests for get_page_children().
Props santagada, boonebgorges.
See #10852.

git-svn-id: https://develop.svn.wordpress.org/trunk@32354 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 19:36:46 +00:00
Boone Gorges
1efe303ebf Improve sanitization of 'name' param in get_terms().
Values of 'name' that contain db-encoded character on insert - like an
ampersand, which is HTML-encoded in the database - will only match if they go
through the same `sanitize_term_field()` routine.

Fixes #32248.

git-svn-id: https://develop.svn.wordpress.org/trunk@32353 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 11:13:51 +00:00
Drew Jaynes
3ca1ff6b72 Fix documentation syntax and formatting for the media_sideload_image() DocBlock.
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32352 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:19:47 +00:00
Drew Jaynes
9d9fbf6a5b Add a changelog entry for the $resource_type parameter added to the get_ancestors filter in 4.1.1.
Props dimadin.
See #31925.


git-svn-id: https://develop.svn.wordpress.org/trunk@32351 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:16:58 +00:00
Drew Jaynes
7138b7e1bd Add two changelog entries for functional changes introduced in 4.2.0.
Props dimadin.
See #31925.


git-svn-id: https://develop.svn.wordpress.org/trunk@32350 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:15:27 +00:00
Drew Jaynes
fae4ff9b2f Ensure the optional parameters for get_taxonomies() are documented as such.
See #31800.


git-svn-id: https://develop.svn.wordpress.org/trunk@32349 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:04:52 +00:00
Drew Jaynes
e8668f7bca Improve inline documentation in wp-includes/taxonomy.php.
* Adds missing `@since` versions
* Adds `@global` tags and descriptions to DocBlocks where appropriate

Props ChaseWiseman.
See #31800.


git-svn-id: https://develop.svn.wordpress.org/trunk@32348 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 02:00:18 +00:00
Andrew Ozz
717ea3f7cd Emoji: add shorter/faster regex for testing for emoji chars in added nodes.
See #32125.

git-svn-id: https://develop.svn.wordpress.org/trunk@32347 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 01:40:21 +00:00
Boone Gorges
a4625b51eb Add 'webcal' to the list of URI protocols whitelisted by default.
Fixes #31666.

git-svn-id: https://develop.svn.wordpress.org/trunk@32346 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 00:37:14 +00:00
Drew Jaynes
fbb60698ea Add a missing @return tag and description to the DocBlock for WP_Theme::scandir().
Props lamosty.
Fixes #31872.


git-svn-id: https://develop.svn.wordpress.org/trunk@32345 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-05 00:33:55 +00:00