Commit Graph

24041 Commits

Author SHA1 Message Date
Dion Hulse 43d50e9c9e Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756
git-svn-id: https://develop.svn.wordpress.org/trunk@26013 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 02:14:34 +00:00
Scott Taylor d8f57f88ad Respect `paged` when `offset` is used in `WP_Query`. Adds unit tests.
Props coffee2code.
Fixes #18897.



git-svn-id: https://develop.svn.wordpress.org/trunk@26012 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:34:44 +00:00
Scott Taylor 5643e3ca17 Pass `$args` to the `export_wp` action in `export_wp()`, which is currently passed no arguments.
Props nickdaugherty.
Fixes #25574.



git-svn-id: https://develop.svn.wordpress.org/trunk@26011 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:26:49 +00:00
Scott Taylor ed22220a0f Cast proper fields to `int` when returning from `wp_get_object_terms()`. Add `term_taxonomy_id` and `object_id` to the list in `sanitize_term()` and `sanitize_term_field()`.
Fixes #17646. Adds unit tests.
Props simonwheatley, dd32, kovshenin.



git-svn-id: https://develop.svn.wordpress.org/trunk@26010 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 01:18:02 +00:00
Scott Taylor 67443e080c Don't globalize version variables twice. See #23685.
git-svn-id: https://develop.svn.wordpress.org/trunk@26009 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 00:57:52 +00:00
Scott Taylor 268667e170 When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be. Explicitly make the version variables global.
Props nbachiyski.
Fixes #23685.



git-svn-id: https://develop.svn.wordpress.org/trunk@26008 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-05 00:23:38 +00:00
Scott Taylor 0923b7b93a Category and tag are typically checked before checking for a custom taxonomy. If the global query matches category or tag (even if it also has tax_query set), return category/tag as the queried object, instead of arbitrarily returning the first term in the `tax_query` stack (typically those added with 'pre_get_posts').
Real world example: http://www.emusic.com/17dots/topics/daily-download/ - "tag" page, regionalized for US-only content using `pre_get_posts` passing in the terms "US" and "ALL" for "region" (custom tax). All of the theme functions would output "ALL" as the term name. Even though it was a tag archive, the queried object was an arbitrary term from `tax_query`.

See [26006]. All unit tests pass.
Fixes #20767.




git-svn-id: https://develop.svn.wordpress.org/trunk@26007 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 23:53:55 +00:00
Scott Taylor 5321bc4957 `WP_UnitTestCase::go_to()` tried its best to clean up global space, but ultimately fell short. Because it was blowing away `WP` every time it was called, it was dropping all the query vars that were registered for custom taxonomies and custom post types (ouch).
Introduces `_cleanup_query_vars()`. This is a prerequisite for the unit tests on #20767. All unit tests pass with this change.

See #20767.
Fixes #25818.



git-svn-id: https://develop.svn.wordpress.org/trunk@26006 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 22:46:44 +00:00
Scott Taylor 2f38d2efc6 Move `Tests_Query_Conditionals::assertQueryTrue()` to `WP_UnitTestCase`. It should be available to all unit test classes. The conditionals class is huge, other classes are necessary for better coverage.
git-svn-id: https://develop.svn.wordpress.org/trunk@26005 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 21:55:12 +00:00
Scott Taylor ecbcfc5a20 Set the default parent id to 0, instead of -1, in `Tests_Post_Attachments::_make_attachment()`. Prevents `Out of range value for column 'post_parent'` database error without papering over it in core.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@26004 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 21:39:35 +00:00
Lance Willett e512f03e75 Twenty Fourteen: update bundled Genericons to the latest version, 3.0.2. Props iamtakashi, closes #25812.
git-svn-id: https://develop.svn.wordpress.org/trunk@26003 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 18:07:18 +00:00
Lance Willett 848937c672 Twenty Thirteen: capitalize "Not Found" string for use in a page title, see #24891 and r25907.
git-svn-id: https://develop.svn.wordpress.org/trunk@26002 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 17:56:32 +00:00
Sergey Biryukov 6fa1c89458 Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row().
props drozdz.
fixes #25814.

git-svn-id: https://develop.svn.wordpress.org/trunk@26001 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-04 10:59:58 +00:00
Sergey Biryukov acc8ac64b8 Fall back to comment author email in get_avatar() if the user who left the comment no longer exists.
props mauryaratan, lite3.
fixes #25803.

git-svn-id: https://develop.svn.wordpress.org/trunk@26000 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-02 12:19:43 +00:00
Lance Willett fcc1bb0b65 Twenty Fourteen: revamp the RTL stylesheet and related cleanup. Props iamtakashi, see #25801.
git-svn-id: https://develop.svn.wordpress.org/trunk@25999 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-02 04:35:35 +00:00
Lance Willett b604102332 Twenty Fourteen: second pass at revamping the main CSS file. Update pattern graphics to fix issue with orientation changes on tablets. Props iamtakashi, fixes #25592.
git-svn-id: https://develop.svn.wordpress.org/trunk@25998 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-31 04:27:51 +00:00
Sergey Biryukov 3c625347e6 Correct $user_id parameter description. props mauryaratan, Corphi. fixes #25774.
git-svn-id: https://develop.svn.wordpress.org/trunk@25997 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 20:17:21 +00:00
Andrew Nacin 90202aed35 Explicitly globalize $is_nginx in vars.php.
props johnjamesjacoby.
fixes #25776.


git-svn-id: https://develop.svn.wordpress.org/trunk@25996 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 19:36:39 +00:00
Lance Willett 34139288e8 Twenty Fourteen: JavaScript fixes after running jshint, see r25960:
* Enforce `===` instead of `==`
 * Fix confusing use of `!`
 * Remove unused variables like `calcNext`, defined but never used
 * Proper use of braces
 * Move functions out of if/else statements
 * Document unknown functions as Microsoft-specific

git-svn-id: https://develop.svn.wordpress.org/trunk@25995 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 18:52:54 +00:00
Drew Jaynes 206d47a9c2 Inline documentation for hooks in wp-admin/network/edit.php and wp-admin/network/users.php.
Props aralbald for the initial patch.
Fixes #25728.


git-svn-id: https://develop.svn.wordpress.org/trunk@25994 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 16:03:14 +00:00
Drew Jaynes 3dc92bdd03 Inline documentation for hooks in wp-admin/nav-menus.php.
Props pauldewouters for the intial patch.
Fixes #25528.


git-svn-id: https://develop.svn.wordpress.org/trunk@25993 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 15:44:32 +00:00
Andrew Nacin 5c63859ffb Add jshintrc to qunit.
props jorbin.
see #25187.


git-svn-id: https://develop.svn.wordpress.org/trunk@25992 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 14:38:37 +00:00
Sergey Biryukov bc6c0c9b0f Correct @since values for various hooks. fixes #25766.
git-svn-id: https://develop.svn.wordpress.org/trunk@25991 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-30 03:19:16 +00:00
Sergey Biryukov a1fe0926b3 Remove incorrect @return value from status_header(). Rename some variables for clarity.
props tivnet for initial patch.
fixes #25451.

git-svn-id: https://develop.svn.wordpress.org/trunk@25990 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 22:43:08 +00:00
Andrew Nacin 23ad7058fb Internal linking: Remove explicit orderby, thus allowing the relevancy improvements in #7394 to work.
see #25763.


git-svn-id: https://develop.svn.wordpress.org/trunk@25988 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 21:20:59 +00:00
Andrew Nacin 1cce2a89fd PHP4 compatibility for files loaded before we bail. fixes #25760.
git-svn-id: https://develop.svn.wordpress.org/trunk@25986 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 20:05:16 +00:00
Lance Willett e575c315fb Twenty Fourteen: allow any page to be set as the front page, removing requirement for `front-page.php` template file. Props iamtakashi, fixes #25685.
git-svn-id: https://develop.svn.wordpress.org/trunk@25985 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 19:05:02 +00:00
Drew Jaynes 6b711ca35e Inline documentation for hooks in wp-admin/edit-form-comment.php.
Props rzen.
Fixes #25521.


git-svn-id: https://develop.svn.wordpress.org/trunk@25983 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 17:35:13 +00:00
Lance Willett 7b05d5c2e7 Twenty Fourteen: get rid of two last cases of `clear` class value. See #25592.
git-svn-id: https://develop.svn.wordpress.org/trunk@25980 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 16:40:38 +00:00
Lance Willett 93b93b103f Twenty Fourteen: implement an alternate "slider" view for home page featured content. Props iamtakashi for the design and implementation. Slider JavaScript code adapted from FlexSlider v2.2.0 props WooThemes and mbmufffin. See #25550.
git-svn-id: https://develop.svn.wordpress.org/trunk@25979 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 16:28:11 +00:00
Sergey Biryukov e3e3e1d109 Remove docs suggesting that wp_insert_user() can be used to update an existing user. wp_update_user() should be used instead. fixes #25745.
git-svn-id: https://develop.svn.wordpress.org/trunk@25978 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 14:31:07 +00:00
Andrew Nacin 78f8c980da Use correct variable in WP_Automatic_Updater::send_email().
props pento.
see #25757 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25977 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 13:45:17 +00:00
Andrew Nacin 9b9311ae2b Move the unit test added in [25974] to the more appropriate file. see #25750.
git-svn-id: https://develop.svn.wordpress.org/trunk@25975 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 01:47:48 +00:00
Andrew Nacin 2cac0fde8a Avoid resetting the 'hierarchical' argument in get_pages() when 'parent' is -1, the default.
Fixes a regression introduced in [25270]. Adds unit tests.

props chrisbliss18.
fixes #25750.


git-svn-id: https://develop.svn.wordpress.org/trunk@25974 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 01:46:01 +00:00
Dominik Schilling (ocean90) 4be9031dc3 Widen fields for Quick Edit for the de_DE locale and improve styles for the ru_RU locale.
props zodiac1978.
fixes #25753.

git-svn-id: https://develop.svn.wordpress.org/trunk@25973 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 23:28:32 +00:00
Sergey Biryukov ddf0147a4f Move test_get_pages_include_exclude() and test_get_pages_parent() to tests/post/getPages.php. Add a @ticket reference. see [25168] and [25244].
git-svn-id: https://develop.svn.wordpress.org/trunk@25972 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 21:49:27 +00:00
Lance Willett eb01af41c2 Twenty Fourteen: clean up post thumbnail naming. Props iamtakashi, fixes #25718.
git-svn-id: https://develop.svn.wordpress.org/trunk@25971 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 17:57:57 +00:00
Lance Willett 01a703070b Twenty Fourteen: Fix gallery posts in the ephemera widget. Props iamtakashi, fixes #25740.
git-svn-id: https://develop.svn.wordpress.org/trunk@25970 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 17:52:45 +00:00
Lance Willett bd5ac31911 Twenty Fourteen: display titles for aside, link, and quote format on small screens. Props iamtakashi, fixes #25694.
git-svn-id: https://develop.svn.wordpress.org/trunk@25969 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 17:48:46 +00:00
Sergey Biryukov 2e50c871ab Avoid a PHP warning in wp_generate_attachment_metadata() if $metadata is not an array. props asakurayoh. fixes #25649.
git-svn-id: https://develop.svn.wordpress.org/trunk@25968 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 16:42:36 +00:00
Drew Jaynes 030d69717c Inline documentation for hooks in wp-admin/network/settings.php.
Props ninio for the initial patches.
Fixes #25727.


git-svn-id: https://develop.svn.wordpress.org/trunk@25967 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 15:21:59 +00:00
Sergey Biryukov 9a5e8acead Restore @see get_next_post_link() reference and move it to next_post_link(). see #25743.
git-svn-id: https://develop.svn.wordpress.org/trunk@25966 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 11:10:28 +00:00
Sergey Biryukov 5674a54940 Fix a copy/paste error in get_next_post_link() description and $format argument. props jim912, ounziw. fixes #25743.
git-svn-id: https://develop.svn.wordpress.org/trunk@25965 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 11:05:26 +00:00
Sergey Biryukov 267b476885 Fix a copy/paste error in wp_update_theme() description. props Caspie. fixes #25742.
git-svn-id: https://develop.svn.wordpress.org/trunk@25964 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 10:55:50 +00:00
Drew Jaynes e496679014 Clarify that `wpmu_update_blog_options` fires after ''site'' options are updated.
See #25725.


git-svn-id: https://develop.svn.wordpress.org/trunk@25963 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-28 00:16:54 +00:00
Drew Jaynes d8f9cc6fff Mark `subdirectory_reserved_names` filter as duplicate in wp-admin/network/site-new.php.
Props ninio.
Fixes #25729.


git-svn-id: https://develop.svn.wordpress.org/trunk@25962 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 23:36:46 +00:00
Drew Jaynes 3a26e383ae Inline documentation for hooks in wp-admin/includes/theme.php.
Props l10n for the initial patch.
Fixes #25732.


git-svn-id: https://develop.svn.wordpress.org/trunk@25961 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 22:45:32 +00:00
Andrew Nacin 06635ed4cd Add a .jshintrc file and associated jshint grunt task.
This .jshintrc is adopted from the jQuery project, with some basic modifications (such as single quotes instead of double quotes). This pretty closely follows our current JS standards and rather closely resembles our PHP standards, especially the love of whitespace. The major changes are enforcing === and always using braces for if statements.

props kadamwhite, gnarf37, with mattwiebe and carldanley.
see #25187.


git-svn-id: https://develop.svn.wordpress.org/trunk@25960 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 21:53:11 +00:00
Andrew Nacin add8bc4e57 Add a $taxonomy argument to each of the adjacent post functions.
Each took an array of category (IDs) when to search. Those can now be term IDs and each function now has $taxonomy = 'category' as an optional argument.

Functions affected: get_previous_post(), get_next_post(), get_adjacent_post(), get_adjacent_post_rel_link(), adjacent_posts_rel_link(), next_post_rel_link(), prev_post_rel_link(), get_boundary_post(), get_previous_post_link(), previous_post_link(), get_next_post_link(), next_post_link(), get_adjacent_post_link(), adjacent_post_link().

props ethitter.
finally fixes #17807.


git-svn-id: https://develop.svn.wordpress.org/trunk@25959 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 21:39:51 +00:00
Andrew Nacin 1694272bff When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@25956 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-27 21:08:25 +00:00