Commit Graph

40590 Commits

Author SHA1 Message Date
Sergey Biryukov 4b93e1eff3 Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock.
Props david.binda.
Fixes #48179.

git-svn-id: https://develop.svn.wordpress.org/trunk@46368 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 01:18:03 +00:00
Sergey Biryukov 38ea9f486f Docs: Remove obsolete comment in `wpmu_signup_blog_notification()` and `wpmu_signup_user_notification()`.
Props david.binda.
Fixes #48185.

git-svn-id: https://develop.svn.wordpress.org/trunk@46367 602fd350-edb4-49c9-b593-d223f7449a82
2019-10-01 00:45:20 +00:00
Jonathan Desrosiers 796f012ddc Post WordPress 5.3 Beta 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@46366 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 21:08:00 +00:00
Jonathan Desrosiers 6de28b0b81 WordPress 5.3 Beta 2.
git-svn-id: https://develop.svn.wordpress.org/trunk@46365 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 20:50:17 +00:00
Jonathan Desrosiers 08b757ec9e Block Editor: Update WordPress packages to include the latest bug fixes.
Updated packages:

@wordpress/annotations@1.7.1
@wordpress/api-fetch@3.6.1
@wordpress/babel-plugin-makepot@3.2.1
@wordpress/babel-preset-default@4.6.1
@wordpress/block-directory@1.0.1
@wordpress/block-editor@3.2.1
@wordpress/block-library@2.9.1
@wordpress/blocks@6.7.1
@wordpress/components@8.3.1
@wordpress/compose@3.7.1
@wordpress/core-data@2.7.1
@wordpress/data-controls@1.3.1
@wordpress/data@4.9.1
@wordpress/docgen@1.4.1
@wordpress/dom@2.5.1
@wordpress/e2e-test-utils@2.4.1
@wordpress/e2e-tests@1.7.1
@wordpress/edit-post@3.8.1
@wordpress/editor@9.7.1
@wordpress/element@2.8.1
@wordpress/format-library@1.9.1
@wordpress/i18n@3.6.1
@wordpress/jest-console@3.3.1
@wordpress/jest-preset-default@5.1.1
@wordpress/keycodes@2.6.1
@wordpress/library-export-default-webpack-plugin@1.4.1
@wordpress/list-reusable-blocks@1.8.1
@wordpress/media-utils@1.2.1
@wordpress/notices@1.8.1
@wordpress/nux@3.7.1
@wordpress/plugins@2.7.1
@wordpress/redux-routine@3.6.1
@wordpress/rich-text@3.7.1
@wordpress/scripts@5.0.1
@wordpress/server-side-render@1.3.1
@wordpress/shortcode@2.4.1
@wordpress/token-list@1.6.1
@wordpress/viewport@2.8.1
@wordpress/wordcount@2.6.1 

Props epiqueras, youknowriad, donmhico, jorgefilipecosta, soean, mcsf, noisysocks, andraganescu, gziolo, talldanwp, iseulde, nrqsnchz, mapk, karmatosed, joen, afercia, kjellr, desrosj.
Fixes #48186.

git-svn-id: https://develop.svn.wordpress.org/trunk@46364 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 20:05:51 +00:00
Andrea Fercia 6013fa1240 Accessibility: Media: Use the ARIA tabs pattern for the media modal menus.
The ARIA tabs pattern improves interaction for keyboard and assistive technologies users.
It gives the menu items proper roles, and `aria-selected` allows users of assistive technologies to know which tab is currently selected.

Props audrasjb, afercia, joedolson, karmatosed, melchoyce.
See #47149.


git-svn-id: https://develop.svn.wordpress.org/trunk@46363 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 19:36:42 +00:00
Andrea Fercia da73b95dd9 Media: Fix the media modal "Insert from URL" field height after [46356].
See #47477.


git-svn-id: https://develop.svn.wordpress.org/trunk@46362 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 19:19:06 +00:00
Jonathan Desrosiers dc07c1f52f Site Health: Revert [46323-46325] for further discussion of how the admin email verification should be filtered.
See #48153.

git-svn-id: https://develop.svn.wordpress.org/trunk@46361 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 18:51:30 +00:00
Andrea Fercia 74f9cf79a0 Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
Props audrasjb, garrett-eclipse.
Fixes #48131.


git-svn-id: https://develop.svn.wordpress.org/trunk@46360 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 18:04:59 +00:00
Anthony Burchell 4b152de517 Media: Prevents clipping of text when scaling image edit screen.
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.

Props sabernhardt, audrasjb, afercia.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46359 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:55:07 +00:00
Jonathan Desrosiers d65349005c Site Health: Improve the message displayed to sites not utilizing HTTPS.
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.

Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118.

git-svn-id: https://develop.svn.wordpress.org/trunk@46358 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:53:53 +00:00
Jonathan Desrosiers f905d80e77 Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46271], see 932b16248...dd7032f

Props anlino, ianbelanger, nielslange, acosmin, netweb, williampatton, adhitya03, phpdocs, acalfieri, itowhid06, littlebigthing, aristath, karmatosed, poena.
See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46357 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:40:14 +00:00
Andrea Fercia f93cd8ceea Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
Improves cross-browsers rendering and addresses most of the reported edge cases.

See #47477.


git-svn-id: https://develop.svn.wordpress.org/trunk@46356 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:23:06 +00:00
Anthony Burchell 48564fa823 Media: Revert [46354] preventing bad clipping of text in image details page.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46355 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 17:11:14 +00:00
Anthony Burchell 32b7a5e076 Media: Prevents clipping of text when scaling image edit screen.
Props sabernhardt, audrasjb, afercia.
See #47115.


git-svn-id: https://develop.svn.wordpress.org/trunk@46354 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 16:33:39 +00:00
Andrew Ozz ba2d023bad Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins.
Props pbiron.
See #47873.

git-svn-id: https://develop.svn.wordpress.org/trunk@46353 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 16:27:11 +00:00
Jonathan Desrosiers e9e1c4c30d Built/Test Tools: Ignore the `node_modules` folder in Twenty Twenty.
Ignore the `node_modules` folder in Twenty Twenty in SVN, and when running `grunt build` or `grunt jshint:themes`.

See #48110.

git-svn-id: https://develop.svn.wordpress.org/trunk@46352 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 15:57:21 +00:00
Jonathan Desrosiers 14d0316b3c Docs: Correct `WP_Styles_Registry` documentation.
This change updates the file’s docblock to correctly indicate `WordPress`/`Blocks` as the `@package`/`@subpackage`, updates the `_doing_it_wrong()` versions to `5.3.0` instead of the Gutenberg plugin versions, and removes some stray `gutenberg` text domains.

Props david.binda.
Fixes #48181.

git-svn-id: https://develop.svn.wordpress.org/trunk@46351 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 15:43:36 +00:00
Andrea Fercia 9288beb7b5 Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
Props Joen.
See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46350 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 10:52:36 +00:00
Sergey Biryukov 0e26adbaea Comments: Add `rel="nofollow ugc"` attribute to links in comments.
UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props audrasjb, joostdevalk, dkarfa, SergeyBiryukov.
Fixes #48022.

git-svn-id: https://develop.svn.wordpress.org/trunk@46349 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 01:29:10 +00:00
Jonathan Desrosiers 1504804b7c Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port.
Props garrett-eclipse, pierlo, afragen.
Fixes #48077.

git-svn-id: https://develop.svn.wordpress.org/trunk@46348 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-30 00:04:46 +00:00
Sergey Biryukov d6aa801691 Twenty Nineteen: Remove trailing comma after selector in `sass/site/primary/_posts-and-pages.scss`.
Props itowhid06.
Fixes #48171.

git-svn-id: https://develop.svn.wordpress.org/trunk@46347 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 22:39:20 +00:00
Sergey Biryukov 679b6a09e6 REST API: Combine `array` and `object` cases in `WP_REST_Meta_Fields::get_default_for_type()` to remove duplicated line.
Add missing description for `$type` parameter.

Props itowhid06, dkarfa.
Fixes #48169.

git-svn-id: https://develop.svn.wordpress.org/trunk@46346 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 22:33:35 +00:00
Andrea Fercia f00bceaa86 Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
Props desrosj, garrett-eclipse, afercia.
See #47498.


git-svn-id: https://develop.svn.wordpress.org/trunk@46345 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 21:55:51 +00:00
Andrea Fercia ef206a787f Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.


git-svn-id: https://develop.svn.wordpress.org/trunk@46344 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 21:52:38 +00:00
Sergey Biryukov 47643f7621 Coding Standards: Remove inline assignments and extra whitespace in `tests/multisite/network.php`.
Props garrett-eclipse, jrf.
See #48142.

git-svn-id: https://develop.svn.wordpress.org/trunk@46343 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 12:21:29 +00:00
Sergey Biryukov c3dfdf84af Docs: Improve comments in `tests/multisite/network.php` per the documentation standards.
Props garrett-eclipse, jrf.
See #48142.

git-svn-id: https://develop.svn.wordpress.org/trunk@46342 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 12:18:48 +00:00
Sergey Biryukov 65ec343e0b Docs: Improve documentation for `::display()` methods in various list tables.
Props itowhid06.
Fixes #47947.

git-svn-id: https://develop.svn.wordpress.org/trunk@46341 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-29 11:03:14 +00:00
Andrea Fercia d020b72508 Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
See #47477.
See #48128.


git-svn-id: https://develop.svn.wordpress.org/trunk@46340 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:44:09 +00:00
Andrea Fercia 8408e42de9 Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.


git-svn-id: https://develop.svn.wordpress.org/trunk@46339 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:34:43 +00:00
Andrew Ozz d47627d555 Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
Props masummdar, audrasjb, afercia.
Fixes #47318.

git-svn-id: https://develop.svn.wordpress.org/trunk@46338 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:19:49 +00:00
Andrea Fercia 91f5592886 Accessibility: Improve and modernize user interface controls. Make the select elements background white.
Props adhitya03.
See #47477.
Fixes #48128.


git-svn-id: https://develop.svn.wordpress.org/trunk@46337 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-28 16:14:50 +00:00
Sergey Biryukov ab8c873323 Docs: Add documentation for `WP_Comments_List_Table::display()`.
Props itowhid06, dinhtungdu.
Fixes #47929.

git-svn-id: https://develop.svn.wordpress.org/trunk@46336 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-27 23:02:29 +00:00
Jake Spurlock 4ffefc2574 Comments: Avoid PHP notice in `get_comment_reply_link()` for `null` comment.
If there is no global comment, or the input comment is null, return early to prevent warnings.

Fixes #41846
Props birgire, earnjam



git-svn-id: https://develop.svn.wordpress.org/trunk@46335 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-27 14:45:49 +00:00
Andrea Fercia 9e59d26200 Login and Registration: Revert divs and restore paragraphs after [46256].
Fixes #42888.


git-svn-id: https://develop.svn.wordpress.org/trunk@46334 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 22:19:14 +00:00
Jake Spurlock ea1d3b13cc Options: `register_uninstall_hook()` causes large amounts of unnecessary option updates.
Prevent extra database read/writes from the the hook.

Props jeichorn, MikeHansenMe, DrewAPicture, Rahe, tha_sun, mikeschroder.
Fixes #31792.



git-svn-id: https://develop.svn.wordpress.org/trunk@46333 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 22:07:05 +00:00
Jake Spurlock f2e9aa79f5 Administration: Ensure visual consistency with large titles in the sidebar.
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201


git-svn-id: https://develop.svn.wordpress.org/trunk@46332 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 21:50:10 +00:00
Andrea Fercia 4369b82732 Media: Restore the original Image Editor columns layout after [46326].
Fixes #47116.


git-svn-id: https://develop.svn.wordpress.org/trunk@46331 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 20:37:01 +00:00
Jake Spurlock 2ff8e68e15 Menus: Replace http with https in placeholders.
Encourage the use of https with the placeholder text in menus.

Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.


git-svn-id: https://develop.svn.wordpress.org/trunk@46330 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 20:30:59 +00:00
Sergey Biryukov d9e6a5dd68 Tests: Correct `::assertArrayHasKey()` capitalization in [46252].
Props dkarfa, david.binda.
Fixes #48155.

git-svn-id: https://develop.svn.wordpress.org/trunk@46329 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 20:30:35 +00:00
John Blackbourn 6b983b1d5c Themes: Add a test to ensure `get_template_part()` does not return a value.
This function must not be modified to return anything due to existing themes which output the return value, for example via `echo get_template_part( ... )`.

See #40969


git-svn-id: https://develop.svn.wordpress.org/trunk@46328 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 20:25:59 +00:00
Jake Spurlock c61471a495 Themes: Docblock cleanup for `get_theme_root_uri()`
In the function docblock of `get_theme_root_uri()`, the argument types of `$stylesheet_or_template` and `$theme_root` do not match. Default values of arguments are boolean but in function doc they are stated as strings.

Props subrataemfluence, williampatton, garrett-eclipse.
Fixes #44397.


git-svn-id: https://develop.svn.wordpress.org/trunk@46327 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 20:20:51 +00:00
Andrea Fercia d6770e5c61 Accessibility: Media: Make the Image Editor buttons text visible.
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.


git-svn-id: https://develop.svn.wordpress.org/trunk@46326 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 17:15:34 +00:00
Jonathan Desrosiers c177399a13 Docs: Correct typos introduced in [46324]
Props TimothyBlynJacobs.
See #48153.

git-svn-id: https://develop.svn.wordpress.org/trunk@46325 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 16:31:33 +00:00
Jonathan Desrosiers fbb6d75125 Site Health: Consolidate documentation for the `admin_email_check_interval` filter.
See #48153.

git-svn-id: https://develop.svn.wordpress.org/trunk@46324 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 15:44:10 +00:00
Jonathan Desrosiers d8337e1994 Site Health: Allow the capability required for the site admin email verification screen to be filtered.
Props desrosj, Clorith.
Fixes #48153.

git-svn-id: https://develop.svn.wordpress.org/trunk@46323 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 15:40:10 +00:00
Sergey Biryukov 1c9f3e0a15 Code Modernisation: Introduce the spread operator in `do_action()`.
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

git-svn-id: https://develop.svn.wordpress.org/trunk@46322 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 13:52:46 +00:00
Andrea Fercia 8c8999d933 Media: Fix JavaScript TypeError after [45376].
Props desrosj, afercia.
Fixes #48021.


git-svn-id: https://develop.svn.wordpress.org/trunk@46321 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 13:05:19 +00:00
Gary Pendergast da43c14a5d Build Tools: Pass the current uid/gid to Docker containers.
This prepares for an upcoming change to the Docker images, which improves file permission handling.

See #47767.



git-svn-id: https://develop.svn.wordpress.org/trunk@46320 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 04:57:38 +00:00
Sergey Biryukov d2ec28bfdd Login and Registration: Standardize on `6 * MONTH_IN_SECONDS` over `180 * DAY_IN_SECONDS` for `admin_email_check_interval` filter.
[45788] changed the first instance, but not the second.

Props tmatsuur.
Fixes #48144.

git-svn-id: https://develop.svn.wordpress.org/trunk@46319 602fd350-edb4-49c9-b593-d223f7449a82
2019-09-26 02:28:15 +00:00