Commit Graph

39621 Commits

Author SHA1 Message Date
Sergey Biryukov
9fa1b6f332 Feeds: Amend [45208] to avoid phpcs:ignore.
See #46922.

git-svn-id: https://develop.svn.wordpress.org/trunk@45215 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 15:45:07 +00:00
Sergey Biryukov
65837fb178 Permalinks: Avoid a PHP notice in wp_resolve_numeric_slug_conflicts() when visiting a day archive with the /%postname%/ permalink structure.
Props thakkarhardik, thomstark.
Fixes #46828.

git-svn-id: https://develop.svn.wordpress.org/trunk@45214 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 15:33:38 +00:00
Jonathan Desrosiers
1954fa7385 Bundled Themes: Use the theme version when enqueuing theme specific stylesheets.
For many bundled theme related stylesheets, a version is either not specified, or specified as a hardcoded date string when enqueued. This is problematic when a stylesheet is updated and the version number is not (which has happened several times recently). This change ensures that all bundled theme related stylesheets use the theme’s version as the stylesheet version. This ensures cache busting for theme stylesheets every time a theme is updated and guarantees that users receive any new or updated styles included in the update when visiting the site for the first time after an update.

Props parsmizban, ianbelanger, dswebsme.
Fixes #39997.

git-svn-id: https://develop.svn.wordpress.org/trunk@45213 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 14:55:48 +00:00
Jonathan Desrosiers
855232ec60 Twenty Thirteen: Correct Genericons stylesheet version number.
In [28693], the Genericons stylesheet was updated to `3.0.3`, but the version was incorrectly indicated as `3.03`.

See #39997.

git-svn-id: https://develop.svn.wordpress.org/trunk@45212 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 14:06:33 +00:00
Felix Arntz
aa377f582d Bootstrap/Load: Allow more than one recovery link to be valid at a time.
While currently a recovery link is only made available via the admin email address, this will be expanded in the future. In order to accomplish that, the mechanisms to store and validate recovery keys must support multiple keys to be valid at the same time.

This changeset adds that support, adding an additional token parameter which is part of a recovery link in addition to the key. A key itself is always associated with a token, so the two are only valid in combination. These associations are stored in a new `recovery_keys` option, which is regularly cleared in a new Cron hook, to prevent potential cluttering from unused recovery keys.

This changeset does not have any user-facing implications otherwise.

Props pbearne, timothyblynjacobs.
Fixes #46595. See #46130.


git-svn-id: https://develop.svn.wordpress.org/trunk@45211 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 05:08:16 +00:00
Felix Arntz
2f8a683fdc General: Display fatal error handler notice in admin backend even if headers have been sent.
This ensures that at least for the admin, which is more predictable than the frontend, the user-friendlier error notice from the fatal error handler still shows if a runtime fatal error happens within the page generation process.

Props axaak.
Fixes #46811.


git-svn-id: https://develop.svn.wordpress.org/trunk@45210 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 04:37:46 +00:00
Sergey Biryukov
5895974f10 Bundled Themes: Use consistent HTML comments after closing HTML tags.
Props iamdmitrymayorov.
Fixes #46871.

git-svn-id: https://develop.svn.wordpress.org/trunk@45209 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 01:29:20 +00:00
Sergey Biryukov
f83829ca4e Feeds: Remove whitespace from <updated> elements in Atom feeds.
Per Atom format's RFC, there must not be any whitespace in a Date construct or in any IRI.

Props josephwa.
Fixes #46922.

git-svn-id: https://develop.svn.wordpress.org/trunk@45208 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-16 00:45:05 +00:00
Sergey Biryukov
b66077a1aa I18N: Fix typo in a translator comment.
See #46920.

git-svn-id: https://develop.svn.wordpress.org/trunk@45207 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 23:55:52 +00:00
Sergey Biryukov
80817d3209 Bootstrap/Load: After [45016], make sure wp_die() does not cause _doing_it_wrong() notices if called before $wp_query global is set.
Props tmdesigned, TimothyBlynJacobs.
Fixes #46813.

git-svn-id: https://develop.svn.wordpress.org/trunk@45206 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 23:48:11 +00:00
Sergey Biryukov
d979017b64 Bootstrap/Load: Remove WP_Recovery_Mode_Cookie_Service constructor to avoid referencing cookie constants before they are defined.
Instantiating `WP_Recovery_Mode` should no longer have any required timing.

Props TimothyBlynJacobs, lkraav.
Fixes #46882.

git-svn-id: https://develop.svn.wordpress.org/trunk@45205 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:43:57 +00:00
John Blackbourn
8b1ecf68d9 I18N: Improvements to and additions of translator comments for various email subject strings.
Props ramiy

Fixes #46920


git-svn-id: https://develop.svn.wordpress.org/trunk@45204 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:38:59 +00:00
Sergey Biryukov
3d9f8c4d96 Docs: Adjust comments in wp_initial_constants() to conform to WPCS.
See #46543.

git-svn-id: https://develop.svn.wordpress.org/trunk@45203 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 22:09:31 +00:00
Mel Choyce
1442389a75 Administration: Update chevron color in Site Health.
Props afercia.
Fixes #46934. See #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45202 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:55:34 +00:00
Andrea Fercia
94af7683fe Administration: Add a chevron icon to the Site Health "Passed tests" button.
The chevron icon helps clarify what the button does.

Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730.


git-svn-id: https://develop.svn.wordpress.org/trunk@45201 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 18:00:57 +00:00
Andrea Fercia
3eb83ade1e Administration: Provide translatable strings for the Site Health comment status report.
Props ocean90.
Fixes #46909.


git-svn-id: https://develop.svn.wordpress.org/trunk@45200 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 15:07:36 +00:00
Andrea Fercia
9f8366994b Site Health: Add missing translator comments.
Amends [45178].
See #46683.


git-svn-id: https://develop.svn.wordpress.org/trunk@45199 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-15 14:38:26 +00:00
Andrea Fercia
92909607d6 Site health: Improve jQuery selectors so that they don't depend on a specific markup.
Amends [45178].
See #46683.


git-svn-id: https://develop.svn.wordpress.org/trunk@45198 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-14 14:29:03 +00:00
Andrea Fercia
5c9d27cd17 Coding standards: Site health: Avoid to use var in the middle of JavaScript function blocks.
Amends [45178].
See #46683.


git-svn-id: https://develop.svn.wordpress.org/trunk@45197 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-14 13:48:59 +00:00
Sergey Biryukov
d52d60c809 Site Health: Merge duplicate "utf8mb4 requires a newer client library" strings.
Props ramiy.
Fixes #46917.

git-svn-id: https://develop.svn.wordpress.org/trunk@45196 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:17:16 +00:00
Sergey Biryukov
7d54ac58cc Site Health: Merge duplicate "Error" strings.
Props ramiy.
Fixes #46915.

git-svn-id: https://develop.svn.wordpress.org/trunk@45195 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:11:46 +00:00
Sergey Biryukov
68ac2e4998 Users: Merge duplicate "Download failed" strings.
Props ramiy.
Fixes #46914.

git-svn-id: https://develop.svn.wordpress.org/trunk@45194 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:07:35 +00:00
Sergey Biryukov
35498b090e Site Health: Merge duplicate "Latest version" strings.
Props ramiy.
Fixes #46913.

git-svn-id: https://develop.svn.wordpress.org/trunk@45193 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 18:03:23 +00:00
Sergey Biryukov
b9b33979a0 Site Health: Merge duplicate "Learn more about updating PHP" strings.
Props ramiy.
Fixes #46912.

git-svn-id: https://develop.svn.wordpress.org/trunk@45192 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 17:58:12 +00:00
Dominik Schilling
c4d7d5e772 Docs: Add missing @since tag for [45031].
Props dimadin.
See #46667.

git-svn-id: https://develop.svn.wordpress.org/trunk@45191 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 14:16:57 +00:00
Sergey Biryukov
30caafae40 Bootstrap/Load: Remove duplicate leading slashes on inclusion of various files under ABSPATH.
Props dmsnell, birgire, szepe.viktor.
Fixes #46327.

git-svn-id: https://develop.svn.wordpress.org/trunk@45190 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:45:05 +00:00
Sergey Biryukov
5f93c86b84 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-controls.css.
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45189 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:36:01 +00:00
Sergey Biryukov
4de00af6f8 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/themes.css.
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45188 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:31:08 +00:00
Sergey Biryukov
eb2f56da08 CSS Coding Standards: Use unitless values for line-height for count bubbles in wp-admin/css/admin-menu.css.
Missed in [45186].

Props ianbelanger.
See #46489, #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45187 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 04:19:52 +00:00
SergeyBiryukov
10112902ce CSS Coding Standards: Use unitless values for line-height in wp-admin/css/admin-menu.css.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.

git-svn-id: https://develop.svn.wordpress.org/trunk@45186 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-13 00:16:01 +00:00
Sergey Biryukov
78e868e4c7 Plugins: Introduce is_wp_version_compatible() and is_php_version_compatible() for checking compatibility with the current WordPress or PHP version.
Props afragen.
Fixes #46599.

git-svn-id: https://develop.svn.wordpress.org/trunk@45185 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 23:55:19 +00:00
Sergey Biryukov
e844945b31 Plugins: In list_plugin_updates(), only display the annotation and the surrounding tags if it's not empty.
Props afragen.
Fixes #46680.

git-svn-id: https://develop.svn.wordpress.org/trunk@45184 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 21:51:58 +00:00
Jonathan Desrosiers
a8e7d339ae Post WordPress 5.2 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@45183 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 21:26:49 +00:00
Jonathan Desrosiers
bb3c56a5bc WordPress 5.2 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@45182 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 21:05:09 +00:00
Sergey Biryukov
b7c8eb8bcb Bootstrap/Load: Finalize recovery mode email language.
Props TimothyBlynJacobs, miss_jwo, desrosj.
Fixes #46898.

git-svn-id: https://develop.svn.wordpress.org/trunk@45181 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:48:05 +00:00
Andrew Duthie
f627138361 Privacy: Remove unnecessary translation from help notice action label.
As static markup, the Privacy Policy editor help notice link no longer needs to be translateable with the revisions included in [45174].

Props garrett-eclipse.
Fixes #46098. See [45174].


git-svn-id: https://develop.svn.wordpress.org/trunk@45180 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:43:40 +00:00
Sergey Biryukov
6627bc4967 Site Health: Use _n() for %s Items with no issues detected string, missed in [45178].
See #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45179 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:39:05 +00:00
Sergey Biryukov
936db1b0e1 Site Health: i18n audit, take 2.
* Use `wp.i18n` to translate JavaScript strings.
* Use `_n()` for proper plural forms support.

Props TimothyBlynJacobs, ocean90, afercia.
Fixes #46683.

git-svn-id: https://develop.svn.wordpress.org/trunk@45178 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:33:48 +00:00
Joe McGill
5021d218ef Media: Fix deletion of files when using stream wrappers.
This fixes a bug introduced in [43392] which breaks file deletion on systems using stream wrappers, due to limitations of `realpath()`.

Props antonypuckey, pfiled.
Fixes #44563.


git-svn-id: https://develop.svn.wordpress.org/trunk@45177 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 20:00:42 +00:00
Andrew Ozz
05981179e4 Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page.
Props xkon, afercia, Clorith, azaozz.
See #46707.

git-svn-id: https://develop.svn.wordpress.org/trunk@45176 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 19:23:13 +00:00
Jonathan Desrosiers
212bbbae98 Administration: Move “Recovery Mode” to the beginning of the document title.
This improves accessibility, ensuring users utilizing screen readers are informed that the site is in recovery mode.

Props: afercia, TimothyBlynJacobs.
See #46608.

git-svn-id: https://develop.svn.wordpress.org/trunk@45175 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 19:04:13 +00:00
Andrew Duthie
b0d7c97806 Privacy: Display help notice on block editor screen.
Use the Notices data module when viewing the block editor screen for the assigned Privacy Policy page to display a help notice.

Props garrett-eclipse, joen, xkon.
Fixes #46098.


git-svn-id: https://develop.svn.wordpress.org/trunk@45174 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:18:59 +00:00
Jonathan Desrosiers
f01fd34f21 Text Changes: Use simpler language for login detail email subjects.
Props: peterwilsoncc, desrosj.
Fixes #37940.

git-svn-id: https://develop.svn.wordpress.org/trunk@45173 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:15:15 +00:00
Andrew Ozz
ac97906269 TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually.
Props afercia, azaozz.
Fixes #46640.

git-svn-id: https://develop.svn.wordpress.org/trunk@45172 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 18:07:47 +00:00
Jonathan Desrosiers
908b8238b9 Site Health: Correctly refer to an .htaccess file as hidden.
The preceding period (`.`) should always be included when referring to an `.htaccess` file.

Props: ianbelanger, garrett-eclipse, subrataemfluence, burhandodhy.
Fixes #46841.

git-svn-id: https://develop.svn.wordpress.org/trunk@45171 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:49:04 +00:00
Jonathan Desrosiers
94b6167a04 Site Health: Add missing actions to tests.
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.

git-svn-id: https://develop.svn.wordpress.org/trunk@45170 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:39:37 +00:00
Jonathan Desrosiers
3bba7f2f31 Site Health: Improve the test badge implementation.
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.

This change makes several improvements to the label badges:

- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.

Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623.

git-svn-id: https://develop.svn.wordpress.org/trunk@45169 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 17:03:24 +00:00
Jonathan Desrosiers
ee18178416 Site Health: Ensure Site Health pages are correctly displayed for RTL locales.
Props: ebrahimzadeh, afercia, mohadeseghasemi.
Fixes #46868.

git-svn-id: https://develop.svn.wordpress.org/trunk@45168 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 16:38:57 +00:00
Jonathan Desrosiers
f36d2fbbdc Administration: Remove unnecessary numbered placeholders.
Props: tobifjellner, thrijith.
Fixes #46824.

git-svn-id: https://develop.svn.wordpress.org/trunk@45167 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 16:31:37 +00:00
Jonathan Desrosiers
4740573142 Site Health: Include both site and user locales in debug information.
Previously, only the site’s locale was displayed in the Site Health debug information. Moving forward, both the site’s default locale and the user’s locale will be specified.

This change also removes the `@param` tag for `WP_Debug_Data::debug_data()`. This parameter was previously removed in [45156].

Props: mukesh27, ianbelanger, Clorith, desrosj.
Fixes #46803.

git-svn-id: https://develop.svn.wordpress.org/trunk@45166 602fd350-edb4-49c9-b593-d223f7449a82
2019-04-12 15:48:13 +00:00