Commit Graph

27172 Commits

Author SHA1 Message Date
Andrew Ozz
0ef495da6a wpLink:
- Fix adding a link on pressing Enter.
- Don't auto-focus the URL field after selecting a local link.
- Don't auto-focus the URL field when opening on touch devices. Toggle focus/blur on it to close the onscreen keyboard so the modal is positioned properly.
See #28897.

git-svn-id: https://develop.svn.wordpress.org/trunk@29333 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-31 23:27:14 +00:00
Andrew Ozz
cba848581b Use node.nodeName instead of tagName for better consistency/compatibility, see #28704.
git-svn-id: https://develop.svn.wordpress.org/trunk@29332 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:48:21 +00:00
Helen Hou-Sandi
8790d81cb4 Prevent key event handlers from firing when in input areas in the media modal, as people understandably want to type inside said inputs. props kovshenin. fixes #28704.
git-svn-id: https://develop.svn.wordpress.org/trunk@29331 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:38:18 +00:00
Sergey Biryukov
6be5fc19b3 Make sure phpinfo() is not disabled before calling it in apache_mod_loaded().
props rohan013, harmr.
fixes #26772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29330 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 17:27:54 +00:00
Sergey Biryukov
09877657d4 Customizer: Don't hide controls the preview frame has no information about.
props kovshenin.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29329 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 16:23:47 +00:00
Andrew Ozz
23d876d86a Tests Autop: remove <option> from the list of inline tags. It is valid only in specific context (<select>, <optgroup> or <datalist>) and should not be wrapped in <p>. Props kovshenin, fixes #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29328 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 19:02:36 +00:00
Andrew Nacin
94c53962b1 Don't pass around the password reset key.
props mdawaffe.
fixes #29060.


git-svn-id: https://develop.svn.wordpress.org/trunk@29327 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 18:18:58 +00:00
Sergey Biryukov
502e9b675a In add_submenu_page(), avoid inadvertently copying classes of a menu item to the first submenu item.
fixes #28936.

git-svn-id: https://develop.svn.wordpress.org/trunk@29326 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:07:59 +00:00
Helen Hou-Sandi
3c71a49abc Labels for the installation form should get the pointer cursor. props Ankit K Gupta. fixes #28818.
git-svn-id: https://develop.svn.wordpress.org/trunk@29325 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:04:44 +00:00
Sergey Biryukov
40d1133c6f Fix duplicate Customize button in theme details modal.
props afercia.
fixes #28987.

git-svn-id: https://develop.svn.wordpress.org/trunk@29324 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 16:01:13 +00:00
Sergey Biryukov
e4c8f3a843 QuickPress: Disable autocomplete for content, enable "Save Draft" button on load.
props morganestes, michalzuber.
fixes #27760.

git-svn-id: https://develop.svn.wordpress.org/trunk@29323 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 15:33:07 +00:00
Sergey Biryukov
fd1652d6bb Media Grid: Close the modal if the attachment is deleted.
props ericlewis.
fixes #28819.

git-svn-id: https://develop.svn.wordpress.org/trunk@29322 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 14:57:21 +00:00
Andrew Ozz
93aff47ac5 wpLink: add keyboard navigation, improve accessibility. Props afercia, fixes #28897.
git-svn-id: https://develop.svn.wordpress.org/trunk@29321 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 03:15:34 +00:00
Sergey Biryukov
e2d9939e57 Avoid PHP notices in Media Library if an attachment parent post type no longer exists.
Synchronize the 'edit_post' capability check between the list table and the media grid.

fixes #27446.

git-svn-id: https://develop.svn.wordpress.org/trunk@29320 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 01:40:24 +00:00
Sergey Biryukov
a475124608 Use 3-digit x.x.x style for two 4.0.0 @since versions.
see #28885.

git-svn-id: https://develop.svn.wordpress.org/trunk@29319 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:58:22 +00:00
Sergey Biryukov
7ac0669493 Avoid PHP notices in _count_posts_cache_key(), _update_blog_date_on_post_publish(), and _update_blog_date_on_post_delete() if post type is not registered.
props jesin.
fixes #28135.

git-svn-id: https://develop.svn.wordpress.org/trunk@29318 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 00:50:53 +00:00
Andrew Ozz
fbfd88cecb TinyMCE:
- Use `data-wp-*` for processing and styling of the `more` and `nextpage` placeholders, keep the class names for back-compat. Makes them "immune" to "Clear formatting".
- Translate the titles of the placeholders.
Fixes #28772.

git-svn-id: https://develop.svn.wordpress.org/trunk@29317 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 23:44:28 +00:00
Andrew Ozz
01051b4e2f Formatting: make the removal of white space around <option> greedy, see #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29316 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:54:50 +00:00
Andrew Ozz
5fa36977a0 Formatting: no <p> or <br> around <option> tags in both flavours of wpautop, make "selects" easier to read in the Text editor. Fixes #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29315 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:43:06 +00:00
Dominik Schilling (ocean90)
70a6b6390c IE8 doesn't support ::before and ::after pseudo-elements. Replace them with :before and :after.
props andrezrv, DrewAPicture, ocean90.
fixes #28082.

git-svn-id: https://develop.svn.wordpress.org/trunk@29314 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 15:51:02 +00:00
Dominik Schilling (ocean90)
41360a0086 Remove parent::footer() in Language_Pack_Upgrader_Skin::bulk_footer() as it prints a closing div which is not needed.
props michalzuber.
fixes #28947.

git-svn-id: https://develop.svn.wordpress.org/trunk@29313 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 09:05:33 +00:00
Dominik Schilling (ocean90)
9f105673fb Media Grid: Improve lazy loading.
props kovshenin.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@29312 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:57:25 +00:00
Dominik Schilling (ocean90)
ea34a0bdf7 Replace is_https_url() with 'https' === parse_url( $url, PHP_URL_SCHEME ).
see #28427, #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29311 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:45:34 +00:00
Dominik Schilling (ocean90)
0f93a72879 Remove unit test for is_https_url(), see [29309].
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29310 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:18:19 +00:00
Dominik Schilling (ocean90)
080f52ceb9 Revert [28894] as it's currently unused in core.
see #28487.

git-svn-id: https://develop.svn.wordpress.org/trunk@29309 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 17:15:22 +00:00
Dominik Schilling (ocean90)
0e42ce2dc0 Add missing screen-reader-text CSS class in [29294].
see #28867.

git-svn-id: https://develop.svn.wordpress.org/trunk@29308 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 13:42:49 +00:00
Dominik Schilling (ocean90)
db77bc8bff Media Grid: Align "Apply" button on small screens.
fixes #28903.

git-svn-id: https://develop.svn.wordpress.org/trunk@29307 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 12:14:58 +00:00
Dominik Schilling (ocean90)
3003895858 Fix jshint errors introduced in [29284] and [29299].
git-svn-id: https://develop.svn.wordpress.org/trunk@29306 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:48:26 +00:00
Dominik Schilling (ocean90)
812ecd9b8d Media Grid: Ignore user setting for content.
fixes #29034.

git-svn-id: https://develop.svn.wordpress.org/trunk@29305 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-27 11:43:08 +00:00
Dominik Schilling (ocean90)
cb5838a937 Media Grid: Improve dropzone margins when viewport height is <400px.
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29304 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 15:29:39 +00:00
Dominik Schilling (ocean90)
0480144f86 Media Grid: Add context for "or" in [29296].
see #28851.

git-svn-id: https://develop.svn.wordpress.org/trunk@29303 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 14:36:56 +00:00
Andrew Ozz
42ac48d52a TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29302 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 00:07:55 +00:00
Helen Hou-Sandi
357d96c367 Don't interfere with browser-based autocomplete in the link modal. props SergeyBiryukov. fixes #28685.
git-svn-id: https://develop.svn.wordpress.org/trunk@29301 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:56:57 +00:00
Helen Hou-Sandi
59cec2e2ff When adding a post of a post type whose menu item is in a submenu, highlight the correct menu item. props mordauk, markjaquith. fixes #24137.
git-svn-id: https://develop.svn.wordpress.org/trunk@29300 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 15:25:20 +00:00
Scott Taylor
0b3802eb12 Media Grid: when closing the modal, automatically focus the proper attachment by reading the model's ID, which is unique.
Props adamsilverstein (for the red), wonderboymusic (for the green).
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29299 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:59:29 +00:00
Andrew Ozz
67032cf170 TinyMCE wpView:
- Fix opening the media modal on clicking Edit in Firefox.
- Fix range errors when restoring the selection bookmark in IE11 after editing a view.
See #28595.

git-svn-id: https://develop.svn.wordpress.org/trunk@29298 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:55:33 +00:00
Scott Taylor
e11d72f889 Media Grid: make check box-shadow more subtle.
See #28842.


git-svn-id: https://develop.svn.wordpress.org/trunk@29297 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:46:14 +00:00
Scott Taylor
3fef7648f6 Media Grid: improve uploader styles.
Props michalzuber, ericlewis.
See #28851.


git-svn-id: https://develop.svn.wordpress.org/trunk@29296 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:30:28 +00:00
Scott Taylor
276496aa29 Media Grid: change text to "Close Media Panel" to provide context for screen readers.
Props joedolson.
Fixes #28976.


git-svn-id: https://develop.svn.wordpress.org/trunk@29295 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:25:16 +00:00
Scott Taylor
ced3f94927 Adds <label>s to current page selector and bulk actions <select> field so that screen readers have an explicit label.
Props joedolson.
Fixes #28867.


git-svn-id: https://develop.svn.wordpress.org/trunk@29294 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-25 00:19:21 +00:00
Scott Taylor
f0318988c4 Correct a few @param docs for $walker.
Props dnaber-de.
Fixes #29011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29293 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:24:07 +00:00
Scott Taylor
6e74d46d94 Whitelist input types that are styled in the scope of .form-field.
Props mauteri.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29292 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:21:00 +00:00
Scott Taylor
66c8ad501f Add exif orientation to data extracted in wp_read_image_metadata().
Props shanebp.
Fixes 28916.


git-svn-id: https://develop.svn.wordpress.org/trunk@29291 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:13:19 +00:00
Scott Taylor
1cbe1cec12 In sanitize_file_name(), replace %20 and + with dashes. Remove unnecessary code from _wp_handle_upload().
Adds unit tests.

Props ericmann.
Fixes #16330.


git-svn-id: https://develop.svn.wordpress.org/trunk@29290 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 22:08:09 +00:00
Scott Taylor
cdf2c8132c Media Grid: UI improvements to Attachment modal.
Props ryelle.
See #28844.


git-svn-id: https://develop.svn.wordpress.org/trunk@29289 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:54:22 +00:00
Scott Taylor
dd76aeea5b Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.
Fixes #28945.


git-svn-id: https://develop.svn.wordpress.org/trunk@29288 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:17:32 +00:00
Scott Taylor
1b01b92dc6 Media Grid CSS: Media modal close icon should be consistent with other modals.
Props celloexpressions.
Fixes #29012.


git-svn-id: https://develop.svn.wordpress.org/trunk@29287 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:06:42 +00:00
Scott Taylor
052e5c5062 Remove white box-shadow divider from uploading status area for consistency.
Props paulwilde.
Fixes #28751.


git-svn-id: https://develop.svn.wordpress.org/trunk@29286 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 21:03:25 +00:00
Scott Taylor
b1053cca13 Don't render Attachment Display Settings when display is set to false. Currently, the value for display in the media.view.AttachmentsBrowser instance in the media.view.MediaFrame.Select frame is set to the value for displaySettings.
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.


git-svn-id: https://develop.svn.wordpress.org/trunk@29285 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 20:57:05 +00:00
Scott Taylor
c2491f31ae When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.
`wp.media.collection` has a new method to do this: `setDefaults()`.	Also flips the use of `_.extend` to allow this method to be overriden on instance creation.

See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29284 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 19:59:18 +00:00