Scott Taylor
7793a90fd1
Eliminate use of extract()
in wp_list_categories()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28434 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 17:27:18 +00:00
Scott Taylor
812493f259
Eliminate use of extract()
in default-widgets.php
.
...
Props rzen, wonderboymusic.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28433 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 16:32:18 +00:00
Scott Taylor
29efc53b6a
Eliminate use of extract()
in wp_dropdown_categories()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28432 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:47:43 +00:00
Scott Taylor
4aa28e9cdc
Eliminate use of extract()
in get_comment_reply_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28431 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:34:37 +00:00
Scott Taylor
7d8a053aeb
Eliminate use of extract()
in WP_Ajax_Response::add()
. Just set most of the properties to variables to avoid interpolation churn.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28430 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 15:24:21 +00:00
Scott Taylor
e06aa222ea
Eliminate the use of extract()
in get_post_reply_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28429 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:48:16 +00:00
Scott Taylor
2a5a75e6d3
Eliminate the use of extract()
in wp_list_comments()
. All unit tests pass.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28428 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:42:19 +00:00
Scott Taylor
95394c6e7e
Eliminate the use of extract()
in wp_update_comment()
. All unit tests pass.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28427 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:36:17 +00:00
Scott Taylor
bb4ea7ae3f
Eliminate the use of extract()
in wp_check_filetype_and_ext()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28426 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:21:51 +00:00
Scott Taylor
6dd449551e
Eliminate the use of extract()
in wp_mail()
. Check the filtered array for each value before re-setting variables.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28425 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:16:34 +00:00
Scott Taylor
3c418d4b57
Eliminate the use of extract()
in wp_validate_auth_cookie()
.
...
Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28424 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 06:10:21 +00:00
Scott Taylor
034de7f1de
Eliminate the use of extract()
in get_objects_in_term()
. Only one property (order
) was extracted.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28423 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:42:55 +00:00
Scott Taylor
e00ce3ae95
Eliminate the use of extract()
in WP_Tax_Query::get_sql()
. All unit tests still pass.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28422 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:40:40 +00:00
Scott Taylor
17edee17af
Eliminate the use of extract()
in the_taxonomies()
. Adds unit test.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28421 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:24:54 +00:00
Scott Taylor
a3c9e611a8
Eliminate the use of extract()
in wp_dropdown_users()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28420 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:17:12 +00:00
Scott Taylor
f116de6203
Set @param
back to $output
, not $html
, in the inline filter docs. This was a copy/paste mistake.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28419 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:07:18 +00:00
wonderboymusic
30dcd2c3e9
Eliminate the use of extract()
in WP_Upgrader
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28418 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 05:01:02 +00:00
Scott Taylor
650e0580e4
Eliminate one of the uses of extract()
in wp_handle_upload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28417 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 04:30:32 +00:00
Scott Taylor
219ad73200
Eliminate one of the uses of extract()
in wp_handle_sideload()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28416 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 04:28:24 +00:00
Scott Taylor
3e54a1fab5
Eliminate use of extract()
in get_the_taxonomies()
. Adds unit test.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28415 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:50:46 +00:00
Scott Taylor
e135cc2076
Eliminate use of extract()
in gallery_shortcode()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28414 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:40:46 +00:00
Scott Taylor
e9f929443f
Update the inline docs for add_shortcode()
to eliminate suggestion to use extract()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28413 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:27:17 +00:00
Scott Taylor
9d873771b7
Eliminate use of extract()
in wp_xmlrpc_server::blogger_editPost()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28412 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:24:40 +00:00
Scott Taylor
c4b23f9fc3
Eliminate use of extract()
in Walker_Category_Checklist::start_el()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28411 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:13:44 +00:00
Scott Taylor
85d6f8e54f
Eliminate use of extract()
in wp_terms_checklist()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28410 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 03:08:46 +00:00
Scott Taylor
98ca12ef2e
Eliminate use of extract()
in wp_star_rating()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28409 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:56:56 +00:00
Scott Taylor
5e046b92fd
(REALLY) Eliminate use of extract()
in wp_insert_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28408 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:54:27 +00:00
Scott Taylor
27ff2a1cd0
Eliminate use of extract()
in get_media_item()
.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:45:01 +00:00
Scott Taylor
e0ddd2ebf0
Eliminate use of extract()
in wp_insert_link()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28406 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:27:55 +00:00
Scott Taylor
da440f54fd
Eliminate use of extract()
in wp_list_bookmarks()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28405 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:17:52 +00:00
Scott Taylor
30564338b0
Eliminate use of extract()
in _walk_bookmarks()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28404 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:04:50 +00:00
Scott Taylor
0dd9d3aeff
Eliminate use of extract()
in get_bookmarks()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:57:24 +00:00
Scott Taylor
61faf32275
Eliminate use of extract()
in Walker_Page::start_el()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28402 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:40:48 +00:00
Scott Taylor
c96d4a94b9
Eliminate use of extract()
in wp_list_pages()
which, surprisingly, didn't even use any of the extracted variables.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28401 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:21:20 +00:00
Scott Taylor
c47d71feb2
Add unit tests for wp_list_pages()
.
...
Props MikeHansenMe.
See #27326 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28400 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:17:37 +00:00
Scott Taylor
e4a800238f
Eliminate use of extract()
in wp_dropdown_pages()
.
...
Adds unit tests to: `tests/post/template.php`.
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28399 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:11:21 +00:00
Scott Taylor
21e0370e5c
Eliminate use of extract()
in wp_link_pages()
.
...
Adds unit tests to a new file: `tests/post/template.php`.
There were previously no unit tests for `wp_link_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28398 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 00:43:40 +00:00
Scott Taylor
9e07b1037e
Eliminate use of extract()
in paginate_links()
. Adds unit tests. Moves tests/general/template.php
(which only had one method) to tests/general/paginateLinks.php
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 22:28:08 +00:00
Scott Taylor
46f15a84ab
Eliminate use of extract()
in display_setup_form()
. Only needs to read password
and password_message
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28396 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 16:42:42 +00:00
Lance Willett
44e4e3e4d0
Twenty Thirteen: add accessibility-ready
tag. Fixes #28225 , props BODA1982.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28395 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 23:10:00 +00:00
Drew Jaynes (DrewAPicture)
cfc1b74ddb
Properly split and document the admin_post*
actions into the following four hooks:
...
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action
See [28349], [28350], [28351].
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28394 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 07:23:35 +00:00
Drew Jaynes (DrewAPicture)
1954f9b7d4
Clarify inline documentation for back-compat load-*
action hooks.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28393 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:27:11 +00:00
Scott Taylor
540826e4e3
Eliminate use of extract()
in wp_list_authors()
.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28392 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:01:33 +00:00
Scott Taylor
bc17731c23
Eliminate use of extract()
in post_tags_meta_box()
and post_categories_meta_box()
.
...
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28391 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:47:03 +00:00
Scott Taylor
b72bd1c40f
Eliminate use of extract()
in WP_Terms_List_Table::display_rows_or_placeholder()
:
...
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28390 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:36:22 +00:00
Scott Taylor
7c0e12f5c6
Eliminate use of extract()
in WP_List_Table::pagination()
:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28389 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:26:34 +00:00
Scott Taylor
31e187faa3
Eliminate use of extract()
in WP_Plugin_Install_List_Table::get_table_classes()
. It only needs to read plural
, no need to extract.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28388 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:16:39 +00:00
Scott Taylor
fac2faee93
Eliminate use of extract()
in WP_List_Table::ajax_response()
:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28387 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:13:09 +00:00
Scott Taylor
a2122e6f7b
Eliminate use of extract()
in WP_List_Table::display()
. The method only needs to read singular
from $this->_args
. Extraction is unnecessary.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28386 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:07:11 +00:00
Scott Taylor
878a974477
Eliminate use of extract()
in WP_Post_Comments_List_Table::display()
. The method only needs to read singular
from $this->_args
. Extraction is unnecessary.
...
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28385 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 05:03:26 +00:00