Commit Graph

509 Commits

Author SHA1 Message Date
Andrew Nacin 1cc12103f5 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: https://develop.svn.wordpress.org/trunk@23083 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 00:41:06 +00:00
Ryan Boren 511cb0ec93 Directly access post_status instead of using get_post_status() when checking for auto-draft status. Attachments with their inherit post_status were getting the auto-draft status of their parent when using get_post_status(). This caused some things to display improperly on the edit attachment page.
Props nacin, miqrogroove
fixes #22672


git-svn-id: https://develop.svn.wordpress.org/trunk@22963 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-01 23:12:30 +00:00
Andrew Nacin 8eb663ed3c Media help. props DrewAPicture, merty, Ipstenu. fixes #22451.
git-svn-id: https://develop.svn.wordpress.org/trunk@22925 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-29 17:51:54 +00:00
Andrew Nacin a2535a19b9 No AYS or autosave for attachments on post.php. Reverts part of [22725]. fixes #22491.
git-svn-id: https://develop.svn.wordpress.org/trunk@22858 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-27 02:02:32 +00:00
Ryan Boren 293f8923c4 Consolidate some strings. Props SergeyBiryukov. see #21087
git-svn-id: https://develop.svn.wordpress.org/trunk@22854 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-26 23:12:11 +00:00
Andrew Nacin be4bf5a2aa Updates to post.php help text for posts and pages, including a new section on inserting media. props DrewAPicture, Ipstenu. see #22451.
git-svn-id: https://develop.svn.wordpress.org/trunk@22813 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-22 09:00:39 +00:00
Andrew Ozz 251ab5e8b1 Fix typo in [22795]
git-svn-id: https://develop.svn.wordpress.org/trunk@22796 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 21:16:19 +00:00
Andrew Ozz f1cdbe4224 Improve AYS comparison on the Edit Attachment screen, props nacin, fixes #22491
git-svn-id: https://develop.svn.wordpress.org/trunk@22795 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 21:11:21 +00:00
Andrew Nacin 79435f42fa Use a variable that is set a few lines up. $post_id is set only in post.php, not post-new.php. fixes #21092.
git-svn-id: https://develop.svn.wordpress.org/trunk@22742 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-21 09:35:23 +00:00
Andrew Nacin db7dc96921 Media: For pages, use 'Insert into page' rather than 'Insert into post'.
Custom post types can use the media_view_strings filter. No new post type "labels" for now.

see #22712. see #21092 (and #19696).



git-svn-id: https://develop.svn.wordpress.org/trunk@22735 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 23:22:03 +00:00
Andrew Ozz 5e7443ca85 Don't load autosave.js on the attachment editing screen, add simple AYS on unload if there are changes, props helenyhou, fixes #22491
git-svn-id: https://develop.svn.wordpress.org/trunk@22725 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 19:46:38 +00:00
Andrew Nacin a5a14e4e7e No-JS fixes.
* Hide QuickPress.
 * Hide the gap between the title and content editor.
 * Hide 'select all' checkboxes in list tables.
 * Hide a non-functioning link in the custom fields metabox.
 * Hide non-functioning buttons in the featured image box (same as in 3.4).
 * RTL and miscellany.

props TobiasBg, lessbloat, ocean90. fixes #22456.



git-svn-id: https://develop.svn.wordpress.org/trunk@22719 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 18:20:14 +00:00
Daryl Koopersmith 7baca50473 Media: Ensure media and its dependencies are included when a post type supports the editor or featured images. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22490 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-09 05:10:07 +00:00
Daryl Koopersmith 2189575beb Media: Add wp_enqueue_media to easily include all media dependencies.
Also, media templates now print on `wp_footer`.

props sushkov. fixes #22060, see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22489 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-09 04:57:25 +00:00
Andrew Nacin e775c9ee99 edit_form_after_editor action. props helenyhou. fixes #19658.
git-svn-id: https://develop.svn.wordpress.org/trunk@22446 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:49:47 +00:00
Ryan Boren 41697f3910 Attachment editor improvements. Put the non-editable metadata into the submit/publish box.
Props helenyhou
see #21391


git-svn-id: https://develop.svn.wordpress.org/trunk@22364 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-05 14:04:22 +00:00
Ryan Boren 308c702183 Use the create_posts capability in more places.
In get_post_type_capabilities(), make sure create_posts reflects customizations to the edit_posts capability when create_posts is not specifically set.


git-svn-id: https://develop.svn.wordpress.org/trunk@22291 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-24 22:15:43 +00:00
Daryl Koopersmith 1758d1aae3 Add QuickPress support for new media workflow.
* Adds the code required to include the new media scripts, styles, and settings to `media_button()`.
* Improves script dependencies, namely making `media-upload` require `media-views`.
* Some CSS tweaks for the making the new button work well with QuickPress.

see #21390, fixes #22021.


git-svn-id: https://develop.svn.wordpress.org/trunk@22072 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-27 20:04:34 +00:00
Andrew Ozz 5ad7fe8cd6 Main editor: maintain the height when switching Visual to Text and back, save the height when resizing as user state, output the height in the textarea tag when loading, (thanks @nacin for the help), fixes #21718
git-svn-id: https://develop.svn.wordpress.org/trunk@22007 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-26 03:30:21 +00:00
Ryan Boren 48cd2a2299 Add help to the attachment editor. Props DrewAPicture. see #21391
git-svn-id: https://develop.svn.wordpress.org/trunk@21968 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-24 13:13:09 +00:00
Daryl Koopersmith 0a0732f9ab Makes custom TinyMCE views easier to implement.
For details and examples, see the ticket.

props azaozz, fixes #21812.


git-svn-id: https://develop.svn.wordpress.org/trunk@21961 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-24 00:13:18 +00:00
Andrew Nacin 991be145a9 Use the regular post type UI for editing single media items (attachments).
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
 * Taxonomies attached to the media library now appear in the admin menu (if show_ui).
 * Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:
 * New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
 * Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
 * wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
 * New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.



git-svn-id: https://develop.svn.wordpress.org/trunk@21948 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 22:52:54 +00:00
Andrew Nacin 1c58ef9f33 Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: https://develop.svn.wordpress.org/trunk@21944 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-21 19:34:23 +00:00
Daryl Koopersmith 7d6e53317c New button styles.
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: https://develop.svn.wordpress.org/trunk@21789 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-08 04:58:34 +00:00
Daryl Koopersmith 5a4a17687a Add new media workflow scripts, styles, and templates.
Please note that this commit does not integrate media into the existing UI. If you would like to see the new UI, navigate to the post editor and run the following in your browser's Javascript console:

	new wp.media.controller.Workflow().render().modal.open();


The Javascript is broken up into two files, with the slugs media-models and media-views.

* media-models: The models are UI agnostic, and can be used independent of the views. If you'd like to create custom UIs, this is the script for you.

* media-views: This is the Media Experience. The views (and controllers) depend on the models (which are listed as a dependency and will automatically be included thanks to wp_enqueue_script). The views also require the media templates, media-view styles, and the plupload bridge settings. Perhaps we should create a function to include the whole shebang, but in the meantime...

To include media-views in the admin, run the following PHP in or after 'admin_enqueue_scripts':

	wp_enqueue_script( 'media-views' );
	wp_enqueue_style( 'media-views' );
	wp_plupload_default_settings();
	add_action( 'admin_footer', 'wp_print_media_templates' );

see #21390.



git-svn-id: https://develop.svn.wordpress.org/trunk@21683 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-31 04:54:23 +00:00
Andrew Ozz 877e8f6a2a Don't hide the label for the Title on the Edit Post screen, use 'screen-reader-text' instead, props SergeyBiryukov, fixes #21458
git-svn-id: https://develop.svn.wordpress.org/trunk@21584 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-22 17:40:17 +00:00
Ryan Boren 4974f5f233 Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194
git-svn-id: https://develop.svn.wordpress.org/trunk@21504 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-14 18:39:15 +00:00
Andrew Ozz 6e6b727315 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: https://develop.svn.wordpress.org/trunk@21311 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-24 00:15:15 +00:00
Andrew Ozz 446b40235f TinyMCE: fix tabbig in and out of the editor, fixes #20834
git-svn-id: https://develop.svn.wordpress.org/trunk@21300 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-22 02:33:53 +00:00
Mark Jaquith 5d74a50af4 Switch "HTML" tab to "Text" in DFW mode. Update documentation and inline comments to refer to the "Text" tab or mode instead of "HTML". see #20993
git-svn-id: https://develop.svn.wordpress.org/trunk@21212 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-05 15:28:13 +00:00
Andrew Ozz 3ca0c089f2 Fix closing div position when post doesn't support editor, props markoheijnen, SergeyBiryukov, fixes #20709
git-svn-id: https://develop.svn.wordpress.org/trunk@20832 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-20 22:20:00 +00:00
Ryan Boren d04dbfb0e5 Clean out layout columns API in WP_Screen.
* Move layout column setup into render_screen_meta() so that the number of columns is available earlier.
* Store the user provisioned number of columns in an instance var.
* Access the var with get_columns()
* Move all templates away from the screen_layout_columns global to the get_columns() method.
* Deprecate the global
* Remove the no longer needed check for 'auto' in the user option.
* Cast the user option to an int.

Props griffinjt
fixes #20506


git-svn-id: https://develop.svn.wordpress.org/trunk@20579 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-24 20:46:04 +00:00
Andrew Ozz aff09817e7 Dashboard and write screen columns: remove unneeded class from the .wrap div on Write/Edit screens, see #20015
git-svn-id: https://develop.svn.wordpress.org/trunk@20570 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-23 22:40:59 +00:00
Andrew Ozz 3b9e5468e1 Add the jQuery UI Touch Punch plugin to handle dragging on mobile devices, props georgestephanis, see #20014
git-svn-id: https://develop.svn.wordpress.org/trunk@20433 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-11 02:20:51 +00:00
Andrew Ozz 74cfcd36e3 Responsive columns on the dashboard and write screens, first run, see #20015
git-svn-id: https://develop.svn.wordpress.org/trunk@20272 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-23 21:41:00 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Daryl Koopersmith 9270d2e101 Fix grammar and remove references to 'new in 3.2' in the post editor help text. props dougwrites, see #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19475 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-29 17:47:35 +00:00
Andrew Ozz 596034c7c9 Fix tabbing from 'title' to 'content', see #19088
git-svn-id: https://develop.svn.wordpress.org/trunk@19206 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-07 19:49:50 +00:00
Andrew Nacin 6114e7218d Only call wp_comment_reply() on post.php if the post type supports comments. props zeo, fixes #17931.
git-svn-id: https://develop.svn.wordpress.org/trunk@19170 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-05 05:41:25 +00:00
Andrew Nacin 33ee9a7d04 s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19119 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 20:14:10 +00:00
Ryan Boren 4709ef3dc2 Chain off of get_current_screen() instead of using global. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19110 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 02:38:37 +00:00
Ryan Boren fd10e500e4 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@19054 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-24 19:13:23 +00:00
Ryan Boren 5914353c06 Update meta box functions to handle WP_Screen objects and pass objects instead of IDs to them in core files. Allow passing emptiness to get the current screen. see #18958
git-svn-id: https://develop.svn.wordpress.org/trunk@19013 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-19 21:43:02 +00:00
Andrew Nacin 8f0389b3e9 Enforce IDs for add_help_tab(). props mbijon. Restore default_contextual_help, for now. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18941 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-11 19:29:09 +00:00
Andrew Nacin 2efff75050 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18911 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-07 04:57:12 +00:00
Andrew Nacin 0a6ff4024f Kill the multisite mu_media_buttons option. see #17578.
git-svn-id: https://develop.svn.wordpress.org/trunk@18892 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-05 22:04:09 +00:00
Andrew Ozz 22f4cdc7d7 Revert 'auto' column setting, props markjaquith, see #18863
git-svn-id: https://develop.svn.wordpress.org/trunk@18889 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-05 18:46:21 +00:00
Andrew Ozz 98554b4bb6 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18867 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-03 04:00:57 +00:00
Andrew Ozz d0d3855285 Add screen_options with contextual content, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18864 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-02 06:59:36 +00:00
Daryl Koopersmith a5acbaa574 Make screen options a help tab. Move screen option functions into WP_Screen. see #18690, #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18853 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-01 00:24:44 +00:00