Commit Graph

365 Commits

Author SHA1 Message Date
Sergey Biryukov bb2a27be5b Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: https://develop.svn.wordpress.org/trunk@24207 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-08 21:27:31 +00:00
Andrew Ozz 2c201632a2 Bulk actions: do not move locked posts to the trash, props pdclark, see #23792
git-svn-id: https://develop.svn.wordpress.org/trunk@23747 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 21:11:06 +00:00
Andrew Ozz 631980b5fa Post locks on the posts list screen: new icons for the lock, props empireoflight, show avatar for the user currently editing, props dh-shredder, see #23312
git-svn-id: https://develop.svn.wordpress.org/trunk@23681 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-13 00:28:07 +00:00
Ryan Boren 4088ca8723 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Andrew Ozz 756c28bf5c Post locks: use heartbeat to dynamically update locked posts on the Posts screen, first run, see #23312
git-svn-id: https://develop.svn.wordpress.org/trunk@23487 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-25 23:17:10 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Ryan Boren 308c702183 Use the create_posts capability in more places.
In get_post_type_capabilities(), make sure create_posts reflects customizations to the edit_posts capability when create_posts is not specifically set.


git-svn-id: https://develop.svn.wordpress.org/trunk@22291 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-24 22:15:43 +00:00
Ryan Boren de06b81360 Remove return ref from all calls to get_post()
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: https://develop.svn.wordpress.org/trunk@21597 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-23 20:01:10 +00:00
Ryan Boren ff3b56e89f Fix per_page screen option for custom post types and taxonomies. Don't convert taxonomy and post type slugs from hyphen to underscore when saving the per_page usermeta. Props nacin. see #18958
git-svn-id: https://develop.svn.wordpress.org/trunk@21322 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-25 16:13:13 +00:00
Andrew Nacin 1c9dcbeb0b Clean up messages on edit.php. see #19470.
git-svn-id: https://develop.svn.wordpress.org/trunk@20630 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-27 22:54:02 +00:00
Ryan Boren 54067a5f20 Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: https://develop.svn.wordpress.org/trunk@19596 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-14 17:36:38 +00:00
Ryan Boren 6610e321e7 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@19528 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 04:51:35 +00:00
Andrew Nacin bc0f0de8a0 Help tweaks for comments, media, edit.php, update-core.php. props jane, see #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19511 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 01:33:26 +00:00
Ryan Boren 4ae0813953 Help tabs. Props chexee. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19445 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-24 00:21:39 +00:00
Ryan Boren fe5a0a0bb0 Help tabs. Props chexee. see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19435 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-23 23:02:22 +00:00
Ryan Boren f626327800 Don't fallback to default post type or taxonomy if given an invalid post type or taxonomy. Use typenow as the canonical post type. Props nacin. see #19131
git-svn-id: https://develop.svn.wordpress.org/trunk@19321 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-17 18:01:08 +00:00
Ryan Boren 9356ce2a74 Fix edit.php row action redirects when referrers are not sent. Return false from wp_get_referer() when no referrer found. Props mitchoyoshitaka. fixes #17628
git-svn-id: https://develop.svn.wordpress.org/trunk@19272 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-14 16:59:45 +00:00
Ryan Boren 46f69c809a Fix message concatentation. Remove no longer used 'posted' message. fixes #16380
git-svn-id: https://develop.svn.wordpress.org/trunk@19259 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-11 20:01:56 +00:00
Andrew Nacin 33ee9a7d04 s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19119 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 20:14:10 +00:00
Ryan Boren db63861af8 Use add_help_sidebar(). see #19020
git-svn-id: https://develop.svn.wordpress.org/trunk@19111 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 03:12:37 +00:00
Andrew Nacin 2efff75050 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18911 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-07 04:57:12 +00:00
Andrew Ozz 98554b4bb6 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18867 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-03 04:00:57 +00:00
Andrew Ozz d0d3855285 Add screen_options with contextual content, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18864 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-02 06:59:36 +00:00
Andrew Ozz fc4915fb0f Do not run bulk edit when the user clicks on a filter, fixes #17733
git-svn-id: https://develop.svn.wordpress.org/trunk@18222 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-10 00:01:16 +00:00
Mark Jaquith 4f8b646e03 Centralize pagination bound exceeding redirects for list tables. props garyc40. props johnjamesjacoby. fixes #16208
git-svn-id: https://develop.svn.wordpress.org/trunk@17900 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-12 06:09:42 +00:00
Daryl Koopersmith 2c5592178f Admin Header 2: The Return of 32px Icons. Props, iammattthomas. see #17324.
git-svn-id: https://develop.svn.wordpress.org/trunk@17872 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-12 00:22:22 +00:00
Ryan Boren 57d714aedc Remove favorite_actions() from h2s. Restore Add New buttons. see #17324
git-svn-id: https://develop.svn.wordpress.org/trunk@17849 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-10 19:18:16 +00:00
Mark Jaquith e897910b75 Big UI style update. props koopersmith. see #17324
git-svn-id: https://develop.svn.wordpress.org/trunk@17800 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-04 20:15:05 +00:00
Andrew Nacin f504e221e1 Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: https://develop.svn.wordpress.org/trunk@17748 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 15:24:49 +00:00
Ryan Boren b84defcda1 Fix redirects for trashed post bulk ops. Props nacin, SergeyBiryukov. fixes #16355
git-svn-id: https://develop.svn.wordpress.org/trunk@17362 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-25 19:30:24 +00:00
Andrew Nacin 2b4674a3b4 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: https://develop.svn.wordpress.org/trunk@17322 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-16 21:47:24 +00:00
Andrew Nacin 71b24d4577 Revert [17270], [17273], see #16166, see #16262.
git-svn-id: https://develop.svn.wordpress.org/trunk@17321 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-16 21:34:38 +00:00
Andrew Nacin 03582ad585 Revert [17275] and [17276]. The rabbit hole is too deep. see #16166.
git-svn-id: https://develop.svn.wordpress.org/trunk@17277 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-13 00:50:35 +00:00
Andrew Nacin aa8519609e Move edit.php bulk actions code to a handler in the list table class. see #16166.
git-svn-id: https://develop.svn.wordpress.org/trunk@17276 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-13 00:34:18 +00:00
Andrew Nacin 19122c3516 Keep sorting and paging for bulk actions. props garyc40, see #16166.
git-svn-id: https://develop.svn.wordpress.org/trunk@17270 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-12 17:06:33 +00:00
scribu 0f40bb19cd Introduce WP_List_Table::search_box(). See #15353
git-svn-id: https://develop.svn.wordpress.org/trunk@17006 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 20:45:10 +00:00
Andrew Nacin afecafe7ab Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326.
git-svn-id: https://develop.svn.wordpress.org/trunk@16990 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 08:43:22 +00:00
Andrew Nacin 7feeb0a320 Help text edits. props dougwrites, fixes #15346.
git-svn-id: https://develop.svn.wordpress.org/trunk@16980 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 06:37:03 +00:00
Peter Westwood 424a82f2ef Move post_type var setup back into edit.php and reinstate the cap check. See #15326
git-svn-id: https://develop.svn.wordpress.org/trunk@16965 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-15 18:58:05 +00:00
Ryan Boren 6dc2d07bc4 Pink trailing whites.
git-svn-id: https://develop.svn.wordpress.org/trunk@16900 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-13 21:21:50 +00:00
scribu 3f5f212ffb Don't show search box if there are no items available. See #15353
git-svn-id: https://develop.svn.wordpress.org/trunk@16868 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-10 20:22:34 +00:00
scribu 13055dfc1a Remove unnecessary comments. See #15416
git-svn-id: https://develop.svn.wordpress.org/trunk@16856 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-10 08:55:17 +00:00
scribu 70e3fbe1e8 Redirect to correct page after bulk action for posts and comments. Props garyc40. Fixes #15416
git-svn-id: https://develop.svn.wordpress.org/trunk@16855 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-10 08:49:16 +00:00
Peter Westwood e3d0969ded Revert brokenness. See #15326.
git-svn-id: https://develop.svn.wordpress.org/trunk@16779 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-07 21:35:46 +00:00
Peter Westwood ab5f09cfda Restore some more cap checks for clarity. See #15326.
git-svn-id: https://develop.svn.wordpress.org/trunk@16776 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-07 21:06:19 +00:00
Peter Westwood 60a7e5973c If we have not items don't try and output the inline_edit form. Fixes #15240 props mrmist for tracking the bug down.
git-svn-id: https://develop.svn.wordpress.org/trunk@16685 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-02 08:09:58 +00:00
Andrew Nacin 8d9b2cd2b3 Properly check, initialize, or cast a number of variables. props ChenHui. see #14642.
git-svn-id: https://develop.svn.wordpress.org/trunk@16377 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-15 06:38:10 +00:00
Peter Westwood 817aa1975c Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
git-svn-id: https://develop.svn.wordpress.org/trunk@16175 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-04 08:07:03 +00:00
scribu d1034ad0d3 complete the renaming. props ocean90. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@16172 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-03 22:06:45 +00:00