Commit Graph

42275 Commits

Author SHA1 Message Date
Sergey Biryukov
e393d41e3c Administration: Don't print the .php-error class in the admin header for PHP notices in wp-config.php.
Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`.

Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided.

Follow-up to [20102], [21025], [26620], [47745].

Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov.
Merges [48850] to the 5.5 branch.
Fixes #51073.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48851 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-24 10:48:24 +00:00
Sergey Biryukov
4ad67eb3c2 REST API: In WP_REST_Block_Directory_Controller::get_items(), make sure the blocks data for a plugin is not empty before proceeding.
This avoids a PHP notice if the API returns a plugin with empty data for `blocks` key.

Props khag7, TwentyZeroTwo, justinahinon, TimothyBlynJacobs, dd32, SergeyBiryukov.
Merges [48842] to the 5.5 branch.
Fixes #51018.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48849 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-24 10:33:09 +00:00
Sergey Biryukov
4e7ac9bb9f Docs: Update documentation for get_custom_logo() and the_custom_logo() to mention the unlink-homepage-logo theme feature.
Follow-up to [48039], [48283], [48749], [48757], [48758].

Props sabernhardt.
Merges [48832] to the 5.5 branch.
Fixes #51075.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48833 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-20 10:40:40 +00:00
Sergey Biryukov
acc404eaf8 Docs: Add a @since note to register_rest_route() about the _doing_it_wrong() notice when the required permission_callback argument is not set.
Follow-up to [48526].

Props psykro.
Merges [48827] to the 5.5 branch.
Fixes #51060.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48828 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-19 12:31:23 +00:00
Sergey Biryukov
5b338a892f Plugins: Avoid a PHP notice if the update-supported key in plugin data is not set.
Props sanzeeb3.
Merges [48820] to the 5.5 branch.
Fixes #51052.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48821 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-18 20:38:21 +00:00
Sergey Biryukov
ba58ceefa4 Formatting: Make the check for empty text in wp_trim_excerpt() more resilient.
This addresses a regression in [47808], which caused excerpts to be generated from post content if an empty string is passed, but not for other values considered empty, e.g. `null` or `false`.

Props riaanlom, laxman-prajapati, SergeyBiryukov.
Merges [48817] to the 5.5 branch.
Fixes #51042.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48819 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-18 19:35:30 +00:00
Sergey Biryukov
a8f733a239 Docs: Add a @since note to get_the_archive_title() about the title part being wrapped in a <span> element.
Follow-up to [48294].

Props justinahinon, audrasjb.
Merges [48814] to the 5.5 branch.
Fixes #51050.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48815 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-18 12:05:13 +00:00
Sergey Biryukov
e35a4f0170 Help/About: Revert [48811] from the 5.5 branch for now, to avoid displaying untranslated strings on the About page.
This should be merged back when 5.5.1 is about to be released.

See #51028.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48813 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-18 03:00:58 +00:00
Sergey Biryukov
1006cd9c2c Help/About: Fix typo and remove trailing spaces from some strings.
Props mukesh27, casiepa, davidbaumwald.
Merges [48809] to the 5.5 branch.
Fixes #51028.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48811 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 10:57:37 +00:00
Sergey Biryukov
fe47413a65 Site Health: Ensure that the tests returned by WP_Site_Health::get_tests() always have the required array keys: direct and async.
This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter.

Props khag7, Ov3rfly, desrosj, Clorith.
Merges [48808] to the 5.5 branch.
Fixes #50858.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48810 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 02:21:17 +00:00
Sergey Biryukov
3212a7dffb REST API: Add uniqueItems as a permitted endpoint argument JSON Schema keyword.
Support for the `uniqueItems` keyword was added in [48357], but wasn't included in the list of permitted keywords for `WP_REST_Controller::get_endpoint_args_for_item_schema()`. This prevented the keyword from being automatically supported if specified in a controller's item schema.

Props TimothyBlynJacobs.
Merges [48796] to the 5.5 branch.
Fixes #51021.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48807 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 01:40:59 +00:00
Sergey Biryukov
267960fc5d Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Merges [48800] and [48801] to the 5.5 branch.
Fixes #50945.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48806 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 01:27:29 +00:00
Sergey Biryukov
6ee7a4f5c8 Site Health: Add site environment type to the debug information.
Follow-up to [47919], [48188], [48372].

Props joostdevalk, Clorith.
Merges [48802] to the 5.5 branch.
Fixes #50887.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48805 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 01:23:58 +00:00
Sergey Biryukov
9e0800ebe9 Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value.
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.

With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Merges [48792] to the 5.5 branch.
Fixes #50912.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48804 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 01:02:38 +00:00
Sergey Biryukov
6b6be351ef Filesystem API: Use correct variable when closing the file handle in WP_Filesystem_FTPext::get_contents().
Props gothick@gothick.org.uk.
Merges [48797] to the 5.5 branch.
Fixes #51029.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48803 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-17 00:55:28 +00:00
Sergey Biryukov
aabef3109e Post WordPress 5.5 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48787 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-11 19:33:39 +00:00
Jake Spurlock
70fcbf67df WordPress 5.5
git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48785 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-11 18:12:27 +00:00
Jonathan Desrosiers
b591209e14 Help/About: Final adjustments to the 5.5 About page.
- Final CDN asset URLs.
- Some minor color adjustments.

Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Merges [48783] to the 5.5 branch.
Fixes #50416.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48784 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-11 16:55:20 +00:00
Jake Spurlock
32016c9a91 Post WordPress 5.5 RC 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48781 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 16:53:55 +00:00
Jake Spurlock
002569e0c7 WordPress 5.5 RC 3.
git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48780 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 16:31:54 +00:00
Sergey Biryukov
dd5e7eecdf Options, Meta APIs: Update the docs around default metadata values.
Add a missing @since value for 5.5 and potential default filter names.

Props johnbillion.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48777] and [48778] to the 5.5 branch.
Fixes #50891.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48779 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 15:52:01 +00:00
Jonathan Desrosiers
8f90e1214a Bundled Themes: Bump theme versions ahead of WordPress 5.5.
The following theme versions will be released in coordination with WordPress 5.5:
- Twenty Ten: 3.1
- Twenty Eleven: 3.5
- Twenty Twelve: 3.2
- Twenty Thirteen: 3.1
- Twenty Fourteen: 2.9
- Twenty Fifteen: 2.7
- Twenty Sixteen: 2.2
- Twenty Seventeen: 2.4
- Twenty Nineteen: 1.7
- Twenty Twenty: 1.5

Props whyisjake, desrosj.
Reviewed by whyisjake, SergeyBiryukov, desrosj.
Merges [48775] to the 5.5 branch.
Fixes #50889.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48776 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 15:35:03 +00:00
Sergey Biryukov
b54b69fcfb Editor: update packages.
Props ellatrix.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48772] to the 5.5 branch.
Fixes #50888.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48773 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 14:20:54 +00:00
Sergey Biryukov
612dba0c7e I18N: Fix typo in a screen reader text string on the About page.
Follow-up to [48729].

Props pedromendonca.
Reviewed by desrosj, SergeyBiryukov.
Merges [48770] to the 5.5 branch.
Fixes #50884.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48771 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-10 13:23:42 +00:00
Sergey Biryukov
dcfb85f81b I18N: Fix typo in a string in rest_validate_value_from_schema().
Props pedromendonca.
Reviewed by TimothyBlynJacobs, SergeyBiryukov.
Merges [48767] to the 5.5 branch.
Fixes #50879.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48768 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-09 02:01:01 +00:00
Sergey Biryukov
ec8435cf47 Help/About: Update videos and their descriptions on the About page.
Follow-up to [48675], [48686], [48721], [48729], [48730], [48736].

Props ryelle, marybaum, estelaris, desrosj, joen, afercia.
Reviewed by jorbin, SergeyBiryukov.
Merges [48761] to the 5.5 branch.
See #50416.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48763 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-08 21:00:09 +00:00
Jake Spurlock
89c0054e1f Themes: Add unlink-homepage-logo to the create_initial_theme_features() registration for the custom-logo theme feature.
Follow-up to [48039], [48283], [48749], [48757], [48758].

This brings the changes to the 5.5 branch.

Props TimothyBlynJacobs, SergeyBiryukov, whyisjake.
Fixes #37011.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48759 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 21:20:23 +00:00
Jake Spurlock
fb5dafdac3 Docs: Correct usage of the dynamic auto_update_{$type} filter.
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.

This brings the changes from [48750] to the 5.5 branch.

Props johnbillion.
Fixes #50868, see [48750].


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48756 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 19:23:04 +00:00
Jake Spurlock
2dd5d516ce Accessibility: Themes: Only unlink custom logo on the home page if the theme declares support for that.
To accommodate for the change, the custom-logo theme feature now accepts the unlink-homepage-logo parameter.

If and when the logo is linked on the home page, the link has the aria-current attribute for better accessibility.

Follow-up to [48039], [48283], see [48749].

This brings the changes to the 5.5 branch.

Props sabernhardt, audrasjb, johnstonphilip, demetris, SergeyBiryukov.
Fixes #37011.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48755 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 19:18:19 +00:00
Sergey Biryukov
ed42560f33 Comments: Update comment cache in the upgrade routine for changing the comment_type DB field value in comments table.
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.

Add a unit test for `_wp_batch_update_comment_type()`.

Follow-up to [47597], [47626], [48225], [48227].

Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes #49236.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48752 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 16:33:39 +00:00
Jonathan Desrosiers
a2b00b87ee Site Health: Consistently pass an object to the auto_update_{$type} filter in Site Health debug data.
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.

Merges [48745] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bpayton, pbiron.
Fixes #50852.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48747 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 13:49:47 +00:00
Jonathan Desrosiers
cdcda4981e Site Health: Check if session_status() exists before calling it.
Merges [48742] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bgermann.
Fixes #50862.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48746 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-07 13:41:55 +00:00
Jonathan Desrosiers
ec8a5568b7 General: Add svn:mergeinfo missed in [48733].
Finishes merging [48729-48730] to the 5.5 branch.
See #50416.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48740 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 19:44:09 +00:00
Jake Spurlock
c345b2af30 WordPress 5.5 RC 2 post-release version bump.
git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48739 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 19:16:17 +00:00
Jake Spurlock
da34d0a098 WordPress 5.5 RC 2.
git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48738 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 18:55:02 +00:00
Sergey Biryukov
4e0dbae2da Help/About: Correct header spacing on shorter screens after removing the musician name.
Remove some unnecessary CSS.

Follow-up to [48730].

Props ryelle.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48736] to the 5.5 branch.
See #50416.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48737 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 18:11:15 +00:00
Sergey Biryukov
d83a210f21 Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader method.
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.

Props sswebster, nateinaction.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48734] to the 5.5 branch.
Fixes #50837.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48735 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 18:02:45 +00:00
Jonathan Desrosiers
b211576719 Help/About: String updates and accessibility improvements to the 5.5 About page.
Merges [48729-48730] to the 5.5 branch.
Props audrasjb, SergeyBiryukov.
See #50416.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48733 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:42:44 +00:00
Jake Spurlock
21e7801838 Site Health: Display auto-update properly for plugins that don't support auto-updates.
Properly filter auto_update_plugin when displaying the table.

This brings the changes from [48731] to the 5.5 branch.

Fixes #50822.
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48732 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:37:59 +00:00
Sergey Biryukov
f3ffb37107 Editor: Update JS packages.
Props ellatrix.
Reviewed by youknowriad, SergeyBiryukov.
Merges [48725] to the 5.5 branch.
Fixes #50844.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48728 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:04:38 +00:00
Sergey Biryukov
8b8275897e Editor: Make some hardcoded strings in block patterns translatable.
Props ocean90.
Reviewed by youknowriad, SergeyBiryukov.
Merges [48726] to the 5.5 branch.
Fixes #50842.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48727 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 17:02:42 +00:00
Jake Spurlock
c3c901bb2f Help/About: String update for 5.5 release.
We don't use hyphens for the [block editor](https://make.wordpress.org/core/handbook/best-practices/spelling/).

See #50416.
Props davidbaumwald, marybaum, desrosj.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48723 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 15:56:18 +00:00
Jonathan Desrosiers
086abbc22d Editor: update JS packages.
Merges [48719] to the 5.5 branch.
Fixes #50841.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48720 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 14:02:46 +00:00
Andrea Fercia
9050f838d7 Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340].
Merges [48717] to the 5.5 branch.
Fixes #49288 for 5.5.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48718 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-04 13:28:58 +00:00
Sergey Biryukov
2cc3234bf6 HTTP: Update the Root Certificate bundle.
Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions.

Props barry, ayeshrajans, desrosj, whyisjake.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48707] to the 5.5 branch.
See #50828.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48708 602fd350-edb4-49c9-b593-d223f7449a82
2020-08-01 14:11:02 +00:00
Aaron Jorbin
27c8c04be3 Build/Test Tools: Update grunt-patch-wordpress for 5.5
Trunk's update happened in [50829]

Seconded by whyisjake and SergeyBiryukov.
Fixes #50829.



git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48706 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 19:20:09 +00:00
Jake Spurlock
0f98da6e55 Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled.
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.

This brings the changes from [48703] to the WordPress 5.5 branch.

Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48704 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 17:22:06 +00:00
Jake Spurlock
0ff10b7f0a Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.

This brings the changes from [48701] to the 5.5 branch.

Fixes #50824.
Props dd32, whyisjake, SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48702 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-31 17:03:24 +00:00
Jake Spurlock
b700cb82c7 Upgrade/Install: Only show auto-update for themes that support the feature.
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.

This brings the changes from [48688] to the 5.5 branch.

See #50280.
Props dd32.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48698 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 22:02:54 +00:00
Jake Spurlock
f91ef2f0a8 Upgrade/Install: Pass the plugin file path into the plugin_auto_update_debug_string filter.
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.

This brings [48696] to the 5.5 branch.

Fixes #50821.

Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake.


git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48697 602fd350-edb4-49c9-b593-d223f7449a82
2020-07-30 21:50:39 +00:00