Commit Graph

26479 Commits

Author SHA1 Message Date
Scott Taylor
0d0cdfe1c7 Don't use variable variables in wp_insert_user().
Add a local array, `$meta`, to provide substantial disambiguation among variables. 

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28740 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:20:57 +00:00
Scott Taylor
35af75077b Don't use variable variables in plugins_url().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28739 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 18:17:52 +00:00
Scott Taylor
ce8cff84aa Don't use variable variables in WP_Comment_Query::query().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28738 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:57:39 +00:00
Scott Taylor
f2b3e0c4e4 Don't use variable variables in WP_Query::get_posts().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28737 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:49:07 +00:00
Scott Taylor
5fe5f8f3ad Don't use variable variables in get_terms().
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28736 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 17:40:11 +00:00
Drew Jaynes (DrewAPicture)
e535d7fe6e Improve inline documention for set_transient() and set_site_transient() to specify the 45- and 40-character limits for their respective transient name values.
Props edwin-at-studiojoyo.com for the original patch.
See #15058, #13310. Fixes #28467.


git-svn-id: https://develop.svn.wordpress.org/trunk@28735 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:32:06 +00:00
Scott Taylor
fa03901cd8 Don't use a variable variable in wp_widget_rss_form(). Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields.
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28734 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 16:17:56 +00:00
Scott Taylor
eadc17c4f9 In wp_insert_term(), when no slug is provided, check for an existing term by name. If it exists, use that slug instead of calling sanitize_title( $name ).
Prevents creating an endless number of terms like `A+` or `$$$$` in any given taxonomy.

Props wonderboymusic, SergeyBiryukov, aaroncampbell.
Fixes #17689.


git-svn-id: https://develop.svn.wordpress.org/trunk@28733 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 02:27:36 +00:00
Andrew Ozz
1b07af046f Fix the layout of the Image Details modal, props gcorne, see #24716 [28682]
git-svn-id: https://develop.svn.wordpress.org/trunk@28732 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-11 00:22:53 +00:00
John Blackbourn
f02e878bb0 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt.
git-svn-id: https://develop.svn.wordpress.org/trunk@28731 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 19:14:26 +00:00
John Blackbourn
827cf97b00 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein.
git-svn-id: https://develop.svn.wordpress.org/trunk@28730 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:49:26 +00:00
Scott Taylor
121726df31 edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants.
Props knutsp.
Fixes #27951.


git-svn-id: https://develop.svn.wordpress.org/trunk@28729 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:47:57 +00:00
John Blackbourn
f54bb586c8 A little more abstraction in the WP_oEmbed class. Fixes #24381.
git-svn-id: https://develop.svn.wordpress.org/trunk@28728 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 18:13:43 +00:00
Scott Taylor
821c052473 In wptexturize(), ensure that texturization does not corrupt contents of HTML elements, HTML comments, and smartcode attributes.
Adds a variety of unit tests/assertions.

Props miqrogroove.
Fixes #12690, #8912, #27602.


git-svn-id: https://develop.svn.wordpress.org/trunk@28727 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:33:16 +00:00
Scott Taylor
9e347a40c2 In wptexturize(), allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool."
Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.


git-svn-id: https://develop.svn.wordpress.org/trunk@28726 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:21:36 +00:00
Scott Taylor
66b539bdab wptexturize() should handle apostrophes before primes.
Props nacin, miqrogroove.
Fixes #22823.


git-svn-id: https://develop.svn.wordpress.org/trunk@28725 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 14:13:52 +00:00
Drew Jaynes (DrewAPicture)
da0b2f9769 Improve inline documentation for the wp_spaces_regexp filter.
Fixes #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28724 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 06:45:38 +00:00
Drew Jaynes (DrewAPicture)
0d0f24fbbb Add inline documentation for the run_wptexturize filter.
Props miqrogroove for the original patch.
Fixes #19550.


git-svn-id: https://develop.svn.wordpress.org/trunk@28723 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 06:28:19 +00:00
Scott Taylor
fe2ca3965e Set a variable for like-escaped string before looping in WP_User_Query::get_search_sql().
Props miqrogroove.
Fixes #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28722 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:44:35 +00:00
Scott Taylor
013f3f14e3 Fix curly quotes around numbers when applicable.
Adds unit tests.

Props filosofo, mrmist, aliso, MikeHansenMe, miqrogroove.
Fixes #8775.


git-svn-id: https://develop.svn.wordpress.org/trunk@28721 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:42:35 +00:00
Scott Taylor
ce59109919 In WP_Comment_Query::get_search_sql(), don't double-like-escape.
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28720 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:19:30 +00:00
Scott Taylor
a66f776684 In wptexturize(), don't convert C-style hexadecimals to mathematical ×.
Adds unit tests.

Props harrym, kurtpayne, miqrogroove.
Fixes #19308.


git-svn-id: https://develop.svn.wordpress.org/trunk@28719 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:17:24 +00:00
Scott Taylor
f9bcf40db7 In wptexturize(), treat   like whitespace when texturizing hyphens.
Adds unit tests.

Props redsweater, miqrogroove.
Fixes #23185.


git-svn-id: https://develop.svn.wordpress.org/trunk@28718 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:08:05 +00:00
Scott Taylor
db7816dd0c smilies_init(), treat   like whitespace when converting smilies.
Adds unit tests.

Props miqrogroove.
Fixes #27587.


git-svn-id: https://develop.svn.wordpress.org/trunk@28717 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 02:02:23 +00:00
Scott Taylor
97bacb3121 Ensure that shortcode_unautop() treats   like whitespace.
`shortcode_unautop()` and `wptexturize()` now use `wp_spaces_regexp()` instead of raw regex.

Adds unit tests.

Props miqrogroove.
See #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28716 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 01:54:11 +00:00
Scott Taylor
8ec05a3926 Add a $run_texturize static var to wptexturize() that is filterable via a new run-once filter: 'run_wptexturize'. Allows user to disable texturization.
Needs filter docs.

Props nacin, SergeyBiryukov.
See #19550.


git-svn-id: https://develop.svn.wordpress.org/trunk@28715 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 01:45:28 +00:00
Scott Taylor
cfe11de507 Fix a unit test for the now deprecated function like_escape().
Props miqrogroove.
Fixes #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28714 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 01:21:33 +00:00
Scott Taylor
4459acb59d Remove unnecessary ->test() method from Tests_Canonical_HTTPS to avoid PHP error.
See [28704].


git-svn-id: https://develop.svn.wordpress.org/trunk@28713 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 01:09:43 +00:00
Scott Taylor
84ad12b439 Replace all uses of like_escape() with $wpdb->esc_like().
Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28712 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:43:32 +00:00
Scott Taylor
2a551f57a4 LIKE escape sanity:
* Deprecate `like_escape()`
* Add a method to `$wpdb`, `->esc_like()`, and add unit tests

`$wpdb::esc_like()` is not used yet. As such, many unit tests will throw `Unexpected deprecated notice for like_escape`. Subsequent commits will alleviate this.

Props miqrogroove.
See #10041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28711 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-10 00:29:35 +00:00
John Blackbourn
12ea157f2c Correct the deprecated function parameter in url_is_accessable_via_ssl(). See #19555.
git-svn-id: https://develop.svn.wordpress.org/trunk@28710 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 22:26:27 +00:00
John Blackbourn
7a220d7e95 Deprecate url_is_accessable_via_ssl(). Fixes #19555. Props jgadbois.
git-svn-id: https://develop.svn.wordpress.org/trunk@28709 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 22:02:50 +00:00
Scott Taylor
b7d411e724 Add a function: wp_spaces_regexp(). It is not used yet.
This function is required by a bunch of patches by miqrogroove. Needs filter docs.

Props miqrogroove.
See #27588.


git-svn-id: https://develop.svn.wordpress.org/trunk@28708 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 19:29:55 +00:00
Scott Taylor
faf208de38 Live update the menu item title when the user is editing the "Navigation Label" field.
Props celloexpressions.
See #23076.


git-svn-id: https://develop.svn.wordpress.org/trunk@28707 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 18:38:29 +00:00
Scott Taylor
12e325582a Update unit tests to reflect:
* [28673] - title attributes are no longer expected to be present in some assertions
* [28704] - Fix `Declaration of Tests_Canonical_HTTPS::test() should be compatible with Tests_Canonical::test($test_url, $expected, $ticket = 0)`
* [28679] - Add `@expectedDeprecated get_all_category_ids`


git-svn-id: https://develop.svn.wordpress.org/trunk@28706 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 15:58:16 +00:00
Scott Taylor
69384c40a3 When a plain URL or email address is selected in the editor and "Insert/edit link" is clicked, pre-populate the URL field with the URL or mailto:<email-address>.
Props tillkruess.
Fixes #19992.


git-svn-id: https://develop.svn.wordpress.org/trunk@28705 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 15:34:21 +00:00
John Blackbourn
65890b4858 Add some basic unit tests for HTTPS canonical redirects. See #27954.
git-svn-id: https://develop.svn.wordpress.org/trunk@28704 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-09 01:05:46 +00:00
Helen Hou-Sandi
70390c48f5 Properly indicate with the cursor that the editor can be vertically resized using the entire info bar, not just the handle displayed in the corner.
props torresga. fixes #28420.


git-svn-id: https://develop.svn.wordpress.org/trunk@28703 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 19:47:00 +00:00
Lance Willett
3462f4d964 Twenty Twelve: bump JS version after r28700 change. See #24767.
git-svn-id: https://develop.svn.wordpress.org/trunk@28702 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 19:20:48 +00:00
Lance Willett
4083df4b38 Twenty Thirteen: adjust background size of header image(s) for small devices. Props senlin, fixes #26856.
git-svn-id: https://develop.svn.wordpress.org/trunk@28701 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 19:12:46 +00:00
Lance Willett
1ff9d938af Twenty Twelve: make submenu links work correctly on tablets. Props tar.gz, purzlbaum, DavidTheMachine. See #24767.
git-svn-id: https://develop.svn.wordpress.org/trunk@28700 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 18:59:45 +00:00
Lance Willett
6779256079 Twenty Thirteen: make submenu links work correctly on tablets. Props tar.gz, purzlbaum, DavidTheMachine. See #24767.
git-svn-id: https://develop.svn.wordpress.org/trunk@28699 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 18:47:58 +00:00
Lance Willett
7a53e007ec Twenty Fourteen: fix menu toggle display on older Android devices. Props obenland, DavidTheMachine. Fixes #27456.
git-svn-id: https://develop.svn.wordpress.org/trunk@28698 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 18:23:06 +00:00
Sergey Biryukov
dfffa2cffd Fix JSHint error.
props avryl.
see #24716.

git-svn-id: https://develop.svn.wordpress.org/trunk@28697 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-08 12:32:50 +00:00
Sergey Biryukov
88e8720018 Use get_pages() instead of a raw SQL query in get_body_class().
fixes #28159.

git-svn-id: https://develop.svn.wordpress.org/trunk@28696 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-07 03:21:46 +00:00
Sergey Biryukov
40a7bccdc1 Include *.yml coding standards in .editorconfig.
props netweb.
fixes #28289.

git-svn-id: https://develop.svn.wordpress.org/trunk@28695 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 22:05:25 +00:00
Lance Willett
36bf68f86f Twenty Fourteen: first pass at better Audio/Video player styling with genericons. Props celloexpressions, see #26469.
git-svn-id: https://develop.svn.wordpress.org/trunk@28694 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 18:56:18 +00:00
Lance Willett
abef8628f5 Twenty Thirteen: update to Genericons 3.0.3. Props celloexpressions, lancewillett. Closes #25391.
git-svn-id: https://develop.svn.wordpress.org/trunk@28693 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 18:21:42 +00:00
Lance Willett
d99120e86b Twenty Fourteen: update to Genericons 3.0.3. Props celloexpressions, closes #28456.
git-svn-id: https://develop.svn.wordpress.org/trunk@28692 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 17:35:24 +00:00
Lance Willett
d17b15c793 Twenty Fourteen: Apply max-width values to avoid site title breaking the layout in small screens. Props sixhours, rclations. See #28237.
git-svn-id: https://develop.svn.wordpress.org/trunk@28691 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-06 17:30:38 +00:00