Commit Graph

34 Commits

Author SHA1 Message Date
Dominik Schilling (ocean90)
df884cb92e Customizer: Use deep-links for Backgrounds, Headers, and Widgets.
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.

git-svn-id: https://develop.svn.wordpress.org/trunk@30459 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-20 15:28:55 +00:00
John Blackbourn
4e1e4745ff Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin


git-svn-id: https://develop.svn.wordpress.org/trunk@30356 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-16 06:15:29 +00:00
Dominik Schilling (ocean90)
8d61151356 Improve keyboard accessibility on Custom Header and Custom Background screen.
props florianziegler.
fixes #29289.

git-svn-id: https://develop.svn.wordpress.org/trunk@30327 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-13 11:59:23 +00:00
Scott Taylor
c502804272 In Custom_Image_Header:
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30187 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-03 05:14:11 +00:00
Scott Taylor
334fc5b9f2 In Custom_Image_Header->step_2(), $type is set internally but never used.
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30136 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-01 01:23:50 +00:00
John Blackbourn
6fcb1bf817 Add a hidden submit button to the Appearance -> Header screen so keyboard users can submit the form correctly when a default image provided by the theme is in use.
Fixes #20880.
Props kovshenin, joedolson.


git-svn-id: https://develop.svn.wordpress.org/trunk@30095 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-29 21:40:58 +00:00
Sergey Biryukov
8e3a90887e Fix a copy/paste issue in Custom_Image_Header::get_header_dimensions() introduced in [27497].
props ipm-frommen.
fixes #30095.

git-svn-id: https://develop.svn.wordpress.org/trunk@30021 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-25 15:55:37 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
49fdc296ba Fill out inline documentation for magic methods added to the Custom_Image_Header class in [28481], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29150 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:58:27 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:31:00 +00:00
Scott Taylor
c6919845ca Remove public keyword from some JS functions. Sorry.
Props ocean90.
See #22234.



git-svn-id: https://develop.svn.wordpress.org/trunk@28483 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 21:42:32 +00:00
Scott Taylor
e509190fb3 Use proper access modifiers and add a magic __get() method to Custom_Background and Custom_Image_Header.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28481 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-18 21:30:43 +00:00
Scott Taylor
f57bdbd238 Eliminate use of extract() in Custom_Image_Header::step_2().
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28384 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:53:13 +00:00
Drew Jaynes (DrewAPicture)
d59c371180 Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28375 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:12:02 +00:00
Dominik Schilling (ocean90)
b09a91a666 Custom Header: Fix logic when a theme doesn't set default-text-color.
fixes #28042.

git-svn-id: https://develop.svn.wordpress.org/trunk@28294 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 15:26:46 +00:00
Scott Taylor
88ad28ffdf In wp-admin/custom-header.php, $default_color is set twice before it is used. The first is unnecessary.
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28290 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 14:50:05 +00:00
Andrew Nacin
c0822b532e Custom header: Avoid warnings in the process_default_headers() method.
props obenland.
fixes #27850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28275 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:06:39 +00:00
Drew Jaynes (DrewAPicture)
d1137de3de Ensure all duplicate calls of the wp_create_file_in_uploads filter are labeled as such.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28212 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:45:26 +00:00
Andrew Nacin
6ec7a5a52b Header images: Accessibility and style improvements. Headers no longer jump around when chosen.
props mcsf, ehg.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27947 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:48:34 +00:00
Andrew Nacin
5f98beb862 Custom Headers: Simplify and consolidate the querying of custom headers for the customizer.
props mcsf.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27849 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 10:52:17 +00:00
Andrew Nacin
6f2544944f Add header image uploads with cropping to the customizer.
props mcsf, ehg, gcorne.
see #21785.


git-svn-id: https://develop.svn.wordpress.org/trunk@27497 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-11 04:12:17 +00:00
Andrew Nacin
4cf6fc1a99 Use SSL when linking to WordPress.org. see #27115.
git-svn-id: https://develop.svn.wordpress.org/trunk@27469 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:13:28 +00:00
Andrew Ozz
48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-24 19:05:15 +00:00
Sergey Biryukov
71954e1f44 Always show Background Image section heading and the opening table tag on Custom Background screen, to make in consistent with Custom Header and avoid broken markup.
props obenland.
fixes #26731.

git-svn-id: https://develop.svn.wordpress.org/trunk@26878 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-29 08:05:50 +00:00
Drew Jaynes
bd39e26032 First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.


git-svn-id: https://develop.svn.wordpress.org/trunk@26868 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-24 18:56:05 +00:00
Andrew Ozz
b33d0da84c Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
git-svn-id: https://develop.svn.wordpress.org/trunk@26518 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 03:52:23 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:21:32 +00:00
Drew Jaynes
0edc7a4087 Inline documentation for hooks in wp-admin/custom-header.php.
Props gizburdt for the initial patch.
Fixes #25443.


git-svn-id: https://develop.svn.wordpress.org/trunk@25821 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-16 23:25:30 +00:00
Scott Taylor
16ef2c2e36 Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.
Props jdgrimes.
See #25160.



git-svn-id: https://develop.svn.wordpress.org/trunk@25254 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 16:33:50 +00:00
Andrew Nacin
328117ffbf Only show 'Preview' on the custom header screen if there is something to show.
props nickmomrik.
fixes #14531.


git-svn-id: https://develop.svn.wordpress.org/trunk@25135 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-27 12:27:00 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00