Commit Graph

69 Commits

Author SHA1 Message Date
Andrew Ozz b254457b19 Skip To links: visually hide by only setting top: -1000em; (this should make them work well in all screen readers), fixes #21312
git-svn-id: https://develop.svn.wordpress.org/trunk@22730 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-20 21:14:49 +00:00
Andrew Ozz 7c30ff0dcb Accessibility shortcuts: new looks and fix for the WebKit focus bug, props lessbloat, fixes #21471
git-svn-id: https://develop.svn.wordpress.org/trunk@22249 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-16 21:26:59 +00:00
Andrew Nacin a7111de3b5 Remove the @return for WP_Admin_Bar::remove_node(). props scribu. fixes #20906.
git-svn-id: https://develop.svn.wordpress.org/trunk@21608 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-24 17:34:52 +00:00
Andrew Ozz d80d9acc28 Accessibility: add off-screen Log Out link in the toolbar, tweak the class names of the accessible links in #adminbar, see #21312
git-svn-id: https://develop.svn.wordpress.org/trunk@21452 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-06 00:34:44 +00:00
Andrew Ozz b9892b6f4e Add "Skip to toolbar" accessibility shortcut, see #21471
git-svn-id: https://develop.svn.wordpress.org/trunk@21423 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-05 18:41:52 +00:00
Andrew Nacin e6eda2b3f7 Admin bar: When calling add_node() for an existing node, all properties should be merged into the existing arguments, including individual meta arguments. Corrects a logic inversion. fixes #21117.
git-svn-id: https://develop.svn.wordpress.org/trunk@21259 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-10 21:26:35 +00:00
Andrew Nacin aa7f457bfb Tabs, not spaces for intendation. Add a docblock to the file/class.
git-svn-id: https://develop.svn.wordpress.org/trunk@21257 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-10 20:32:48 +00:00
Andrew Nacin 168e08168c Don't output empty class names or ones with leading/trailing spaces. props MattyRob for the initial patch. fixes #20698.
git-svn-id: https://develop.svn.wordpress.org/trunk@21193 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-30 11:47:21 +00:00
Andrew Ozz bce0d37a67 Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014
git-svn-id: https://develop.svn.wordpress.org/trunk@20417 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-10 01:19:30 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Andrew Nacin 0e4935d078 Make sure that _render() is only called with a valid root object. As in, render() can only be validly called once and must not fail on the second call. props SergeyBiryukov, see #19642 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@19638 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-30 23:04:28 +00:00
Ryan Boren e08ad42704 Introduce user-actions group and move profile and logout menu items to it and change priority. Props koopersmith. fixes #19425
git-svn-id: https://develop.svn.wordpress.org/trunk@19559 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-06 03:51:58 +00:00
Ryan Boren 2bf922daf5 Admin bar API improvements. Props koopersmith. fixes #19416 #19371
git-svn-id: https://develop.svn.wordpress.org/trunk@19558 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-06 03:42:11 +00:00
Ryan Boren e18515a5a1 Don't drop dollars. see #19426
git-svn-id: https://develop.svn.wordpress.org/trunk@19556 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-06 00:46:03 +00:00
Ryan Boren 286193bb4f Add back compat support for my-account-with-avatar admin bar node id. fixes #19426
git-svn-id: https://develop.svn.wordpress.org/trunk@19555 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-06 00:31:11 +00:00
Andrew Ozz 6bd61a831e Remove role="menu" and role="menuitem" for now, fixes #19394
git-svn-id: https://develop.svn.wordpress.org/trunk@19548 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-05 17:47:23 +00:00
Daryl Koopersmith 345b3b943a Remove the shortlink item from the toolbar, but keep the function for plugins. fixes #19407.
git-svn-id: https://develop.svn.wordpress.org/trunk@19519 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 03:25:54 +00:00
Daryl Koopersmith c6003cf37b In toolbar, move search item to the right of the account menu and make it icon-only. fixes #19370, #19406.
git-svn-id: https://develop.svn.wordpress.org/trunk@19518 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 03:03:12 +00:00
Andrew Nacin d36315ee66 Finalize the WP_Admin_Bar architecture for 3.3.
* Introduce a get_node() method for plugins.
 * Deprecate $wp_admin_bar->menu. Plugins will need to use get_node(), remove_node(), add_node() to make modifications. This finalizes a backwards incompatible change made earlier in the cycle.
 * Allow add_node() to take a node object (which could come from get_node(), then be modified).
 * Ensure that our underlying storage (the nodes property) is private to core. Introduce _set_node, _unset_node, _get_nodes, get_nodes as the only ways to interface with this.
 * Protect and finalize _render_item, and _render_group. render() remains public and technically overridable, though I would discourage this of plugin authors.
 * Deprecate recursive_render(). Use render() or _render_item().

More about the internals:
 * Late-binds a node's 'children' array.
 * Eliminates the root property, leverages a 'root' node.
 * Splits render() into _bind() and _render(), both protected and finalized.

Fixes #19371.


git-svn-id: https://develop.svn.wordpress.org/trunk@19501 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 00:25:04 +00:00
Daryl Koopersmith fffc2eee5c Print title attributes for linkless toolbar items. see #19277.
git-svn-id: https://develop.svn.wordpress.org/trunk@19499 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-30 23:59:10 +00:00
Andrew Ozz a13312c624 Add ARIA related attributes (first take), props DrewAPicture, see #19394
git-svn-id: https://develop.svn.wordpress.org/trunk@19484 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-30 01:27:33 +00:00
Andrew Nacin 48f128a12b Use an 'appearance' group in the admin bar. fixes #19245.
git-svn-id: https://develop.svn.wordpress.org/trunk@19434 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-23 23:01:20 +00:00
Daryl Koopersmith 4a089df74d Admin Bar: Secondary is so passé. Groups are the new black. fixes #19136.
git-svn-id: https://develop.svn.wordpress.org/trunk@19429 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-23 21:46:47 +00:00
Andrew Ozz 91431801a1 Admin bar: add class for IE9 and fix background color in search, props SergeyBiryukov, see #19151
git-svn-id: https://develop.svn.wordpress.org/trunk@19407 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-22 21:35:08 +00:00
Ryan Boren 1ae56f59eb Don't show Add New and Comments admin bar menus in network or user admins. Add tooltip to comments menu. Props ocean90. fixes #19327
git-svn-id: https://develop.svn.wordpress.org/trunk@19398 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-22 16:19:05 +00:00
Daryl Koopersmith 8d57c1e16f Slight rearrangements in admin bar render logic. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@19390 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-21 23:07:54 +00:00
Andrew Ozz 0ed396ffed Admin bar IE7, iPad and rtl refresh, see #81197
git-svn-id: https://develop.svn.wordpress.org/trunk@19368 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-21 02:03:02 +00:00
Andrew Nacin f4fe632477 Handle 'appearance' as a admin bar menu parent in a backwards compatible way. fixes #19245.
git-svn-id: https://develop.svn.wordpress.org/trunk@19365 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-20 18:39:54 +00:00
Daryl Koopersmith b9e3cf466a Allow linkless items in the admin bar. Improve non-jQuery admin bar tabbing. fixes #19277, #19149, #19164, #15519. see #18197, #19088.
git-svn-id: https://develop.svn.wordpress.org/trunk@19328 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-18 00:12:57 +00:00
Daryl Koopersmith 0ebb52f9a3 More admin bar markup improvements. Make primary and secondary submenu groups siblings (and prevent ul nesting issues). see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@19270 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-14 11:05:37 +00:00
Daryl Koopersmith 161ee6a46d Improve admin bar markup. Un-nest top level secondary menu. Remove unnecessary span. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@19261 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-12 00:26:55 +00:00
Daryl Koopersmith 49e85592f0 Add general top-level class to the secondary admin menu. Fixes hover styling and tabbing JS. fixes #19220.
git-svn-id: https://develop.svn.wordpress.org/trunk@19248 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-10 20:46:29 +00:00
Andrew Nacin fb32b677e2 Promote secondary admin bar items to primary if there are no primary items at time of render. see #19136, #19221.
git-svn-id: https://develop.svn.wordpress.org/trunk@19236 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-10 00:42:39 +00:00
Daryl Koopersmith 716906a149 Add secondary flag to admin bar. fixes #19136.
git-svn-id: https://develop.svn.wordpress.org/trunk@19230 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-09 19:12:48 +00:00
Andrew Ozz b1af3610ec Fix a:focus styling and backwards tabbing, add tabindex arg for <a>, see #19088
git-svn-id: https://develop.svn.wordpress.org/trunk@19207 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-07 20:38:38 +00:00
Andrew Ozz bf02e004e0 Support for "tabbing" through the admin bar and admin menu, fixes #19088
git-svn-id: https://develop.svn.wordpress.org/trunk@19162 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-05 01:13:18 +00:00
Ryan Boren 242b3f48e4 If an empty menu ID is passed, derive it from the title and issue a _doing_it_wrong() notice. see #18197
git-svn-id: https://develop.svn.wordpress.org/trunk@19158 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-04 17:41:38 +00:00
Andrew Ozz 882574b78c Revert placement of Help and Screen Options to under the admin bar on the right, see #18197, see #18785
git-svn-id: https://develop.svn.wordpress.org/trunk@19130 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-03 17:08:12 +00:00
Daryl Koopersmith e2a62a3134 Improve admin bar internal representation. Simpler signatures, with backwards compatibility. Add items without requiring parents to be added first. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@19120 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-02 20:34:54 +00:00
Daryl Koopersmith 9bf6d8e25f Improve admin bar item order for W menu, add new menu, and edit content item. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@18927 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-10 18:40:00 +00:00
Daryl Koopersmith e33486dbb6 Clean up the 'Site Name' admin bar functions.
git-svn-id: https://develop.svn.wordpress.org/trunk@18919 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-07 19:52:26 +00:00
Daryl Koopersmith e7ab67e395 Adjust admin bar item order. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@18898 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-06 00:02:18 +00:00
Daryl Koopersmith c9e4b0fcb9 Revise admin bar items based on user testing. Post at http://wp.me/pbNCB-qz. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@18888 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-05 18:45:32 +00:00
Daryl Koopersmith a7767fbcec Second pass, admin bar overhaul. see #18197.
git-svn-id: https://develop.svn.wordpress.org/trunk@18776 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-25 23:30:40 +00:00
Peter Westwood 1688cde0e2 Remove the unimplemented user locale code in the admin bar until we actually implement it for real.
git-svn-id: https://develop.svn.wordpress.org/trunk@18690 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-16 11:12:37 +00:00
Peter Westwood 44821916ca We don't need to do this if the user isn't logged in.
git-svn-id: https://develop.svn.wordpress.org/trunk@18688 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-16 10:56:06 +00:00
Daryl Koopersmith e1038932b9 Admin bar UX improvements. First pass, see #18197
git-svn-id: https://develop.svn.wordpress.org/trunk@18683 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-16 05:01:54 +00:00
Andrew Nacin 5464b1abc2 Some more class instantiations. props eko-fr, fixes #18049.
git-svn-id: https://develop.svn.wordpress.org/trunk@18563 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-18 06:16:57 +00:00
Andrew Ozz 804284c665 Admin bar: use jQuery if loaded to improve UX, fixes #18299
git-svn-id: https://develop.svn.wordpress.org/trunk@18488 602fd350-edb4-49c9-b593-d223f7449a82
2011-07-29 22:57:30 +00:00
Andrew Nacin e59cd1d706 'Dashboard' should be to the right of 'My Sites' for visual hierarchy reasons. see #17705.
git-svn-id: https://develop.svn.wordpress.org/trunk@18284 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-12 02:47:02 +00:00