Commit Graph

37566 Commits

Author SHA1 Message Date
Weston Ruter ea5fb388da WordPress 4.9 Beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@41938 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 04:42:28 +00:00
Joe McGill 2cce6bb55a Customizer: Improve handling of crops in the media library.
This is a follow up on r41732, implementing the following improvements:

* Attachment parent info is now stored in attachment meta rather than a 
separate post meta key.
* Attachments created from contextual crops (e.g. header, logos, etc.) are
filtered out of the media library using a new `_filterContext` method in
`wp.media.controller.Library`.

Props joemcgill, westonruter.
See #21819.


git-svn-id: https://develop.svn.wordpress.org/trunk@41937 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 04:17:31 +00:00
Weston Ruter aac833887e Customize: Consistently use `input_attrs` as control param key in JS instead of `inputAttrs`.
See #30738, #41897.


git-svn-id: https://develop.svn.wordpress.org/trunk@41936 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 03:24:20 +00:00
Weston Ruter 1c04006909 Customize: Move control's fallback selection of default content template to `renderContent` method to align with sections and panels.
* Only use default control content template when a more specific template doesn't exist.
* Remove extraneous whitespace from being output in `WP_Customize_Control::render()` method.
* Move Custom Header template printing to `customize_controls_print_footer_scripts` action.

See #30738.


git-svn-id: https://develop.svn.wordpress.org/trunk@41935 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 03:03:19 +00:00
Sergey Biryukov b1f20b6763 I18N: Unify permission error message in `wp-admin/ms-delete-site.php`.
Props ramiy.
Fixes #42268.

git-svn-id: https://develop.svn.wordpress.org/trunk@41934 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 00:47:15 +00:00
Weston Ruter 0421a2b0a4 Widgets: Harden logic for checking for valid media URLs.
* Update deprecated `isHostedVideo` method to always return `true` since all oEmbeds are now supported.
* Disable `scanImage` for non-image media widgets.
* Ensure embed URL field element is matched from current media frame instance due to bug where media frames are not destroyed upon closing.
* Update error message for invalid video URLs to ask user to check the URL for validity.

Props gk.loveweb, octalmage, westonruter.
See #42039, #40935.
Fixes #41052.


git-svn-id: https://develop.svn.wordpress.org/trunk@41933 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-19 00:06:25 +00:00
westonruter 285be53824 Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.
Props bpayton, westonruter.
See #42114, #39896.
Fixes #42211.


git-svn-id: https://develop.svn.wordpress.org/trunk@41932 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 23:05:02 +00:00
Sergey Biryukov 3ce1938687 Dashboard: Add missing URL to "Help with testing" link in Gutenberg callout.
See #41316.

git-svn-id: https://develop.svn.wordpress.org/trunk@41931 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 22:40:42 +00:00
Weston Ruter 1c521e35c5 Customize: Draw attention to "Add Items" button after creating a new menu.
Introduce `wp.customize.utils.highlightButton()` and `wp.customize.Menus.MenuSection#highlightNewItemButton()`.

Props bpayton, melchoyce, afercia, westonruter.
Fixes #42114.


git-svn-id: https://develop.svn.wordpress.org/trunk@41930 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:59:34 +00:00
Sergey Biryukov 66f9609763 Build/Test Tools: Clean up `$_REQUEST` and `$GLOBALS` after modifying them in `_test_list_hierarchical_page()`.
Props birgire.
Fixes #42044.

git-svn-id: https://develop.svn.wordpress.org/trunk@41929 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:47:39 +00:00
Sergey Biryukov 40706838a1 Rewrite Rules: Remove redundant `if` condition in `extract_from_markers()`.
Props Dency, yahil, appchecker.
Fixes #39920.

git-svn-id: https://develop.svn.wordpress.org/trunk@41928 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:27:22 +00:00
Sergey Biryukov 6426b0b400 I18N: Unify error messages in XML-RPC methods `wp_deleteCategory()` and `wp_deleteComment()`.
Props ramiy.
Fixes #39019.

git-svn-id: https://develop.svn.wordpress.org/trunk@41927 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:11:47 +00:00
Sergey Biryukov ac8bc46b09 Administration: After [41120], check for a registered action before sending a Bad Request HTTP response status code.
Props Clorith.
Fixes #42240.

git-svn-id: https://develop.svn.wordpress.org/trunk@41926 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 21:00:39 +00:00
Sergey Biryukov adfa4cd450 Menus: Remove unnecessary top margin for menu item type on Menus screen for correct alignment with the dropdown icon.
Props punit5658.
Fixes #41521.

git-svn-id: https://develop.svn.wordpress.org/trunk@41925 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 20:51:23 +00:00
Sergey Biryukov a8518be72b Network Admin: After [41923], move the second `<p>` tag to a new line for better readability.
See #41652.

git-svn-id: https://develop.svn.wordpress.org/trunk@41924 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 20:50:58 +00:00
Sergey Biryukov 76c2aa8c85 I18N: Remove hardcoded constant from a translatable string in `network_step1()`.
Props ramiy.
Fixes #41652.

git-svn-id: https://develop.svn.wordpress.org/trunk@41923 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 20:01:36 +00:00
Sergey Biryukov 6561981976 Docs: Document `$ini_all` staticvar in `wp_is_ini_value_changeable()`.
Props nileshdudakiya94.
Fixes #41399.

git-svn-id: https://develop.svn.wordpress.org/trunk@41922 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 19:53:40 +00:00
Sergey Biryukov beeb0acd94 I18N: Combine two "Warning" strings in `network_step1()` and `network_step2()`.
Props ramiy.
Fixes #38570.

git-svn-id: https://develop.svn.wordpress.org/trunk@41921 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 19:49:17 +00:00
Sergey Biryukov dcb6ef8aa4 Date/Time: Use delta comparison in `get_gmt_from_date()` tests to avoid race conditions.
Props keesiemeijer.
Fixes #38815.

git-svn-id: https://develop.svn.wordpress.org/trunk@41920 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 19:41:46 +00:00
Weston Ruter 349ccdf2d7 Customize: Fix visibility of overlay notifications in Safari.
Props sayedwp, westonruter.
Amends [41390].
See #35210, #42024, #42052.


git-svn-id: https://develop.svn.wordpress.org/trunk@41919 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:12:29 +00:00
Felix Arntz 4124fbfa7c Multisite: Document all return types in get_networks().
Adds more complete documentation to get_networks() and the corresponding methods in WP_Network_Query.

Fixes #42260.


git-svn-id: https://develop.svn.wordpress.org/trunk@41918 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:12:20 +00:00
SergeyBiryukov a540d91f8f Docs: Document `$default_scripts` parameter in `_WP_Editors::enqueue_scripts()`.
Props danieltj, ajayghaghretiya1.
Fixes #41322.

git-svn-id: https://develop.svn.wordpress.org/trunk@41917 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:08:02 +00:00
Sergey Biryukov 88a6ebaa75 Plugins: Revert unintended change from [41915].
See #37430.

git-svn-id: https://develop.svn.wordpress.org/trunk@41916 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 18:00:54 +00:00
Sergey Biryukov 93a3fa4506 Plugins: After [41608], make the markup in `WP_Plugin_Install_List_Table::no_items()` a bit more readable.
See #37430.

git-svn-id: https://develop.svn.wordpress.org/trunk@41915 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:58:00 +00:00
Sergey Biryukov dca34e10d5 Docs: Add `@since` entry for `WP_Automatic_Updater::after_core_update()`, introduced in [25841].
See #41017, #29086.

git-svn-id: https://develop.svn.wordpress.org/trunk@41914 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:47:34 +00:00
Weston Ruter a7c6a25eba Widgets: Fix previewing embeds in Text widget by allowing `parse-embed` admin ajax requests with an empty `post_ID` just as `WP_oEmbed_Controller::get_proxy_item_permissions_check()` allows.
As of #34115 if there is no post context the oEmbed will be cached in an `oembed_cache` custom post type, so having a post as context is no longer a requirement for caching.

Props biskobe, westonruter.
See #34115, #40450.
Fixes #40854.


git-svn-id: https://develop.svn.wordpress.org/trunk@41913 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:39:46 +00:00
Jeremy Felt d4bdbbf542 Multisite: Document all return types in `get_sites()`.
Adds more complete documentation to `get_sites()` and the corresponding methods in `WP_Site_Query`.

Fixes #41789.


git-svn-id: https://develop.svn.wordpress.org/trunk@41912 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:38:35 +00:00
Sergey Biryukov d3df7a6a18 I18N: Remove `<a>` tag from a translatable string in `confirm_another_blog_signup()`.
Props ramiy.
Fixes #41694.

git-svn-id: https://develop.svn.wordpress.org/trunk@41911 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:35:55 +00:00
Sergey Biryukov aa3e40c32c I18N: Remove `<b>` tag from a translatable string in `post_submit_meta_box()`.
Props ramiy.
Fixes #41681.

git-svn-id: https://develop.svn.wordpress.org/trunk@41910 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:30:35 +00:00
Sergey Biryukov c7e02480bb I18N: Remove `<strong>` tag from a translatable string in `Theme_Upgrader::install_strings()`.
Props ramiy.
Fixes #41695.

git-svn-id: https://develop.svn.wordpress.org/trunk@41909 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:19:21 +00:00
Sergey Biryukov 8aaf0aa4bc I18N: Remove `<code>` tags from translatable strings in `Core_Upgrader`, `Language_Pack_Upgrader`, `Plugin_Upgrader`, `Theme_Upgrader`.
Props ramiy.
Fixes #41705.

git-svn-id: https://develop.svn.wordpress.org/trunk@41908 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 17:14:58 +00:00
Sergey Biryukov cb3abb4abc Docs: Correct type and description for the `$data` parameter in `WP_Http::browser_redirect_compatibility()`.
Fixes #41380.

git-svn-id: https://develop.svn.wordpress.org/trunk@41907 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 16:37:08 +00:00
Sergey Biryukov 129c9f42da I18N: Replace hardcoded file name in a translatable string in `convert_to_screen()` with a placeholder.
Props ramiy.
Fixes #41668.

git-svn-id: https://develop.svn.wordpress.org/trunk@41906 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:45:48 +00:00
Sergey Biryukov 1cc00439ae I18N: Make context for "Schedule" string added in [41898] more accurate.
Props ocean90.
Fixes #42165.

git-svn-id: https://develop.svn.wordpress.org/trunk@41905 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:38:27 +00:00
Sergey Biryukov facb2fe0ea I18N: Replace hardcoded file name in translatable strings in `wp-admin/setup-config.php` with a placeholder.
Props ramiy, danieltj.
Fixes #42161.

git-svn-id: https://develop.svn.wordpress.org/trunk@41904 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:26:10 +00:00
Konstantin Obenland e27c43d386 Customize: Unstick filter pane in Theme selector
Prevents the filter pane from blocking the view of theme search results when it's open.
Users are now able to just scroll to view results.

Props rclations.
Fixes #42212.


git-svn-id: https://develop.svn.wordpress.org/trunk@41903 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:10:19 +00:00
Sergey Biryukov c2db3e5baf Embeds: Avoid "Division by zero" warning in `embed-content.php` template if a thumbnail has a zero height.
Props stevenlinx, aegis123.
Fixes #40931.

git-svn-id: https://develop.svn.wordpress.org/trunk@41902 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:08:58 +00:00
Sergey Biryukov 55dd1738fd I18N: Replace function name in error message in `WP_Http_Curl::request()` and `WP_Http_Streams::request()` with a placeholder.
Props ramiy.
Fixes #41666.

git-svn-id: https://develop.svn.wordpress.org/trunk@41901 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 15:03:07 +00:00
Gary Pendergast 3afcaa1374 Dashboard: Ensure the "Dismiss" button on the Gutenberg callout is clickable.
Who likes z-index? We like z-index!

Props joemcgill.
See #41316.




git-svn-id: https://develop.svn.wordpress.org/trunk@41900 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 14:54:39 +00:00
Konstantin Obenland 043609bca4 Customize: Allow menu creation in locations pane
Adds a link to the menu creation workflow from the locations selector in the nav menu control.

Props bpayton, westonruter, Travel_girl, melchoyce, celloexpressions.
Fixes #36279.


git-svn-id: https://develop.svn.wordpress.org/trunk@41899 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 14:50:34 +00:00
Sergey Biryukov f2d01f25ba I18N: Add a context for "Schedule" string.
Props Mirucon.
Fixes #42165.

git-svn-id: https://develop.svn.wordpress.org/trunk@41898 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 14:44:07 +00:00
Mel Choyce 6f326e407d Code Editors: Fix display of "help" cursor.
Props studionashvegas .
Fixes #42210.


git-svn-id: https://develop.svn.wordpress.org/trunk@41897 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 13:10:16 +00:00
Gary Pendergast 65585359c3 Dashboard: Remove a rogue comma introduced in [41895].
See #41316.



git-svn-id: https://develop.svn.wordpress.org/trunk@41896 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 12:39:00 +00:00
Gary Pendergast 5fa59cf197 Dashboard: Introduce a "Try Gutenberg" callout.
To encourage more people to try Gutenberg, this new Dashboard box allows site users to easily install and try out Gutenberg.

Props pento, melchoyce, joen, karmatosed.
Fixes #41316.



git-svn-id: https://develop.svn.wordpress.org/trunk@41895 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 10:03:39 +00:00
Weston Ruter 896db16fc7 Customize: Add missing filter docs in `WP_Customize_Nav_Menu_Item_Setting::sanitize()`.
Props dlh.
Fixes #42257.


git-svn-id: https://develop.svn.wordpress.org/trunk@41894 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 04:56:10 +00:00
Weston Ruter 18057a93a2 Customize: Improve theme browsing UI on small screens.
Props Mahvash-Fatima, melchoyce, celloexpressions.
See #37661.
Fixes #42215.


git-svn-id: https://develop.svn.wordpress.org/trunk@41893 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 04:05:03 +00:00
Weston Ruter 92f9610907 Customize: Remove incorrect test assertions for the `post_date` of customization drafts.
Amends [41887].
See #42220.


git-svn-id: https://develop.svn.wordpress.org/trunk@41892 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 02:40:27 +00:00
Weston Ruter 39031f5b5c Media: Add missing `mediaelement-migrate.js` script to get uglified.
Amends [41877].
See #42189, #39686.


git-svn-id: https://develop.svn.wordpress.org/trunk@41891 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 02:25:06 +00:00
Weston Ruter 6c6fe52a8d Widgets: Use a `foreach` loop instead of The Loop to iterate over posts in Recent Posts widget to avoid needing to reset a polluted global `$post`.
Props welcher, westonruter.
Amends [14607].
See #12320.
Fixes #37312.


git-svn-id: https://develop.svn.wordpress.org/trunk@41890 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 00:34:01 +00:00
Weston Ruter 9bca555920 Media: Use user locale as ME.js language in admin and add `mejsL10n` inline script before `mediaelement-core` so WP-exported translation strings are used.
See #39686.
Fixes #42241.


git-svn-id: https://develop.svn.wordpress.org/trunk@41889 602fd350-edb4-49c9-b593-d223f7449a82
2017-10-18 00:07:30 +00:00