Commit Graph

40701 Commits

Author SHA1 Message Date
Sergey Biryukov
eabc288f67 Bundled Themes: Update Twenty Twenty.
* Add `.has-background` excluding condition to wide and full group-blocks.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46714], see 162edc0...fa8c3fc.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46715 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 02:04:14 +00:00
Sergey Biryukov
732a358f61 Bundled Themes: Update Twenty Twenty.
* Add a11y-friendly default text-colors when selecting a background-color.
* Remove margins for the group block when a background-color is set.
* Excluding pullquote block from width resize rules.

This brings Twenty Twenty in sync with GitHub. For a full list of changes since [46711], see ab5fa23...162edc0.

Props allancole, karmatosed.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46713 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-12 01:42:20 +00:00
Sergey Biryukov
14df1712fd Twenty Twenty: Make CSS adjustments to account for the latest editor changes and ensure that group blocks work in expected ways.
Props williampatton, allancole, karmatosed, pierlo, joen, ianbelanger.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46711 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 20:54:49 +00:00
Sergey Biryukov
895ec7224b Help/About: Update the 5.3 About page.
* Remove extra padding on the Credits tab.

Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46709 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 20:43:48 +00:00
Jake Spurlock
91312ab695 Tests: Fix a typo in an inline comment.
Fix a regression from [46568].

Props david.binda.
See #48312.


git-svn-id: https://develop.svn.wordpress.org/trunk@46707 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 18:48:06 +00:00
Sergey Biryukov
385d0794ae Help/About: Update the 5.3 About page.
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.

Previously [46556], [46572], [46616].

Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708.

git-svn-id: https://develop.svn.wordpress.org/trunk@46705 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 16:05:39 +00:00
Sergey Biryukov
e4edcf9845 Script Loader: In wp_default_packages_inline_scripts(), make sure the root URL middleware is registered before using the media middleware.
This allows for requests to retry post-processing large images using the `post-process` REST API endpoint to work as expected.

Props azaozz, mikeschroder, TimothyBlynJacobs, epiqueras, johnbillion, youknowriad.
Fixes #48542.

git-svn-id: https://develop.svn.wordpress.org/trunk@46703 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 15:08:43 +00:00
Sergey Biryukov
fdeb2ff358 Twenty Twenty: Fix WPCS issue in [46701].
See #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46702 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 12:57:54 +00:00
Sergey Biryukov
41a47a0168 Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC4, see c267289...898792b.

Props williampatton, poena, andersnoren, desrosj, schlessera, leprincenoir, alextran, aristath, b-07.
See #48110, #48386, #48450, #48505.
Fixes #48557.

git-svn-id: https://develop.svn.wordpress.org/trunk@46701 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 12:27:21 +00:00
Sergey Biryukov
ae487b5f67 Comments: Check if comment form element exists before adding a key handler to detect the cmd/ctrl-enter key press.
Follow-up to [45790].

Props raamdev.
Fixes #48543. See #41545.

git-svn-id: https://develop.svn.wordpress.org/trunk@46700 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 11:49:29 +00:00
Sergey Biryukov
1ee0c8e54f Customize: Remove the deprecated -precomposed suffix from apple-touch-icon link in wp_site_icon().
Props mukto90, khag7.
Fixes #48555.

git-svn-id: https://develop.svn.wordpress.org/trunk@46698 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 09:58:17 +00:00
Sergey Biryukov
188f809598 Networks and Sites: Pass the $blog_id parameter to the newblog_notify_siteadmin filter.
Props mukto90, virgodesign.
Fixes #48554.

git-svn-id: https://develop.svn.wordpress.org/trunk@46697 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 09:51:09 +00:00
Sergey Biryukov
cde71eed52 Docs: In various @return tags, list the expected type first, instead of WP_Error.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46696 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 02:41:15 +00:00
Sergey Biryukov
63a534030e Docs: Miscellaneous docblock corrections in wp-admin/includes/plugin.php.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46695 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-11 00:03:53 +00:00
Sergey Biryukov
84540ab336 Docs: Improve documentation for deactivate_plugins() and activate_plugins().
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352.

git-svn-id: https://develop.svn.wordpress.org/trunk@46694 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 23:03:34 +00:00
Sergey Biryukov
1b82ea8284 Tests: Don't skip the tests intended for Multisite when running on single site, add them to the ms-required group instead.
See #43438.

git-svn-id: https://develop.svn.wordpress.org/trunk@46693 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:53:17 +00:00
Sergey Biryukov
a31133173d Coding Standards: Fix WPCS issue in [46690].
See #41880.

git-svn-id: https://develop.svn.wordpress.org/trunk@46692 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:43:55 +00:00
Sergey Biryukov
a9b3e85dd3 Docs: Move the @link tag for Customize API in WP_Customize_Manager::add_setting() and WP_Customize_Setting to a more appropriate place.
See #48303.

git-svn-id: https://develop.svn.wordpress.org/trunk@46691 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:41:43 +00:00
Sergey Biryukov
99132f8abc Docs: Improve documentation for WP_Http per the documentation standards.
Props hareesh-pillai, adnan.limdi, isabel_brison.
Fixes #41880.

git-svn-id: https://develop.svn.wordpress.org/trunk@46690 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-10 01:17:00 +00:00
Sergey Biryukov
00aff3a706 Docs: Use 3-digit, x.x.x style semantic versioning for $version argument in do_action_deprecated() and apply_filters_deprecated() calls.
Props jrf.
Fixes #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46689 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:55:43 +00:00
Sergey Biryukov
67e82bc32a Docs: Correct the documentation placement for wp_print_styles and shortcode_atts_{$shortcode} hooks.
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46688 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:41:29 +00:00
Sergey Biryukov
36994ef153 Coding Standards: Fix WPCS issue in [46684].
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46687 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:31:07 +00:00
Sergey Biryukov
51d64085dc Coding Standards: Revert the change to wp-includes/class-wp-xmlrpc-server.php in [46684] to investigate unit test failures.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46686 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:29:14 +00:00
Sergey Biryukov
26dec96b21 Docs: Use the {@see ...} tag for the replacement in @deprecated tags, so that Developer Reference could automatically link to the replacement.
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46685 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 13:03:02 +00:00
Sergey Biryukov
ae2ebb8b18 Coding Standards: Consistently use do_action_deprecated() and apply_filters_deprecated() for deprecated hooks.
Props jrf.
See #48255.

git-svn-id: https://develop.svn.wordpress.org/trunk@46684 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 12:57:27 +00:00
Sergey Biryukov
243d1a2e38 Test: Don't skip the tests intended for single site when running on Multisite, add them to the ms-excluded group instead.
See #39776, #45747.

git-svn-id: https://develop.svn.wordpress.org/trunk@46683 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 03:44:51 +00:00
Sergey Biryukov
fcf86b80b6 Tests: Skip test_readme() if the HTTP request to secure.php.net or dev.mysql.com failed on timeout.
Move `skipTestOnTimeout()` to `WP_UnitTestCase_Base` to avoid duplication.

See #44613.

git-svn-id: https://develop.svn.wordpress.org/trunk@46682 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 03:36:19 +00:00
Sergey Biryukov
9b1fc27c3f Docs: Correct some inconsistencies in comments with Dashicon class references in wp-admin/css/customize-widgets.css.
Prepend all class name references with `dashicons-` for clarity.

Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417.

git-svn-id: https://develop.svn.wordpress.org/trunk@46681 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-09 00:01:40 +00:00
Sergey Biryukov
4a73b562a3 Docs: Correct description for $recursive parameter of ::chmod() and ::delete() methods in WP_Filesystem implementations.
Props skithund.
Fixes #48422.

git-svn-id: https://develop.svn.wordpress.org/trunk@46679 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-08 22:54:33 +00:00
John Blackbourn
a216b6d838 Toolbar: Un-deprecate the WP_Admin_Bar::add_menu() method.
This is only a wrapper for the `add_node()` method, but it's in widespread use both in core until [46642] and in thousands of plugins and themes. Deprecating it would have made sense when #19647 was originally opened but that's no longer the case.

Props whyisjake

Fixes #19647 


git-svn-id: https://develop.svn.wordpress.org/trunk@46678 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-08 13:17:35 +00:00
Andrew Ozz
698aa0e564 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in wp_get_missing_image_subsizes(). Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
Props desrosj, azaozz.
Fixes #48518 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46677 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-07 18:49:17 +00:00
Jonathan Desrosiers
3dca77e628 Bundled Themes: Standardize the Required PHP and Tested Up To headers.
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Fixes #48517.

git-svn-id: https://develop.svn.wordpress.org/trunk@46676 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-07 15:17:02 +00:00
Sergey Biryukov
4185cf789a Docs: Make @param tags in mce_buttons and related filters consistent with the variable names.
Props upadalavipul, isabel_brison.
Fixes #41456.

git-svn-id: https://develop.svn.wordpress.org/trunk@46675 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-07 07:10:38 +00:00
Sergey Biryukov
75f82d8bc2 Tests: Properly mark test_submenu_helpers_priority() as skipped for multisite, so it's not categorized as "risky".
See #39776.

git-svn-id: https://develop.svn.wordpress.org/trunk@46674 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-06 01:15:11 +00:00
Sergey Biryukov
9c3319de66 Coding Standards: Fix WPCS issues in [46670].
See #48145.

git-svn-id: https://develop.svn.wordpress.org/trunk@46671 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 23:17:01 +00:00
John Blackbourn
bd2130f367 REST API: Use explicit dates in a post ordering test to avoid indeterminate ordering.
See #48145


git-svn-id: https://develop.svn.wordpress.org/trunk@46670 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 22:39:37 +00:00
Jonathan Desrosiers
560b682e3c Bundled Themes: Update Twenty Twenty.
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.

git-svn-id: https://develop.svn.wordpress.org/trunk@46668 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 22:20:52 +00:00
Jonathan Desrosiers
1842040204 Emoji: Upgrade Twemoji to 12.1.3.
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.

Props matstars, desrosj, Otto42, pento.
Fixes #48293.

git-svn-id: https://develop.svn.wordpress.org/trunk@46665 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 22:02:03 +00:00
John Blackbourn
ed4b67b17e Block Editor: Revert [46663] which was itself an erroneous revert.
See #48502


git-svn-id: https://develop.svn.wordpress.org/trunk@46664 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 21:57:47 +00:00
John Blackbourn
afecdb29c5 Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
Merges [46656] to the 5.3 branch.
Fixes #48502


git-svn-id: https://develop.svn.wordpress.org/trunk@46663 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 21:51:30 +00:00
John Blackbourn
46581088d5 Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46662 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 21:28:51 +00:00
John Blackbourn
3cdee7a705 Docs: Further improve documentation of known return types, plus other docs fixes.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46661 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 21:25:53 +00:00
John Blackbourn
db4f746b4a Docs: Improve documentation of known return types, plus other docs fixes.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46660 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 21:21:46 +00:00
Andrew Ozz
63d4dcd10a Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image.
Props ianmjones, azaozz.
Fixes #48453 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@46658 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 20:51:12 +00:00
Sergey Biryukov
4a729f0498 REST API: Speed up pagination unit tests by creating less fixtures and reusing them where possible.
Includes minor documentation and code layout fixes for better readability.

See #30017, #48145.

git-svn-id: https://develop.svn.wordpress.org/trunk@46657 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 20:41:12 +00:00
Jorge Costa
4cee80b682 Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
The list of included fixes is:

https://github.com/WordPress/gutenberg/pull/18183
https://github.com/WordPress/gutenberg/pull/18194
https://github.com/WordPress/gutenberg/pull/18230
https://github.com/WordPress/gutenberg/pull/18275
https://github.com/WordPress/gutenberg/pull/18287

Updated packages:
 - @wordpress/block-editor@3.2.4
 - @wordpress/block-library@2.9.5
 - @wordpress/edit-post@3.8.5
 - @wordpress/editor@9.7.5
 - @wordpress/format-library@1.9.4

Props @aduth, @mcsf, @youknowriad, @johnbillion.
Fixes #48502.

git-svn-id: https://develop.svn.wordpress.org/trunk@46656 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 19:34:07 +00:00
Jake Spurlock
969285d54b REST API: Fix for Yoda condition.
Little coding standards fix for the REST API.

Props mukesh27, spenserhale.

Fixes #48337.


git-svn-id: https://develop.svn.wordpress.org/trunk@46654 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-05 17:36:31 +00:00
John Blackbourn
f6cb28a6a2 Docs: Correct and improve the readability of some parameters of WP_Term_Query.
See #48303


git-svn-id: https://develop.svn.wordpress.org/trunk@46652 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-04 17:48:55 +00:00
Andrew Ozz
9ed5e8c9f7 Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it.
See #48472.

git-svn-id: https://develop.svn.wordpress.org/trunk@46651 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-04 17:05:53 +00:00
Sergey Biryukov
20165c2ffb Login and Registration: Simplify the test for wp_signon() added in [46640].
Make sure it actually tests the change in behavior, previously it passed both before and after the patch.

Add `wp_unslash()` to the last remaining instance of `$_POST['user_login']` that didn't have it.

See #38744.

git-svn-id: https://develop.svn.wordpress.org/trunk@46650 602fd350-edb4-49c9-b593-d223f7449a82
2019-11-04 15:04:41 +00:00