158 Commits

Author SHA1 Message Date
Scott Taylor
16a58e34a2 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming.
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:38:23 +00:00
John Blackbourn
2d3568380b Remove some unnecessary abstraction introduced in [28191]. See #27985.
git-svn-id: https://develop.svn.wordpress.org/trunk@28194 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 11:54:31 +00:00
johnbillion
34b0686be1 Avoid an expensive attachment counting query on the post editing screen. See #27985, for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28191 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-23 22:04:03 +00:00
Drew Jaynes (DrewAPicture)
d2e679179b Part II of inline documentation for hooks in wp-includes/post.php.
Documents all remaining hooks following [28041] and [28042]. Also updates the hash notation style for `wp_insert_post()`.

Props nacin for several hook descriptions.

Fixes #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28106 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 23:05:20 +00:00
Drew Jaynes (DrewAPicture)
54e59a0290 Clarify documentation for hooks in sanitize_post_field().
* `edit_post_{$field}` pairs with `edit_{$field}`
* `pre_post_{$field}` pairs with `pre_{$field}`
* `post_{$field}` pairs with `{$field}`

As the above pairs' docs are unnecessarily duplicative, the second sets of docs have been removed. Also, the "duplicates" are purposely not marked as such in this case as the hook names differ. Also remove `@deprecated` tags mistakenly left in in [28041].

See #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28042 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 07:40:30 +00:00
Drew Jaynes (DrewAPicture)
a3d04ec9ed Part I of inline documenation for hooks in wp-includes/post.php.
Adds docs for the following hooks:
* `get_attached_file`
* `update_attached_file`
* `_wp_relative_upload_path`
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `edit_post_{$field}`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `pre_post_{$field}`
* `{$field}_pre`
* `$field`
* `post_{$field}`
* `wp_count_posts`
* `wp_count_attachments`
* `post_mime_types`
* `wp_insert_post_empty_content`

See #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28041 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 06:48:32 +00:00
Drew Jaynes (DrewAPicture)
01ecedbb0d Fix the wp_count_attachments() PHPDoc to reflect that it returns an object, not array.
See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@27807 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 05:42:49 +00:00
Scott Taylor
115f291221 Use wp_parse_id_list() when parsing exclude_tree in get_pages(). Add unit tests to ensure a URL string, array with string as value, and array with array as value for exclude_tree can be used to specify multiple IDs.
Props cgaffga, roothorick, hakre, tbrams for patches across the years.
Fixes #9153.



git-svn-id: https://develop.svn.wordpress.org/trunk@27767 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 01:17:41 +00:00
Helen Hou-Sandi
ccc5f363c0 Use Dashicon-style images for mime type icons. Actually moving to Dashicons via the font can be explored later, but has theme/plugin implications and requires too many changes to make it for 3.9. props melchoyce for the icons. fixes #26650.
git-svn-id: https://develop.svn.wordpress.org/trunk@27726 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-25 21:09:34 +00:00
Scott Taylor
0697544056 Turn on thumbnail support for attachment:audio and attachment:video. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin.
Fixes #27460.



git-svn-id: https://develop.svn.wordpress.org/trunk@27657 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-23 02:34:39 +00:00
Drew Jaynes
5fde82be76 Better standardize parameter value types in PHPDocs where both a post ID or WP_Post would be acceptable.
Covers cases where previously only `int` or `int|object` types were notated.

Props coffee2code for the original patch.
See #20495.


git-svn-id: https://develop.svn.wordpress.org/trunk@27473 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 19:31:51 +00:00
Andrew Nacin
928a972fb5 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context.
see #13265.


git-svn-id: https://develop.svn.wordpress.org/trunk@27470 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-08 04:18:30 +00:00
John Blackbourn
54ea3a0cfd Allow get_page_by_path() and get_page_by_title() to accept an array of post types. Fixes #24763. Props zbtirrell.
git-svn-id: https://develop.svn.wordpress.org/trunk@27423 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 22:25:31 +00:00
Andrew Nacin
6a35efe1e5 Revert [27115] and let cache backends handle the stripping of spaces in cache keys as necessary.
microtime() returns greater precision than microtime(true).

see #27000, #23448, #26903, #14485.


git-svn-id: https://develop.svn.wordpress.org/trunk@27300 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-26 22:04:52 +00:00
Drew Jaynes
647f80595d Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core.
See #27200.


git-svn-id: https://develop.svn.wordpress.org/trunk@27262 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-25 17:13:08 +00:00
Sergey Biryukov
013a4e3381 Correct return values for update_metadata() and related functions.
fixes #21864.

git-svn-id: https://develop.svn.wordpress.org/trunk@27191 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-18 21:35:07 +00:00
Drew Jaynes
75c028e042 Inline documentation for the wp_insert_attachment_data filter hook, added in [27130].
Fixes #20547.


git-svn-id: https://develop.svn.wordpress.org/trunk@27138 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 22:46:25 +00:00
Scott Taylor
2238c7fb7f Add a filter wp_insert_attachment_data in wp_insert_attachment(). This is similar to the wp_insert_post_data filter in wp_insert_post().
Fixes #20547.



git-svn-id: https://develop.svn.wordpress.org/trunk@27130 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-08 00:43:16 +00:00
Andrew Nacin
4f5608f653 Use a float for last_changed microtime cache values.
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.

props _jameslee, drozdz.
fixes #27000. see #23448.


git-svn-id: https://develop.svn.wordpress.org/trunk@27115 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-07 08:13:37 +00:00
Scott Taylor
28bab15d16 Properly invalidate the cache for wp_count_posts() on insert, trash, or when transitioning post_status inside of _transition_post_status(). Introduces _count_posts_cache_key(). Adds unit tests.
Props mark8barnes, for bringing this to our attention in an initial patch.
Fixes #21879.



git-svn-id: https://develop.svn.wordpress.org/trunk@27081 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-03 19:41:40 +00:00
Drew Jaynes
2fc50487ea Improve inline documentation for add_post_type_support().
Props philiparthurmoore.
Fixes #26683.


git-svn-id: https://develop.svn.wordpress.org/trunk@26911 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-07 02:04:16 +00:00
Sergey Biryukov
0b3022708b Use correct example of a Dashicons helper class in add_menu_page() and register_post_type() docs.
props Rarst.
fixes #26617 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@26884 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-31 10:32:18 +00:00
Andrew Nacin
006045395c Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.

To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.

props helen.
fixes #25147.


git-svn-id: https://develop.svn.wordpress.org/trunk@26664 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 06:37:20 +00:00
Andrew Nacin
2ec996d812 Return false from wp_delete_post() and wp_delete_attachment() if the DELETE is unsuccessful.
This prevents attachments from being deleted off disk when a DB is locked and the delete is otherwise unsuccessful.

fixes #25107.


git-svn-id: https://develop.svn.wordpress.org/trunk@26543 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-02 22:58:40 +00:00
Scott Taylor
18a088a4e1 In get_posts(), alter the doc block and default args to make orderby equal to date, not post_date.
Props ounziw.
Fixes #26128.



git-svn-id: https://develop.svn.wordpress.org/trunk@26329 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-22 17:38:34 +00:00
Andrew Nacin
2cac0fde8a Avoid resetting the 'hierarchical' argument in get_pages() when 'parent' is -1, the default.
Fixes a regression introduced in [25270]. Adds unit tests.

props chrisbliss18.
fixes #25750.


git-svn-id: https://develop.svn.wordpress.org/trunk@25974 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-29 01:46:01 +00:00
Andrew Nacin
c87ad6023d Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.


git-svn-id: https://develop.svn.wordpress.org/trunk@25868 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-22 17:21:32 +00:00
Andrew Nacin
20686308d3 Reset "Page on Front" when such a page is trashed.
props danielbachhuber.
fixes #24171.


git-svn-id: https://develop.svn.wordpress.org/trunk@25686 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-03 03:50:26 +00:00
Dominik Schilling (ocean90)
6311fbbfdb Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372.
git-svn-id: https://develop.svn.wordpress.org/trunk@25669 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 21:09:52 +00:00
Scott Taylor
faa8c3c9ef post_content does not have a default value in the $wpdb->posts table. Add a default value of empty string to wp_insert_attachment() to avoid a tornado of database errors in PHP 5.5/MySQL 5.6, even when debug mode is turned off.
See #25282.



git-svn-id: https://develop.svn.wordpress.org/trunk@25661 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-02 19:51:57 +00:00
Drew Jaynes
f7a6959048 Improve inline documentation for wp_insert_post() by adding a hash notation.
See #25412.


git-svn-id: https://develop.svn.wordpress.org/trunk@25628 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-25 17:33:36 +00:00
Drew Jaynes
c9bf087f36 Clarify inline documentation for the return in get_attached_file().
Fixes #25409.


git-svn-id: https://develop.svn.wordpress.org/trunk@25609 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-24 21:28:35 +00:00
Andrew Nacin
17a0ace2a4 Use correct variable. props helen. see #17071.
git-svn-id: https://develop.svn.wordpress.org/trunk@25581 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-23 20:17:37 +00:00
Andrew Nacin
740bb2d494 Introduce a wp_count_attachments filter.
props kevinB.
fixes #17071.


git-svn-id: https://develop.svn.wordpress.org/trunk@25579 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-23 19:10:53 +00:00
Andrew Nacin
fbc417775d In wp_count_posts(), rename 'count_posts' hook to 'wp_count_posts', for clarity. see #16603.
git-svn-id: https://develop.svn.wordpress.org/trunk@25578 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-23 19:07:08 +00:00
Andrew Nacin
46fef6ef24 Introduce a meta_box_cb argument for register_taxonomy().
The specified callback function is used as the meta box callback for the taxonomy.

props garyc40, helen.
fixes #14206.


git-svn-id: https://develop.svn.wordpress.org/trunk@25572 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-23 17:11:09 +00:00
Scott Taylor
5a74d939ec Add hooks to wp_count_posts(). Adds filter docs. Adds unit test to test count_posts filter.
Props nacin, DrewAPicture. 
Fixes #16603.



git-svn-id: https://develop.svn.wordpress.org/trunk@25554 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-21 17:54:36 +00:00
Scott Taylor
0d6c7bbbc3 Add @access private to _get_custom_object_labels(), which was already implied by the dangling underscore. Cast $labels to array in get_taxonomy_labels() and _get_custom_object_labels().
Props nacin, foofy.
Fixes #16310.



git-svn-id: https://develop.svn.wordpress.org/trunk@25553 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-21 17:43:14 +00:00
Scott Taylor
e72ffa5d96 Move checks for post_type being an array inline. See [25291], [25292], #18614.
git-svn-id: https://develop.svn.wordpress.org/trunk@25312 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-10 03:01:10 +00:00
Scott Taylor
e688f070dc Check the value passed to get_post_type_object(). If it's an array, use the first item. get_query_var( 'post_type' ) can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests.
In `template-loader.php`, move `is_post_type_archive()` and `is_tax()` directly below `is_home()`.

See #18614, [25291].



git-svn-id: https://develop.svn.wordpress.org/trunk@25292 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 23:38:51 +00:00
Andrew Nacin
760d5825ad More adjustments and improvements for inline documentation for get_pages(). see #25186.
git-svn-id: https://develop.svn.wordpress.org/trunk@25271 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-06 01:20:17 +00:00
Scott Taylor
bd610dd68a Simplify the check for false-y child_of arg.
Props SergeyBiryukov.
See #25230, [25245].



git-svn-id: https://develop.svn.wordpress.org/trunk@25270 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 23:35:30 +00:00
Scott Taylor
d765349b75 Fix spacing in docs for get_pages().
Props DrewAPicture.
See #25186.



git-svn-id: https://develop.svn.wordpress.org/trunk@25268 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 23:20:20 +00:00
Scott Taylor
dbdc3ce528 Add docs to the woefully under-documented get_pages().
Props DrewAPicture.
Fixes #25186.



git-svn-id: https://develop.svn.wordpress.org/trunk@25266 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 22:12:17 +00:00
Scott Taylor
eb63aeff1c Add check to make sure a valid argument was passed to get_page_uri().
Props Viper007Bond.
Fixes #24491.




git-svn-id: https://develop.svn.wordpress.org/trunk@25262 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-05 21:41:48 +00:00
Scott Taylor
44011782d3 Set hierarchical to false when parent is passed to get_pages() and child_of is not.
Fixes #25230.



git-svn-id: https://develop.svn.wordpress.org/trunk@25245 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 20:59:20 +00:00
Scott Taylor
0b28c0137d Allow get_pages() to accept an array for the arg parent. Adds unit tests, some will fail until the next commit.
Fixes #9470.



git-svn-id: https://develop.svn.wordpress.org/trunk@25244 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 20:55:05 +00:00
Scott Taylor
1e0d32406d Allow int to be passed in lieu of array, add append arg to wp_set_post_categories(). Adds more extensive unit tests for wp_set_post_categories().
Props ptahdunbar for initial patch.
Fixes #16550.



git-svn-id: https://develop.svn.wordpress.org/trunk@25234 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-04 17:41:03 +00:00
Jon Cave
a0940de83d Correct rewrite tag for hierarchical post types without a query_var.
Hierarchical rewrite rules operate via the 'pagename' query variable which is
passed to get_page_by_path(). However, the current rewrite rules use the 'name'
query variable for hierarchical types without a custom query_var.

Fixes #16323.


git-svn-id: https://develop.svn.wordpress.org/trunk@25182 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-30 08:07:06 +00:00
Scott Taylor
59b9a3a6f8 No need to re-map the return values of wp_parse_id_list() to int.
See #22074, #11823.



git-svn-id: https://develop.svn.wordpress.org/trunk@25169 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-29 18:53:03 +00:00