Commit Graph

346 Commits

Author SHA1 Message Date
Scott Taylor
baf230c80f Media Grid/Modal Keyboard navigation improvements:
* Add focus to arrows on Next/Previous in the grid's modal on left/right keypress, and add the necessary CSS for `:focus`
* When in a disabled input in the grid modal, allow the left/right keys to work
* Make the image editor return a `$.Deferred` so that there isn't a race condition with UI loading. 
* Assign focus when the edit image mode is rendered so that the modal can be closed on Esc press

Props wonderboymusic, adamsilverstein (for the initial patch).
See #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@29560 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-21 02:34:23 +00:00
Dominik Schilling (ocean90)
c6e4597bbf Plugin details: Accessibility improvements
* Focus the close link to transfer focus into the plugin modal.
* Set title attribute on iframe for screereaders.

props jwenerd for initial patch and a11y team for testing.
fixes #28823.

git-svn-id: https://develop.svn.wordpress.org/trunk@29534 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 20:01:47 +00:00
Andrew Ozz
1e61bbb8f1 DFW: revert applying the Visual editor body color and background-color for now. Set the color to #333 and the background to transparent. Fixes #28330.
git-svn-id: https://develop.svn.wordpress.org/trunk@29533 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 18:22:54 +00:00
Andrew Ozz
27cd1b4f92 Editor scrolling: set max-width: 100% for the text editor clone instead of always resizing it. See #29246.
git-svn-id: https://develop.svn.wordpress.org/trunk@29524 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 01:12:31 +00:00
Andrew Ozz
dcba23a58e Editor scrolling:
- Properly handle change of sidebar height when opening, closing or hiding postboxes.
- Add a flag when to start pinning. Set it to few pixels more than the initial editor height.
See #28328

git-svn-id: https://develop.svn.wordpress.org/trunk@29523 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-18 00:34:45 +00:00
Andrew Ozz
53488d1404 Editor scrolling: always resize the text editor clone so it doesn't "push" the parent's width over 100%, fixes #29246.
git-svn-id: https://develop.svn.wordpress.org/trunk@29522 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 21:32:10 +00:00
Dominik Schilling (ocean90)
7de002f960 Admin Menu: Auto fold the menu at 960px.
This gives us some more room at the post edit screen.

props vinod dalvi for initial patch.
fixes #28592.

git-svn-id: https://develop.svn.wordpress.org/trunk@29518 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-17 14:14:09 +00:00
Helen Hou-Sandi
ee20b5a45f Editor scrolling:
* Reduce the starting height of the editor to better match the height at which the top toolbar unpins.
* Pin the side metaboxes so they do not get lost when the editor content is long.
* Turn magic numbers into variables.

props stephdau, azaozz. see #28328.



git-svn-id: https://develop.svn.wordpress.org/trunk@29495 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-15 03:16:07 +00:00
Helen Hou-Sandi
f37a0e160d Plugin details modal:
* Scroll all content, rather than the dual-pane scrolling awkwardness.
* Better align the header image and title overlay with the display on WordPress.org, at least at full-width.
* Move the close button outside of the modal itself, rather than overlay on top of colors we can't predict.

props stephdau, tellyworth, helen. fixes #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29474 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-12 23:01:38 +00:00
Scott Taylor
af851b9bda Add some docs to Customizer JS.
Props ericlewis.
See #29157.


git-svn-id: https://develop.svn.wordpress.org/trunk@29451 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-08 23:30:30 +00:00
Andrew Nacin
42f2f27267 Language chooser imporvements.
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.


git-svn-id: https://develop.svn.wordpress.org/trunk@29372 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-04 20:46:42 +00:00
Andrew Ozz
96daabb134 Editor scrolling: run one more adjust() 200ms after scroll or resize in case the browser is slow to re-calculate the element heights and pin/unpin the toolbars. See #28328, fixes #29059.
git-svn-id: https://develop.svn.wordpress.org/trunk@29352 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 21:42:03 +00:00
Dominik Schilling (ocean90)
257a3ad0e3 Disable background page scrolling when modals are open.
props celloexpressions.
fixes #29074.

git-svn-id: https://develop.svn.wordpress.org/trunk@29346 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 20:14:43 +00:00
Mark Jaquith
a46a981daa Match background color in DFW and adapt the dashed outline color.
fixes #28330. props avryl, ipstenu.

git-svn-id: https://develop.svn.wordpress.org/trunk@29340 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 18:09:47 +00:00
Andrew Ozz
c94edd08bd Editor scrolling:
- Add a Screen Option to turn it on/off, and on()/off() methods from JS. Store the user preference.
- Fix delayed calls to resize() in the TinyMCE autoresize plugin.
See #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29336 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-01 02:42:30 +00:00
Sergey Biryukov
09877657d4 Customizer: Don't hide controls the preview frame has no information about.
props kovshenin.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29329 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-30 16:23:47 +00:00
Sergey Biryukov
e4c8f3a843 QuickPress: Disable autocomplete for content, enable "Save Draft" button on load.
props morganestes, michalzuber.
fixes #27760.

git-svn-id: https://develop.svn.wordpress.org/trunk@29323 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-29 15:33:07 +00:00
Andrew Ozz
01051b4e2f Formatting: make the removal of white space around <option> greedy, see #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29316 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:54:50 +00:00
Andrew Ozz
5fa36977a0 Formatting: no <p> or <br> around <option> tags in both flavours of wpautop, make "selects" easier to read in the Text editor. Fixes #28217.
git-svn-id: https://develop.svn.wordpress.org/trunk@29315 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-28 19:43:06 +00:00
Andrew Ozz
42ac48d52a TinyMCE:
- Fix complex character input in Japanese, Chinese, etc. Was broken in getCursorOffset() in editor-expand.js.
- Disable auto-scrolling in some edge cases when editor expanding is enabled.
See #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29302 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-26 00:07:55 +00:00
Helen Hou-Sandi
5698a9dc7e Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 05:25:28 +00:00
Andrew Ozz
0a73faec46 Editor scrolling:
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29279 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-24 01:32:29 +00:00
Dominik Schilling (ocean90)
f5c0cf95e0 Fix jshint errors introduced in [29259]. see #11325.
git-svn-id: https://develop.svn.wordpress.org/trunk@29269 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-22 20:02:34 +00:00
Sergey Biryukov
ac17007b10 Remove requirement for a minimum image size in the image editor.
props ericlewis, solarissmoke.
fixes #11325.

git-svn-id: https://develop.svn.wordpress.org/trunk@29259 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-21 19:09:44 +00:00
Andrew Ozz
9c366c8f61 Fix admin menu open/close issues on some mobile devices, props adamsilverstein, fixes #27980.
git-svn-id: https://develop.svn.wordpress.org/trunk@29247 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 18:54:50 +00:00
Sergey Biryukov
d83dbfca17 Customizer: Remove "Add a Widget" button from tab order when reordering widgets.
fixes #28890.

git-svn-id: https://develop.svn.wordpress.org/trunk@29243 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 03:31:49 +00:00
Sergey Biryukov
45ec949d58 Customizer: When widget reorder button is actioned, transfer focus to the first Move control within the section.
fixes #28891.

git-svn-id: https://develop.svn.wordpress.org/trunk@29242 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 03:23:51 +00:00
Sergey Biryukov
a740868552 Customizer: Add widget title to Move/Up/Down controls to provide context for screen readers when reordering or moving widgets.
fixes #28889.

git-svn-id: https://develop.svn.wordpress.org/trunk@29238 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 01:57:05 +00:00
Sergey Biryukov
7a01c6af7b Customizer: Avoid losing focus when adding widgets via keyboard.
props sathishn.
fixes #28835.

git-svn-id: https://develop.svn.wordpress.org/trunk@29237 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-19 01:18:39 +00:00
Helen Hou-Sandi
021750b4f4 Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
git-svn-id: https://develop.svn.wordpress.org/trunk@29217 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-18 03:39:04 +00:00
Scott Taylor
283fa473e6 In Plugin Install List Table, remove title attribute for plugin action links; add screen-reader-text.
Props joedolson.
Fixes #28853.


git-svn-id: https://develop.svn.wordpress.org/trunk@29201 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 22:49:53 +00:00
Andrew Ozz
09f5183276 Editor scrolling: better "scroll into view" in the visual editor. Don't override MCE path focus style. Props avryl, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29186 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-16 04:05:13 +00:00
Dominik Schilling (ocean90)
1264558022 Media Grid improvements:
* Remove fixed elements.
* Adjusts toolbar and search, fixes #28833.
* Add link to Add New button, fixes #28825.
* Add "Edit Metadata" tab to all items, "Edit Image" only for images
* Make strings translatable.
* First pass for help tab.

see #28850.

git-svn-id: https://develop.svn.wordpress.org/trunk@29136 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 16:15:36 +00:00
Dominik Schilling (ocean90)
1285d1450b Improvements to the plugin information modal:
* Whitespace/braces cleanup for [29040].
* Reduce width of modal to 792px, which is the default banner size.
* Reduce banner height when screen height is smaller than 500px.
* Remove inline CSS.
* Re-use tab var in JS.
* Encode ampersands in links.

props avryl, michalzuber, ocean90.
see #27440.


git-svn-id: https://develop.svn.wordpress.org/trunk@29125 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 22:07:16 +00:00
Andrew Ozz
dbb367bee8 Editor scrolling: disable on mobile devices and hide the resize handle. See #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29117 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-12 00:53:08 +00:00
Scott Taylor
ce01c5c760 Media Grid:
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29086 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 05:33:29 +00:00
Scott Taylor
ee0e7ccbca Media Grid: make registering Screen Options for non-list tables more generic.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29079 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:43:49 +00:00
Scott Taylor
d5cbf00457 Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29078 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 21:25:49 +00:00
Scott Taylor
3ebde0c4d6 Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29077 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 20:59:12 +00:00
Helen Hou-Sandi
e4f0744b8e Editor scrolling:
* Make sure the background color for tools is only applied to the main editor.
* Fix toolbar width for smaller screens.
* Ensure toolbar doesn't end up in a weird place when scrolling down too fast.
* Avoid JS errors for post types that don't support the editor.

props avryl. see #28328.


git-svn-id: https://develop.svn.wordpress.org/trunk@29075 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 19:35:32 +00:00
Sergey Biryukov
ca97e64c50 Revisions: Explicitly set the 'from' handle position when switching from two-handled mode back to single-handled mode.
props adamsilverstein.
fixes #26793.

git-svn-id: https://develop.svn.wordpress.org/trunk@29052 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-10 00:59:13 +00:00
Sergey Biryukov
1477277b53 Customizer: Introduce WP_Customize_Control::active() method to determine whether the control is relevant to the current context (i.e. to the current URL being previewed).
Control can indicate its active state by a subclass overriding the 'active_callback' method, by supplying a callable 'active_callback' argument into the control's constructor, or by filtering 'customize_control_active'.

props westonruter.
see #27993.

git-svn-id: https://develop.svn.wordpress.org/trunk@29051 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 23:57:29 +00:00
Andrew Ozz
ccef0ae5f0 Fix whitespace, quotes and double patch content in wpautoresize plugin, see #28328
git-svn-id: https://develop.svn.wordpress.org/trunk@29050 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 22:42:28 +00:00
Andrew Ozz
14d1e57e99 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328.
git-svn-id: https://develop.svn.wordpress.org/trunk@29049 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 22:05:06 +00:00
Sergey Biryukov
f92dc5aa41 Customizer: Export Previewer instance to wp.customize.previewer, and utilize for Widget Customizer.
props westonruter.
fixes #27666.

git-svn-id: https://develop.svn.wordpress.org/trunk@29048 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 20:57:58 +00:00
Helen Hou-Sandi
194122cb84 Remove an unused JS variable after [29036]. see #27406.
git-svn-id: https://develop.svn.wordpress.org/trunk@29042 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 17:45:36 +00:00
Helen Hou-Sandi
56706c324d Improvements to the plugin information modal:
* Show the banner image when available.
* Show contributors and ratings breakdown in the FYI box.
* Show reviews in a tab.

props stephdau, tellyworth, paulwilde, michalzuber. see #27440. fixes #19784, #22599, #26202.


git-svn-id: https://develop.svn.wordpress.org/trunk@29040 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-09 17:27:22 +00:00
Helen Hou-Sandi
4e8a1a1ab1 accordion.js:
* Remove remnants from when some corners were rounded.
* Docs.

props celloexpressions. see #27406.


git-svn-id: https://develop.svn.wordpress.org/trunk@29036 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 20:21:47 +00:00
Helen Hou-Sandi
054e4b5e65 Customizer panels:
* Close all accordion sections when going in and out of panels.
* Fix panel positioning when top-level Customizer controls are scrolled down.
* Keyboard accessibility: only focus on visible elements and transfer between them as needed when navigating around panels.

props celloexpressions. see #27406.


git-svn-id: https://develop.svn.wordpress.org/trunk@29035 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 20:18:30 +00:00
Helen Hou-Sandi
d1c4c6fd6e Customizer info section:
* Only show the theme info when doing a live preview of another theme.
* Replace with helper text about what you are customizing and what the Customizer is for.
* Fix focus styling.

props celloexpressions, westonruter. fixes #28550.


git-svn-id: https://develop.svn.wordpress.org/trunk@29034 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-08 19:52:17 +00:00