Commit Graph

38244 Commits

Author SHA1 Message Date
Andrea Fercia 475a58b384 Accessibility: Insert Link modal: Improve keyboard interaction.
Avoids to change the selected link when using the Shift and Up/Down arrow keys
to select text in the form fields.

Fixes #43253.


git-svn-id: https://develop.svn.wordpress.org/trunk@42807 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 20:57:44 +00:00
Sergey Biryukov 19ed786c78 Filesystem API: Avoid an infinite loop in `wp_mkdir_p()` when trying to determine the parent folder with `open_basedir` restriction in effect.
Props soulseekah, 1265578519-1.
Fixes #43417.

git-svn-id: https://develop.svn.wordpress.org/trunk@42801 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 19:31:59 +00:00
Sergey Biryukov f6de9b77f8 General: In `wp_debug_backtrace_summary()`, normalize paths before replacement for better cross–platform compatibility.
Props Rarst.
Fixes #43501.

git-svn-id: https://develop.svn.wordpress.org/trunk@42800 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 17:07:04 +00:00
Sergey Biryukov 257048ac71 Tests: Correct assertion in `Tests_WP_Customize_Setting::test_constructor_with_args()`.
Props jipmoors.
See #30988, #43218.

git-svn-id: https://develop.svn.wordpress.org/trunk@42799 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 16:37:59 +00:00
Sergey Biryukov c6ecac6ad5 Docs: Improve JSDoc for `wp-includes/js/media/controllers/gallery-add.js`.
Props boblinthorst, bramheijmink, manuelaugustin, ireneyoast, igorsch, nataliashitova.
Fixes #43500.

git-svn-id: https://develop.svn.wordpress.org/trunk@42798 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 16:24:16 +00:00
Sergey Biryukov 4933dff8c1 Docs: Remove copy/pasted default value description for `$type` in `WP_Customize_Manager::add_setting()`.
Props DannyCooper.
Fixes #43497.

git-svn-id: https://develop.svn.wordpress.org/trunk@42797 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 13:05:35 +00:00
Sergey Biryukov a846684cfc Docs: Improve documentation for `add_meta_boxes` and `do_meta_boxes` actions.
Props danieltj, johnbillion, SergeyBiryukov.
Fixes #43229.

git-svn-id: https://develop.svn.wordpress.org/trunk@42796 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 03:56:50 +00:00
Sergey Biryukov a1ce238e6f Docs: Document globals in `wp-admin/revision.php` as `@global` instead of `@param`.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42795 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-08 03:52:24 +00:00
Andrea Fercia 9054719d29 Accessibility: Widgets: Make the "Available Widgets" section operable with a keyboard.
For a number of years, the "Available Widgets" section has been off-limits for
keyboard users. Now it can be used also with the keyboard. This change introduces
also some improvements for assistive technologies.

- makes the widget toggles focusable and adds an `aria-expanded` attribute to indicate their state
- improves the toggles labelling to clarify context (add/edit)
- changes the controls to choose a sidebar from list items to buttons
- adds an `aria-label` attribute to the buttons to clarify their purpose
- adds an `aria-pressed` attribute to the buttons to indicate which one is selected
- improves color contrast of the selected button
- uses a `wp.a11y.speak()` message to announce to screen reader users when a widget has been added to a sidebar
- moves focus back to the toggle button when closing a widget

See #40677.


git-svn-id: https://develop.svn.wordpress.org/trunk@42794 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-07 22:26:39 +00:00
Andrea Fercia 77fbbbdbec Accessibility: Networks and Sites: mark the New Site required form fields as required.
Also, adds an `aria-describedby` attribute to associate the Admin Email field with its description.

Props dipesh.kakadiya, jackreichert, rianrietveld.
Fixes #37331.


git-svn-id: https://develop.svn.wordpress.org/trunk@42793 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-07 19:40:58 +00:00
Mike Schroder 3a46cba430 Media: Correctly allow changing PDF thumbnail crop value.
Corrects logic that keeping plugins from setting crop value of intermediate image sizes for rendered PDFs.

Adds test.

Props leemon, SergeyBiryukov, chetan200891, birgire.
Fixes #43226.

git-svn-id: https://develop.svn.wordpress.org/trunk@42792 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-07 01:18:08 +00:00
Andrew Ozz 0005ad91d6 Add a method to confirm user requests by email. First run.
Props mikejolley.
See #43443.

git-svn-id: https://develop.svn.wordpress.org/trunk@42791 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-06 23:46:44 +00:00
Andrea Fercia 1a03159d26 Accessibility: Make the Widgets screen "Enable accessibility mode" link more discoverable.
For a number of years, the link to the Widgets screen "Accessibility mode" lived
in the Screen Options panel, hidden by default. Many users, including assistive
technologies users, weren't able to find it or even aware it existed. By bringing
the link in the main screen, visible by default, this change makes the
"Accessibility mode" easily discoverable for everyone.

Props chetan200891, antonioeatgoat.
Fixes #42778.


git-svn-id: https://develop.svn.wordpress.org/trunk@42790 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-06 17:20:07 +00:00
John Blackbourn cdcce1b9c6 Database: Add the query start time to logged query data.
This allows debugging plugins to plot the time at which queries were executed.

Props Rarst for initial patch.

Fixes #43315


git-svn-id: https://develop.svn.wordpress.org/trunk@42789 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 22:53:40 +00:00
John Blackbourn d83f786d3c Themes: Ensure the theme roots cache is cleared when registering a theme directory.
Props soulseekah, johnbillion

Fixes #43228


git-svn-id: https://develop.svn.wordpress.org/trunk@42788 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 22:13:36 +00:00
John Blackbourn b20dc7aaaf Docs: Standardise and correct documentation relating to parameters which accept plugin names.
See #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42787 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 21:49:53 +00:00
John Blackbourn 3e182c7f71 Upgrade/Install: Fix the format of the `upgrader_process_complete` actions after [42343].
More info: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1323

See #41057, #42505


git-svn-id: https://develop.svn.wordpress.org/trunk@42786 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 21:43:25 +00:00
Andrea Fercia 0a63e2ed96 Accessibility: Change the "Show / Hide dismissed updates" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.
Also, adds an `aria-expanded` attribute to communicate the expandable panel state
and improves the buttons spacing.

Props Cheffheid, audrasjb, afercia.
Fixes #38674.


git-svn-id: https://develop.svn.wordpress.org/trunk@42785 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 15:49:58 +00:00
Andrea Fercia ef84e589d2 Accessibility: Change the media upload "Dismiss error" link to a button.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffheid, audrasjb.
Fixes #38671.


git-svn-id: https://develop.svn.wordpress.org/trunk@42784 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 15:32:54 +00:00
Sergey Biryukov 3fe0cb97a5 Help/About: Adjust capability checks formatting in help text on Dashboard screen for readability and consistency with similar checks in other files.
See #43472.

git-svn-id: https://develop.svn.wordpress.org/trunk@42783 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 03:31:06 +00:00
Sergey Biryukov 3ba6cf2894 Help/About: Remove popular plugins feed reference from help text on Dashboard screen, no longer relevant since [40607].
Props denisco.
See #43472.

git-svn-id: https://develop.svn.wordpress.org/trunk@42782 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 03:16:05 +00:00
Sergey Biryukov 366e736785 Help/About: Update "WordPress News" widget references in help text and inline documentation.
Props monikarao, denisco.
Fixes #43400, #43472.

git-svn-id: https://develop.svn.wordpress.org/trunk@42781 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 03:03:05 +00:00
Sergey Biryukov 007a7caad4 Media: Recognize `.ico` files as displayable images on PHP 5.3+ and allow attachment meta data to be generated for them.
Props remyvv, Guido07111975.
Fixes #43458.

git-svn-id: https://develop.svn.wordpress.org/trunk@42780 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 01:02:20 +00:00
Sergey Biryukov 9de76899c1 Help/About: Correct the number of most recent drafts in help text on Dashboard screen.
Props denisco.
Fixes #43471.

git-svn-id: https://develop.svn.wordpress.org/trunk@42779 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-05 00:23:34 +00:00
Sergey Biryukov 2d37bd46ec Docs: Expand `delete_theme()` return value, fix typo in `delete_plugins()` return value.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42778 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 22:06:46 +00:00
Sergey Biryukov e0b16ef59c Docs: Use consistent description for `$wp_filesystem` global.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42777 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 21:57:10 +00:00
Sergey Biryukov fa1ce009b5 Docs: Clarify return values and improve DocBlock formatting for `verify_file_md5()`, `unzip_file()`, `_unzip_file_ziparchive()`, `_unzip_file_pclzip()`, `copy_dir()`, `WP_Filesystem()`.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42776 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 21:42:12 +00:00
Sergey Biryukov aae94227c6 Docs: Clarify `download_url()` return value, improve DocBlock formatting.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42775 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 19:49:54 +00:00
Sergey Biryukov 78fc54ca37 Docs: Clarify that `wp_update_user()` accepts an array as `$userdata` argument.
Props nextendweb.
Fixes #43051.

git-svn-id: https://develop.svn.wordpress.org/trunk@42774 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 18:11:56 +00:00
Sergey Biryukov 4edda96383 Filesystem API: Allow `download_url()` to return the response code and body on error as an additional `WP_Error` object data.
The error response body size is limited to 1 KB by default to avoid taking up too much memory. The size can be increased using `download_url_error_max_body_size` filter.

Props soulseekah, campusboy1987, mihdan, SergeyBiryukov.
Fixes #43329.

git-svn-id: https://develop.svn.wordpress.org/trunk@42773 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 17:13:35 +00:00
Andrew Ozz 65d8fe578a Add a checkbox to the comment form so logged out users can opt-out of commenter cookies.
Props lakenh, xkon, birgire, azaozz.
See #43436.

git-svn-id: https://develop.svn.wordpress.org/trunk@42772 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-04 16:40:43 +00:00
Dominik Schilling (ocean90) 37acff86ca Import: Avoid counting an uncountable type when reading arguments passed to a script.
Props josephscott.
Fixes #42898.

git-svn-id: https://develop.svn.wordpress.org/trunk@42771 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-02 17:16:37 +00:00
Andrew Ozz 6d094f61bb Add pre-save content filter to make target=_blank always secure.
Props notnownikki, iseulde, azaozz
Fixes #43187

git-svn-id: https://develop.svn.wordpress.org/trunk@42770 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-02 14:41:04 +00:00
Dominik Schilling (ocean90) c3615b2688 Docs: Remove trailing whitespace in `wp-includes/post.php`.
git-svn-id: https://develop.svn.wordpress.org/trunk@42769 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-02 10:01:39 +00:00
Boone Gorges e840759df5 Allow `LIKE` queries against the 'key' value in meta queries.
The new `compare_key=LIKE` parameter works in conjunction with `key` in a
similar way to the `compare=LIKE` and `value`: by doing a "compares" `LIKE`
query. This allows developers to do partial matches against keys when
doing meta queries.

Props mariovalney, chasewg.
Fixes #42409.

git-svn-id: https://develop.svn.wordpress.org/trunk@42768 602fd350-edb4-49c9-b593-d223f7449a82
2018-03-01 04:02:41 +00:00
Andrea Fercia 6e5a560be0 Accessibility: Change the comments "Quick Edit" and "Reply" links to buttons.
For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffeid, audrasjb, afercia.
See #43382, #38677.
Fixes #43376.


git-svn-id: https://develop.svn.wordpress.org/trunk@42767 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-28 22:36:00 +00:00
Sergey Biryukov b15919c8dd Docs: Mark `WP_Http::_dispatch_request()` as deprecated. It's no longer used since [37428].
Fixes #43414.

git-svn-id: https://develop.svn.wordpress.org/trunk@42766 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-28 03:47:14 +00:00
Sergey Biryukov 617a87f114 Docs: Add description for `register_admin_color_schemes()`.
Props terriann, danieltj.
Fixes #42779.

git-svn-id: https://develop.svn.wordpress.org/trunk@42765 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-28 03:27:46 +00:00
Sergey Biryukov 3f7b3865f4 XML-RPC: Unify permission error messages in `wp_xmlrpc_server`.
Props ramiy.
Fixes #42266.

git-svn-id: https://develop.svn.wordpress.org/trunk@42764 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-28 03:18:47 +00:00
Ian Dunn c896326c55 External Libraries: Test for MEjs files in `src` instead of `build`.
The `build` task doesn't get run during TravisCI jobs, so the `build` folder doesn't exist in that context. Because of that, the test added in r42762 was failling.

Checking for the files in `src` instead achieves the same goal as that commit, but should pass in Travis.

See #43101
See https://wordpress.slack.com/archives/C02RQBWTW/p1519742993000615


git-svn-id: https://develop.svn.wordpress.org/trunk@42763 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-28 00:25:08 +00:00
Ian Dunn fde455a89f External Libraries: Test that MediaElement SWF files remain deleted.
The files were removed from Core in r42462 because they're no longer necessary, and have a history of security issues. They remain upstream, though, so this test makes it explicitly clear that they should not be added back in the future without careful consideration and discussion with the Security team.

`Tests_Admin_IncludesUpdateCore::test_new_files_are_not_in_old_files_array_compiled()` would already catch files with the exact same name, but this test will also catch files with new names, just to be extra cautious.

Props iandunn, ocean90, SergeyBiryukov
Fixes 43101


git-svn-id: https://develop.svn.wordpress.org/trunk@42762 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-27 14:37:15 +00:00
Sergey Biryukov 1cc516f2e8 General: Introduce `WP_Error::has_errors()` method and use it where appropriate.
Props robdxw, DrewAPicture, SergeyBiryukov.
Fixes #42742.

git-svn-id: https://develop.svn.wordpress.org/trunk@42761 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-27 02:30:46 +00:00
Ian Dunn 2f68ec5750 Build/Test Tools: Add `watch:phpunit` task.
This allow PHPUnit test groups to run automatically when files are changed, rather than having to be ran manually throughout the development process. This creates a smoother developer experience, and a tighter feedback loop.

Props iandunn, netweb, pento
Fixes #42282


git-svn-id: https://develop.svn.wordpress.org/trunk@42760 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-27 00:31:33 +00:00
Sergey Biryukov c625e2e7d9 Media: Remove unnecessary `aria-required` attribute from legacy (pre-3.5.0) media functions, added in [7888].
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.

Props shital-patel, afercia, audrasjb.
Fixes #43415.

git-svn-id: https://develop.svn.wordpress.org/trunk@42759 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 23:09:57 +00:00
Sergey Biryukov fb2e65d2b9 Comments: Remove unnecessary `aria-required` attribute from `comment_form()`, added with the function in [12810].
At the time, having both `required` and `aria-required` meant a wider range of support for browsers and assistive technology. Today, it's safe to use just `required`.

Props lakenh, afercia, davidakennedy, henry.wright.
Fixes #39045.

git-svn-id: https://develop.svn.wordpress.org/trunk@42758 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 20:49:13 +00:00
Dominik Schilling (ocean90) cb78bce02f Administration: Remove unnecessary capitalization when referencing to plugin/theme editors.
Fixes #43072.

git-svn-id: https://develop.svn.wordpress.org/trunk@42757 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 19:34:56 +00:00
SergeyBiryukov 74afab6950 Docs: Add missing `@since` entries for functions in `wp-admin/image-edit.php`.
See #42505.

git-svn-id: https://develop.svn.wordpress.org/trunk@42756 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 18:37:02 +00:00
Sergey Biryukov 282923aca6 Taxonomy: Make the "Format" taxonomy name plural, for consistency with other taxonomies.
Props afercia, danieltj.
Fixes #43370.

git-svn-id: https://develop.svn.wordpress.org/trunk@42755 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 18:21:59 +00:00
Sergey Biryukov 27e6766367 Docs: Fix typo in `wp.customize.selectiveRefresh.placements()` description.
Props Nikschavan.
Fixes #43418.

git-svn-id: https://develop.svn.wordpress.org/trunk@42754 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 17:51:37 +00:00
Pascal Birchler c6d5775840 Docs: Remove erroneous period in the description for `esc_html__()`.
Props danieltj.
Fixes #43419.


git-svn-id: https://develop.svn.wordpress.org/trunk@42753 602fd350-edb4-49c9-b593-d223f7449a82
2018-02-26 15:56:15 +00:00