Commit Graph

224 Commits

Author SHA1 Message Date
Andrew Nacin 6e96c1d7db Remove pattern="" in the comment form (HTML5 mode) to avoid mistaken :invalid styles.
This was originally included for Opera 10, but is not needed as of Opera 11, and current is Opera 15.

props jorbin, markjaquith.
fixes #24475.



git-svn-id: https://develop.svn.wordpress.org/trunk@24573 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-05 21:59:10 +00:00
Dominik Schilling (ocean90) 925e2f67ee Replace the `cite` element with a `b` element to markup the comment author in comment_html5().
In HTML5 the `cite` element isn't valid for just an author's name.
"The cite element represents the title of a work [..] A person's name is not the title of a work" (http://www.w3.org/TR/html5/text-level-semantics.html#the-cite-element)

fixed #24522.

git-svn-id: https://develop.svn.wordpress.org/trunk@24539 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-01 18:26:16 +00:00
Andrew Nacin f8d88e8dd7 Comment form: Add HTML classes.
* #respond gains .comment-respond
 * #reply-title gains .comment-reply-titlw
 * form gains .comment-form

props obenland.
see #23851.



git-svn-id: https://develop.svn.wordpress.org/trunk@24525 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-27 21:18:08 +00:00
Andrew Nacin 6204be9e9c `add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'
props obenland.
see #23850.



git-svn-id: https://develop.svn.wordpress.org/trunk@24417 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-06 15:31:34 +00:00
Sergey Biryukov 0abc45b90f Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: https://develop.svn.wordpress.org/trunk@24377 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-28 03:29:15 +00:00
Andrew Nacin c4ee22898d Remove use of global $id from comment_form() and the media list table. see #24330.
git-svn-id: https://develop.svn.wordpress.org/trunk@24337 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-23 18:40:16 +00:00
Sergey Biryukov bb2a27be5b Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: https://develop.svn.wordpress.org/trunk@24207 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-08 21:27:31 +00:00
Andrew Nacin c91475ebe1 Required arguments can't follow optional arguments.
Make required arguments optional in confirm_blog_signup().

Mark arguments as required in _future_post_hook(), the walker method display_element(), get_author_link() (deprecated), and the WP_Widget constructor.

props rlerdorf.
see #24210.



git-svn-id: https://develop.svn.wordpress.org/trunk@24126 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-29 13:26:31 +00:00
Sergey Biryukov 6c981a7835 Fix inconsistent spacing in comment_form(). props sim, TravisHoffman. fixes #23878.
git-svn-id: https://develop.svn.wordpress.org/trunk@23932 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-07 23:57:35 +00:00
Mark Jaquith 134fb4f257 Improve wp_list_comments() markup.
* Whitespace cleanup
* Accepts format=html5 which uses some of the HTML5 elements
* Some helpful HTML comments to help untangle the HTML
* Other misc code cleanup

props lancewillett, obenland, georgestephanis. fixes #20088.

git-svn-id: https://develop.svn.wordpress.org/trunk@23694 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-14 04:26:04 +00:00
Mark Jaquith b95b9917f1 Add the ability to use HTML5 input types in the comment form.
props jorbin, georgestephanis, obenland. fixes #15080

git-svn-id: https://develop.svn.wordpress.org/trunk@23689 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-13 20:31:43 +00:00
Andrew Nacin 11b772ea05 Add filters to comments_link_feed(), comment_link(), and get_comments_link(). esc_url() the echoed output of comments_link().
props MarcusPope.
fixes #19210.



git-svn-id: https://develop.svn.wordpress.org/trunk@23624 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-06 19:57:31 +00:00
Ryan Boren b0cae159ea Put required field indicators within labels. Update styling of bundled themes to accommodate. Props MikeHansenMe. fixes #21897
git-svn-id: https://develop.svn.wordpress.org/trunk@22123 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-05 16:34:32 +00:00
Ryan Boren d6f78d6554 Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: https://develop.svn.wordpress.org/trunk@22115 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-04 18:26:25 +00:00
Ryan Boren e22b981706 Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: https://develop.svn.wordpress.org/trunk@22114 602fd350-edb4-49c9-b593-d223f7449a82
2012-10-04 18:21:47 +00:00
Ryan Boren 31ec698423 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: https://develop.svn.wordpress.org/trunk@21735 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-04 16:29:28 +00:00
Ryan Boren d2774833b2 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: https://develop.svn.wordpress.org/trunk@21364 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-30 18:30:03 +00:00
Ryan Boren 712e8a48d2 Don't attempt to define the COMMENTS_TEMPLATE constant twice. Props kitchin. fixes #21337
git-svn-id: https://develop.svn.wordpress.org/trunk@21330 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-25 17:54:35 +00:00
Ryan Boren c4b8b6b42a Set the global comment var before invoking callbacks in wp_list_comments(). Props sirzooro. fixes #21184
git-svn-id: https://develop.svn.wordpress.org/trunk@21324 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-25 16:27:48 +00:00
Ryan Boren daf2f84da0 Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812
git-svn-id: https://develop.svn.wordpress.org/trunk@20974 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-01 20:47:08 +00:00
Andrew Nacin 20c3b25c7e In comment_form(), pass the $post_id to comments_open(). props insertvisionhere. fixes #20572.
git-svn-id: https://develop.svn.wordpress.org/trunk@20641 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-30 01:47:22 +00:00
Ryan Boren 6f9ceb2326 Introduce WP_User::exists(). see #20372
git-svn-id: https://develop.svn.wordpress.org/trunk@20378 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-06 19:18:45 +00:00
Ryan Boren 2b186b0c45 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
Ryan Boren a8d77cbae9 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: https://develop.svn.wordpress.org/trunk@19687 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:50:54 +00:00
Ryan Boren c855c642ea Clear strict notices for the walkers. fixes #19249
git-svn-id: https://develop.svn.wordpress.org/trunk@19679 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-04 23:03:46 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Andrew Nacin c107d9ffed Don't use $user_identity global. props duck_. fixes #19146.
git-svn-id: https://develop.svn.wordpress.org/trunk@19284 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-14 21:35:44 +00:00
Jon Cave 205aa5ba5c Fix typos in documentation (wp-includes/[a-h]). See #18560.
git-svn-id: https://develop.svn.wordpress.org/trunk@18633 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-03 16:02:41 +00:00
Ryan Boren e73ec3abe0 Pass post id along to *comment_id_fields(). Props natecook. fixes #17193
git-svn-id: https://develop.svn.wordpress.org/trunk@17812 602fd350-edb4-49c9-b593-d223f7449a82
2011-05-05 19:33:47 +00:00
Andrew Nacin 18edc09e6a More @since. props SergeyBiryukov, fixes #15445.
git-svn-id: https://develop.svn.wordpress.org/trunk@17071 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-20 09:25:21 +00:00
Peter Westwood 143c92e3ad Revert [16649] - The core output on this is for logged out users only - need to rework this if we want to move the output. See #14510
git-svn-id: https://develop.svn.wordpress.org/trunk@16704 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-03 09:44:17 +00:00
Ryan Boren c8c8bf146d Fix comment_notes_before. Props mrmist. fixes #14510
git-svn-id: https://develop.svn.wordpress.org/trunk@16649 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-01 16:52:32 +00:00
Nikolay Bachiyski 3a01f911cd comments_number() doesn't need to call get_the_ID(), because get_comments_number() does it if post ID is missing
git-svn-id: https://develop.svn.wordpress.org/trunk@16613 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-29 17:34:43 +00:00
scribu fc764ebc45 Remove nofollow on comment reply links. Fixes #10550
git-svn-id: https://develop.svn.wordpress.org/trunk@16230 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-07 01:06:37 +00:00
Andrew Nacin e2dfe4f5c2 Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064, fixes #15247.
git-svn-id: https://develop.svn.wordpress.org/trunk@16066 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-29 00:31:27 +00:00
Mark Jaquith d65cdf4ba8 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: https://develop.svn.wordpress.org/trunk@16061 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 21:56:43 +00:00
Andrew Nacin 7b6f24eeeb Add a class to 'Your comment is awaiting moderation' in the comment walker and Twenty Ten's callback. fixes #15206.
git-svn-id: https://develop.svn.wordpress.org/trunk@16028 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-28 03:58:51 +00:00
Andrew Nacin d8672ca5d8 Pass comment ID from comment_text to get_comment_text. Also add the comment object as context to the filter. fixes #14261
git-svn-id: https://develop.svn.wordpress.org/trunk@15957 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-25 03:11:01 +00:00
Andrew Nacin 9494e4ce7e Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: https://develop.svn.wordpress.org/trunk@15590 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-07 11:21:11 +00:00
Andrew Nacin 457c37ff01 Adjustments to [15549]. See #11624.
git-svn-id: https://develop.svn.wordpress.org/trunk@15563 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-04 15:51:04 +00:00
scribu b3ef955990 Don't use the global anymore. Fixes #11624
git-svn-id: https://develop.svn.wordpress.org/trunk@15549 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-28 11:57:28 +00:00
Peter Westwood 8d72c5172c Fix the theme compat file require paths to be fully absolute so they don't rely on a particular php path to work. Fixes #14315 for trunk props dougal.
git-svn-id: https://develop.svn.wordpress.org/trunk@15433 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-16 09:40:09 +00:00
Andrew Nacin fb83a22b94 Restore trackback_rdf(). reverts [13991]. fixes #11139 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@15363 602fd350-edb4-49c9-b593-d223f7449a82
2010-07-03 05:55:04 +00:00
Dion Hulse 7efc4efdaa Alot more tabs. Props jacobsantos & Viper007bond. See #14147
git-svn-id: https://develop.svn.wordpress.org/trunk@15355 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-30 00:05:18 +00:00
Andrew Nacin 6f57a1a3ec s/echos/echoes/ in phpdoc. props demetris, fixes #13742.
git-svn-id: https://develop.svn.wordpress.org/trunk@15148 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-06 05:16:32 +00:00
Andrew Nacin 542dea5b25 Use p instead of definition list for allowed tags in comment_form(). props demetris. Style the new markup in Twenty Ten. see #10910.
git-svn-id: https://develop.svn.wordpress.org/trunk@14689 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-16 06:38:58 +00:00
Andrew Nacin 384cd5a9d3 Fix typos in phpdoc for comment_form(). props demetris, fixes #10910.
git-svn-id: https://develop.svn.wordpress.org/trunk@14538 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-10 08:47:13 +00:00
Ryan Boren d783952469 Strip trailing whites.
git-svn-id: https://develop.svn.wordpress.org/trunk@14404 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 20:26:11 +00:00
Nikolay Bachiyski e9acc6d0b6 Take out the leading space from the translatable string
git-svn-id: https://develop.svn.wordpress.org/trunk@14378 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 18:48:33 +00:00
Ryan Boren 57a5a11660 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051
git-svn-id: https://develop.svn.wordpress.org/trunk@14374 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-03 18:16:22 +00:00