Commit Graph

45 Commits

Author SHA1 Message Date
Mark Jaquith
8dfbe56e79 Pass back dateUnix (a unix timestamp) for better sorting of revisions in Backbone.
Props duck_. See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24615 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 19:21:25 +00:00
Mark Jaquith
b4b9544d35 Move the loading of surrounding diffs functionality into the model.
* `wp.revisions.log()` — temporary measure for logging based on `wp.revisions.debug`
* Return promises from functions that sometimes bail but normally return promises.

See #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24613 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 19:00:11 +00:00
Daryl Koopersmith
286a44fcf6 Revisions: Debounce fetching Diffs when revisions are updated.
Fixes navigation and casting bugs.

See #24425.


git-svn-id: https://develop.svn.wordpress.org/trunk@24611 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 09:57:58 +00:00
Daryl Koopersmith
f9e4a8500a Revisions: Move data management into the frame state. See #24425.
This helps to solidify the separation between data and UI. We track the diffId internally now, as the property itself was never referenced, and was always derived from the 'from' and 'to' models. This also sets us up for better request debouncing and diff management.



git-svn-id: https://develop.svn.wordpress.org/trunk@24609 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 08:50:32 +00:00
Daryl Koopersmith
f2ab17ee13 Revisions: Simplify router property name. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24608 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 08:20:12 +00:00
Daryl Koopersmith
155046f796 Revisions: Remove unnecessary router property. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24607 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 08:15:55 +00:00
Daryl Koopersmith
0e8e4b4e49 Revisions: Simplify how URLs are updated. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24606 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 08:14:38 +00:00
Daryl Koopersmith
15df489ecd Revisions: Reduce points where IDs are cast in JS. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24605 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:55:50 +00:00
Daryl Koopersmith
5917fcb621 Revisions: Remove unused template. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24604 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:34:54 +00:00
Daryl Koopersmith
45d2a20783 Revisions: A healthy dose of pinking shears. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24603 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:33:15 +00:00
Daryl Koopersmith
8e85892a3f Revisions: Remove redundant tagNames. Props markjaquith, see #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24602 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:14:23 +00:00
Daryl Koopersmith
9e5fb3311f Revisions: Use toggleClass instead of a conditional. See #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24601 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:11:43 +00:00
Daryl Koopersmith
7f8538805b Revisions: Remove redundant method, see #24425.
git-svn-id: https://develop.svn.wordpress.org/trunk@24600 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-09 07:07:53 +00:00
Mark Jaquith
4c35743a1a Tick marks are back for revisions
* Simple tick marks
* Tooltips snap to tick marks
* Tooltips arrow reverses side for LTR/RTL
* Fix for routing issue where just the hash is changed in the URL bar relating to compare two mode

see #24425. props adamsilverstein, ocean90.

git-svn-id: https://develop.svn.wordpress.org/trunk@24595 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-08 21:37:03 +00:00
Dominik Schilling (ocean90)
fbeed0e364 Revisions improvements
* Enable smooth sliding in Compare two mode

props adamsilverstein. see #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24579 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-06 20:22:02 +00:00
Dominik Schilling (ocean90)
814c36baea Revisions improvements
* Corrected routing behavior
* Simplified CSS for tooltips
* Compare two mode for RTL
* Support for posts without titles 

props adamsilverstein, ocean90. see #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24578 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-06 10:48:14 +00:00
Dominik Schilling (ocean90)
fcf1e26cff Revisions improvements
Revert mouse dragging code which was accidentally removed in [24565].

see #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24575 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-05 22:54:17 +00:00
Mark Jaquith
e87e8f608a Revisions improvements
* Consolidated router code
* Corrected routing behavior
* Tooltip model
* Removed mouse dragging code

props adamsilverstein, ocean90. see #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24565 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-05 17:44:47 +00:00
Mark Jaquith
ffa73b8fc5 Debounce the Revisions UI URL updates as you scrub, for a massive speedup and a reduction in URL history detritus.
see #24425

git-svn-id: https://develop.svn.wordpress.org/trunk@24556 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-04 08:30:36 +00:00
Dominik Schilling (ocean90)
3690db14f7 Revisions UI update:
* Restore Compare two mode
* Restore tooltips
* RTL support
* First pass for URL routing and history

props adamsilverstein, see #24425.

git-svn-id: https://develop.svn.wordpress.org/trunk@24549 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-03 20:27:19 +00:00
Mark Jaquith
ac0d0d1dee Cleanup of the revisions screen, both on the PHP API side, and the JS.
* Much simpler PHP API
* Cleaner and more Backbone-y JS API
* Consequently, does batch queries; this now scales up to hundreds of revisions

Currently missing, but much easier considering the cleaned up base:

* Compare two mode
* RTL

props koopersmith, nacin, adamsilverstein, ocean90. see #24425

git-svn-id: https://develop.svn.wordpress.org/trunk@24520 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-26 21:06:50 +00:00
Dominik Schilling (ocean90)
e1a2affe21 Revisions UI: Reduce the min width of a tick. props adamsilverstein. see #23901.
git-svn-id: https://develop.svn.wordpress.org/trunk@24254 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 17:35:26 +00:00
Dominik Schilling (ocean90)
19fd80736a Revisions JS: Fix inline docs. props a.hoereth. see #23901.
git-svn-id: https://develop.svn.wordpress.org/trunk@24253 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 17:30:18 +00:00
Sergey Biryukov
2b1420456d Fix typos in phpdoc. props TheLastCicada. fixes #24302.
git-svn-id: https://develop.svn.wordpress.org/trunk@24229 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-10 01:39:30 +00:00
Dominik Schilling (ocean90)
0b5b837917 Revisions UI: RTL support. (And inline docs.)
props DrewAPicture, adamsilverstein. fixes #23897.

git-svn-id: https://develop.svn.wordpress.org/trunk@24205 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-08 21:22:01 +00:00
Dominik Schilling (ocean90)
40cf994e77 Revisions UI: Just another update - Now with improved tick marks and tooltips.
props adamsilverstein. see #23935.

git-svn-id: https://develop.svn.wordpress.org/trunk@24174 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-03 23:17:06 +00:00
Dominik Schilling (ocean90)
67d2cfeb89 Revisions UI: Add translation contexts and remove unneeded lines.
props nao. fixes #23917.

git-svn-id: https://develop.svn.wordpress.org/trunk@24157 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-02 10:12:19 +00:00
Dominik Schilling (ocean90)
800d88397a Revisions UI update:
* Style status loading as a regular update message like on the other screens
 * Move compare two checkbox to diff header to avoid an overlap on long post titles
 * Restore color shades for the scope of changes visualisation 
 * Show tooltips while moving the slider handle
 * Diff header styling
 * Move color declarations to classic/fresh stylesheets
 * Sync admin color stylesheets

props jrbeilke for initial patch. see #23935.

git-svn-id: https://develop.svn.wordpress.org/trunk@24119 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-28 10:56:57 +00:00
Dominik Schilling (ocean90)
990c7c1b81 Revisions JS: Fix typo. props westi . fixes #24136.
git-svn-id: https://develop.svn.wordpress.org/trunk@24040 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-19 22:02:24 +00:00
Dominik Schilling (ocean90)
814a49b51b Revisions UI: Disable previous and next buttons when you're on the first, and last node. Put revision ticks above the slider range. props lessbloat for initial patch. see #23899.
git-svn-id: https://develop.svn.wordpress.org/trunk@24020 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-17 20:12:25 +00:00
Dominik Schilling (ocean90)
d8bf6c44b3 Revisions: Clean up JavaScript variable names, see #23901.
git-svn-id: https://develop.svn.wordpress.org/trunk@24019 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-17 19:34:21 +00:00
Sergey Biryukov
4200e2702f Use correct class. see #23933.
git-svn-id: https://develop.svn.wordpress.org/trunk@23915 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-05 00:20:19 +00:00
Sergey Biryukov
3095f5af6b Use correct id attribute. props ocean90. fixes #23937.
git-svn-id: https://develop.svn.wordpress.org/trunk@23909 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-04 20:58:33 +00:00
Sergey Biryukov
244974e838 Fix typo in revisions JS/CSS. props mgibbs189, JustinSainton. fixes #23941.
git-svn-id: https://develop.svn.wordpress.org/trunk@23908 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-04 20:49:26 +00:00
Mark Jaquith
6bae3a6eda A little more revisions js/php cleanup. see #23901. props kovshenin, ocean90.
git-svn-id: https://develop.svn.wordpress.org/trunk@23904 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-04 16:03:21 +00:00
Mark Jaquith
25c799470e Revisions CSS cleanup.
props ocean90. fixes #23933

git-svn-id: https://develop.svn.wordpress.org/trunk@23901 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-04 15:49:28 +00:00
Mark Jaquith
8351c2e87d Further cleanup of revisions code. Probably not the last.
see #23901. props adamsilverstein, azaozz, ocean90.

git-svn-id: https://develop.svn.wordpress.org/trunk@23898 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-04 07:53:49 +00:00
Mark Jaquith
f18cddb1e1 Make sure the first revision is seen as coming from emptiness, so it can be restored.
props adamsilverstein. fixes #23898.

git-svn-id: https://develop.svn.wordpress.org/trunk@23872 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-29 20:50:09 +00:00
Mark Jaquith
240dc4b968 correct a revision/tooltip mismatch.
props adamsilverstein. see #23497

git-svn-id: https://develop.svn.wordpress.org/trunk@23831 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-28 01:51:12 +00:00
Mark Jaquith
348f0f4fd5 *Very* rough runthough of revisions.js for JS style, variable names, etc.
Consider this the lawnmower that precedes Daryl's scissors.

see #23497

git-svn-id: https://develop.svn.wordpress.org/trunk@23813 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-27 12:59:41 +00:00
Peter Westwood
ae03f1a0b6 Revisions: UI Update.
* Refines the UI to make it clearer and easier to use
* Introduces weighted tickmarks
* Fixes comparison bugs.

See #23497 props adamsilverstein


git-svn-id: https://develop.svn.wordpress.org/trunk@23769 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-21 15:54:11 +00:00
Peter Westwood
ae4522b5f1 Revisions: Updates to the new Revisions UI.
Various Updates including:
 * i18n fixes
 * Added tracking of what revision ID was restored
 * async fetching of diffs so that slider works sooner even with many revisions

See #23497 props adamsilverstein, ethitter


git-svn-id: https://develop.svn.wordpress.org/trunk@23639 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-07 15:32:26 +00:00
Peter Westwood
79d635459e Revisions: Fix up some half renamed variables that break the view and display a mismash of split and combined views. See #23497 props adamsilverstein.
git-svn-id: https://develop.svn.wordpress.org/trunk@23509 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-28 16:48:33 +00:00
Peter Westwood
b1db3a3aa0 Revisions: Fix up some bugs I introduced while reviewing the mega revisions patch - when comparing two historical revisions only one half of the diff would load
See #23497 props adamsilverstein.


git-svn-id: https://develop.svn.wordpress.org/trunk@23508 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-28 16:10:45 +00:00
Peter Westwood
554627a0d5 Revisions: First pass an implementing a new UI/UX for reviewing the revisions of posts. See #23497 props adamsilverstein for the initial patch.
This implements a new revisions ui using Backbone and preserves all the old methods of "integration" so the change should be transparent to plugins using revisi
ons with CPTs.

This is the first pass and so there are a number of things still to be resolved, more details in the ticket. Feedback welcomed.


git-svn-id: https://develop.svn.wordpress.org/trunk@23506 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-28 15:14:34 +00:00