Commit Graph

22 Commits

Author SHA1 Message Date
Sergey Biryukov
4ec8c0bcfe Docs: Add missing @since entry for Walker::unset_children().
Props chiragpatel.
Fixes #39506.

git-svn-id: https://develop.svn.wordpress.org/trunk@39741 602fd350-edb4-49c9-b593-d223f7449a82
2017-01-06 14:52:24 +00:00
Drew Jaynes
195572596b Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.

Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.

Props ocean90.
Fixes #36835.


git-svn-id: https://develop.svn.wordpress.org/trunk@37431 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-13 18:40:19 +00:00
John Blackbourn
9c354378ff Avoid a PHP notice when trying to access the post_parent property of hierarchical post type nav menu items.
FIxes #34446


git-svn-id: https://develop.svn.wordpress.org/trunk@35876 602fd350-edb4-49c9-b593-d223f7449a82
2015-12-12 01:05:27 +00:00
Drew Jaynes
112a84fe93 Docs: Add missing parameter and return descriptions for Walker::get_number_of_root_elements().
Fixes #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@34121 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-14 15:32:46 +00:00
Drew Jaynes
b75e5cdfd8 Docs: Add a missing summary to the DocBlock for Walker::get_number_of_root_elements().
Props wen-solutions
See #33662.


git-svn-id: https://develop.svn.wordpress.org/trunk@33868 602fd350-edb4-49c9-b593-d223f7449a82
2015-09-02 19:50:32 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function.
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
2015-08-25 20:27:56 +00:00
Scott Taylor
4eb0e01825 Cleanup missing doc blocks for class-wp-walker.php.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32549 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 17:58:42 +00:00
Scott Taylor
46752a491e When calling unset(), it is unnecessary to immediately precede it with a call to isset().
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32545 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-22 05:46:47 +00:00
Boone Gorges
29d06de35d Walker::$has_children should be public for backward compatibility.
See [31137]. See #30891.

git-svn-id: https://develop.svn.wordpress.org/trunk@31141 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-11 01:55:34 +00:00
Scott Taylor
406b174a55 In Walker:
* Every subclass of `Walker` overrides `$db_fields` and makes it public
* `wp_list_comments()` accesses `->max_pages` on an instance of `Walker`, it must be public
* `$has_children` was added as `protected` in 4.0. doesn't need BC

Make `$db_fields` and `$max_pages` public and remove magic methods.

See #30891.


git-svn-id: https://develop.svn.wordpress.org/trunk@31137 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-10 23:43:43 +00:00
Drew Jaynes (DrewAPicture)
ab6063cc88 Fix some documentation typos in various core files.
Props vlajos.
Fixes #29199.


git-svn-id: https://develop.svn.wordpress.org/trunk@29479 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-13 03:55:10 +00:00
Drew Jaynes (DrewAPicture)
a84d50dfa3 Fix some words that aren't words.
See #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29454 602fd350-edb4-49c9-b593-d223f7449a82
2014-08-09 19:29:37 +00:00
Drew Jaynes (DrewAPicture)
7ad77d58ee Add periods to short descriptions for magic methods added in [28501], [28521], and [28524].
See #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29165 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-14 01:11:55 +00:00
Drew Jaynes (DrewAPicture)
930db4b518 Fill out inline documentation for magic methods added to the Walker class in [28514].
See #27881, #22234 and #28885.


git-svn-id: https://develop.svn.wordpress.org/trunk@29143 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-13 23:40:14 +00:00
Scott Taylor
73fe9d548b Ensure that a has_children parameter is given to Walker::start_el().
Adds unit tests.

Props scribu, obenland.
Fixes #14041.


git-svn-id: https://develop.svn.wordpress.org/trunk@28824 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 17:05:56 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:51:35 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set().
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 06:31:00 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method.
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-19 05:59:07 +00:00
wonderboymusic
2b1c764ec7 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28322 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:08:02 +00:00
Ryan Boren
30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Drew Jaynes
6ff14b2408 Improve inline documentation for the Walker class.
Includes previously undocumented parameters.

See #23406.


git-svn-id: https://develop.svn.wordpress.org/trunk@25644 602fd350-edb4-49c9-b593-d223f7449a82
2013-09-28 21:28:03 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00