Commit Graph

20580 Commits

Author SHA1 Message Date
Ryan Boren
f5fafe1a2e Don't show "Skip Cropping, Publish Image as Is" button for themes that do not support headers with flexible width or height. Forces too small images to be scaled to fit in the absence of flex support.
Props MadtownLems, kobenland
fixes #21100


git-svn-id: https://develop.svn.wordpress.org/trunk@22468 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 19:11:46 +00:00
Daryl Koopersmith
cf75c68b55 Media JS: Add media.model.Composite, to aid in the representation of joint views. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22467 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 15:32:40 +00:00
Daryl Koopersmith
68d143d20d Media: Improve sidebar handling and make attachment display properties attachment-specific.
`wp.mce.media`
* Watch all workflows for the `insert` event and attempt to insert the current state's `selection` if it exists.
* Fetch and pass attachment display properties through to `wp.media.string.image()`.

`wp.media.controller.Region`
* Separate the concept of events and modes.
* All events triggered on a `Region` trigger both `event` and `event:mode` callbacks.
* When a mode is deactivated, `deactivate` and `deactivate:mode` events are fired.
* When a mode is activated, `activate` and `activate:mode` events are fired.

`wp.media.controller.Library`
* Remove the `details()`, `buildDetails()`, and `clearDetails()` methods that juggled sidebar views. Instead, handle the sidebar views using modes.

`wp.media.controller.Gallery`
* Shift the overloaded `sidebar()` method to use modes.

`wp.media.view.MediaFrame.Post`
* Declare `activate:mode` event bindings using an nested object to reduce repetition.
* Update sidebar activation callbacks.

`wp.media.view.Settings`
* Refactor to leverage HTML data attributes and implicit values (instead of setting the fallback whenever an object was created). This has the additional benefit that gallery shortcode parameters are not output when the user has left them set to the default.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22466 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 14:15:09 +00:00
Ryan Boren
8b4612f97a If $this->posts is empty, don't do stuff to it.
Props wonderboymusic
fixes #22061


git-svn-id: https://develop.svn.wordpress.org/trunk@22465 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 13:52:40 +00:00
Andrew Nacin
6f8681b02d Revert [22445]. see #20376. fixes #22389.
git-svn-id: https://develop.svn.wordpress.org/trunk@22464 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 03:30:56 +00:00
Andrew Nacin
5395736356 In WP_Image_Editor / wp_load_image(), use is_file() rather than file_exists() so we do not accidentally load a directory.
props benkulbertis, DH-Shredder, scribu.
fixes #17814.



git-svn-id: https://develop.svn.wordpress.org/trunk@22463 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 02:02:03 +00:00
Andrew Nacin
e2f0bcf510 Proper button heights on the custom header and background pages. props johnbillion. fixes #22385.
git-svn-id: https://develop.svn.wordpress.org/trunk@22462 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 01:51:05 +00:00
Andrew Nacin
b7e9155e33 Fix the matching in is_email_address_unsafe(), which was too aggressive.
We should only check to see if the user's email address has the same
domain as or is a subdomain of any banned email domain.

Add a filter.

props mdawaffe.
fixes #21570.



git-svn-id: https://develop.svn.wordpress.org/trunk@22461 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 01:06:17 +00:00
Andrew Nacin
7f9ce4fbd3 Blue style fixes and updates. props melchoyce. see #22248.
git-svn-id: https://develop.svn.wordpress.org/trunk@22460 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-08 00:57:27 +00:00
Andrew Nacin
85efa182f7 Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855.
git-svn-id: https://develop.svn.wordpress.org/trunk@22459 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 23:54:03 +00:00
Andrew Ozz
f909a703b0 Editor: fix position of the resize handle in Text mode in RTL (also some minor css cleanup), see #21718
git-svn-id: https://develop.svn.wordpress.org/trunk@22458 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 23:33:21 +00:00
Andrew Nacin
0b66789582 Swatches for the color picker. Improves discoverability of colors especially when the picker is opened with a grayscale color. props mattwiebe. FIXES #21206.
git-svn-id: https://develop.svn.wordpress.org/trunk@22457 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 23:32:03 +00:00
bumpbot
6b78173371 Compress scripts/styles: 3.5-beta2-22455.
git-svn-id: https://develop.svn.wordpress.org/trunk@22456 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:58:33 +00:00
Andrew Nacin
5ad3756ce6 Minor UI tweaks to Press This. props lessbloat. fixes #21997.
git-svn-id: https://develop.svn.wordpress.org/trunk@22455 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:58:30 +00:00
Daryl Koopersmith
9dc03c5c29 Media: Improve memory management of views, events, and DOM nodes. see #21390.
git-svn-id: https://develop.svn.wordpress.org/trunk@22454 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:43:16 +00:00
Andrew Nacin
9817bcc28a Don't show additional focus outline on customizer sections. Remove unused CSS selectors. props lessbloat. see #21283.
git-svn-id: https://develop.svn.wordpress.org/trunk@22453 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:18:58 +00:00
Andrew Nacin
05740a6837 Customizer accessibility: Align focus styles with hover styles. props helenyhou. fixes #21283.
git-svn-id: https://develop.svn.wordpress.org/trunk@22452 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:15:49 +00:00
Andrew Nacin
80c7908e62 Sanity checks in get_body_class() to ensure we are operating on the type of queried object that we expect. props wonderboymusic. fixes #17662.
git-svn-id: https://develop.svn.wordpress.org/trunk@22451 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:12:44 +00:00
Andrew Nacin
a2082dcf2b Don't call get_term_by() in get_queried_object() if we have no terms. props wonderboymusic. fixes #21967.
git-svn-id: https://develop.svn.wordpress.org/trunk@22450 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:09:05 +00:00
Andrew Nacin
117dd15e79 Merge two strings. props pavelevap, see #22306.
git-svn-id: https://develop.svn.wordpress.org/trunk@22449 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 22:03:23 +00:00
Andrew Nacin
da07593046 Ensure a method is compatible with its parent. props kurtpayne, fixes #22265.
git-svn-id: https://develop.svn.wordpress.org/trunk@22448 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:59:20 +00:00
Andrew Nacin
02a73e7262 Fix display of a post's date fields in IE7 and IE7 compat mode. props SergeyBiryukov, lessbloat. fixes #21088.
git-svn-id: https://develop.svn.wordpress.org/trunk@22447 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:56:50 +00:00
Andrew Nacin
e775c9ee99 edit_form_after_editor action. props helenyhou. fixes #19658.
git-svn-id: https://develop.svn.wordpress.org/trunk@22446 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:49:47 +00:00
Andrew Nacin
d9bab22085 Fix meta value querying in wp_list_pages(). props SergeyBiryukov. fixes #20376.
git-svn-id: https://develop.svn.wordpress.org/trunk@22445 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:48:38 +00:00
Andrew Nacin
a95ed8d15b Put the label outside the span to ensure margins when the text wraps. props waclawjacek. fixes #19254.
git-svn-id: https://develop.svn.wordpress.org/trunk@22444 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:41:31 +00:00
Andrew Nacin
3f01c9132d Try to avoid overflow of the page template dropdown with long template names. props SergeyBiryukov, ocean90. fixes #21956.
git-svn-id: https://develop.svn.wordpress.org/trunk@22443 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:34:45 +00:00
Peter Westwood
2bd843f1e7 Post UI: Provide visual feedback to the user if they try to set an invalid date for a post. Fixes #17180 props jkudish.
git-svn-id: https://develop.svn.wordpress.org/trunk@22442 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:31:08 +00:00
Andrew Nacin
dea9cf01ce Update the old wp-app.php rule to allow for a trailing slash followed by endpoint data. props wonderboymusic. fixes #22035.
git-svn-id: https://develop.svn.wordpress.org/trunk@22441 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:27:02 +00:00
Andrew Nacin
30df4b2aa0 Allow the .hidden class to hide a button. props helenyhou. fixes #22018.
git-svn-id: https://develop.svn.wordpress.org/trunk@22440 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 21:25:25 +00:00
Andrew Ozz
0493132497 More retina backgrounds and bits, props saracannon, empireoflight and lessbloat, see #21019
git-svn-id: https://develop.svn.wordpress.org/trunk@22439 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:54:08 +00:00
bumpbot
7ec25963e0 Compress scripts/styles: 3.5-beta2-22438. TinyMCE updated.
git-svn-id: https://develop.svn.wordpress.org/trunk@22438 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:29:58 +00:00
Daryl Koopersmith
b636e94e47 Media: Integrate the gallery workflow with the media menu.
`wp.media.model.Query.more()`
* If a request has already been sent out for more attachments, return that request object instead of creating another.

`wp.media.controller.Region`
* A region allows views to be swapped in and out of a section of the page without either view having to know about the other.
* Application components can use the same callbacks and resources by leveraging `Region.mode()`, which triggers a set of callbacks to create or transform the current view, but only if necessary.

`wp.media.view.Frame`
* Leverage `Region` controllers instead of forcing states to swap view objects, which causes states to fit more comfortably in the controller-camp.
* Add `previous()`, a method to fetch the previous state `id`.
* Separate out the default settings over several objects (so blank frames can be instantiated).

`wp.media.view.MediaFrame`
* The base `Frame` used for media management: handles integration with the `Modal` and `UploaderWindow` views.

`wp.media.view.MediaFrame.Post`
* Includes all default media states and callbacks necessary for inserting media into a post.

see #21390.


git-svn-id: https://develop.svn.wordpress.org/trunk@22437 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:14:41 +00:00
Andrew Nacin
df6d81af5b Allow get_custom_header() to handle a default registered header that has yet to be saved to the database. fixes #22221.
git-svn-id: https://develop.svn.wordpress.org/trunk@22436 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:12:47 +00:00
Andrew Nacin
e25ee1e3e6 Avoid an uncaught exception in get_gmt_from_date(). The return value is imperfect - date( $format, 0 ) - but better than a fatal error. props wonderboymusic. fixes #20942.
git-svn-id: https://develop.svn.wordpress.org/trunk@22435 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:07:41 +00:00
Ryan Boren
b21172a14a Don't assign wp_the_query to wp_query by reference. Removing the ref avoids accidentally stomping wp_the_query.
Props scribu, wpmuguru
fixes #22125


git-svn-id: https://develop.svn.wordpress.org/trunk@22434 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:03:28 +00:00
Andrew Nacin
51f16233ac Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505.
git-svn-id: https://develop.svn.wordpress.org/trunk@22433 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 20:00:51 +00:00
Andrew Nacin
2dc1a1d97f Align the check column on the Updates screen. props ocean90. fixes #22339.
git-svn-id: https://develop.svn.wordpress.org/trunk@22432 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:57:55 +00:00
Andrew Nacin
c2ad4403de Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate.
props markjaquith, SergeyBiryukov. fixes #21841.



git-svn-id: https://develop.svn.wordpress.org/trunk@22431 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:56:10 +00:00
Andrew Nacin
496ae7b83f Merge some strings. props pavelevap. fixes #22306.
git-svn-id: https://develop.svn.wordpress.org/trunk@22430 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:37:54 +00:00
Andrew Nacin
a7097f60d5 Enforce a minimum of two arguments for wpdb::prepare(). The first argument is the query (or fragment thereof), which is required. Additional arguments are values to substitute into placeholders.
This will generate E_WARNINGs for insufficient arguments when prepare() is called with no additional arguments. This should discourage improper uses of prepare() under the guise of safely running a query.

props xknown. fixes #22262.



git-svn-id: https://develop.svn.wordpress.org/trunk@22429 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:30:59 +00:00
Andrew Nacin
d34180efc2 Remove single-argument calls to wpdb:prepare(), which are invalid as nothing is being prepared. see #22262.
git-svn-id: https://develop.svn.wordpress.org/trunk@22428 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:28:08 +00:00
Andrew Nacin
d1045ffced Extend Press This by a few pixels to allow longer strings. props SergeyBiryukov. fixes #20975.
git-svn-id: https://develop.svn.wordpress.org/trunk@22427 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:27:19 +00:00
Andrew Nacin
6e69cc9798 Display links if no link categories exist. props MikeHansenMe. fixes #22216.
git-svn-id: https://develop.svn.wordpress.org/trunk@22426 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 19:25:18 +00:00
Mark Jaquith
504b94b1b3 Use ImageOptim to losslessly smush our images. About half a MB in savings! fixes #22381. props waldojaquith
git-svn-id: https://develop.svn.wordpress.org/trunk@22425 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 18:49:10 +00:00
Andrew Nacin
84a66ac1bc Larger buttons for the DB upgrade screens. see #21598.
git-svn-id: https://develop.svn.wordpress.org/trunk@22424 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 18:38:17 +00:00
Andrew Nacin
e6ca72f48a Fix the 'Change' button in the users list table. props c3mdigital. fixes #22034.
git-svn-id: https://develop.svn.wordpress.org/trunk@22423 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 18:34:46 +00:00
Andrew Nacin
30280a363c Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697.
git-svn-id: https://develop.svn.wordpress.org/trunk@22422 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 18:01:31 +00:00
Ryan Boren
08a2d93b7c Call Imagick::queryformats() non-statically to preserve back compat with older versions of Imagick.
Props mpvanwinkle77
fixes #22308
see #6821


git-svn-id: https://develop.svn.wordpress.org/trunk@22421 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 17:50:38 +00:00
Andrew Nacin
7cd087d4b2 Properly return new WP_Error objects. props bpetty. see #6812.
git-svn-id: https://develop.svn.wordpress.org/trunk@22420 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 17:49:00 +00:00
Ryan Boren
46d017a331 Use retina logo in install, upgrade, setup-config, repair, and confirmation screens.
Props kopepasah, SergeyBiryukov
fixes #22375


git-svn-id: https://develop.svn.wordpress.org/trunk@22419 602fd350-edb4-49c9-b593-d223f7449a82
2012-11-07 17:34:22 +00:00