Commit Graph

26553 Commits

Author SHA1 Message Date
Scott Taylor
220fda0095 In $wpdb->update(), prevent explosions when $where is empty.
Adds unit tests.

Props UmeshSingla, wonderboymusic.
Fixes #26106


git-svn-id: https://develop.svn.wordpress.org/trunk@28814 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:23:09 +00:00
Scott Taylor
76bd35fa79 In comment_form(), allow name_submit to be passed to change the name attribute of the submit button.
Props obenland.
Fixes #22792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28813 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:09:51 +00:00
Scott Taylor
0d7450108c Use dir instead of folder in the language for jshint:plugins
Props MattyRob.
See #28464.


git-svn-id: https://develop.svn.wordpress.org/trunk@28812 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:07:00 +00:00
Scott Taylor
723927ca74 Adjust CSS for "Moved to the trash" message for a pingback in the dashboard.
Props zoerooney, codenameEli.
Fixes #28286.


git-svn-id: https://develop.svn.wordpress.org/trunk@28811 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-24 00:02:17 +00:00
Scott Taylor
848034a190 Use unobtrusive JS for Comment list table row actions.
Props aubreypwd.
Fixes #27533.


git-svn-id: https://develop.svn.wordpress.org/trunk@28810 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 23:54:28 +00:00
Sergey Biryukov
ee307dc160 Use assertCount() for consistency with other tests.
see #28611.

git-svn-id: https://develop.svn.wordpress.org/trunk@28809 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 22:26:12 +00:00
Sergey Biryukov
2120ede170 Remove mbstring_binary_safe_strlen(). Use mbstring_binary_safe_encoding() and reset_mbstring_encoding() directly.
fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28808 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 22:20:23 +00:00
Scott Taylor
0adec3db8a Use the proper height property when calculating video size in wp_underscore_video_template().
Props Fab1en.
See #28190.


git-svn-id: https://develop.svn.wordpress.org/trunk@28807 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 20:34:14 +00:00
Sergey Biryukov
4fd715c937 Introduce a binary-safe wrapper for strlen() and use it in seems_utf8(), utf8_uri_encode(), and wp_read_image_metadata().
Use binary-safe POMO_Reader::strlen() in MO::export_to_file_handle().

fixes #28162.

git-svn-id: https://develop.svn.wordpress.org/trunk@28806 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:47:08 +00:00
Sergey Biryukov
b11b6f2f2b Simplify the code for calculating plugin API check timeout.
props leewillis77.
fixes #28600.

git-svn-id: https://develop.svn.wordpress.org/trunk@28805 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 14:30:14 +00:00
Sergey Biryukov
21cf4d1ab4 Don't kill an empty search query.
see #11330.

git-svn-id: https://develop.svn.wordpress.org/trunk@28804 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 13:33:39 +00:00
Sergey Biryukov
f7d7ecd0a6 Prevent multiple hierarchical posts with the same slug from being displayed in single post template.
fixes #28611.

git-svn-id: https://develop.svn.wordpress.org/trunk@28803 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-23 13:14:39 +00:00
Sergey Biryukov
1c7bfc7ed1 Revert [28776] and use a correct variable instead.
props miqrogroove.
fixes #28575.

git-svn-id: https://develop.svn.wordpress.org/trunk@28802 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 22:12:47 +00:00
Sergey Biryukov
256de085ec Fix MediaElement i18n.
props Namibia, eherman24.
fixes #28366 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28801 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 14:15:55 +00:00
Sergey Biryukov
f393fecbc5 Add @ticket references.
see #16854, #19198.

git-svn-id: https://develop.svn.wordpress.org/trunk@28800 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-22 01:40:38 +00:00
Scott Taylor
562d64a4a3 Improve Travis CI configuration for better performance.
Props netweb, jorbin.
Fixes #28301.


git-svn-id: https://develop.svn.wordpress.org/trunk@28799 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 20:05:19 +00:00
Scott Taylor
72a61e941d Add a grunt jshint:plugins task.
Props MattyRob.
Fixes #28464.


git-svn-id: https://develop.svn.wordpress.org/trunk@28798 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 20:02:47 +00:00
Scott Taylor
5c48c4f8a8 Allow wp_die() to die in plain text when running the test suite.
Props jorbin.
Fixes #27749.


git-svn-id: https://develop.svn.wordpress.org/trunk@28797 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 19:59:28 +00:00
Scott Taylor
ce3248c482 Update phpunit grunt task to not use deprecated util package. Run npm install or sudo npm install to get the updates.
Props jorbin.
Fixes #27343.


git-svn-id: https://develop.svn.wordpress.org/trunk@28796 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 19:44:26 +00:00
Andrew Ozz
31da18f841 TinyMCE: revert 158b742410 and 576fa77aa2 as they may cause selection restore problems in old IE. See #28391.
git-svn-id: https://develop.svn.wordpress.org/trunk@28795 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-21 01:14:43 +00:00
Andrew Nacin
c45a47efdd Stop denying wp-includes/* in our default robots.txt.
props joostdevalk.
fixes #28604.


git-svn-id: https://develop.svn.wordpress.org/trunk@28794 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 21:01:29 +00:00
Andrew Nacin
18d069703b Fix documentation for wp_create_nonce() which wrongly suggests these tokens are actually numbers used once.
git-svn-id: https://develop.svn.wordpress.org/trunk@28793 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 20:46:13 +00:00
Scott Taylor
84fb91f383 Don't annotate $wp_error twice in login_header() docs. $wp_error is always expected to be of type WP_Error.
Props SergeyBiryukov.
Fixes #28518.


git-svn-id: https://develop.svn.wordpress.org/trunk@28792 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:18:25 +00:00
Scott Taylor
304f4f5ba9 Posts in the Trash should not drag attachment pages down with them.
Props ericlewis.
Fixes #14639.


git-svn-id: https://develop.svn.wordpress.org/trunk@28791 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 19:13:39 +00:00
Scott Taylor
e447c8f823 Add Animoto to the list of oEmbed providers. Example video: http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA.
Props lritter.
Fixes #28265.



git-svn-id: https://develop.svn.wordpress.org/trunk@28790 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:56:11 +00:00
Scott Taylor
4540455f95 Whitespace in navMenuL10n after [28707].
Fixes #23076.



git-svn-id: https://develop.svn.wordpress.org/trunk@28789 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:29:44 +00:00
Scott Taylor
a7c1728f2e Reinstate the changes from [28579] with some adjustments:
* Check `! empty( $postarr['file'] )` before calling `update_attached_file()`
* Add a unit test: `test_update_attachment_fields()`
* Run the same logic for empty `guid` for attachments that always ran in `wp_insert_post()`, as per #18310. This fixes a unit test that would have broken when this ticket was marked closed.
* Updated the unit test in `Tests_Media::test_wp_prepare_attachment_for_js()` to account for `url` no longer being empty

Props kovshenin, wonderboymusic.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28788 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 18:26:17 +00:00
Scott Taylor
05abd7e56f Cleanup wp_widget_rss_form() after [28734]. "$$input used sanitized variables which contained actual values, unlike $inputs[$input] which in that context contains data about which input fields are hidden."
Props kovshenin.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28787 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:28:12 +00:00
Scott Taylor
76ccf2a956 Remove unused globals from link-parse-opml.php after [28743].
Props SergeyBiryukov.
Fixes #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28786 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:25:47 +00:00
Scott Taylor
33275a0826 Cleanup after [28671]:
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests

Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606.


git-svn-id: https://develop.svn.wordpress.org/trunk@28785 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 17:11:14 +00:00
Scott Taylor
eb289835f7 Further adjustments after [8364], listen to an editor instance event instead of delegating a body click when attempting to pause all players belonging to a particular MCE view.
Props avryl.
Fixes #27971.


git-svn-id: https://develop.svn.wordpress.org/trunk@28784 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:29:47 +00:00
Scott Taylor
5ec545d5ab Revert [28613] and [28664]. A good idea, but too much BC baggage.
See #28099.



git-svn-id: https://develop.svn.wordpress.org/trunk@28783 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-20 16:20:35 +00:00
John Blackbourn
dbc30e94b3 Increase the timeout for plugin and theme update checks based on how many are being checked. Props dd32. Fixes #25788
git-svn-id: https://develop.svn.wordpress.org/trunk@28782 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 23:20:15 +00:00
John Blackbourn
036c2b5fca Remove SSL verification by default for requests to wp-cron.php. Props sivel, rhurling. Fixes #12609.
git-svn-id: https://develop.svn.wordpress.org/trunk@28781 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 22:52:35 +00:00
Andrew Nacin
e27b672b22 Narrower screen when choosing a language. see #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28780 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 04:46:40 +00:00
Andrew Nacin
aa6ef01298 Fix variable usage in new language install choices. see #28577.
git-svn-id: https://develop.svn.wordpress.org/trunk@28779 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 04:36:29 +00:00
Helen Hou-Sandi
ae2cce3f64 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583.
git-svn-id: https://develop.svn.wordpress.org/trunk@28778 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 02:17:08 +00:00
Sergey Biryukov
4bee2a9c4a Fix copy/paste error in a comment.
see #28581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28777 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 01:35:28 +00:00
Sergey Biryukov
4306de30e3 Move preg_match() that should only run once out of the loop.
props dllh.
fixes #28575.

git-svn-id: https://develop.svn.wordpress.org/trunk@28776 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 00:00:27 +00:00
Scott Taylor
9642d17ff8 Diambiguate type and shortcode in TinyMCE view classes and their attached view.View class. Has the added feature of not causing JS errors.
See #28532.


git-svn-id: https://develop.svn.wordpress.org/trunk@28775 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 23:02:10 +00:00
Andrew Nacin
39cf46851b Allow a language to be chosen before installing WordPress. First pass.
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 


git-svn-id: https://develop.svn.wordpress.org/trunk@28774 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:57:21 +00:00
Scott Taylor
0688f9eb49 In wptexturize() + tests:
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.

Props miqrogroove.
Fixes #28564.


git-svn-id: https://develop.svn.wordpress.org/trunk@28773 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 19:48:46 +00:00
Sergey Biryukov
6719d08d2d Revert [28766].
see #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28772 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 02:22:45 +00:00
Sergey Biryukov
9561db4dee Don't add # to URL when clicking 'OK' without changing the permalink.
props avryl.
fixes #27594.

git-svn-id: https://develop.svn.wordpress.org/trunk@28771 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:28:35 +00:00
Sergey Biryukov
550d0f0aea Don't generate adjacent links in wp_head() for attachments.
props kovshenin.
fixes #21658.

git-svn-id: https://develop.svn.wordpress.org/trunk@28770 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-18 00:04:14 +00:00
Sergey Biryukov
566fd5da8d Pass WP_Customize_Setting instance to 'customize_save_*' action.
props danielbachhuber.
fixes #27979.

git-svn-id: https://develop.svn.wordpress.org/trunk@28769 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:57:19 +00:00
Andrew Ozz
b8fd9d997e TinyMCE: update to 4.0.28+. Includes all changes until 09-06-2014: 32cb108d41. Changelog: 32cb108d41/changelog.txt.
See #28391.

git-svn-id: https://develop.svn.wordpress.org/trunk@28768 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:49:00 +00:00
Sergey Biryukov
f1172ba195 Pass WP_Customize_Setting instance to 'customize_preview_*' and 'customize_update_*' actions.
props dustyn, DrewAPicture.
fixes #27979.

git-svn-id: https://develop.svn.wordpress.org/trunk@28767 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 23:34:31 +00:00
Sergey Biryukov
63596d6868 Prevent bulk actions from being performed when Filter button is clicked.
props layotte.
fixes #28555.

git-svn-id: https://develop.svn.wordpress.org/trunk@28766 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 22:16:11 +00:00
Scott Taylor
b11edb94d9 Fix abbreviations mixed with quotes, example: '99% of people'.
Add/alter unit tests.

Props miqrogroove.
Fixes #26850.


git-svn-id: https://develop.svn.wordpress.org/trunk@28765 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-17 20:18:38 +00:00