Commit Graph

24 Commits

Author SHA1 Message Date
Drew Jaynes
1cd420af5e Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.


git-svn-id: https://develop.svn.wordpress.org/trunk@37488 602fd350-edb4-49c9-b593-d223f7449a82
2016-05-22 18:00:23 +00:00
Dominik Schilling (ocean90)
39ddaa65cc Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
Fixes #36218.

git-svn-id: https://develop.svn.wordpress.org/trunk@36970 602fd350-edb4-49c9-b593-d223f7449a82
2016-03-12 12:38:48 +00:00
Drew Jaynes
3725408616 Docs: Document declaration of the $submenu_file global in wp-admin/menu-header.php.
See #24531. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34725 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-01 01:47:07 +00:00
Drew Jaynes
72e5ad9390 Declare the $submenu_file global to avoid a notice generated by passing it as a parameter to the submenu_file hook, introduced in [34722].
Fixes #24531.


git-svn-id: https://develop.svn.wordpress.org/trunk@34724 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-01 01:22:55 +00:00
Sergey Biryukov
be98773ac9 Add 'submenu_file' filter for the file of an admin menu sub-menu item.
This complements the `'parent_file'` filter added in [12712].

Props swissspidy, kraftbj.
Fixes #24531.

git-svn-id: https://develop.svn.wordpress.org/trunk@34722 602fd350-edb4-49c9-b593-d223f7449a82
2015-10-01 00:22:37 +00:00
Scott Taylor
9f5df5d045 Admin menu: improve accessibility when collapsed.
Props afercia.
Fixes #32346.


git-svn-id: https://develop.svn.wordpress.org/trunk@32946 602fd350-edb4-49c9-b593-d223f7449a82
2015-06-25 19:32:36 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*.
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
2015-05-28 21:40:27 +00:00
Dominik Schilling (ocean90)
14dc44fb83 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.

git-svn-id: https://develop.svn.wordpress.org/trunk@31955 602fd350-edb4-49c9-b593-d223f7449a82
2015-04-01 13:16:47 +00:00
Sergey Biryukov
692f79087f In _wp_menu_output(), $submenu_items is an array and should be initialized as such.
props ipm-frommen.
fixes #31257.

git-svn-id: https://develop.svn.wordpress.org/trunk@31364 602fd350-edb4-49c9-b593-d223f7449a82
2015-02-07 17:56:18 +00:00
Scott Taylor
0c37f866f2 After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks.
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31106 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 22:51:30 +00:00
Scott Taylor
c4e2ad04a2 Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php.
Fixes #30958.


git-svn-id: https://develop.svn.wordpress.org/trunk@31105 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 22:14:58 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
2015-01-08 07:04:40 +00:00
Helen Hou-Sandi
db97a05fce Accessibility: hide admin menu separators from screen readers.
props afercia. fixes #30010.


git-svn-id: https://develop.svn.wordpress.org/trunk@30393 602fd350-edb4-49c9-b593-d223f7449a82
2014-11-19 19:36:43 +00:00
Drew Jaynes (DrewAPicture)
6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-17 09:13:53 +00:00
Sergey Biryukov
d2a246e82c Avoid inadvertently adding admin page titles as classes for admin menu submenu items.
fixes #28817.

git-svn-id: https://develop.svn.wordpress.org/trunk@29083 602fd350-edb4-49c9-b593-d223f7449a82
2014-07-11 01:09:32 +00:00
Helen Hou-Sandi
ae2cce3f64 Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583.
git-svn-id: https://develop.svn.wordpress.org/trunk@28778 602fd350-edb4-49c9-b593-d223f7449a82
2014-06-19 02:17:08 +00:00
Dominik Schilling (ocean90)
1de1f27249 Admin Menu: Use .dashicons-before as default $img_class.
props kovshenin for noticing and testing.
see #26630.

git-svn-id: https://develop.svn.wordpress.org/trunk@27425 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 23:21:11 +00:00
Dominik Schilling (ocean90)
8f1a77a070 Introduce a .dashicons-before CSS class.
If you want to use a Dashicon before an element you can use the class because it will not change the elements content styling. With that you don't need to copy the entire `.dashicons` styling to your :before styling anymore.
To demonstrate this change, Admin Menu now uses Dashicons classes directly.

And it fixes a glitch in IE.

fixes #26630.

git-svn-id: https://develop.svn.wordpress.org/trunk@27418 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-05 20:03:33 +00:00
Sergey Biryukov
13571cf6b2 Update comment about structure of items in $menu global.
props kitchin.
fixes #26635.

git-svn-id: https://develop.svn.wordpress.org/trunk@27151 602fd350-edb4-49c9-b593-d223f7449a82
2014-02-09 21:42:28 +00:00
Drew Jaynes
74df859ebf Inline documentation for hooks in wp-admin/menu-header.php.
Props piontkowski, kpdesign.
Fixes #26051.


git-svn-id: https://develop.svn.wordpress.org/trunk@26893 602fd350-edb4-49c9-b593-d223f7449a82
2014-01-02 02:45:29 +00:00
Helen Hou-Sandi
df454bb0b6 More targeted background image styling for admin menu SVG icons. fixes #25147.
git-svn-id: https://develop.svn.wordpress.org/trunk@26671 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 17:52:48 +00:00
Andrew Nacin
006045395c Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.

To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.

props helen.
fixes #25147.


git-svn-id: https://develop.svn.wordpress.org/trunk@26664 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-05 06:37:20 +00:00
Helen Hou-Sandi
17a8516d2e Remove now-unused #adminmenushadow. see #25858.
git-svn-id: https://develop.svn.wordpress.org/trunk@26182 602fd350-edb4-49c9-b593-d223f7449a82
2013-11-14 23:48:44 +00:00
Andrew Nacin
b43712e0f7 New develop.svn.wordpress.org repository based on the old core.svn repository.
* All WordPress files move to a src/ directory.
 * New task runner (Grunt), configured to copy a built WordPress to build/.
 * svn:ignore and .gitignore for Gruntfile.js, wp-config.php, and node.js.
 * Remove Akismet external from develop.svn. Still exists in core.svn.
 * Drop minified files from src/. The build process will now generate these.

props koop.
see #24976.

and see http://wp.me/p2AvED-1AI.



git-svn-id: https://develop.svn.wordpress.org/trunk@25001 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-07 05:25:25 +00:00