Commit Graph

39523 Commits

Author SHA1 Message Date
Andrew Ozz da7b514926 TinyMCE: fix editor height when loaded hidden.
Props nnikolov, azaozz.
Fixes #45461.

git-svn-id: https://develop.svn.wordpress.org/trunk@44832 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-12 20:13:14 +00:00
Dominik Schilling e6442466f9 I18N: Add `$domain` argument to `translate_user_role()`.
The text domain is optional and gets passed to `translate_with_gettext_context()`.

Props johnjamesjacoby	.
Fixes #38736.

git-svn-id: https://develop.svn.wordpress.org/trunk@44830 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-11 20:31:46 +00:00
Jonathan Desrosiers ecfc9872d7 General: Add missing `@since` annotation for `wp_get_direct_php_update_url()`.
Missed in [44815].

Props birgire.
See #46074.

git-svn-id: https://develop.svn.wordpress.org/trunk@44829 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-11 12:58:28 +00:00
Sergey Biryukov ae5940dd25 Bootstrap/Load: Add `nocache_headers()` to all `wp_die()` handlers.
Props spacedmonkey.
Fixes #46054.

git-svn-id: https://develop.svn.wordpress.org/trunk@44828 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-11 11:46:41 +00:00
Sergey Biryukov cba9eda1f4 Database: Use `wp_die()` instead of `die()` in `dead_db()`, for more flexibility and consistency with other error messages in core.
Props gitlost.
Fixes #41655.

git-svn-id: https://develop.svn.wordpress.org/trunk@44827 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-11 11:30:18 +00:00
Sergey Biryukov 56e7d96070 Docs: Improve wording in a comment in `wp_set_current_user()`.
Props nielsdeblaauw.
Fixes #45032.

git-svn-id: https://develop.svn.wordpress.org/trunk@44826 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-11 10:56:39 +00:00
Andrea Fercia 2e6ce4195b Accessibility: Customize: Improve the widgets search and the widget Remove button.
- debounces the widgets search to avoid multiple `speak()` audible messages while typing: search results and messages are now triggered when users stop typing
- clarifies the Remove button title attribute
- removes a couple unnecessary `preventDefault()`

Props davetgreen, afercia.
Fixes #28888.


git-svn-id: https://develop.svn.wordpress.org/trunk@44825 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-09 12:55:12 +00:00
Jonathan Desrosiers 1615233fa2 Privacy: Be less restrictive of the HTML tags allowed in user data exports.
Previously, only `a` and `br` tags were allowed in the `value` table cell for each field included in the HTML file generated when a user is exporting their personal data. Instead of relying on a hardcoded list of allowed tags, the `wp_kses()` call in `wp_privacy_generate_personal_data_export_group_html()` will now fallback to the default list of allowed tags (which includes `i`, `strong`, `em`, and other basic HTML formatting tags).

Also, a new context of `personal_data_export` will now be passed to the `wp_kses()` call. As a result, the list of HTML tags and attributes allowed in the export file can now be filtered using the `wp_kses_allowed_html` filter and checking for the `personal_data_export` context.

Fixes #44044.
Props tz-media, desrosj, pento, birgire, garrett-eclipse.

git-svn-id: https://develop.svn.wordpress.org/trunk@44824 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-08 22:04:50 +00:00
Jonathan Desrosiers a71fece6b8 Built/Test Tools: Add missing access modifiers to `abstract-testcase.php`.
Fixes #46384.
Props andizer.

git-svn-id: https://develop.svn.wordpress.org/trunk@44823 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-08 20:51:32 +00:00
Boone Gorges 3f60af4bcc Taxonomy: Introduce `post_column_taxonomy_links`.
This filter allows plugin developers to modify the markup for the links
in taxonomy columns on edit.php.

Props DaveFX.
Fixes #42669.

git-svn-id: https://develop.svn.wordpress.org/trunk@44822 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-08 15:36:04 +00:00
Jonathan Desrosiers e10f419b3c Privacy: Add missing header text for screen readers to privacy list tables.
In [34891], `WP_Screen` was updated with methods to store, retrieve, and render screen reader text used by screens with `WP_List_Table` instances. When the export/erase personal data list tables were introduced in [42967], these headings were missing.

Fixes #46041.
Props afercia, xkon, garrett-eclipse, desrosj.

git-svn-id: https://develop.svn.wordpress.org/trunk@44821 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-08 15:24:22 +00:00
allancole 315616aa5e Twenty Nineteen: Improve custom color behavior for InnerBlocks
Currently, if a parent block has a custom background color assigned, its child blocks will inherit the parent's text colors — even if the child block has its own custom text color assigned to it. 

This update changes the following: 

- Adjusts Twenty Nineteen's custom background color defaults to target direct children only which fixes the issue

Props kjellr.

See #46432.



git-svn-id: https://develop.svn.wordpress.org/trunk@44818 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 22:36:58 +00:00
Jonathan Desrosiers 0f618b4f30 Widgets: Remove `change` event when editing a Custom HTML widget.
The `change` event was previously required to ensure that the Customizer picked detected changes to the widget’s content and synced them to the preview. In the current state, though, the `trigger( ‘change’ )` is no longer required and is causing issues with the widget’s “Done” and “Save” buttons.

Fixes #45335.
Props audrasjb, afercia, westonruter.

git-svn-id: https://develop.svn.wordpress.org/trunk@44816 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 22:25:55 +00:00
Jonathan Desrosiers 8ae4796288 General: Add a way to specify a direct link for a user to update PHP.
A direct URL to where a user can update PHP for their website can now be specified in one of two ways:

- Defining the `WP_DIRECT_UPDATE_PHP_URL` environment variable.
- Returning a URL to the `wp_direct_php_update_url` filter.

When a URL is specified, an additional “Update PHP” button will be displayed at the bottom of the Core dashboard widget informing administrators that their site is running an outdated version of PHP (see [42832]).

Fixes #46074.
Props afragen, desrosj, lukecarbis.

git-svn-id: https://develop.svn.wordpress.org/trunk@44814 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 21:31:50 +00:00
Sergey Biryukov 31bc4e2bac Users: Use `login__in` parameter for `WP_User_Query` in `WP_MS_Users_List_Table::prepare_items()`, instead of a manual query.
Props spacedmonkey.
Fixes #45223.

git-svn-id: https://develop.svn.wordpress.org/trunk@44813 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 12:34:56 +00:00
Riad Benguella ccfb76d26f Block Editor: Fix unit tests after new blocks addition.
- Regenerate the REST API fixtures.
 - Remove the block registration hooks in the unit tests.

Refs #46429.


git-svn-id: https://develop.svn.wordpress.org/trunk@44812 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 11:53:15 +00:00
Sergey Biryukov 0ad7b1a169 Theme Editor: Capitalize "Think very carefully about your site crashing..." message for consistency with other strings.
Props immeet94.
Fixes #46436.

git-svn-id: https://develop.svn.wordpress.org/trunk@44811 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 10:16:49 +00:00
Riad Benguella ccaa0663a2 Block Editor: Include the missing blocks files
These were missed from the previous commit.

Refs #46429.


git-svn-id: https://develop.svn.wordpress.org/trunk@44810 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 09:23:36 +00:00
Sergey Biryukov 4b10390b7d Date/Time: Reduce explicit local `current_time( 'timestamp' )` usage in favor of native PHP functions.
Timestamps don't carry any timezone information, using the intended format directly simplifies the logic and makes the code less confusing.

Props Rarst, jdgrimes.
See #40657.

git-svn-id: https://develop.svn.wordpress.org/trunk@44809 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 09:11:37 +00:00
Riad Benguella 79a3abcb2a Block Editor: Update the WordPress Packages from Gutenberg 5.2.
Updated Packages:

 - @wordpress/a11y@2.1.0
 - @wordpress/annotations@1.1.0
 - @wordpress/api-fetch@3.0.0
 - @wordpress/autop@2.1.0
 - @wordpress/babel-plugin-import-jsx-pragma@2.0.0
 - @wordpress/babel-plugin-makepot@3.0.0
 - @wordpress/babel-preset-default@4.0.0
 - @wordpress/blob@2.2.0
 - @wordpress/block-editor@1.0.0
 - @wordpress/block-library@2.3.0
 - @wordpress/block-serialization-default-parser@3.0.0
 - @wordpress/block-serialization-spec-parser@3.0.0
 - @wordpress/blocks@6.1.0
 - @wordpress/browserslist-config@2.3.0
 - @wordpress/components@7.1.0
 - @wordpress/compose@3.1.0
 - @wordpress/core-data@2.1.0
 - @wordpress/custom-templated-path-webpack-plugin@1.2.0
 - @wordpress/data@4.3.0
 - @wordpress/date@3.1.0
 - @wordpress/deprecated@2.1.0
 - @wordpress/docgen@1.0.0
 - @wordpress/dom-ready@2.1.0
 - @wordpress/dom@2.1.0
 - @wordpress/e2e-test-utils@1.0.0
 - @wordpress/e2e-tests@1.0.0
 - @wordpress/edit-post@3.2.0
 - @wordpress/editor@9.1.0
 - @wordpress/element@2.2.0
 - @wordpress/escape-html@1.1.0
 - @wordpress/eslint-plugin@2.0.0
 - @wordpress/format-library@1.3.0
 - @wordpress/hooks@2.1.0
 - @wordpress/html-entities@2.1.0
 - @wordpress/i18n@3.2.0
 - @wordpress/is-shallow-equal@1.2.0
 - @wordpress/jest-console@3.0.0
 - @wordpress/jest-preset-default@4.0.0
 - @wordpress/jest-puppeteer-axe@1.0.0
 - @wordpress/keycodes@2.1.0
 - @wordpress/library-export-default-webpack-plugin@1.1.0
 - @wordpress/list-reusable-blocks@1.2.0
 - @wordpress/notices@1.2.0
 - @wordpress/npm-package-json-lint-config@1.2.0
 - @wordpress/nux@3.1.0
 - @wordpress/plugins@2.1.0
 - @wordpress/postcss-themes@2.0.0
 - @wordpress/priority-queue@1.0.0
 - @wordpress/redux-routine@3.1.0
 - @wordpress/rich-text@3.1.0
 - @wordpress/scripts@3.0.0
 - @wordpress/shortcode@2.1.0
 - @wordpress/token-list@1.2.0
 - @wordpress/url@2.4.0
 - @wordpress/viewport@2.2.0
 - @wordpress/wordcount@2.1.0

This also includes the update to the scripts dependencies and the new widgets php files.

Props iseulde.
Fixes #46429.


git-svn-id: https://develop.svn.wordpress.org/trunk@44808 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 09:08:38 +00:00
Jeremy Felt 716eea408b Multisite: Fix code formatting errors from r44805
See #46351.


git-svn-id: https://develop.svn.wordpress.org/trunk@44806 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 03:45:26 +00:00
Jeremy Felt 0d707e5da2 Multisite: Ensure `wpmu_new_blog` hook receives expected data in `$meta`.
Restores `public`, `archived`, `mature`, `spam`, `deleted`, `lang_id`, and `WPLANG` to the `$meta` data passed to `wpmu_new_blog`. This hook was deprecated in 5.1.0, but code using it still relies on this data.

Props david.binda, pbiron.
Fixes #46351.


git-svn-id: https://develop.svn.wordpress.org/trunk@44805 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 03:33:25 +00:00
Boone Gorges 0cc536e173 Taxonomy: Add `level-n` classes to rows on edit-tags.php.
Props johnjamesjacoby.
Fixes #38810.

git-svn-id: https://develop.svn.wordpress.org/trunk@44804 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-07 03:03:57 +00:00
Aaron Jorbin 8b9f7b4d6b Build: Add PHP 7.4 to the Travis build.
Travis have switched the nightly PHP version to PHP 8.0. The 7.4snapshot version is PHP 7.4.

We don't support 7.4 yet, so it's in allowed failures.

Fixes #46235.


git-svn-id: https://develop.svn.wordpress.org/trunk@44803 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-06 21:01:53 +00:00
Sergey Biryukov 14cebbe987 Menus: After [42857], apply background to the correct elements on Menus screen.
Props audrasjb, afercia, mukesh27, garrett-eclipse.
Fixes #46368.

git-svn-id: https://develop.svn.wordpress.org/trunk@44801 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 21:00:14 +00:00
Sergey Biryukov ff957050ce Networks and Sites: Check the result of `get_site()` in `wp_insert_site()`.
Props davidbinda, vanyukov, lukecarbis.
Fixes #46300.

git-svn-id: https://develop.svn.wordpress.org/trunk@44799 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 20:34:58 +00:00
Sergey Biryukov 98c71e17e2 I18N: Remove trailing spaces from translatable strings introduced in [43436].
Props dimadin.
Fixes #46277.

git-svn-id: https://develop.svn.wordpress.org/trunk@44797 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 20:13:05 +00:00
Andrea Fercia 951b462ea2 Accessibility: Replace media placeholder clickable divs with buttons.
`<button>` elements are natively interactive, supported by any assistive technology, and must be used instead of non-semantic, non-accessible `<div>` elements.

Also, this change aligns the Media Widgets and the Customizer site icon and site logo controls with the design pattern used in the new Block Editor for similar controls.

Props ramonopoly, welcher, afercia.
Fixes #43151.


git-svn-id: https://develop.svn.wordpress.org/trunk@44796 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 17:49:00 +00:00
Peter Wilson da4f8d0ffb Comments: Allow for `comment-reply.js` to be loaded in the HTML header.
Allows for themes or plugins setting the comment-reply JavaScript as a dependency of an HTML header script. This in turn causes `comment-reply.js` to be loaded early, requiring execution to be delayed.

Props pento, peterwilsoncc, jorbin for feedback.
Fixes #46280.



git-svn-id: https://develop.svn.wordpress.org/trunk@44794 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-05 01:51:31 +00:00
Andrea Fercia e8fa2d66d0 Accessibility: Hide the Toolbar sub-menu CSS generated icons from assistive technologies.
CSS generated content is rendered for speech output. When it's not meant to be announced by assistive technologies, for example with font icons, special care should be used to hide it. At the moment, the only reliable way to do this is making use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.


git-svn-id: https://develop.svn.wordpress.org/trunk@44793 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 22:45:24 +00:00
Jonathan Desrosiers 4a09766cb0 Privacy: Remove two test methods that fail on certain configurations.
The `test_detects_cannot_create_index()` and `tests_detects_cannot_write_html()` test methods are prone to failure under certain configurations, as discovered by the hosts reporting back the test suite results. This removes those two methods until a better approach to testing those scenarios can be created.

Partial revert of [44786].
See #44233.

git-svn-id: https://develop.svn.wordpress.org/trunk@44792 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 22:19:05 +00:00
Andrea Fercia 19abdee85f Coding standards: Fix incorrect CSS `rgba()` values.
Also, fixes some indentation where spaces were used instead of tabs.

Props nielslange, mukesh27.
Fixes #45937.


git-svn-id: https://develop.svn.wordpress.org/trunk@44791 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 22:01:10 +00:00
Jonathan Desrosiers d80e627fdf Build/Test Tools: Fix validation error in multisite PHPUnit configuration file.
A PHPUnit configuration file with more than one `<php>` tag causes a validation error in PHPUnit versions 7.x. There are currently 2 in the `tests/phpunit/multisite.xml` file, which appears to be accidentally introduced in [29954].

Fixes #46414.

git-svn-id: https://develop.svn.wordpress.org/trunk@44790 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 21:32:02 +00:00
Felix Arntz 521c4a81a8 General: Introduce `wp_is_php_version_acceptable` filter to make the check for triggering PHP version warnings stricter.
The filter is only run if the wordpress.org API considers the PHP version acceptable. This ensures that other plugins or hosting providers can only make this check stricter, but not loosen it.

Props j-falk, mikeschroder.
Fixes #46065.


git-svn-id: https://develop.svn.wordpress.org/trunk@44788 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 21:13:45 +00:00
Jonathan Desrosiers 0e59ee558d Privacy: Remove privacy feature related admin pointers.
In 4.9.6, several new privacy related features were introduced. Admin pointers were included to make administrators aware of these features. They have served their purpose and can now go silently into the night.

Props garrett-eclipse, desrosj, xkon.
Fixes #45999.

git-svn-id: https://develop.svn.wordpress.org/trunk@44787 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 20:46:25 +00:00
Jonathan Desrosiers 636af9078d Privacy: Add missing unit tests for exporting personal data.
Props allendav, birgire, iandunn, desrosj, garrett-eclipse.
Fixes 44233.

git-svn-id: https://develop.svn.wordpress.org/trunk@44786 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-04 19:35:30 +00:00
Aaron Jorbin e421f262dc Replace usages of basename() with wp_basename() in order to support multibyte filenames
This is focused on the pieces of code that touch media files and the tests that support them. `basename` isn't multibyte compatible out of the box. See http://php.net/basename and https://bugs.php.net/bug.php?id=62119.

See #43170.
Props Viper007Bond.


git-svn-id: https://develop.svn.wordpress.org/trunk@44785 602fd350-edb4-49c9-b593-d223f7449a82
2019-03-01 20:57:26 +00:00
Sergey Biryukov 4c45ff7c43 Users: Revert [44780] pending test failure investigation.
See #45845.

git-svn-id: https://develop.svn.wordpress.org/trunk@44784 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 22:57:47 +00:00
Jonathan Desrosiers 91e5365218 Editor: Allow the default font size options to be removed.
Similar to `editor-color-palette`, a theme or plugin should be able to set the theme support for `editor-font-sizes` to an empty array, indicating that no additional font sizes should be available in the block’s ‘Text Settings’. The current conditional was using `empty()`, which was incorrectly causing the default font sizes to be used instead.

Props jorgefilipecosta, chrisvanpatten, SergeyBiryukov.
Fixes #46290.

git-svn-id: https://develop.svn.wordpress.org/trunk@44782 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 21:43:04 +00:00
Adam Silverstein faa0bcd2c6 Revisions: improve display responsiveness, especially on smaller screen sizes.
* Fix an overlap issue with the "Restore this Revision" button that made it difficult to use on phone sized devices.

Props ryan, PranaliPatel, karinedo.
Fixes #33830.



git-svn-id: https://develop.svn.wordpress.org/trunk@44781 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 20:10:53 +00:00
Sergey Biryukov a16cbba2fd Users: Replace raw SQL query in `check_password_reset_key()` with `get_user_by()`.
Props davidbaumwald, iworks, spacedmonkey.
Fixes #45845.

git-svn-id: https://develop.svn.wordpress.org/trunk@44780 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 14:38:27 +00:00
Sergey Biryukov 169a73aaed Privacy: Escape Privacy Policy guide URL in in Privacy Policy edit page notice.
Props itowhid06, garrett-eclipse.
Fixes #44761.

git-svn-id: https://develop.svn.wordpress.org/trunk@44779 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 12:07:20 +00:00
Sergey Biryukov 4620357c99 Privacy: Improve translator comments for Privacy Policy page links in Privacy Settings; escape URLs.
Props birgire, garrett-eclipse.
Fixes #46369.

git-svn-id: https://develop.svn.wordpress.org/trunk@44778 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 12:00:45 +00:00
Sergey Biryukov 9074c8dd94 Privacy: Return a more accurate error message when the user cannot perform the requested action.
Props mmuhsin, jplojohn, garrett-eclipse, desrosj.
Fixes #44833.

git-svn-id: https://develop.svn.wordpress.org/trunk@44777 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 11:48:46 +00:00
Sergey Biryukov 010cdb3ce6 Login and Registration: Update URLs for browser cookie documentation.
Props joostdevalk.
Fixes #46254.

git-svn-id: https://develop.svn.wordpress.org/trunk@44776 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 11:43:24 +00:00
Sergey Biryukov 835279c775 Privacy: Change "Email Data" link text on "Export Personal Data" screen to "Send Export Link" for clarity.
Previously: [43172], accidentally reverted in [43212].

Props birgire, ianbelanger.
Fixes #44822. See #43964.

git-svn-id: https://develop.svn.wordpress.org/trunk@44775 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 11:36:54 +00:00
Sergey Biryukov ebe84c7e52 Twenty Nineteen: Remove stray `÷` character in `print.css`.
Props mukesh27, laurelfulford.
Fixes #46083.

git-svn-id: https://develop.svn.wordpress.org/trunk@44774 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 02:46:39 +00:00
Sergey Biryukov 37c5efcdee Twenty Nineteen: Update `style-rtl.css` after [44657].
See #45731.

git-svn-id: https://develop.svn.wordpress.org/trunk@44773 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 02:43:09 +00:00
Sergey Biryukov 9cc6caa670 Docs: Add missing `WP_Customize_Control` reference to `WP_Customize_Nav_Menu_Control` and `WP_Customize_Nav_Menu_Item_Control` DocBlocks.
Props aniketpatel.
Fixes #46077.

git-svn-id: https://develop.svn.wordpress.org/trunk@44772 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 02:06:30 +00:00
Sergey Biryukov 3574d43d28 Twenty Nineteen: Avoid nested comment author links in `TwentyNineteen_Walker_Comment::html5_comment()`.
Props iamdmitrymayorov, mukesh27.
Fixes #46291.

git-svn-id: https://develop.svn.wordpress.org/trunk@44771 602fd350-edb4-49c9-b593-d223f7449a82
2019-02-28 01:54:14 +00:00