Commit Graph

30706 Commits

Author SHA1 Message Date
Sergey Biryukov
ade1ffde80 Plugins list table: Add an aria-label attribute with the plugin name to plugin action links to provide context for screen reader users.
props bramd, rianrietveld, afercia.
fixes #26167.

git-svn-id: https://develop.svn.wordpress.org/trunk@33087 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-05 15:02:04 +00:00
Konstantin Obenland
c35f5f16b0 Remove deprecated constructor notice.
Since Twenty Eleven can be used with WordPress releases prior to 4.3, it can't
contain calls to functions that were introduced after its initial release.

Props ocean90.
Fixes #32881.



git-svn-id: https://develop.svn.wordpress.org/trunk@33086 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 20:42:43 +00:00
Konstantin Obenland
9b40a4f79f Deprecate PHP4 style contructor in Twenty Eleven's Ephemera widget.
See #31982.

Props Frank Klein.
Fixes #32881.



git-svn-id: https://develop.svn.wordpress.org/trunk@33085 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 20:28:17 +00:00
Konstantin Obenland
9d101ee78e Site Icon: Switch to using H1 headings.
See #31650.

Props afercia.
Fixes #32885.



git-svn-id: https://develop.svn.wordpress.org/trunk@33084 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 18:48:37 +00:00
Jeremy Felt
14f39faab1 Usernames in multisite should be restricted to 60 characters or fewer.
Only 60 characters can be stored in the database for a username, which could cause lookup issues when attempting to use similar usernames of extreme length.

Props @DJPaul.
See #17904, Fixes #26784.


git-svn-id: https://develop.svn.wordpress.org/trunk@33083 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 05:52:46 +00:00
Jeremy Felt
d8df19141a Don't autocapitalize or autocorrect domain or path when adding a new site in iOS.
Props @ohryan.
Fixes #32646.


git-svn-id: https://develop.svn.wordpress.org/trunk@33082 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:39:48 +00:00
Jeremy Felt
ea4baac6e8 Use the full site URL in choose_primary_blog() when a user is a member of only one site.
Aligns with the output used when a user is a member of multiple sites.

Fixes #32884.


git-svn-id: https://develop.svn.wordpress.org/trunk@33081 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:20:18 +00:00
Jeremy Felt
4a785cbeb0 Only output Save Changes in My Sites when a user is a member of more than one site.
The conditional also checks for the existence of filters that may otherwise alter the HTML in My Sites to include extra form inputs for these users. If a filter is in use, the Save Changes button will display.

Props @Oxymoron, @obenland.
Fixes #32645.


git-svn-id: https://develop.svn.wordpress.org/trunk@33080 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 04:00:48 +00:00
Sergey Biryukov
e03c9a769a Don't capitalize words in a sentence after comma.
props bjornjohansen, netweb.
fixes #31927.

git-svn-id: https://develop.svn.wordpress.org/trunk@33079 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-04 00:49:52 +00:00
Sergey Biryukov
313c416f6c Customizer: Remove HTML tags from two translatable strings.
props henrikakselsen.
fixes #32817.

git-svn-id: https://develop.svn.wordpress.org/trunk@33078 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 22:28:29 +00:00
Dominik Schilling (ocean90)
45e6228070 Customizer: Fix tabindex of reorder buttons for menu items with depth 1 and 10.
props celloexpressions.
fixes #32767.

git-svn-id: https://develop.svn.wordpress.org/trunk@33077 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 22:20:04 +00:00
Sergey Biryukov
056fcf6162 Plugins list table: Use case-insensitive sorting.
props GaryJ.
fixes #32735.

git-svn-id: https://develop.svn.wordpress.org/trunk@33076 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:52:46 +00:00
Konstantin Obenland
e7c286551f Site Icon: Remove date dropdown from media modal.
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.

Props ocean90.
Fixes #32860.



git-svn-id: https://develop.svn.wordpress.org/trunk@33075 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:27:06 +00:00
Dominik Schilling (ocean90)
787016376a Customizer: Improve descriptive text and focus for menu items reorder button.
props afercia.
fixes #32725.

git-svn-id: https://develop.svn.wordpress.org/trunk@33074 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 21:23:12 +00:00
Konstantin Obenland
e33229a237 Synchronize star ratings of themes and plugins.
Makes themes ratings look like plugins ratings already do.

Props helen.
Fixes #32782.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@33073 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:53:18 +00:00
Boone Gorges
02bd602dfe Improve the display of my-sites.php on small screens.
Props tryon.
Fixes #31685.

git-svn-id: https://develop.svn.wordpress.org/trunk@33072 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:46:54 +00:00
Weston Ruter
a21c6e76d6 Customizer: Fix saving menus with empty names or names that are already used.
Adds validation for initially-supplied nav menu name, blocking empty names from being supplied. If later an empty name is supplied and the nav menu is saved, the name "(unnamed)" will be supplied instead and supplied back to the client. If a name is supplied for the menu which is currently used by another menu, then the name conflict is resolved by adding a numerical counter similar to how `post_name` conflicts are resolved. Includes unit tests.

Fixes #32760.



git-svn-id: https://develop.svn.wordpress.org/trunk@33071 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:46:48 +00:00
Dominik Schilling (ocean90)
55d7ab3da5 Customizer: Remove some non-functional code.
props afercia.
fixes #32839.

git-svn-id: https://develop.svn.wordpress.org/trunk@33070 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:36:59 +00:00
Dominik Schilling (ocean90)
e430245d00 Customizer: Accessibility enhancements.
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.

props celloexpressions.
fixes #31336.

git-svn-id: https://develop.svn.wordpress.org/trunk@33069 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 20:18:17 +00:00
Konstantin Obenland
1757c3f4d4 Don't let wp-pointers cover the theme detail modal.
Fixes #31544.


git-svn-id: https://develop.svn.wordpress.org/trunk@33068 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 17:04:33 +00:00
Konstantin Obenland
8d40cdcb1b Use a less element-specific class name for links within page titles.
After [32974] these links are no longer within an `h2`, making the class name
inaccurate. `add-new-h1` has the potential to expose the same problem for in a
possible future change.

Fixes #31650.



git-svn-id: https://develop.svn.wordpress.org/trunk@33067 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 16:41:18 +00:00
Konstantin Obenland
04a01d7354 Check if commentReply exists before trying to work with it.
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.

Introduced in [33024].
See #29457.



git-svn-id: https://develop.svn.wordpress.org/trunk@33066 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 15:31:38 +00:00
Aaron Jorbin
3baf370b28 Remove accidental change to embed
Reverts about.php change from [33064]




git-svn-id: https://develop.svn.wordpress.org/trunk@33065 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 14:29:37 +00:00
Aaron Jorbin
a547d6fed1 Don't strip newline in esc_url() when protocol is mailto:
The mailto protocol is a bit different than the other protocols in that new lines are something you might realistically want to include. Includes tests to make sure that http protocol urls that contain mailto: aren't affected. Tests for stripping newlines in general already exist.

Fixes #31632
Props danielbachhuber



git-svn-id: https://develop.svn.wordpress.org/trunk@33064 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 14:27:11 +00:00
Dion Hulse
12168b78d5 Press This: Rewrite WP_Press_This::fetch_source_html() to utilise the HTTP API better without the need for a local temporary file.
This reverts [33061] but keeps it's custom UA string.

See #32864


git-svn-id: https://develop.svn.wordpress.org/trunk@33062 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 12:00:10 +00:00
Sergey Biryukov
9cfb72615c Press This: Set explicit user agent.
props kraftbj.
fixes #32864.

git-svn-id: https://develop.svn.wordpress.org/trunk@33061 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 11:16:08 +00:00
Ella Iseulde Van Dorpe
220121249a Editor: refresh word count quicker
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.

See #30966.



git-svn-id: https://develop.svn.wordpress.org/trunk@33060 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 09:14:08 +00:00
Dion Hulse
2fbb13be21 Don't upgrade global tables to utf8mb4 when wp_should_upgrade_global_tables() says not to.
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154


git-svn-id: https://develop.svn.wordpress.org/trunk@33058 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 05:43:28 +00:00
Dion Hulse
947825f326 Introduce wp_should_upgrade_global_tables() to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines.
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33057 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 04:33:14 +00:00
Helen Hou-Sandi
e7a184a832 Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.


git-svn-id: https://develop.svn.wordpress.org/trunk@33056 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:28:15 +00:00
Dion Hulse
e709e91218 Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally.
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33055 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-03 03:25:07 +00:00
Konstantin Obenland
bfbdb6f0b2 Use get_default_comment_status() globally.
Also makes the filter name static and passes the post type for context.

Props valendesigns.
Fixes #31168.



git-svn-id: https://develop.svn.wordpress.org/trunk@33054 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 22:31:58 +00:00
Konstantin Obenland
9532df3c9f Site Icon: Improve responsiveness for small screen devices.
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.

Props tyxla for initial patch.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33053 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 21:15:52 +00:00
Sergey Biryukov
07ee7f1ef7 Replace @returns with @return in PHP docblocks.
props kraftbj.
fixes #32865.

git-svn-id: https://develop.svn.wordpress.org/trunk@33052 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 21:04:57 +00:00
Konstantin Obenland
3d71278f58 Site Icon: Skip cropping if image has the correct size.
Props jipmoors for initial patch.
See #16434.



git-svn-id: https://develop.svn.wordpress.org/trunk@33051 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 20:39:23 +00:00
Konstantin Obenland
40b504fffc Add missing prefixed attributes, introduced in [33023].
See ##32589.


git-svn-id: https://develop.svn.wordpress.org/trunk@33050 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 17:39:31 +00:00
Konstantin Obenland
8f4774104b Site Icon: Show correct background preview for transparent images.
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.

See #16434.


git-svn-id: https://develop.svn.wordpress.org/trunk@33049 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 17:15:47 +00:00
Sergey Biryukov
f8cbb8fde8 Make "Preformatted" string in TinyMCE translatable.
props iseulde.
fixes #32862.

git-svn-id: https://develop.svn.wordpress.org/trunk@33048 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 12:01:00 +00:00
Sergey Biryukov
dcc6fb838f Restore rel='nofollow' for comment reply links to reduce extra crawling by search engines.
This reverts [16230], which didn't have enough review at the time of commit.

props joostdevalk.
see #22889, #18547, #16881.

git-svn-id: https://develop.svn.wordpress.org/trunk@33047 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 11:08:42 +00:00
Konstantin Obenland
5c531b9969 4.3-beta1-33046
git-svn-id: https://develop.svn.wordpress.org/trunk@33046 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:35:01 +00:00
Helen Hou-Sandi
b896a4e31b Customizer: Build flips the panel arrow for RTL on our behalf.
see #31336.


git-svn-id: https://develop.svn.wordpress.org/trunk@33045 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:28:43 +00:00
Konstantin Obenland
83f8f62739 4.3-beta1
git-svn-id: https://develop.svn.wordpress.org/trunk@33044 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:21:05 +00:00
Sergey Biryukov
8a8fc13bd0 Update test_filter_wp_nav_menu_args() after [33035].
see #32781.

git-svn-id: https://develop.svn.wordpress.org/trunk@33043 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 01:17:58 +00:00
Mark Jaquith
fcd4f3ea0f Revert [33038] because of objections raised on #22889 and #31590
git-svn-id: https://develop.svn.wordpress.org/trunk@33042 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 00:46:28 +00:00
Konstantin Obenland
efdce1da51 Turn of comments for pages by default.
Pages are static content, for which comments are not expected out of the box.

Props valendesigns, rachelbaker.
Fixes #31168.



git-svn-id: https://develop.svn.wordpress.org/trunk@33041 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-02 00:21:28 +00:00
Konstantin Obenland
dd28f15179 Prevent link to customizer from wrpping on small screens.
Fixes #32808.


git-svn-id: https://develop.svn.wordpress.org/trunk@33040 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 23:35:57 +00:00
Mark Jaquith
165b3fccaa Restore $noreplytext default value in comment_form_title()
props ocean90
see #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33039 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:50:13 +00:00
Mark Jaquith
bac0e68b48 Say goodbye to ?replytocom=123 links and their URL pollution.
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889

git-svn-id: https://develop.svn.wordpress.org/trunk@33038 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:41:17 +00:00
Dominik Schilling (ocean90)
d0728bf768 Site icon: Remove option name from $whitelist_options for the general options screen.
The option gets saved in `WP_Site_Icon->set_site_icon()`.

fixes #32859.

git-svn-id: https://develop.svn.wordpress.org/trunk@33037 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 21:40:40 +00:00
Weston Ruter
552879c842 Customizer: Add link to Widgets panel from Menus panel description.
Props celloexpressions.
Fixes #32742.



git-svn-id: https://develop.svn.wordpress.org/trunk@33036 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-01 19:34:17 +00:00