Commit Graph

54 Commits

Author SHA1 Message Date
Andrew Nacin 1b8afaa995 Remove an unslash in the deprecated WP_User_Search, as search_term is already unslashed in the constructor. see #21767.
git-svn-id: https://develop.svn.wordpress.org/trunk@23577 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:57:49 +00:00
Ryan Boren 4088ca8723 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Sergey Biryukov 07d596afb7 Add missing inline descriptions. see #19067.
git-svn-id: https://develop.svn.wordpress.org/trunk@23437 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-16 02:52:57 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Andrew Nacin 818598ac2c Deprecate wp_create_thumbnail(). props obenland. fixes #21555.
git-svn-id: https://develop.svn.wordpress.org/trunk@21956 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-23 17:48:24 +00:00
Andrew Nacin 2313f09a45 Correct return values for two deprecated media admin functions. props SergeyBiryukov. fixes #21518.
git-svn-id: https://develop.svn.wordpress.org/trunk@21835 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-13 17:09:41 +00:00
Andrew Nacin 1e270f44a4 Remove 'hwstring_small' from attachment metadata and deprecate get_udims(). props SergeyBiryukov. fixes #21518.
git-svn-id: https://develop.svn.wordpress.org/trunk@21808 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-11 01:38:26 +00:00
Ryan Boren 46f3985c39 Deprecate get_default_post_to_edit(). Props SergeyBiryukov. fixes #21677
git-svn-id: https://develop.svn.wordpress.org/trunk@21800 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-10 20:39:45 +00:00
Ryan Boren 01527025c9 Add tags_input, page_template, and post_category get magic to WP_Post.
Deprecate get_post_to_edit() and wp_get_single_post().
Props scribu
see #21309


git-svn-id: https://develop.svn.wordpress.org/trunk@21651 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-28 19:08:28 +00:00
Andrew Nacin a5c7405975 Move most instances of new WP_User to get_userdata(). see #21120.
git-svn-id: https://develop.svn.wordpress.org/trunk@21413 602fd350-edb4-49c9-b593-d223f7449a82
2012-08-03 01:06:05 +00:00
Ryan Boren 26b9de056c Deprecate and stub _media_button. fixes #21317
git-svn-id: https://develop.svn.wordpress.org/trunk@21353 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-26 21:33:01 +00:00
Ryan Boren aefca97f8f Deprecate and stub _insert_into_post_button(). fixes #20427
git-svn-id: https://develop.svn.wordpress.org/trunk@21352 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-26 21:30:06 +00:00
Andrew Nacin e71167bbee Updates to WP_Theme, wp_get_themes(), and related deprecated functions, after [UT570] [UT578] [UT579]. see #20103.
* ['Template Files'] and ['Stylesheet Files'] need to return files from the parent theme as well.
 * Don't strip links from the Author header. Some themes rely on the previous behavior, such as to link multiple authors (Sandbox, for example.) Don't restore links to the Name, that's just a bad idea.
 * Ensure we are always passing around arrays in get_files/scandir.
 * Better inline doc for wp_get_themes() arguments.
 * Introduce a 'force' flag for search_theme_directories() to re-scan, rather than return the cache. We will use this to re-build the theme_roots transient in get_theme_roots(), but it is more helpful for unit tests. Since search_theme_directories() is cached, don't cache again in wp_get_themes(). (Again benefits testing.)
 * Handle duplicate theme names in the old get_themes() when two themes match (and neither are a default theme, which is already handled). wp_get_themes() will consider both names to be the same; this is just for back compat since get_themes() is keyed by name.
 * Include an old array key in wp_broken_themes().



git-svn-id: https://develop.svn.wordpress.org/trunk@20193 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-15 15:39:21 +00:00
Andrew Nacin 53a209a4ee Introduce WP_Theme, wp_get_themes(), and wp_get_theme() to replace get_themes(), get_theme(), get_theme_data(), current_theme_info(), and others.
* Getters and Helpers: Introduces a series of methods to allow for easy generation of headers for display, and other theme metadata, including page templates.
 * Screenshots: Handles support for multiple screenshots. (see # Additional screenshots must be PNG and start with screenshot-2.png, and be sequential to be counted. see #19816.
 * Error Handling: Broken themes have a WP_Error object attached to them.
 * Caching: Introduces a wp_cache_themes_persistently filter (also in [20020]) to enable persistent caching of all filesystem and sanitization operations normally handled by WP_Theme (and formerly get_file_data() and get_themes()). Themes are cached individually and across five different cache keys for different data pieces.
 * Compatibility: A WP_Theme object is backwards compatible with a theme's array formerly returned by get_themes() and get_theme(), and an stdClass object formerly returned by current_theme_info().
 * i18n/L10n: Theme headers are now localizable with proper Text Domain and Domain Path headers, like plugins. (Language packs may remove the requirement for headers.) For page templates, see #6007 (not fixed yet, but will be easy now). For headers, fixes #15858.
 * PHP and CSS files: New methods that fetch a list of theme files (for the theme editor) only on demand, rather than only loading them into memory. fixes #11214.

Functions deprecated:
 * get_themes(), get_allowed_themes() and get_broken_themes() -- use wp_get_themes()
 * get_theme() and current_theme_info() -- use wp_get_theme()
 * get_site_allowed_themes() -- use WP_Theme::get_allowed_on_network()
 * wpmu_get_blog_allowedthemes() -- use WP_theme::get_allowed_on_site()

see also [20016], [20018], [20019], [20020], [20021], [20022], [20025], [20026], [20027]. also fixes #19244.

see #20103.



git-svn-id: https://develop.svn.wordpress.org/trunk@20029 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-28 21:24:44 +00:00
Ryan Boren 5e76729992 One newline is enough.
git-svn-id: https://develop.svn.wordpress.org/trunk@19684 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-05 20:10:39 +00:00
Ryan Boren 676ba7043e Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: https://develop.svn.wordpress.org/trunk@19593 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-13 23:45:31 +00:00
Andrew Nacin 04bb986e97 Deprecate add_contextual_help() for get_current_screen()->add_help_tab(). fixes #19020.
git-svn-id: https://develop.svn.wordpress.org/trunk@19520 602fd350-edb4-49c9-b593-d223f7449a82
2011-12-01 03:29:55 +00:00
Andrew Nacin fc9bd67e14 Move WP_Editor to a _WP_Editors encapsulation.
* WP_Editor will return in 3.4 as a one true API for editor instances. Stick to wp_editor() for now.
 * TinyMCE can now be forced on with tinymce = true. It defaults to the value for user_can_richedit().
 * Restores wp_default_editor(), wp_link_query(), wp_link_dialog(), wp_fullscreen_html().
fixes #19320.


git-svn-id: https://develop.svn.wordpress.org/trunk@19420 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-23 19:06:52 +00:00
Andrew Ozz 25c7b371f8 Restore back-compat with wp_tiny_mce(), see #19320
git-svn-id: https://develop.svn.wordpress.org/trunk@19408 602fd350-edb4-49c9-b593-d223f7449a82
2011-11-22 21:47:01 +00:00
Ryan Boren fd10e500e4 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@19054 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-24 19:13:23 +00:00
Andrew Nacin 38440b5e9a Deprecate favorite_actions(). see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@19050 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-24 06:10:36 +00:00
Andrew Nacin ed8f3c3f95 Deprecate media_upload_(image|audio|video|file)(), type_url_form_(image|audio|video|file)(). These now wrap wp_media_upload_handler() and wp_media_insert_url_form(). see #17578.
git-svn-id: https://develop.svn.wordpress.org/trunk@19046 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-23 17:58:06 +00:00
Andrew Nacin 2efff75050 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18911 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-07 04:57:12 +00:00
Andrew Nacin 237d132595 @since for screen_meta(), screen_options(), screen_layout(). props SergeyBiryukov, see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18904 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-06 16:24:14 +00:00
Andrew Ozz 48be8d03eb Don't trigger "deprecated" warnings before WP_Screen is finalized, see #18785
git-svn-id: https://develop.svn.wordpress.org/trunk@18880 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-04 23:10:02 +00:00
Andrew Ozz fee1fe1b36 Deprecate favorite_actions(), add_contextual_help(), add_screen_option(), move meta_box_prefs() and get_screen_icon() in WP_Screen, see #18690
git-svn-id: https://develop.svn.wordpress.org/trunk@18874 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-04 03:32:12 +00:00
Andrew Nacin 8bbc643454 Deprecate screen_meta(). see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18859 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-01 18:13:27 +00:00
Andrew Nacin f214ef7d99 Deprecate secreen_options(), screen_layout(). see #18785.
git-svn-id: https://develop.svn.wordpress.org/trunk@18858 602fd350-edb4-49c9-b593-d223f7449a82
2011-10-01 18:07:41 +00:00
Jon Cave 60d321b14b Fix typos in documentation (wp-admin/). See #18560.
git-svn-id: https://develop.svn.wordpress.org/trunk@18632 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-03 14:18:10 +00:00
Ryan Boren 8eea785bcb Add magic get/set/isset methods to WP_User to avoid data duplication. Standardize on WP_User::ID. Props scribu. see #15458
git-svn-id: https://develop.svn.wordpress.org/trunk@18504 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-04 03:09:27 +00:00
Andrew Ozz 461ceba60d Editor API enhancement, first run (still needs some work), see #17144
git-svn-id: https://develop.svn.wordpress.org/trunk@18498 602fd350-edb4-49c9-b593-d223f7449a82
2011-08-03 10:19:00 +00:00
Ryan Boren cdd05b3c9f Sanitize sort_column and sort_order in get_pages(). Escape search_term in WP_User_Search. Cast blog_id to int in get_blog_prefix(). Props duck_
git-svn-id: https://develop.svn.wordpress.org/trunk@18350 602fd350-edb4-49c9-b593-d223f7449a82
2011-06-27 20:47:04 +00:00
Andrew Nacin 28a5ec7c1c Don't load the QuickPress widget via XHR. see #16927. Reverts [16725] as it's no longer needed. Reverts part of [14815], which introduced the behavior, see #10917.
git-svn-id: https://develop.svn.wordpress.org/trunk@17743 602fd350-edb4-49c9-b593-d223f7449a82
2011-04-28 12:02:24 +00:00
Peter Westwood 1f730d43b8 The old methods are good enough in alot of cases where plugins want to extend simply. So un deprecate for now.
git-svn-id: https://develop.svn.wordpress.org/trunk@17293 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-13 23:19:51 +00:00
Andrew Nacin 18edc09e6a More @since. props SergeyBiryukov, fixes #15445.
git-svn-id: https://develop.svn.wordpress.org/trunk@17071 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-20 09:25:21 +00:00
scribu 90109c1aea Set get_users() as a replacement to get_editable_user_ids() and friends. See #14572
git-svn-id: https://develop.svn.wordpress.org/trunk@16605 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-29 05:39:39 +00:00
scribu a97018ab13 Fix admin comment reply. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@16244 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-08 23:07:37 +00:00
scribu baaf0585dd Use get_current_screen() in list table classes. Fixes #15338
git-svn-id: https://develop.svn.wordpress.org/trunk@16235 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-08 15:43:44 +00:00
scribu 7edd2f0090 Default to get_current_screen() in list table classes. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@16182 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-04 15:00:55 +00:00
scribu 7005ab8841 Revive WP_User_Search as deprecated. See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@15748 602fd350-edb4-49c9-b593-d223f7449a82
2010-10-07 20:13:11 +00:00
scribu 861c929165 Column headers revamp:
* undeprecate get_column_headers()
	* undeprecate get_hidden_columns()
	* in WP_List_Table, rename get_column_headers() to get_column_info()
	* remove $taxonomy argument from single_row()
	* merge manage_columns_prefs() into screen_meta()
Fixes #14952. Fixes #14776.


git-svn-id: https://develop.svn.wordpress.org/trunk@15653 602fd350-edb4-49c9-b593-d223f7449a82
2010-09-24 13:35:06 +00:00
scribu 33f73ce32f Deprecated get_editable_user_ids() altogether, along with similar, unused functions. See #14572
git-svn-id: https://develop.svn.wordpress.org/trunk@15542 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-27 01:07:21 +00:00
scribu 0b1b005b66 Deprecate unused get_author_user_ids()and get_editable_authors(). See #14572
git-svn-id: https://develop.svn.wordpress.org/trunk@15540 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-27 00:22:29 +00:00
scribu 1c4aeef40e replace $table with $wp_list_table. See #14651
git-svn-id: https://develop.svn.wordpress.org/trunk@15519 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-22 11:22:46 +00:00
scribu e848b8b815 Make deprecated functions work. See #14651
git-svn-id: https://develop.svn.wordpress.org/trunk@15517 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-21 18:08:42 +00:00
scribu 83d019c1d9 Move list table deprecated functions to wp-admin/includes/deprecated.php
git-svn-id: https://develop.svn.wordpress.org/trunk@15515 602fd350-edb4-49c9-b593-d223f7449a82
2010-08-21 16:33:56 +00:00
Andrew Nacin 1a1a241eb3 Deprecated doc cleanup.
git-svn-id: https://develop.svn.wordpress.org/trunk@15344 602fd350-edb4-49c9-b593-d223f7449a82
2010-06-28 10:11:41 +00:00
Andrew Nacin cb75ebbb54 Remove autocomplete and codepress. for autocomplete, see #13283. for codepress, see #13307.
git-svn-id: https://develop.svn.wordpress.org/trunk@14718 602fd350-edb4-49c9-b593-d223f7449a82
2010-05-18 03:48:22 +00:00
Andrew Nacin e5f55c5b3d Deprecate add_option_update_handler() and remove_option_update_handler() in favor of register_setting() and unregister_setting(). #11730
git-svn-id: https://develop.svn.wordpress.org/trunk@13805 602fd350-edb4-49c9-b593-d223f7449a82
2010-03-22 23:03:31 +00:00