4088ca8723
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
c363aea627
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
a6c8efadb9
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
1303e7377a
its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@23191 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-20 15:55:32 +00:00
e82d5080b8
New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
...
Be on the lookout for weirdness.
props lessbloat. see #21456 .
git-svn-id: https://develop.svn.wordpress.org/trunk@22019 602fd350-edb4-49c9-b593-d223f7449a82
2012-09-26 19:57:44 +00:00
6e6b727315
Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
...
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.
Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.
See #21340 .
git-svn-id: https://develop.svn.wordpress.org/trunk@21311 602fd350-edb4-49c9-b593-d223f7449a82
2012-07-24 00:15:15 +00:00
299642f86b
Theme Customizer: Fix scrolling on iOS and Kindle Fire. props azaozz, helenyhou. fixes #20805 .
...
Also fixes uploader UIs on iOS and Kindle Fire by improving wp.Uploader.
Adds mobile viewport specifications.
Moves scrollbar back to fixed positioning.
git-svn-id: https://develop.svn.wordpress.org/trunk@21014 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-06 21:45:17 +00:00
83e4dea52c
Fix collapse button and return link markup for theme install preview. Props koopersmith. fixes #20800
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20968 602fd350-edb4-49c9-b593-d223f7449a82
2012-06-01 15:03:50 +00:00
b4277fcd40
Theme Installer: Prevent unnecessary admin code from printing and print markup in correct order. Remove dead code. props ocean90, fixes #20695 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20812 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-16 23:38:53 +00:00
3ae49bd759
Install Themes: Add link to the no-js theme previewer to the 'Preview' link. props ocean90, fixes #20694 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20811 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-16 21:08:10 +00:00
ecf6940ffb
Theme Customizer: Prevent sidebar scrollbar from overlapping sidebar header or footer. fixes #20649 , #20650 , see #19910 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20791 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-15 01:03:31 +00:00
24a6a399d8
Normalize star ratings markup. Props helenyhou. fixes #20655
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20765 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-10 19:59:48 +00:00
0bed53f213
When showing already installed themes in the theme installer list, indicate in the row actions that the theme is installed and offer an update link if updates are available.
...
Props SergeyBiryukov
Fixes #20618
git-svn-id: https://develop.svn.wordpress.org/trunk@20751 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-09 15:01:49 +00:00
b379473aa4
Add 'Install now', 'Preview', and 'Details' links to theme install list items. fixes #20403 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20730 602fd350-edb4-49c9-b593-d223f7449a82
2012-05-06 23:06:47 +00:00
f553c11f28
Default to keyword searches for the plugin and theme installers in case no search type is posted back. fixes #19619 .
...
props georgestephanis, SergeyBiryukov for initial patches.
git-svn-id: https://develop.svn.wordpress.org/trunk@20639 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-30 00:44:47 +00:00
cfe73da905
Reduce clutter and repetive functionality from the initial landing page for installing plugins and themes by removing the tag/author/term dropdown.
...
The tag cloud (plugins) and feature filter (themes) is sufficient for tag functionality. All three "search by" fields are already weighted for a standard keyword search through the WP.org API.
fixes #19619 for 3.4.
git-svn-id: https://develop.svn.wordpress.org/trunk@20592 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-25 19:37:19 +00:00
98f37d532d
Theme browsing UX improvements. see #20403 .
...
* On manage/install themes pages, moved author under theme name.
* On manage themes page, moved version number to details.
git-svn-id: https://develop.svn.wordpress.org/trunk@20414 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-10 00:15:13 +00:00
315d6e31e3
Theme Customizer: Move 'collapse' button to footer and add a visible text label. see #19910 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20391 602fd350-edb4-49c9-b593-d223f7449a82
2012-04-07 00:10:22 +00:00
b1ba2dd995
Deprecate display_theme(). see #19910 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20141 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-07 18:29:36 +00:00
7464fa9565
Theme Customizer: Make theme installer no-js compatible. Fix JS click handler that caught clicks on the 'Activate' link. Relocate display_theme() to WP_Theme_Install_List_Table->single_row(). see #19910 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20140 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-07 18:24:34 +00:00
6e93f773b4
Theme Customizer: Begin integration into the install process. Combine previews, details, and install into a single workflow. see #19910 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20138 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-07 17:35:17 +00:00
b6b4d37fcb
Allow WP_List_Table::_js_vars() to take an array of additional args to add. Allows us to have a single variable printing data when child classes need more data. Also, fix compact() call in [20094]. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20100 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 23:06:31 +00:00
c56b5f3f59
Use sanitize_key(). sanitize_title_with_dashes() is more than we need. see #19815 . see [20096], [20097].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20098 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:32:29 +00:00
9f47e027ca
Revert [20096] which was an accidental partial revert of [20094]. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20097 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:31:15 +00:00
7dd527a421
Use sanitize_key() for theme search tags/features. sanitize_title_with_dashes() is overkill. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20096 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:26:58 +00:00
43209998c6
Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@20094 602fd350-edb4-49c9-b593-d223f7449a82
2012-03-02 22:09:26 +00:00
1597835e12
Infinite scroll for themes.php and theme-install.php. Bump per page limit for themes.php to 999. Props helenyhou, DH-Shredder. see #19815
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19887 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-09 17:20:26 +00:00
7cd04da2e6
Change feature filter from post to get so feature selections aren't lost when paging. Props SergeyBiryukov. fixes #18094
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19857 602fd350-edb4-49c9-b593-d223f7449a82
2012-02-07 21:06:52 +00:00
2b186b0c45
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: https://develop.svn.wordpress.org/trunk@19712 602fd350-edb4-49c9-b593-d223f7449a82
2012-01-08 17:01:11 +00:00
aea659a859
Responsive themes screen, props helenyhou, see #18198
...
git-svn-id: https://develop.svn.wordpress.org/trunk@18673 602fd350-edb4-49c9-b593-d223f7449a82
2011-09-15 04:26:26 +00:00
2b4674a3b4
Remove AJAX from list tables. first pass. see #16262 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17322 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-16 21:47:24 +00:00
5844e953a8
Improve presentation when there are no available themes. Props solarissmoke, garyc40. fixes #16196
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17303 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-15 00:35:29 +00:00
84e50d906f
Leave the 'Try Again' link for the wp_die() when the themes API fails. props solarissmoke, fixes #16132 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17264 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-12 00:18:23 +00:00
6d0af32ea7
Add nonces to instances where the list table display() method is overridden. see #16188 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17262 602fd350-edb4-49c9-b593-d223f7449a82
2011-01-11 22:42:22 +00:00
1f3ea01d78
List table spinner. Props scribu. see #15580
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17090 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-20 18:45:05 +00:00
96e692baed
Always display the table, with a placeholder row when there are no items. Fixes #15849
...
git-svn-id: https://develop.svn.wordpress.org/trunk@17002 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 19:05:14 +00:00
266cd3f5df
Replace check_permissions() with ajax_user_can(). New method returns true/false to current_user_can(), which we then handle in admin ajax. see #15326 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16992 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-16 09:18:28 +00:00
9efb88a3ac
Use more specific view classes in plugin & theme install screens. Props batmoo. Fixes #15658
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16710 602fd350-edb4-49c9-b593-d223f7449a82
2010-12-03 18:51:24 +00:00
7edd2f0090
Default to get_current_screen() in list table classes. See #14579
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16182 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-04 15:00:55 +00:00
817aa1975c
Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16175 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-04 08:07:03 +00:00
ed884411fe
List-table Class Names: Consistency's Revenge. See #14579
...
git-svn-id: https://develop.svn.wordpress.org/trunk@16171 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-03 21:09:27 +00:00
c4633bbd54
The big renaming of the list-table class files.
...
See #14579
git-svn-id: https://develop.svn.wordpress.org/trunk@16128 602fd350-edb4-49c9-b593-d223f7449a82
2010-11-01 09:19:50 +00:00
Ryan Boren
Helen Hou-Sandi
Andrew Nacin
Andrew Ozz
Daryl Koopersmith
scribu
Peter Westwood