Go to file
Scott Taylor 0baa73f2e4 Apply `order` to each passed value for `orderby` in `WP_Query`:
* Since `orderby` in `WP_Query` can accept space-delimited sets, yet only one `order` value: when multiple values are passed (and `DESC` is the order), the default sort order `ASC` is being applied to all values before the last in the set.
* There is a unit test that sporadically fails since 3.6 in `tests/post/revision` due to multiple posts having the same `post_date` from being added so rapidly
* When ordering revisions in `wp_get_post_revisions()`, order by `post_date ID`
* Change the `order` value in `wp_get_post_revisions()` to `ASC`. This will produce SQL like: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID ASC`. Previously, this would have produced SQL like: `ORDER BY $wpdb->posts.post_date DESC`, and with the addition of ` ID`: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID DESC`. Clearly, wrong. The original SQL produced: `ORDER BY $wpdb->posts.post_date DESC`. As such, return the reversions in reverse order using `array_reverse()`. Not doing so would break "Preview Changes."
* Add unit tests to assert that all of this works.
* All existing unit tests pass with the change to ordering multiple `orderby`s in `WP_Query`.
* In the future, we should support independent `order` for each `orderby`, see #17065.

Props SergeyBiryukov, wonderboymusic.
Fixes #26042.


git-svn-id: https://develop.svn.wordpress.org/trunk@28541 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-22 18:18:11 +00:00
src Apply `order` to each passed value for `orderby` in `WP_Query`: 2014-05-22 18:18:11 +00:00
tests Apply `order` to each passed value for `orderby` in `WP_Query`: 2014-05-22 18:18:11 +00:00
tools/i18n i18n tools: Have makepot search for the main file of the plugin. 2014-03-04 21:06:48 +00:00
.editorconfig Add .editorconfig file, see http://editorconfig.org/. 2014-02-20 02:35:38 +00:00
.gitignore Remove twenty* ignore-exclusion lines. Already tracked. 2014-02-26 20:59:25 +00:00
.jshintrc Remove smarttabs from .jshintrc per IRC discussion. see #25187. 2013-11-13 19:23:16 +00:00
.travis.yml Add jshint to Travis CI config. 2014-02-25 17:57:04 +00:00
Gruntfile.js More descriptive docs for `grunt jshint:core`. 2014-04-30 21:39:43 +00:00
package.json 4.0 version bumps. 2014-04-21 04:41:57 +00:00
phpunit.xml.dist
wp-cli.yml Introduce default `wp-cli.yml` for core development. 2014-04-30 21:35:18 +00:00
wp-config-sample.php Move wp-config-sample.php to the root of develop.svn. 2013-08-29 20:45:17 +00:00
wp-tests-config-sample.php Update wp-tests-config-sample.php to run with WP_DEBUG by default. see #25282. 2013-09-23 16:17:59 +00:00