Go to file
Jonathan Desrosiers 2e78177467 Nav Menus: Fix a PHP 7.3 error when switching themes.
When switching themes, `wp_map_nav_menu_locations()` is used to ensure nav menus are placed in the relevant menu location. Occasionally, menus are registered to locations with numeric slugs, rather than strings. `wp_map_nav_menu_locations()` assumed it would be the latter, and ran `stripos()` on those numeric slugs. This behavior is deprecated in PHP 7.3.

As this is the last PHP 7.3 error in unit tests, this commit also removes PHP 7.3 from Travis' `allowed_failures` list.

Props pento, desrosj, jorbin.

Merges [43899] to trunk.

See #45018.

git-svn-id: https://develop.svn.wordpress.org/trunk@44167 602fd350-edb4-49c9-b593-d223f7449a82
2018-12-14 05:15:54 +00:00
src Nav Menus: Fix a PHP 7.3 error when switching themes. 2018-12-14 05:15:54 +00:00
tests Nav Menus: Fix a PHP 7.3 error when switching themes. 2018-12-14 05:15:54 +00:00
tools Build Tools: Copy package JavaScript and CSS into `wp-includes`. 2018-12-14 04:10:26 +00:00
.editorconfig General: Instruct file editors not to trim trailing whitespace in markdown files. 2018-03-20 22:14:53 +00:00
.gitignore Build Tools: Copy package JavaScript and CSS into `wp-includes`. 2018-12-14 04:10:26 +00:00
.jshintrc General: Remove `.jshintrc` and `*.json` from the 2-space-indent `.editorconfig` group. 2017-10-12 01:57:45 +00:00
.npmrc Once upon a midnight dreary, while I coded, weak and weary, 2018-05-23 10:04:22 +00:00
.nvmrc Once upon a midnight dreary, while I coded, weak and weary, 2018-05-23 10:04:22 +00:00
.travis.yml Nav Menus: Fix a PHP 7.3 error when switching themes. 2018-12-14 05:15:54 +00:00
Gruntfile.js Build tools: Build webpack dev in grunt build. 2018-12-14 04:35:59 +00:00
composer.json Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:50:26 +00:00
composer.lock Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:50:26 +00:00
jsdoc.conf.json Build Tools: Fix JSDoc configuration include paths. 2018-06-14 12:45:06 +00:00
package-lock.json Build Tools: Update the `@wordpress/*` packages. 2018-12-14 04:42:55 +00:00
package.json Build Tools: Update the `@wordpress/*` packages. 2018-12-14 04:42:55 +00:00
phpcs.xml.dist Multisite: Fix coding standard errors after [43654]. 2018-09-24 15:22:01 +00:00
phpunit.xml.dist REST API: Introduce Autosaves controller and endpoint. 2018-12-13 22:41:47 +00:00
webpack.config.js Build tools: Build @wordpress packages with webpack. 2018-12-13 15:25:37 +00:00
wp-cli.yml Tools: Update `wp-cli.yml` to point to the `build` directory. 2018-05-25 00:14:14 +00:00
wp-config-sample.php Code is Poetry. 2017-11-30 23:09:33 +00:00
wp-tests-config-sample.php Build/Test Tools: Roses are red, this fixes stuff. 2018-05-23 17:54:44 +00:00