Go to file
Boone Gorges 361b83bf86 Ensure that non-default pagination values work in wp_list_comments().
Prior to 4.4, it was possible to pass 'page' and 'per_page' values to
`wp_list_comments()` that do not match the corresponding global query vars.
This ability was lost in 4.4 with the refactor of how `comments_template()`
queries for comments; when the main comment query started fetching only the
comments that ought to appear on a page, instead of all of a post's comments,
it became impossible for the comment walker to select comments corresponding to
custom pagination parameters. See #8071.

We restore the previous behavior by (a) detecting when a 'page' or 'per_page'
parameter has been passed to `wp_list_comments()` that does not match the
corresponding query vars (so that the desired comments will not be found in
`$wp_query`), and if so, then (b) querying for all of the post's comments and
passing them to the comment walker for pagination, as was the case before 4.4.

Merges [36157] to the 4.4 branch.

Props boonebgorges, smerriman.
Fixes #35175.


git-svn-id: https://develop.svn.wordpress.org/branches/4.4@36158 602fd350-edb4-49c9-b593-d223f7449a82
2016-01-03 02:06:04 +00:00
src Ensure that non-default pagination values work in wp_list_comments(). 2016-01-03 02:06:04 +00:00
tests Ensure that non-default pagination values work in wp_list_comments(). 2016-01-03 02:06:04 +00:00
tools/i18n i18n tools: Use https for msgid-bugs-address URLs. 2015-07-27 19:37:13 +00:00
.editorconfig Use HTTPS URLs for codex.wordpress.org. 2015-04-12 21:28:58 +00:00
.gitignore Remove an IDE-specific rule in .gitignore. These should be managed in the user's ~/.gitignore_global file. 2015-10-18 00:15:23 +00:00
.jshintrc Build: Prevent non-breaking spaces from accidentally being inserted into JavaScript files. 2015-11-12 12:04:55 +00:00
.travis.yml Remove PHP 7 from allowed failures list 2015-11-12 21:44:24 +00:00
Gruntfile.js Build: Update source for includes:embed after [35718]. 2015-11-20 15:36:21 +00:00
package.json Bump package.json and readme.html to 4.4.1 in the 4.4 branch. 2015-12-10 10:55:57 +00:00
phpunit.xml.dist Unit Tests: add SpeedTrapListener to phpunit/includes and add the config node to phpunit.xml.dist. 2015-10-16 00:27:28 +00:00
wp-cli.yml Remove debug mode from WP-CLI by default, as it now outputs too much debugging information to be of use during normal development. 2015-11-28 18:36:06 +00:00
wp-config-sample.php Lightly clean up and improve inline documentation in wp-config-sample.php. 2015-05-10 00:05:30 +00:00
wp-tests-config-sample.php Update wp-tests-config-sample.php to run with WP_DEBUG by default. see #25282. 2013-09-23 16:17:59 +00:00