5043f0c795
When `WP_Term` was introduced in [34997], the `$taxonomy` parameter for `get_term()` was made optional. This meant that, when the optional param was omitted, `get_term()` had no way of determining which term was intended when the term_id was shared between multiple taxonomies. As a (somewhat sneaky) way of fixing things, `get_term()` split any shared terms it found. But this could cause problems with developer expectations: it's not clear why requesting a term should result in a database update, much less a potential change in the ID of a term. In place of this technique, this changeset introduces a number of changes that make the handling of shared terms a bit less insane: * When a taxonomy is provided to `get_term()`, and a cached term is found matching the term_id, make sure the taxonomy also matches before returning it. * When a taxonomy is not provided, ensure that the term is not shared before adding it to the cache. * When a term is shared between taxonomies and no taxonomy is provided, return a `WP_Error` rather than splitting the term. * When a term is shared between taxonomies, only one of which is valid, return the term from that taxonomy. Props boonebgorges, dlh. Fixes #34533. git-svn-id: https://develop.svn.wordpress.org/trunk@35537 602fd350-edb4-49c9-b593-d223f7449a82 |
||
---|---|---|
.. | ||
data | ||
includes | ||
tests | ||
build.xml | ||
multisite.xml | ||
README.txt | ||
wp-mail-real-test.php |
The short version: 1. Create a clean MySQL database and user. DO NOT USE AN EXISTING DATABASE or you will lose data, guaranteed. 2. Copy wp-tests-config-sample.php to wp-tests-config.php, edit it and include your database name/user/password. 3. $ svn up 4. Run the tests from the "trunk" directory: To execute a particular test: $ phpunit tests/phpunit/tests/test_case.php To execute all tests: $ phpunit Notes: Test cases live in the 'tests' subdirectory. All files in that directory will be included by default. Extend the WP_UnitTestCase class to ensure your test is run. phpunit will initialize and install a (more or less) complete running copy of WordPress each time it is run. This makes it possible to run functional interface and module tests against a fully working database and codebase, as opposed to pure unit tests with mock objects and stubs. Pure unit tests may be used also, of course. Changes to the test database will be rolled back as tests are finished, to ensure a clean start next time the tests are run. phpunit is intended to run at the command line, not via a web server.