Go to file
Scott Taylor 74ed2089b4 The gallery shortcode used to accept a SQL chunk for the value of the orderby attribute. The reason? get_posts() used to be called in the shortcode handler with a query-string blob of arguments passed to it. To mitigate breakage, sanitize_sql_orderby() was created in [7592].
`sanitize_sql_orderby()` expects a comma to be present when multiple `orderby` values were passed. The correct syntax for multiple fields is space-delimited. Since [29027], comma-separated values would never be parsed correctly when passed to `WP_Query->parse_orderby()`.

`sanitize_sql_orderby()` is used nowhere else in core, save for the `playlist` shortcode - I only added it there because I was mimic'ing the `gallery` logic. The function call can be removed from both shortcode handlers.
 
See #6476.
Fixes #23873.


git-svn-id: https://develop.svn.wordpress.org/trunk@30068 602fd350-edb4-49c9-b593-d223f7449a82
2014-10-28 20:42:20 +00:00
src The gallery shortcode used to accept a SQL chunk for the value of the orderby attribute. The reason? get_posts() used to be called in the shortcode handler with a query-string blob of arguments passed to it. To mitigate breakage, sanitize_sql_orderby() was created in [7592]. 2014-10-28 20:42:20 +00:00
tests Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8. 2014-10-28 18:34:16 +00:00
tools/i18n Fix strict notices in makepot. 2014-08-21 02:53:16 +00:00
.editorconfig .jshintrc is a json file and .editorconfig should treat it like a json file 2014-10-08 19:26:50 +00:00
.gitignore Ignore any local WP Cli config files. 2014-10-28 17:01:22 +00:00
.jshintrc Remove smarttabs from .jshintrc per IRC discussion. see #25187. 2013-11-13 19:23:16 +00:00
.travis.yml PHP 5.6 test failures shouldn't be allowed. 2014-10-06 20:00:54 +00:00
Gruntfile.js Run JSValidate on core themes JS 2014-10-17 20:37:07 +00:00
package.json Update grunt-autoprefixer to 1.0.1 2014-10-28 20:16:32 +00:00
phpunit.xml.dist Only reset taxonomies and post types between tests when running core tests. 2014-10-10 20:25:39 +00:00
wp-cli.yml Introduce default wp-cli.yml for core development. 2014-04-30 21:35:18 +00:00
wp-config-sample.php Remove 'WordPress Language' reference from wp-config-sample.php. 2014-09-09 01:22:05 +00:00
wp-tests-config-sample.php Update wp-tests-config-sample.php to run with WP_DEBUG by default. see #25282. 2013-09-23 16:17:59 +00:00