817013978d
Since 4.4, when fetching the first page of comments and the 'newest' comments are set to display first, `comments_template()` must perform arithmetic to determine which comments to show. See #8071. This arithmetic requires the total comment count for the current post, which is calculated with a separate `WP_Comment_Query`. This secondary comment query did not properly account for non-approved comment statuses; all unapproved comments should be part of the comment count for admins, and individual users should have their own unapproved comments included in the count. As a result, `comments_template()` was, in some cases, being fooled into thinking that a post had fewer comments available for pagination than it actually had, which resulted in empty pages of comments. We correct this problem by mirroring 'status' and 'include_unapproved' params of the main comment query within the secondary query used to calculate pagination. Fixes #35068. git-svn-id: https://develop.svn.wordpress.org/trunk@36040 602fd350-edb4-49c9-b593-d223f7449a82 |
||
---|---|---|
.. | ||
data | ||
includes | ||
tests | ||
build.xml | ||
multisite.xml | ||
README.txt | ||
wp-mail-real-test.php |
The short version: 1. Create a clean MySQL database and user. DO NOT USE AN EXISTING DATABASE or you will lose data, guaranteed. 2. Copy wp-tests-config-sample.php to wp-tests-config.php, edit it and include your database name/user/password. 3. $ svn up 4. Run the tests from the "trunk" directory: To execute a particular test: $ phpunit tests/phpunit/tests/test_case.php To execute all tests: $ phpunit Notes: Test cases live in the 'tests' subdirectory. All files in that directory will be included by default. Extend the WP_UnitTestCase class to ensure your test is run. phpunit will initialize and install a (more or less) complete running copy of WordPress each time it is run. This makes it possible to run functional interface and module tests against a fully working database and codebase, as opposed to pure unit tests with mock objects and stubs. Pure unit tests may be used also, of course. Changes to the test database will be rolled back as tests are finished, to ensure a clean start next time the tests are run. phpunit is intended to run at the command line, not via a web server.