Wordpress

History

Boone Gorges 8bf5fce78f Improve 'orderby' syntax for `WP_Comment_Query`. Since [29027], `WP_Query` has supported an array of values for the `$orderby` parameter, with field names as array keys and ASC/DESC as the array values. This changeset introduces the same syntax to `WP_Comment_Query`. We leverage the new support for multiple ORDER BY clauses to fix a bug that causes comments to be queried in an indeterminate order when sorting by the default `comment_date_gmt` and comments share the same value for `comment_date_gmt`. By always including a `comment_ID` subclause at the end of the ORDER BY statement, we ensure that comments always have a unique fallback for sorting. This changeset also includes improvements paralleling those introduced to `WP_Query` in [31312] and [31340], which allow `$orderby` to accept array keys from specific `$meta_query` clauses. This change lets devs sort by multiple clauses of an associated meta query. See #31045. Fixes #30478. See #31265. git-svn-id: https://develop.svn.wordpress.org/trunk@31467 602fd350-edb4-49c9-b593-d223f7449a82	2015-02-16 14:09:40 +00:00
..
phpunit	Improve 'orderby' syntax for `WP_Comment_Query`.	2015-02-16 14:09:40 +00:00
qunit	Add jQuery UI Core as a dependency for qUnit tests	2014-12-23 00:16:52 +00:00

Boone Gorges 8bf5fce78f Improve 'orderby' syntax for WP_Comment_Query.

Since [29027], `WP_Query` has supported an array of values for the `$orderby`
parameter, with field names as array keys and ASC/DESC as the array values.
This changeset introduces the same syntax to `WP_Comment_Query`.

We leverage the new support for multiple ORDER BY clauses to fix a bug that
causes comments to be queried in an indeterminate order when sorting by the
default `comment_date_gmt` and comments share the same value for
`comment_date_gmt`. By always including a `comment_ID` subclause at the end of
the ORDER BY statement, we ensure that comments always have a unique fallback
for sorting.

This changeset also includes improvements paralleling those introduced to
`WP_Query` in [31312] and [31340], which allow `$orderby` to accept array keys
from specific `$meta_query` clauses. This change lets devs sort by multiple
clauses of an associated meta query. See #31045.

Fixes #30478. See #31265.

git-svn-id: https://develop.svn.wordpress.org/trunk@31467 602fd350-edb4-49c9-b593-d223f7449a82

2015-02-16 14:09:40 +00:00

phpunit Improve 'orderby' syntax for WP_Comment_Query. 2015-02-16 14:09:40 +00:00

qunit Add jQuery UI Core as a dependency for qUnit tests 2014-12-23 00:16:52 +00:00