a91e769e36
When `$size` is passed to `image_get_intermediate_size()` as an array of width and height values and an exact image size matching those values isn't available, the function loops through the available attachment sizes and returns the smallest image larger than the requested dimensions with the same aspect ratio. The aspect ratio check is skipped for the 'thumbnail' size to provide a fallback for small sizes when no other image option is available. This resulted in a poor selection when the size requested was smaller than the 'thumbnail' dimensions but a larger size matching the requested ratio existed. This refactors the internals of `image_get_intermediate_size()` to ensure the 'thumbnail' size is only returned as a fallback to small sizes once all other options have been considered, and makes the control flow easier to follow. This also introduces a new helper function, `wp_image_matches_ratio()` for testing whether the aspect ratios of two sets of dimensions match. This function is also now used in `wp_calculate_image_srcset()` during the selection process. Props flixos, joemcgill. Fixes #34384, #34980. git-svn-id: https://develop.svn.wordpress.org/trunk@38086 602fd350-edb4-49c9-b593-d223f7449a82 |
||
|---|---|---|
| src | ||
| tests | ||
| tools/i18n | ||
| .editorconfig | ||
| .gitignore | ||
| .jshintrc | ||
| .travis.yml | ||
| Gruntfile.js | ||
| package.json | ||
| phpunit.xml.dist | ||
| wp-cli.yml | ||
| wp-config-sample.php | ||
| wp-tests-config-sample.php | ||