a91e769e36
When `$size` is passed to `image_get_intermediate_size()` as an array of width and height values and an exact image size matching those values isn't available, the function loops through the available attachment sizes and returns the smallest image larger than the requested dimensions with the same aspect ratio. The aspect ratio check is skipped for the 'thumbnail' size to provide a fallback for small sizes when no other image option is available. This resulted in a poor selection when the size requested was smaller than the 'thumbnail' dimensions but a larger size matching the requested ratio existed. This refactors the internals of `image_get_intermediate_size()` to ensure the 'thumbnail' size is only returned as a fallback to small sizes once all other options have been considered, and makes the control flow easier to follow. This also introduces a new helper function, `wp_image_matches_ratio()` for testing whether the aspect ratios of two sets of dimensions match. This function is also now used in `wp_calculate_image_srcset()` during the selection process. Props flixos, joemcgill. Fixes #34384, #34980. git-svn-id: https://develop.svn.wordpress.org/trunk@38086 602fd350-edb4-49c9-b593-d223f7449a82 |
||
|---|---|---|
| .. | ||
| data | ||
| includes | ||
| tests | ||
| build.xml | ||
| multisite.xml | ||
| README.txt | ||
| wp-mail-real-test.php | ||
The short version:
1. Create a clean MySQL database and user. DO NOT USE AN EXISTING DATABASE or you will lose data, guaranteed.
2. Copy wp-tests-config-sample.php to wp-tests-config.php, edit it and include your database name/user/password.
3. $ svn up
4. Run the tests from the "trunk" directory:
To execute a particular test:
$ phpunit tests/phpunit/tests/test_case.php
To execute all tests:
$ phpunit
Notes:
Test cases live in the 'tests' subdirectory. All files in that directory will be included by default. Extend the WP_UnitTestCase class to ensure your test is run.
phpunit will initialize and install a (more or less) complete running copy of WordPress each time it is run. This makes it possible to run functional interface and module tests against a fully working database and codebase, as opposed to pure unit tests with mock objects and stubs. Pure unit tests may be used also, of course.
Changes to the test database will be rolled back as tests are finished, to ensure a clean start next time the tests are run.
phpunit is intended to run at the command line, not via a web server.