af596bcc5b
This avoids displaying duplicate content of the same post under different URLs and ensures the canonical URL is correct. Previously, requests for invalid page numbers were only redirected to the post permalink if the post was actually paginated using the `<!--nextpage-->` marker. Follow-up to [34492]. Props jeremyfelt, prografika, sachit.tandukar, subrataemfluence, hronak, ekatherine, henry.wright, chesio, dd32, SergeyBiryukov. Fixes #40773. See #45337, #28081, #11694. git-svn-id: https://develop.svn.wordpress.org/trunk@47727 602fd350-edb4-49c9-b593-d223f7449a82
252 lines
7.8 KiB
PHP
252 lines
7.8 KiB
PHP
<?php
|
|
/**
|
|
* Tests Canonical redirections.
|
|
*
|
|
* In the process of doing so, it also tests WP, WP_Rewrite and WP_Query, A fail here may show a bug in any one of these areas.
|
|
*
|
|
* @group canonical
|
|
* @group rewrite
|
|
* @group query
|
|
*/
|
|
class Tests_Canonical extends WP_Canonical_UnitTestCase {
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
wp_set_current_user( self::$author_id );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider data_canonical
|
|
*/
|
|
function test_canonical( $test_url, $expected, $ticket = 0, $expected_doing_it_wrong = array() ) {
|
|
|
|
if ( false !== strpos( $test_url, '%d' ) ) {
|
|
if ( false !== strpos( $test_url, '/?author=%d' ) ) {
|
|
$test_url = sprintf( $test_url, self::$author_id );
|
|
}
|
|
if ( false !== strpos( $test_url, '?cat=%d' ) ) {
|
|
$test_url = sprintf( $test_url, self::$terms[ $expected['url'] ] );
|
|
}
|
|
}
|
|
|
|
$this->assertCanonical( $test_url, $expected, $ticket, $expected_doing_it_wrong );
|
|
}
|
|
|
|
function data_canonical() {
|
|
/*
|
|
* Data format:
|
|
* [0]: Test URL.
|
|
* [1]: Expected results: Any of the following can be used.
|
|
* array( 'url': expected redirection location, 'qv': expected query vars to be set via the rewrite AND $_GET );
|
|
* array( expected query vars to be set, same as 'qv' above )
|
|
* (string) expected redirect location
|
|
* [2]: (optional) The ticket the test refers to, Can be skipped if unknown.
|
|
* [3]: (optional) Array of class/function names expected to throw `_doing_it_wrong()` notices.
|
|
*/
|
|
|
|
// Please Note: A few test cases are commented out below, look at the test case following it.
|
|
// In most cases it's simply showing 2 options for the "proper" redirect.
|
|
return array(
|
|
// Categories.
|
|
array( '?cat=%d', array( 'url' => '/category/parent/' ), 15256 ),
|
|
array( '?cat=%d', array( 'url' => '/category/parent/child-1/' ), 15256 ),
|
|
array( '?cat=%d', array( 'url' => '/category/parent/child-1/child-2/' ) ), // No children.
|
|
array(
|
|
'/category/uncategorized/',
|
|
array(
|
|
'url' => '/category/uncategorized/',
|
|
'qv' => array( 'category_name' => 'uncategorized' ),
|
|
),
|
|
),
|
|
array(
|
|
'/category/uncategorized/page/2/',
|
|
array(
|
|
'url' => '/category/uncategorized/page/2/',
|
|
'qv' => array(
|
|
'category_name' => 'uncategorized',
|
|
'paged' => 2,
|
|
),
|
|
),
|
|
),
|
|
array(
|
|
'/category/uncategorized/?paged=2',
|
|
array(
|
|
'url' => '/category/uncategorized/page/2/',
|
|
'qv' => array(
|
|
'category_name' => 'uncategorized',
|
|
'paged' => 2,
|
|
),
|
|
),
|
|
),
|
|
array(
|
|
'/category/uncategorized/?paged=2&category_name=uncategorized',
|
|
array(
|
|
'url' => '/category/uncategorized/page/2/',
|
|
'qv' => array(
|
|
'category_name' => 'uncategorized',
|
|
'paged' => 2,
|
|
),
|
|
),
|
|
17174,
|
|
),
|
|
|
|
// Categories & intersections with other vars.
|
|
array(
|
|
'/category/uncategorized/?tag=post-formats',
|
|
array(
|
|
'url' => '/category/uncategorized/?tag=post-formats',
|
|
'qv' => array(
|
|
'category_name' => 'uncategorized',
|
|
'tag' => 'post-formats',
|
|
),
|
|
),
|
|
),
|
|
array(
|
|
'/?category_name=cat-a,cat-b',
|
|
array(
|
|
'url' => '/?category_name=cat-a,cat-b',
|
|
'qv' => array( 'category_name' => 'cat-a,cat-b' ),
|
|
),
|
|
),
|
|
|
|
// Taxonomies with extra query vars.
|
|
array( '/category/cat-a/page/1/?test=one%20two', '/category/cat-a/?test=one%20two', 18086 ), // Extra query vars should stay encoded.
|
|
|
|
// Categories with dates.
|
|
array(
|
|
'/2008/04/?cat=1',
|
|
array(
|
|
'url' => '/2008/04/?cat=1',
|
|
'qv' => array(
|
|
'cat' => '1',
|
|
'year' => '2008',
|
|
'monthnum' => '04',
|
|
),
|
|
),
|
|
17661,
|
|
),
|
|
/*
|
|
array(
|
|
'/2008/?category_name=cat-a',
|
|
array(
|
|
'url' => '/2008/?category_name=cat-a',
|
|
'qv' => array(
|
|
'category_name' => 'cat-a',
|
|
'year' => '2008'
|
|
)
|
|
)
|
|
),
|
|
*/
|
|
|
|
// Pages.
|
|
array( '/child-page-1/', '/parent-page/child-page-1/' ),
|
|
array( '/?page_id=144', '/parent-page/child-page-1/' ),
|
|
array( '/abo', '/about/' ),
|
|
array( '/parent/child1/grandchild/', '/parent/child1/grandchild/' ),
|
|
array( '/parent/child2/grandchild/', '/parent/child2/grandchild/' ),
|
|
|
|
// Posts.
|
|
array( '?p=587', '/2008/06/02/post-format-test-audio/' ),
|
|
array( '/?name=images-test', '/2008/09/03/images-test/' ),
|
|
// Incomplete slug should resolve and remove the ?name= parameter.
|
|
array( '/?name=images-te', '/2008/09/03/images-test/', 20374 ),
|
|
// Page slug should resolve to post slug and remove the ?pagename= parameter.
|
|
array( '/?pagename=images-test', '/2008/09/03/images-test/', 20374 ),
|
|
|
|
array( '/2008/06/02/post-format-test-au/', '/2008/06/02/post-format-test-audio/' ),
|
|
array( '/2008/06/post-format-test-au/', '/2008/06/02/post-format-test-audio/' ),
|
|
array( '/2008/post-format-test-au/', '/2008/06/02/post-format-test-audio/' ),
|
|
array( '/2010/post-format-test-au/', '/2008/06/02/post-format-test-audio/' ), // A year the post is not in.
|
|
array( '/post-format-test-au/', '/2008/06/02/post-format-test-audio/' ),
|
|
|
|
array(
|
|
'/2008/09/03/images-test/3/',
|
|
array(
|
|
'url' => '/2008/09/03/images-test/3/',
|
|
'qv' => array(
|
|
'name' => 'images-test',
|
|
'year' => '2008',
|
|
'monthnum' => '09',
|
|
'day' => '03',
|
|
'page' => '3',
|
|
),
|
|
),
|
|
),
|
|
array( '/2008/09/03/images-test/?page=3', '/2008/09/03/images-test/3/' ),
|
|
array( '/2008/09/03/images-te?page=3', '/2008/09/03/images-test/3/' ),
|
|
|
|
array( '/2008/03/03/comment-test/3/', '/2008/03/03/comment-test/' ),
|
|
array( '/2008/03/03/comment-test/?page=3', '/2008/03/03/comment-test/' ),
|
|
|
|
// Comments.
|
|
array( '/2008/03/03/comment-test/?cpage=2', '/2008/03/03/comment-test/comment-page-2/' ),
|
|
|
|
// Attachments.
|
|
array( '/?attachment_id=611', '/2008/06/10/post-format-test-gallery/canola2/' ),
|
|
array( '/2008/06/10/post-format-test-gallery/?attachment_id=611', '/2008/06/10/post-format-test-gallery/canola2/' ),
|
|
|
|
// Dates.
|
|
array( '/?m=2008', '/2008/' ),
|
|
array( '/?m=200809', '/2008/09/' ),
|
|
array( '/?m=20080905', '/2008/09/05/' ),
|
|
|
|
array( '/2008/?day=05', '/2008/?day=05' ), // No redirect.
|
|
array( '/2008/09/?day=05', '/2008/09/05/' ),
|
|
array( '/2008/?monthnum=9', '/2008/09/' ),
|
|
|
|
array( '/?year=2008', '/2008/' ),
|
|
|
|
array( '/2012/13/', '/2012/' ),
|
|
array( '/2012/11/51/', '/2012/11/', 0, array( 'WP_Date_Query' ) ),
|
|
|
|
// Authors.
|
|
array( '/?author=%d', '/author/canonical-author/' ),
|
|
// array( '/?author=%d&year=2008', '/2008/?author=3'),
|
|
// array( '/author/canonical-author/?year=2008', '/2008/?author=3'), // Either or, see previous testcase.
|
|
|
|
// Feeds.
|
|
array( '/?feed=atom', '/feed/atom/' ),
|
|
array( '/?feed=rss2', '/feed/' ),
|
|
array( '/?feed=comments-rss2', '/comments/feed/' ),
|
|
array( '/?feed=comments-atom', '/comments/feed/atom/' ),
|
|
|
|
// Feeds (per-post).
|
|
array( '/2008/03/03/comment-test/?feed=comments-atom', '/2008/03/03/comment-test/feed/atom/' ),
|
|
array( '/?p=149&feed=comments-atom', '/2008/03/03/comment-test/feed/atom/' ),
|
|
|
|
// Index.
|
|
array( '/?paged=1', '/' ),
|
|
array( '/page/1/', '/' ),
|
|
array( '/page1/', '/' ),
|
|
array( '/?paged=2', '/page/2/' ),
|
|
array( '/page2/', '/page/2/' ),
|
|
|
|
// Misc.
|
|
array( '/2008%20', '/2008' ),
|
|
array( '//2008////', '/2008/' ),
|
|
|
|
// @todo Endpoints (feeds, trackbacks, etc). More fuzzed mixed query variables, comment paging, Home page (static).
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @ticket 43745
|
|
*/
|
|
public function test_utf8_query_keys_canonical() {
|
|
$p = self::factory()->post->create(
|
|
array(
|
|
'post_type' => 'page',
|
|
)
|
|
);
|
|
update_option( 'show_on_front', 'page' );
|
|
update_option( 'page_on_front', $p );
|
|
|
|
$this->go_to( get_permalink( $p ) );
|
|
|
|
$url = redirect_canonical( add_query_arg( '%D0%BA%D0%BE%D0%BA%D0%BE%D0%BA%D0%BE', 1, site_url( '/' ) ), false );
|
|
$this->assertNull( $url );
|
|
|
|
delete_option( 'page_on_front' );
|
|
}
|
|
}
|